@bill10/agent-007 0.6.2 → 0.6.3000

package/README.md

@@ -156,6 +156,8 @@ Agent 007 runs on macOS, Linux, and Windows -- spawning agents, adding repos, an
 - **Linux:** `build-essential` and `python3` (`sudo apt install build-essential python3`)
 - **Windows:** [Visual Studio Build Tools](https://github.com/microsoft/node-pty#windows) with the C++ workload
 
+**An agent will not start: `"claude" is not installed, or not on the PATH Agent 007 was started with.`** The CLI the agent runs (`claude`, `codex` or `gemini`) was not found, and the message says how to install it. If it is installed, Agent 007 was started from somewhere with a shorter `PATH` than your shell (a launcher or a service manager, say); start it from a terminal where `which claude` finds it. Billion runs on Claude Code too, so without it Billion's tab says what to do instead: install Claude Code and press **Start** next to Billion, or restart with `BILLION=0` to turn Billion off.
+
 ## Architecture
 
 ```
@@ -166,7 +168,7 @@ server/
   direct-run.js    Entry-point detection (symlink/space-safe `npm start` guard)
   git.js           Git operations (worktree, file tree, diff)
   jobs.js          Job board dispatcher (scan, spawn, PR watch, schedule firing, attachment files)
-  command-path.js  Resolves commands to spawnable files on Windows (PATHEXT)
+  command-path.js  Checks a CLI is installed before a spawn; resolves commands to spawnable files on Windows (PATHEXT)
   pty.js           PTY lifecycle (spawn, handlers, state detection)
   ws.js            WebSocket (message routing, broadcast, origin check, shared terminal sizing)
   http.js          HTTP routes (/api/browse, /api/jobs, job attachment downloads, /mcp, origin + auth gates)

package/VERSION

@@ -1 +1 @@
-0.6.2.1
+0.6.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bill10/agent-007",
-  "version": "0.6.2",
+  "version": "0.6.3000",
   "description": "Self-hosted office where a manager agent posts jobs to Claude Code and Codex workers in parallel git worktrees, then reviews and merges their PRs. Cron jobs, agent-to-agent messaging, pixel-art status view.",
   "license": "MIT",
   "repository": {

package/server/billion.js

@@ -150,6 +150,16 @@ export function billionCommand({ created, hasConversation, dir, projectsHint })
   return `claude --dangerously-skip-permissions${!created && hasConversation ? ' --continue' : ''} ${quote(prompt)}`;
 }
 
+// Billion is Claude Code. Without it, its tab runs this instead: one line
+// saying what to do, then an exit. Nothing restarts it, so there is no loop;
+// the Start button checks for claude again. It stays up a moment after
+// printing, since a console host can drop the output of a process that exits
+// at once.
+export const NO_CLAUDE_NOTICE = 'Billion runs on Claude Code, which is not installed (no "claude" on the PATH Agent 007 was started with). Install it from https://docs.anthropic.com/en/docs/claude-code/setup and press Start next to Billion, or restart Agent 007 with BILLION=0 to turn Billion off.';
+export function noClaudeCommand(node = process.execPath) {
+  return `${quote(node)} -e ${quote(`console.log(${JSON.stringify(NO_CLAUDE_NOTICE)}); setTimeout(() => {}, 1000)`)}`;
+}
+
 // Claude Code asks whether to trust a folder the first time it runs there, and
 // highlights "No, exit". Billion's folder is Agent 007's own, holding only
 // what the server put there, so the server answers for it. Board workers get

package/server/command-path.js

@@ -12,8 +12,8 @@
 // something the caller can try/catch. Resolving the command to a full path
 // with a launchable extension up front is what keeps it from happening.
 
-import { statSync } from 'fs';
-import { join, resolve } from 'path';
+import { statSync, accessSync, constants } from 'fs';
+import { join, resolve, delimiter } from 'path';
 
 const DEFAULT_PATHEXT = '.COM;.EXE;.BAT;.CMD';
 
@@ -100,3 +100,35 @@ export function isUsableCwd(dir) {
   if (!dir) return false;
   try { return statSync(dir).isDirectory(); } catch { return false; }
 }
+
+function isExecutable(p) {
+  try { accessSync(p, constants.X_OK); return statSync(p).isFile(); } catch { return false; }
+}
+
+/**
+ * Whether `file` would launch: a path to an executable, or a name on PATH.
+ *
+ * Checked before a spawn because on macOS and Linux node-pty "starts" a
+ * command that does not exist: the fork succeeds, the exec fails, and the tab
+ * shows an empty terminal that is already dead. Windows goes through
+ * resolveExecutable, the same lookup the spawn itself uses.
+ */
+export function commandExists(file, env = process.env, platform = process.platform, cwd = process.cwd()) {
+  if (!file) return false;
+  if (platform === 'win32') return !!resolveExecutable(file, env, platform, cwd);
+  if (file.includes('/')) return isExecutable(resolve(cwd, file));
+  return (env.PATH || '').split(delimiter).filter(Boolean).some(dir => isExecutable(join(dir, file)));
+}
+
+// Where to get the CLIs the + Agent presets and the board start.
+const INSTALL_HINTS = {
+  claude: 'Install Claude Code: https://docs.anthropic.com/en/docs/claude-code/setup',
+  codex: 'Install Codex: npm install -g @openai/codex',
+  gemini: 'Install Gemini CLI: npm install -g @google/gemini-cli',
+};
+
+// The one line a person sees when `file` is not there.
+export function missingCommandMessage(file) {
+  const hint = INSTALL_HINTS[file];
+  return `"${file}" is not installed, or not on the PATH Agent 007 was started with.${hint ? ` ${hint}` : ''}`;
+}

package/server/pty.js

@@ -6,7 +6,7 @@ import { basename } from 'path';
 import { stripAnsiComplete, detectState, createRingBuffer, parseCommand, isRealOutput, trackSyncFrames, ptyEnv } from '../lib/helpers.js';
 // Re-exported so the handler's tests reach the parser through the module they drive.
 export { trackSyncFrames } from '../lib/helpers.js';
-import { resolveExecutable, isUsableCwd } from './command-path.js';
+import { resolveExecutable, isUsableCwd, commandExists, missingCommandMessage } from './command-path.js';
 import { RING_BUFFER_MAX } from './state.js';
 import { mintAgentToken, authEnabled } from './auth.js';
 import { writeMcpConfig, removeMcpConfig, withMcpConfig, takesMcpConfig, withApprovalHook } from './agent-mcp.js';
@@ -218,6 +218,10 @@ export function createSessionFromConfig({ sessionId, name, color, command, repoP
   if (!isUsableCwd(cwd)) {
     return { error: `Working directory no longer exists: ${cwd}` };
   }
+  // A missing CLI "starts" on macOS and Linux and leaves a dead, empty tab.
+  if (!commandExists(file, process.env, process.platform, cwd)) {
+    return { error: missingCommandMessage(file) };
+  }
   // Falls back to the bare name when nothing matched, leaving node-pty's own
   // lookup (and its catchable "File not found") in charge.
   const resolvedFile = resolveExecutable(file, process.env, process.platform, cwd) || file;

package/server.js

@@ -33,7 +33,9 @@ import { startDispatcher, stopDispatcher, boardSettings } from './server/jobs.js
 import { orphans, config } from './server/state.js';
 import { sweepMcpConfigs } from './server/agent-mcp.js';
 import { withDefaultPermission, envPermissionMode, PERMISSION_MODES, ENV_PERMISSION_MODE } from './lib/jobs.js';
-import { BILLION_NAME, billionEnabled, billionRuns, billionDir, ensureBillionRepo, refreshCharter, suggestProjectsDir, billionCommand } from './server/billion.js';
+import { BILLION_NAME, billionEnabled, billionRuns, billionDir, ensureBillionRepo, refreshCharter, suggestProjectsDir, billionCommand, noClaudeCommand } from './server/billion.js';
+import { commandExists, missingCommandMessage } from './server/command-path.js';
+import { parseCommand } from './lib/helpers.js';
 import { hasClaudeTranscript } from './server/agent-transcripts.js';
 import { autoTrusts, trustClaudeFolder } from './server/claude-trust.js';
 
@@ -57,6 +59,10 @@ async function createSession(command, name, repoPath, customBranch, ownerId, met
   // worktree directory's codename: two holders of one name means the first
   // kill frees it while the other still names a directory on disk.
   if (name && codenamePool.has(name)) return { error: `An agent named ${name} already exists` };
+  // A missing CLI, before any worktree is made for it: the board retries a
+  // failed card every tick. A path is left to the spawn, which knows the cwd.
+  const { file } = parseCommand(command);
+  if (!/[\\/]/.test(file) && !commandExists(file)) return { error: missingCommandMessage(file) };
   // An agent someone starts gets the .env default mode for its CLI, unless its
   // command already says how it asks. The board settles its own workers' mode
   // (boardModeFor in server/jobs.js), so their commands are left as built.
@@ -190,12 +196,13 @@ function startBillion() {
       console.error(`Billion: could not commit the updated charter in ${dir}:`, err.message);
     }
   }
-  const command = billionCommand({
+  const hasClaude = commandExists('claude', process.env, process.platform, dir);
+  const command = hasClaude ? billionCommand({
     created,
     hasConversation: !created && hasClaudeTranscript(dir),
     dir,
     projectsHint: suggestProjectsDir(config.repos.map(r => r.path)),
-  });
+  }) : noClaudeCommand();
   const result = createSessionFromConfig({
     sessionId: nextSessionId(), name: BILLION_NAME, color: colorCycler.next(), command,
     repoPath: null, worktreePath: null, cwd: dir, isBillion: true, ownerId: null,
@@ -205,7 +212,7 @@ function startBillion() {
   // introduction, and at the start of every cycle after a restart.
   result.session.messagesHeld = true;
   sessions.set(result.session.id, result.session);
-  return { session: result.session };
+  return { session: result.session, ...(hasClaude ? {} : { notice: 'Claude Code (claude) is not installed; its tab says how to fix that' }) };
 }
 
 // --- WebSocket ---
@@ -245,8 +252,8 @@ async function startup() {
     else if (raw) console.log(`  ${agent} agents start in ${raw} unless told otherwise`);
   }
   if (billionRuns()) {
-    const { error } = startBillion();
-    console.log(error ? `  Billion: not started (${error})` : `  Billion: running in ${billionDir()}`);
+    const { error, notice } = startBillion();
+    console.log(error ? `  Billion: not started (${error})` : notice ? `  Billion: ${notice}` : `  Billion: running in ${billionDir()}`);
   } else if (billionEnabled()) {
     console.log('  Billion: off while user accounts are enabled');
   }