@bigcommerce/eslint-config 2.8.1 → 2.9.1

package/configs/base.js

@@ -8,9 +8,55 @@ module.exports = {
     ecmaVersion: 'latest',
     sourceType: 'module',
   },
-  plugins: ['import', 'gettext', 'switch-case'],
+  plugins: ['import', 'gettext', 'switch-case', '@stylistic'],
   reportUnusedDisableDirectives: true,
   rules: {
+    '@stylistic/padding-line-between-statements': [
+      'warn',
+      {
+        blankLine: 'always',
+        next: 'return',
+        prev: '*',
+      },
+      {
+        blankLine: 'always',
+        next: ['block', 'block-like', 'class', 'const', 'let', 'var', 'interface'],
+        prev: '*',
+      },
+      {
+        blankLine: 'always',
+        next: '*',
+        prev: ['block', 'block-like', 'class', 'const', 'let', 'var', 'interface'],
+      },
+      {
+        blankLine: 'any',
+        next: ['const', 'let', 'var'],
+        prev: ['const', 'let', 'var'],
+      },
+      {
+        blankLine: 'any',
+        next: ['case'],
+        prev: ['case'],
+      },
+      {
+        blankLine: 'always',
+        next: '*',
+        prev: 'directive',
+      },
+      {
+        blankLine: 'any',
+        next: 'directive',
+        prev: 'directive',
+      },
+    ],
+    '@stylistic/spaced-comment': [
+      'warn',
+      'always',
+      {
+        block: { balanced: true, exceptions: ['-', '+'], markers: ['=', '!'] },
+        line: { exceptions: ['-', '+'], markers: ['=', '!'] },
+      },
+    ],
     'array-callback-return': 'error',
     'arrow-body-style': ['error', 'as-needed', { requireReturnForObjectLiteral: false }],
     'block-scoped-var': 'error',
@@ -24,7 +70,6 @@ module.exports = {
     'func-names': 'error',
     'getter-return': ['error', { allowImplicit: true }],
     'gettext/no-variable-string': 'error',
-    'global-require': 'error',
     'guard-for-in': 'error',
     'import/default': 'off',
     'import/dynamic-import-chunkname': 'error',
@@ -41,6 +86,7 @@ module.exports = {
     'import/newline-after-import': 'warn',
     'import/no-absolute-path': 'error',
     'import/no-amd': 'error',
+    'import/no-duplicates': ['warn', { 'prefer-inline': true }],
     'import/no-dynamic-require': 'error',
     'import/no-extraneous-dependencies': 'error',
     'import/no-mutable-exports': 'error',
@@ -55,7 +101,6 @@ module.exports = {
         'newlines-between': 'always',
       },
     ],
-    'lines-around-directive': ['error', { after: 'always', before: 'always' }],
     'max-classes-per-file': ['error', 1],
     'new-cap': [
       'error',
@@ -70,7 +115,6 @@ module.exports = {
     'no-array-constructor': 'error',
     'no-await-in-loop': 'error',
     'no-bitwise': 'error',
-    'no-buffer-constructor': 'error',
     'no-caller': 'error',
     'no-cond-assign': ['error', 'always'],
     'no-console': 'warn',
@@ -95,12 +139,10 @@ module.exports = {
     'no-nested-ternary': 'error',
     'no-new': 'error',
     'no-new-func': 'error',
-    'no-new-object': 'error',
-    'no-new-require': 'error',
     'no-new-wrappers': 'error',
+    'no-object-constructor': 'error',
     'no-octal-escape': 'error',
     'no-param-reassign': ['error', { props: false }],
-    'no-path-concat': 'error',
     'no-plusplus': 'error',
     'no-proto': 'error',
     'no-prototype-builtins': 'off',
@@ -251,7 +293,6 @@ module.exports = {
       },
     ],
     'no-return-assign': ['error', 'except-parens'],
-    'no-return-await': 'error',
     'no-script-url': 'error',
     'no-self-compare': 'error',
     'no-sequences': 'error',
@@ -276,34 +317,6 @@ module.exports = {
     'object-shorthand': ['error', 'always', { avoidQuotes: true, ignoreConstructors: false }],
     'one-var': ['error', 'never'],
     'operator-assignment': ['error', 'always'],
-    'padding-line-between-statements': [
-      'warn',
-      {
-        blankLine: 'always',
-        next: 'return',
-        prev: '*',
-      },
-      {
-        blankLine: 'always',
-        next: ['block', 'block-like', 'class', 'const', 'let', 'var'],
-        prev: '*',
-      },
-      {
-        blankLine: 'always',
-        next: '*',
-        prev: ['block', 'block-like', 'class', 'const', 'let', 'var'],
-      },
-      {
-        blankLine: 'any',
-        next: ['const', 'let', 'var'],
-        prev: ['const', 'let', 'var'],
-      },
-      {
-        blankLine: 'any',
-        next: ['case'],
-        prev: ['case'],
-      },
-    ],
     'prefer-arrow-callback': ['error', { allowNamedFunctions: false, allowUnboundThis: true }],
     'prefer-const': ['error', { destructuring: 'any', ignoreReadBeforeAssign: true }],
     'prefer-numeric-literals': 'error',
@@ -311,14 +324,6 @@ module.exports = {
     'prefer-template': 'error',
     radix: 'error',
     'sort-imports': ['error', { ignoreCase: true, ignoreDeclarationSort: true }],
-    'spaced-comment': [
-      'warn',
-      'always',
-      {
-        block: { balanced: true, exceptions: ['-', '+'], markers: ['=', '!'] },
-        line: { exceptions: ['-', '+'], markers: ['=', '!'] },
-      },
-    ],
     strict: 'error',
     'switch-case/newline-between-switch-case': ['warn', 'always', { fallthrough: 'never' }],
     'symbol-description': 'error',

package/configs/jest.js

@@ -13,9 +13,9 @@ module.exports = {
       },
     ],
     'jest-formatting/padding-around-all': 'warn',
+    'jest/no-conditional-in-test': 'error',
     'jest/no-done-callback': 'off',
     'jest/no-duplicate-hooks': 'off',
-    'jest/no-if': 'error',
     'jest/no-restricted-matchers': [
       'error',
       {

package/configs/prettier.js

@@ -1,13 +1,13 @@
-const { basename, dirname } = require('path');
-const { resolveConfigFile } = require('prettier');
+const path = require('path');
 
 const defaultConfig = require('../prettier.config');
 
 function getRules() {
-  const prettierConfigFile = resolveConfigFile.sync(process.cwd());
-  const hasLocalConfig = prettierConfigFile ? dirname(prettierConfigFile) === process.cwd() : false;
+  const pkgPath = path.resolve(process.cwd(), 'package.json');
+  // eslint-disable-next-line import/no-dynamic-require
+  const pkg = require(pkgPath);
 
-  if (!hasLocalConfig) {
+  if (pkg.prettier !== '@bigcommerce/eslint-config/prettier') {
     throw new Error(`
       =================================================================================
       Please add "prettier": "@bigcommerce/eslint-config/prettier" to your package.json
@@ -15,15 +15,6 @@ function getRules() {
     `);
   }
 
-  if (basename(prettierConfigFile) !== 'package.json') {
-    throw new Error(`
-      =================================================================================
-      Please add "prettier": "@bigcommerce/eslint-config/prettier" to your package.json
-      and remove any other prettier config file
-      =================================================================================
-    `);
-  }
-
   return {
     curly: ['error', 'all'],
     'prettier/prettier': ['warn', defaultConfig, { usePrettierrc: false }],

package/configs/typescript.js

@@ -2,10 +2,9 @@ const { join } = require('path');
 
 module.exports = {
   extends: [
-    'plugin:@typescript-eslint/eslint-recommended',
-    'plugin:@typescript-eslint/recommended',
-    'plugin:@typescript-eslint/recommended-requiring-type-checking',
     'plugin:import/typescript',
+    'plugin:@typescript-eslint/stylistic-type-checked',
+    'plugin:@typescript-eslint/strict-type-checked',
     'plugin:@bigcommerce/recommended',
   ],
   parser: '@typescript-eslint/parser',
@@ -95,7 +94,7 @@ module.exports = {
         selector: ['objectLiteralProperty', 'typeProperty'],
       },
     ],
-    '@typescript-eslint/no-duplicate-imports': 'error',
+    '@typescript-eslint/no-confusing-void-expression': ['error', { ignoreArrowShorthand: true }],
     '@typescript-eslint/no-explicit-any': 'error',
     '@typescript-eslint/no-misused-promises': [
       'error',
@@ -112,7 +111,6 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-shadow': ['error', { hoist: 'all' }],
-    '@typescript-eslint/no-throw-literal': ['error'],
     '@typescript-eslint/no-unnecessary-condition': 'error',
     '@typescript-eslint/no-unnecessary-type-assertion': 'error',
     '@typescript-eslint/no-unused-expressions': 'error',
@@ -126,37 +124,10 @@ module.exports = {
     ],
     '@typescript-eslint/no-use-before-define': ['error', 'nofunc'],
     '@typescript-eslint/no-useless-constructor': 'error',
-    '@typescript-eslint/padding-line-between-statements': [
-      'warn',
-      {
-        blankLine: 'always',
-        next: 'return',
-        prev: '*',
-      },
-      {
-        blankLine: 'always',
-        next: ['block', 'block-like', 'class', 'const', 'let', 'var', 'interface'],
-        prev: '*',
-      },
-      {
-        blankLine: 'always',
-        next: '*',
-        prev: ['block', 'block-like', 'class', 'const', 'let', 'var', 'interface'],
-      },
-      {
-        blankLine: 'any',
-        next: ['const', 'let', 'var'],
-        prev: ['const', 'let', 'var'],
-      },
-      {
-        blankLine: 'any',
-        next: ['case'],
-        prev: ['case'],
-      },
-    ],
     '@typescript-eslint/prefer-for-of': 'error',
     '@typescript-eslint/prefer-function-type': 'error',
     '@typescript-eslint/require-await': 'error',
+    '@typescript-eslint/restrict-template-expressions': ['error', { allowNumber: true }],
     '@typescript-eslint/return-await': 'error',
     '@typescript-eslint/unbound-method': 'off',
     '@typescript-eslint/unified-signatures': 'error',
@@ -169,12 +140,11 @@ module.exports = {
     'import/named': 'off',
     'no-duplicate-imports': 'off',
     'no-shadow': 'off',
-    'no-throw-literal': 'error',
+    'no-throw-literal': 'off',
     'no-unused-expressions': 'off',
     'no-unused-vars': 'off',
     'no-use-before-define': 'off',
     'no-useless-constructor': 'off',
-    'padding-line-between-statements': 'off',
     'sort-keys': 'off',
   },
   settings: {
@@ -191,7 +161,7 @@ module.exports = {
     {
       files: ['**/*.d.ts'],
       rules: {
-        'spaced-comment': [
+        '@stylistic/spaced-comment': [
           'warn',
           'always',
           {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigcommerce/eslint-config",
-  "version": "2.8.1",
+  "version": "2.9.1",
   "description": "Default ESLint configuration used at BigCommerce",
   "main": "index.js",
   "files": [
@@ -20,26 +20,27 @@
     "directory": "packages/eslint-config"
   },
   "dependencies": {
-    "@bigcommerce/eslint-plugin": "^1.2.0",
+    "@bigcommerce/eslint-plugin": "^1.3.1",
     "@rushstack/eslint-patch": "^1.1.3",
-    "@typescript-eslint/eslint-plugin": "^5.56.0",
-    "@typescript-eslint/parser": "^5.56.0",
-    "eslint-config-prettier": "^8.5.0",
+    "@stylistic/eslint-plugin": "^2.1.0",
+    "@typescript-eslint/eslint-plugin": "^8.4.0",
+    "@typescript-eslint/parser": "^8.4.0",
+    "eslint-config-prettier": "^9.1.0",
     "eslint-import-resolver-typescript": "^3.5.2",
     "eslint-plugin-gettext": "^1.2.0",
     "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^26.1.5",
+    "eslint-plugin-jest": "^28.4.0",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-jsdoc": "^48.0.2",
+    "eslint-plugin-jsdoc": "^50.2.2",
     "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-react": "^7.29.4",
     "eslint-plugin-react-hooks": "^4.5.0",
     "eslint-plugin-switch-case": "^1.1.2",
-    "prettier": "^2.6.2"
+    "prettier": "^3.3.3"
   },
   "devDependencies": {
-    "react": "^17.0.2"
+    "react": "^18.3.1"
   },
   "peerDependencies": {
     "eslint": "^8.0.0",
@@ -50,5 +51,5 @@
       "optional": true
     }
   },
-  "gitHead": "82f17771052b6e19064e1b6daf68e65106881d1b"
+  "gitHead": "73ecca900b0e7c1459b1cc4089465d4b49cacc3c"
 }