@bigbinary/neeto-playwright-commons 4.2.1 → 4.2.3

package/index.d.ts

@@ -6867,6 +6867,7 @@ declare const NEETO_EDITOR_SELECTORS: {
   neetoEditorHighlightTextColor: (textColorIndex: number) => string;
   neetoEditorHighlightBgColor: (bgColorIndex: number) => string;
   todoList: string;
+  selectedText: string;
   commandListItem: (index: number) => string;
   itemBlockHeading: string;
 };
@@ -7400,7 +7401,7 @@ declare const PROFILE_SECTION_SELECTORS: {
  *
  * tableHeaderRoleTitle: Selector for the title in the roles table header.
  *
- * permissionCheckbox: Selector for the permission checkbox.
+ * permissionCheckbox(name): Builder for the add/edit-role pane permission checkbox, keyed on the permission name (e.g. meetings.create_meeting).
  *
  * editRoleButton: Selector for the edit role button in the roles table.
  *
@@ -7431,7 +7432,7 @@ declare const ROLES_SELECTORS: {
   headerColumn: string;
   dropDownIcon: string;
   tableHeaderRoleTitle: string;
-  permissionCheckbox: string;
+  permissionCheckbox: (name: string) => string;
   editRoleButton: string;
   deleteRoleButton: string;
   permissionCard: string;

package/index.js

@@ -1377,6 +1377,7 @@ const NEETO_EDITOR_SELECTORS = {
     neetoEditorHighlightTextColor: (textColorIndex) => `neeto-editor-highlight-text-color-dot-${textColorIndex}`,
     neetoEditorHighlightBgColor: (bgColorIndex) => `neeto-editor-highlight-background-color-dot-${bgColorIndex}`,
     todoList: "[data-type='todoList']",
+    selectedText: ".selected-text",
     commandListItem: (index) => `neeto-editor-command-list-item-${index}`,
     itemBlockHeading: "neeto-editor-command-list-item-block-heading",
 };
@@ -1620,7 +1621,7 @@ const ROLES_SELECTORS = {
     headerColumn: "ntm-roles-table-header",
     dropDownIcon: "ntm-roles-table-header-role-dropdown-button",
     tableHeaderRoleTitle: "ntm-roles-table-header-role-title",
-    permissionCheckbox: "ntm-roles-permission-checkbox",
+    permissionCheckbox: (name) => `ntm-roles-permission-checkbox-${hyphenate(name)}`,
     editRoleButton: "ntm-roles-table-edit-role-button",
     deleteRoleButton: "ntm-roles-table-delete-role-button",
     permissionCard: "ntm-roles-permission-card",
@@ -2385,11 +2386,12 @@ class CustomCommands {
         const isMacOS = os.platform() === "darwin";
         const rightArrowKey = isMacOS ? "Meta+ArrowRight" : "End";
         const downArrowKey = isMacOS ? "Meta+ArrowDown" : "PageDown";
-        await this.page.keyboard.press(rightArrowKey);
-        await this.page.keyboard.press(rightArrowKey);
-        await this.page.keyboard.press(downArrowKey);
-        // eslint-disable-next-line playwright/no-wait-for-timeout
-        await this.page.waitForTimeout(500); // Adding some delay for DOM to react
+        await expect(async () => {
+            await this.page.keyboard.press(rightArrowKey);
+            await this.page.keyboard.press(rightArrowKey);
+            await this.page.keyboard.press(downArrowKey);
+            await expect(this.page.locator(NEETO_EDITOR_SELECTORS.selectedText)).toHaveCount(0, { timeout: 2_000 });
+        }).toPass({ timeout: 15_000 });
         await this.page.keyboard.press("Enter");
     };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/neeto-playwright-commons",
-  "version": "4.2.1",
+  "version": "4.2.3",
   "description": "A package encapsulating common playwright code across neeto projects.",
   "repository": "git@github.com:bigbinary/neeto-playwright-commons.git",
   "license": "apache-2.0",