@bigbinary/neeto-playwright-commons 1.13.13 → 1.13.14

package/index.d.ts

@@ -34,6 +34,7 @@ interface VerifyToastParams {
   timeout?: number;
   closeAfterVerification: boolean;
   toastType: "success" | "error";
+  customPageContext?: Page;
 }
 interface VerifyHelpPopoverProps {
   triggerElement?: Locator;
@@ -195,7 +196,9 @@ declare class CustomCommands {
    *
    * toastType(optional): Type of toast. It takes either success or error as it's value. Default is success.
    *
-   * timeout(optional): Timeout in milliseconds to wait for the toast to appear. Default is 10_000
+   * timeout(optional): Timeout in milliseconds to wait for the toast to appear. Default is 10_000.
+   *
+   * customPageContext(optional): Custom page context on which to verify the toast.
    *
    * @example 
    *
@@ -204,6 +207,7 @@ declare class CustomCommands {
    *     closeAfterVerification: false,
    *     toastType: "error",
    *     timeout: 20_000,
+   *     customPageContext: this.page,
    *   });
    * @endexample
   */
@@ -211,7 +215,8 @@ declare class CustomCommands {
     message,
     toastType,
     closeAfterVerification,
-    timeout
+    timeout,
+    customPageContext
   }?: Partial<VerifyToastParams>) => Promise<void>;
   /**
    *

package/index.js

@@ -3882,13 +3882,13 @@ class CustomCommands {
                 (await this.page.getByTestId(COMMON_SELECTORS.toastCloseButton).click());
             await expect(this.page.locator(COMMON_SELECTORS.toastIcon)).toBeHidden();
         };
-        this.verifyToast = async ({ message = "", toastType = "success", closeAfterVerification = true, timeout = 10000, } = {}) => {
-            const toastrCloseButton = this.page.getByTestId(COMMON_SELECTORS.toastCloseButton);
+        this.verifyToast = async ({ message = "", toastType = "success", closeAfterVerification = true, timeout = 10000, customPageContext = this.page, } = {}) => {
+            const toastrCloseButton = customPageContext.getByTestId(COMMON_SELECTORS.toastCloseButton);
             if (!isEmpty$1(message)) {
-                await expect(this.page.getByTestId(COMMON_SELECTORS.toastMessage(toastType))).toContainText(message, { timeout });
+                await expect(customPageContext.getByTestId(COMMON_SELECTORS.toastMessage(toastType))).toContainText(message, { timeout });
             }
             else {
-                await expect(this.page.locator(COMMON_SELECTORS.toastIcon)).toContainText("👍", { timeout });
+                await expect(customPageContext.locator(COMMON_SELECTORS.toastIcon)).toContainText("👍", { timeout });
             }
             if (closeAfterVerification && (await toastrCloseButton.isVisible())) {
                 await toastrCloseButton.click();
@@ -21248,10 +21248,15 @@ class EmbedBase {
         this.clickOnPopupButton = async (popUpButtonSelectorOptions) => {
             const popUpButton = this.embedTestPage.getByRole(this.embedTestPageType === "floatingPopup" ? "button" : "link", popUpButtonSelectorOptions);
             await expect(popUpButton).toBeVisible();
-            await popUpButton.click();
-            await expect(this.embedTestPage.locator(EMBED_SELECTORS.loader(this.appName))).toBeHidden({
-                timeout: 40000,
-            });
+            await expect(async () => {
+                await popUpButton.click();
+                await expect(this.embedTestPage.locator(EMBED_SELECTORS.loader(this.appName))).toBeHidden({
+                    timeout: 40000,
+                });
+                await expect(this.embedTestPage.locator(EMBED_SELECTORS.iframe(this.appName))).toBeVisible({
+                    timeout: 10000,
+                });
+            }).toPass({ timeout: 2 * 60 * 1000 });
         };
         this.copyEmbedScript = async ({ embedLabel }) => {
             await this.page
@@ -23696,12 +23701,14 @@ class SlackPage extends IntegrationBase {
                 .textContent()) || "";
             await allowButton.click();
             await this.page.waitForURL(redirectUrl);
-            await expect(this.page.getByTestId(COMMON_SELECTORS.pageLoader)).toBeHidden({ timeout: 10000 });
+            await this.neetoPlaywrightUtilities.waitForPageLoad({
+                visibilityTimeout: 10000,
+            });
             await expect(this.page.getByRole("heading", {
                 name: this.t("neetoSlack.slack.configure.title", {
                     teamName: currentWorkspace,
                 }),
-            })).toBeVisible();
+            })).toBeVisible({ timeout: 10000 });
             await this.neetoPlaywrightUtilities.selectOptionFromDropdown({
                 value: channelToConfigure,
             });
@@ -24674,7 +24681,12 @@ class TeamMembers {
             }
             // eslint-disable-next-line playwright/no-standalone-expect
             await expect(async () => {
-                await this.page.getByTestId(MEMBER_SELECTORS.submitButton).click();
+                const submitButton = this.page.getByTestId(MEMBER_SELECTORS.submitButton);
+                await submitButton.click();
+                // eslint-disable-next-line playwright/no-standalone-expect
+                await expect(submitButton.locator(COMMON_SELECTORS.buttonSpinner)).toBeHidden({
+                    timeout: 15000,
+                });
                 // eslint-disable-next-line playwright/no-standalone-expect
                 await expect(this.page.getByTestId(COMMON_SELECTORS.paneBody)).toBeHidden();
             }).toPass({ timeout: 40000 });