@bigbinary/neeto-media-recorder 2.5.1 → 2.5.3

package/core.js

@@ -1,5 +1,5 @@
 import axios from 'axios';
-import { isPresent, existsBy, isNotEmpty, isNot } from '@bigbinary/neeto-cist';
+import { isPresent, existsBy, isNotEmpty, isNot, noop } from '@bigbinary/neeto-cist';
 import { MIME_TYPE as MIME_TYPE$1, RETRYABLE_ERRORS, UPLOAD_STATUS, UPLOAD_EVENT, SCREEN_RECORDER_STATUS, START_RECORDING_SOUND, RECORDING_LIMIT_REACHED_WARNING_SOUND, SCREEN_RECORDER_ERROR, SCREEN_RECORDER_EVENT, RECORDING_TIME_LIMIT_FREE_PLAN, ONE_SECOND, HALF_A_SECOND_IN_MILLISECONDS, ONE_SECOND_IN_MILLISECONDS, TWO_HUNDRED_MILLISECONDS, ONE_MINUTE_IN_MILLISECONDS, STOP_RECORDING_DUE_TO_LIMIT_REACHED_SOUND, IS_EXTENSION } from '@bigbinary/neeto-media-recorder/constants';
 import { isNotNil, min, isNil, identity, isEmpty, pick, equals, not } from 'ramda';
 import platform from 'platform';
@@ -827,7 +827,9 @@ function compareChromiumVersions(version1, version2) {
   return 0;
 }
 var getSupportedMimeType = function getSupportedMimeType(fallback) {
-  if (MediaRecorder.isTypeSupported(MIME_TYPE.mp4)) {
+  var _platform$os, _platform$os$family;
+  var isWindows = (_platform$os = platform.os) === null || _platform$os === void 0 ? void 0 : (_platform$os$family = _platform$os.family) === null || _platform$os$family === void 0 ? void 0 : _platform$os$family.includes("Windows");
+  if (MediaRecorder.isTypeSupported(MIME_TYPE.mp4) && !isWindows) {
     if (platform.name === "Safari") {
       return MIME_TYPE.mp4;
     }
@@ -1882,9 +1884,13 @@ var ScreenRecorder = /*#__PURE__*/function () {
                   error: SCREEN_RECORDER_ERROR[error.name]
                 });
                 _classPrivateFieldGet(_this, _fireCallbacks).call(_this, SCREEN_RECORDER_EVENT.onError, [error]);
-                _classPrivateFieldGet(_this, _mediaStream).getVideoTracks()[0].stop();
-                _classPrivateFieldGet(_this, _mediaStream).getAudioTracks()[0].stop();
-                _classPrivateFieldSet(_this, _mediaStream, null);
+                // To prevent triggering #onRecordingStop when the mediaRecorder is failed to start.
+                _classPrivateFieldGet(_this, _mediaRecorder).onstop = noop;
+                if (_classPrivateFieldGet(_this, _mediaStream)) {
+                  _classPrivateFieldGet(_this, _mediaStream).getVideoTracks()[0].stop();
+                  _classPrivateFieldGet(_this, _mediaStream).getAudioTracks()[0].stop();
+                  _classPrivateFieldSet(_this, _mediaStream, null);
+                }
                 _classPrivateFieldSet(_this, _stream, null);
                 _classPrivateFieldSet(_this, _audioStream, null);
                 _classPrivateFieldSet(_this, _mediaRecorder, null);