@bigbinary/neeto-commons-frontend 4.13.42 → 4.13.44

package/configs/scripts/dead-code-eliminator/index.js

@@ -10,7 +10,7 @@ const babelParser = require("@babel/parser");
 const traverse = require("@babel/traverse").default;
 const { isNotEmpty, existsBy } = require("@bigbinary/neeto-cist");
 const enhancedResolve = require("enhanced-resolve");
-const { isEmpty, includes, __ } = require("ramda");
+const { isEmpty, includes, __, mergeDeepLeft } = require("ramda");
 
 const {
   RAILS_MOUNTED_COMPONENTS_REGEX,
@@ -20,8 +20,14 @@ const {
 } = require("./constants");
 
 // @ts-ignore
-// eslint-disable-next-line import/extensions
-const webpackConfig = require("../../../../../../config/webpack/webpack.config.js");
+const projectESBuildConfig = require("../../../../../../config/esbuild/config");
+const baseESBuildAlias = require("../../esbuild/alias");
+const baseESBuildExtensions = require("../../esbuild/index");
+
+const mergedESBuildAlias = mergeDeepLeft(
+  projectESBuildConfig.alias,
+  baseESBuildAlias
+);
 
 let modifiedFiles = [];
 let importedItems = [];
@@ -34,10 +40,8 @@ const javascriptDir = pathLib.resolve(
 );
 
 const resolver = enhancedResolve.create.sync({
-  alias: webpackConfig.resolve.alias,
-  modules: webpackConfig.resolve.modules,
-  extensions: webpackConfig.resolve.extensions,
-  fallback: webpackConfig.resolve.fallback,
+  alias: mergedESBuildAlias,
+  extensions: baseESBuildExtensions.config.resolveExtensions,
   conditionNames: ["require", "import", "node", "default", "types"],
 });
 
@@ -63,24 +67,98 @@ const findImports = filePath => {
       const currentDir = pathLib.dirname(filePath);
       const importSource = node.source.value;
 
-      const resolvedPath = resolver(currentDir, importSource);
-      const isNodeModule = resolvedPath.includes("node_modules");
-      if (isNodeModule) return;
+      try {
+        const resolvedPath = resolver(currentDir, importSource);
+        const isNodeModule = resolvedPath.includes("node_modules");
+        if (isNodeModule) return;
+
+        if (isEmpty(node.specifiers)) {
+          importedItems.push({ item: "*", filePath: resolvedPath });
+        }
 
-      if (isEmpty(node.specifiers)) {
-        importedItems.push({ item: "*", filePath: resolvedPath });
+        node.specifiers.forEach(specifier => {
+          if (specifier.type === TYPES.IMPORT_NAMESPACE_SPECIFIER) {
+            importedItems.push({ item: "*", filePath: resolvedPath });
+          } else if (specifier.type === TYPES.IMPORT_DEFAULT_SPECIFIER) {
+            importedItems.push({ item: "default", filePath: resolvedPath });
+          } else {
+            const item = specifier.imported.name;
+            importedItems.push({ item, filePath: resolvedPath });
+          }
+        });
+      } catch (err) {
+        // Skip resolution errors (e.g., malformed package exports in node_modules)
+        // This typically happens with external packages that have invalid exports(like BrowserPreview in          neeto-molecules)
+        console.warn(
+          `Failed to resolve import "${importSource}" in ${filePath}: ${err.message}`
+        );
+
+        return;
       }
+    },
+
+    // Handle React.lazy(() => import("...")) patterns and dynamic imports
+    CallExpression(path) {
+      const { node } = path;
+
+      // Check for React.lazy pattern
+      if (
+        node.callee.type === "MemberExpression" &&
+        node.callee.object.name === "React" &&
+        node.callee.property.name === "lazy" &&
+        node.arguments.length === 1 &&
+        node.arguments[0].type === "ArrowFunctionExpression"
+      ) {
+        const arrowFunction = node.arguments[0];
+        if (
+          arrowFunction.body.type === "CallExpression" &&
+          arrowFunction.body.callee.type === "Import"
+        ) {
+          const importArg = arrowFunction.body.arguments[0];
+          if (importArg && importArg.type === "StringLiteral") {
+            const currentDir = pathLib.dirname(filePath);
+            const importSource = importArg.value;
+
+            try {
+              const resolvedPath = resolver(currentDir, importSource);
+              if (!resolvedPath || typeof resolvedPath !== "string") return;
+
+              const isNodeModule = resolvedPath.includes("node_modules");
+              if (isNodeModule) return;
+
+              importedItems.push({ item: "default", filePath: resolvedPath });
+            } catch (err) {
+              console.warn(
+                `⚠️  Failed to resolve React.lazy import "${importSource}" in ${filePath}: ${err.message}`
+              );
+            }
+          }
+        }
+      }
+
+      // Handle direct dynamic imports: import("...")
+      if (
+        node.callee.type === "Import" &&
+        node.arguments.length === 1 &&
+        node.arguments[0].type === "StringLiteral"
+      ) {
+        const currentDir = pathLib.dirname(filePath);
+        const importSource = node.arguments[0].value;
+
+        try {
+          const resolvedPath = resolver(currentDir, importSource);
+          if (!resolvedPath || typeof resolvedPath !== "string") return;
+
+          const isNodeModule = resolvedPath.includes("node_modules");
+          if (isNodeModule) return;
 
-      node.specifiers.forEach(specifier => {
-        if (specifier.type === TYPES.IMPORT_NAMESPACE_SPECIFIER) {
-          importedItems.push({ item: "*", filePath: resolvedPath });
-        } else if (specifier.type === TYPES.IMPORT_DEFAULT_SPECIFIER) {
           importedItems.push({ item: "default", filePath: resolvedPath });
-        } else {
-          const item = specifier.imported.name;
-          importedItems.push({ item, filePath: resolvedPath });
+        } catch (err) {
+          console.warn(
+            `Failed to resolve dynamic import "${importSource}" in ${filePath}: ${err.message}`
+          );
         }
-      });
+      }
     },
   });
 };
@@ -233,7 +311,9 @@ const run = () => {
   importedItems = [];
   unusedFiles = [];
 
-  console.log("* Collecting all the imports.");
+  console.log(
+    "* Collecting all the imports (including React.lazy and dynamic imports)."
+  );
   traverseDirectoryAndExecuteFunc(javascriptDir, findImports);
 
   console.log("* Removing exports which are not imported.");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/neeto-commons-frontend",
-  "version": "4.13.42",
+  "version": "4.13.44",
   "description": "A package encapsulating common code across neeto projects including initializers, utility functions, common components and hooks and so on.",
   "repository": "git@github.com:bigbinary/neeto-commons-frontend.git",
   "author": "Amaljith K <amaljith.k@bigbinary.com>",
@@ -143,6 +143,7 @@
     "css-loader": "4.3.0",
     "dayjs": "1.11.13",
     "dompurify": "^3.2.4",
+    "enhanced-resolve": "^5.18.1",
     "esbuild": "0.24.0",
     "esbuild-plugin-svgr": "^3.1.0",
     "esbuild-plugin-yaml": "^0.0.1",
@@ -238,6 +239,7 @@
     "dayjs": "1.11.13",
     "dompurify": "^3.2.4",
     "dotenv-webpack": "^8.0.1",
+    "enhanced-resolve": "^5.18.1",
     "esbuild": "0.24.0",
     "esbuild-plugin-svgr": "^3.1.0",
     "esbuild-plugins-node-modules-polyfill": "^1.6.8",