@bigbinary/neeto-audit-frontend 2.0.12 → 2.0.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/neeto-audit-frontend",
-  "version": "2.0.12",
+  "version": "2.0.14",
   "description": "Audits neeto frontend codebase for issues and suggests a fix.",
   "type": "module",
   "bin": "./dist/index.js",
@@ -28,7 +28,7 @@
   "dependencies": {
     "@bigbinary/neeto-cist": "1.0.8",
     "@bigbinary/neeto-commons-frontend": "3.1.10",
-    "axios": "1.6.0",
+    "axios": "1.7.4",
     "chalk": "5.3.0",
     "commander": "11.1.0",
     "ora": "8.0.1",

package/src/verifiers/recommendedPackageVersions/index.js

@@ -1,5 +1,5 @@
-import { existsBy, isNotEmpty } from "@bigbinary/neeto-cist";
-import { mergeDeepRight, objOf } from "ramda";
+import { existsBy, isNotEmpty, findBy } from "@bigbinary/neeto-cist";
+import { mergeDeepRight, objOf, pick } from "ramda";
 
 import recommendedDependencies from "../../../common/recommendedDependencies";
 import { NANO_TYPE_MAP, PACKAGE_JSON_PATH, STATUSES } from "../../constants";
@@ -7,12 +7,12 @@ import {
   createOrReplaceFile,
   execute,
   getNanoType,
-  getPackageJson
+  getPackageJson,
 } from "../../utils";
 import {
   getInstallationCommands,
   getOutdatedPackages,
-  sortByKey
+  sortByKey,
 } from "./utils";
 
 const recommendedPackageVersions = async (debug) => {
@@ -35,17 +35,28 @@ const recommendedPackageVersions = async (debug) => {
   );
 
   const fix = async (debug) => {
+    const outdatedPeerDependenciesKeys = findBy(
+      { type: "peerDependencies" },
+      packagesToUpdate
+    )?.outdatedPackages;
+
+    const peerDependenciesToBeUpdated = pick(
+      outdatedPeerDependenciesKeys,
+      recommendedVersions.peerDependencies
+    );
+
     let newPackageJson = mergeDeepRight(
       packageJson,
-      objOf("peerDependencies", recommendedVersions.peerDependencies)
+      objOf("peerDependencies", peerDependenciesToBeUpdated)
     );
+
     newPackageJson = sortByKey(newPackageJson);
 
-    isNotEmpty(recommendedVersions.peerDependencies) &&
+    isNotEmpty(peerDependenciesToBeUpdated) &&
       (await createOrReplaceFile({
         relativeFilePath: PACKAGE_JSON_PATH,
         content: JSON.stringify(newPackageJson, null, 2),
-        debug
+        debug,
       }));
 
     const commands = getInstallationCommands(
@@ -67,7 +78,7 @@ const recommendedPackageVersions = async (debug) => {
     return {
       error: "The dependency packages are not using the recommended versions.",
       status: STATUSES.FAIL,
-      fix
+      fix,
     };
   }
 

package/src/verifiers/recommendedPackageVersions/utils.js

@@ -12,9 +12,10 @@ import {
   isEmpty,
   startsWith,
   includes,
-  __
+  pick,
+  __,
 } from "ramda";
-import { filterBy, findBy, isNotEmpty } from "@bigbinary/neeto-cist";
+import { filterBy, findBy } from "@bigbinary/neeto-cist";
 
 import { DEPENDENCY_TYPES, MAX_RETRIES, REQUEST_DELAY } from "./constants";
 
@@ -23,39 +24,37 @@ const updateBigbinaryPackages = async (recommendedList) => {
     startsWith("@bigbinary")
   );
 
-  if (isNotEmpty(auditPackages)) {
-    let success = false;
-    let retries = 0;
-
-    while (!success && retries < MAX_RETRIES) {
-      try {
-        const {
-          data: { nanos }
-        } = await axios.get(
-          "https://ops.neetotower.com/api/v1/public/nanos"
-        );
-
-        const trackedPackages = filterBy(
-          { name: includes(__, auditPackages) },
-          nanos
+  if (isEmpty(auditPackages)) return recommendedList;
+
+  let success = false;
+  let retries = 0;
+
+  while (!success && retries < MAX_RETRIES) {
+    try {
+      const {
+        data: { nanos },
+      } = await axios.get("https://ops.neetotower.com/api/v1/public/nanos");
+
+      const trackedPackages = filterBy(
+        { name: includes(__, auditPackages) },
+        nanos
+      );
+
+      trackedPackages.forEach(({ name, current_version }) => {
+        recommendedList[name] = current_version;
+      });
+
+      return recommendedList;
+    } catch (error) {
+      retries++;
+      await new Promise((resolve) => setTimeout(resolve, REQUEST_DELAY));
+      if (retries === MAX_RETRIES) {
+        console.log(
+          chalk.yellowBright(
+            "\nCouldn't connect to nanos release tool. Please retry or verify the link is working correctly."
+          )
         );
-
-        trackedPackages.forEach(({ name, current_version }) => {
-          recommendedList[name] = current_version;
-        });
-
-        return recommendedList;
-      } catch (error) {
-        retries++;
-        await new Promise((resolve) => setTimeout(resolve, REQUEST_DELAY));
-        if (retries === MAX_RETRIES) {
-          console.log(
-            chalk.yellowBright(
-              "\nCouldn't connect to nanos release tool. Please retry or verify the link is working correctly."
-            )
-          );
-          process.exitCode = 1;
-        }
+        process.exitCode = 1;
       }
     }
   }
@@ -69,9 +68,26 @@ export const getOutdatedPackages = (recommendedVersions, packageJson) => {
 
     const dependencyTypePackages = packageJson[type] ?? {};
 
-    const packages = mapObjIndexed(
+    let packages = {};
+    let dependenciesToCheck = {};
+
+    if (type === "peerDependencies") {
+      const installedDependencies = [
+        ...Object.keys(packageJson.dependencies || {}),
+        ...Object.keys(packageJson.devDependencies || {}),
+      ];
+
+      dependenciesToCheck = pick(installedDependencies, recommendedList);
+    } else {
+      dependenciesToCheck = pick(
+        Object.keys(dependencyTypePackages),
+        recommendedList
+      );
+    }
+
+    packages = mapObjIndexed(
       (_, key) => eqProps(key, recommendedList, dependencyTypePackages),
-      recommendedList
+      dependenciesToCheck
     );
 
     const outdatedPackages = pickBy(not, packages);