@bigbinary/eslint-plugin-neeto 1.8.1 → 1.8.2

package/dist/index.js

@@ -285,114 +285,9 @@
     }
   });
 
-  var name = "@bigbinary/eslint-plugin-neeto";
-  var version = "1.8.0";
-  var main = "dist/index.js";
-  var license = "UNLICENSED";
-  var scripts = {
-  	prepare: "husky install",
-  	test: "npm run build && jest dist/util-tests.spec.js && node dist/rule-tests.js",
-  	build: "rollup --bundleConfigAsCjs -c rollup.config.js",
-  	watch: "rollup --bundleConfigAsCjs -c rollup.config.js --watch"
-  };
-  var files = [
-  	"dist/index.js",
-  	"dist/resolveConfigWorker.js"
-  ];
-  var engines = {
-  	node: ">=22.13",
-  	npm: ">=9",
-  	yarn: ">=1.22"
-  };
-  var dependencies = {
-  };
-  var devDependencies = {
-  	"@babel/core": "^7.19.1",
-  	"@babel/eslint-parser": "^7.27.5",
-  	"@babel/plugin-transform-runtime": "^7.19.1",
-  	"@babel/preset-env": "7.17.10",
-  	"@babel/preset-react": "7.16.7",
-  	"@babel/preset-typescript": "^7.18.6",
-  	"@babel/runtime": "^7.19.0",
-  	"@bigbinary/babel-preset-neeto": "^1.0.3",
-  	"@bigbinary/eslint-plugin-neeto": "^1.7.2",
-  	"@bigbinary/neeto-cist": "^1.0.3",
-  	"@bigbinary/neeto-commons-frontend": "^4.13.42",
-  	"@rollup/plugin-alias": "^3.1.9",
-  	"@rollup/plugin-babel": "^6.0.4",
-  	"@rollup/plugin-commonjs": "^22.0.0",
-  	"@rollup/plugin-json": "^4.1.0",
-  	"@rollup/plugin-node-resolve": "^15.3.0",
-  	"babel-loader": "^8.2.5",
-  	"babel-plugin-dynamic-import-node": "^2.3.3",
-  	"babel-plugin-istanbul": "^6.1.1",
-  	"babel-plugin-js-logger": "1.0.17",
-  	"babel-plugin-macros": "3.1.0",
-  	"babel-plugin-module-resolver": "^5.0.0",
-  	"babel-plugin-preval": "^5.1.0",
-  	"babel-plugin-transform-imports": "^2.0.0",
-  	"babel-plugin-transform-react-remove-prop-types": "0.4.24",
-  	"babel-preset-react": "6.24.1",
-  	"babel-preset-typescript": "^7.0.0-alpha.19",
-  	cheerio: "^1.0.0-rc.12",
-  	"command-line-args": "^5.2.1",
-  	eslint: "^9.25.1",
-  	"eslint-config-prettier": "^10.1.2",
-  	"eslint-plugin-import": "^2.31.0",
-  	"eslint-plugin-jam3": "^0.2.3",
-  	"eslint-plugin-json": "^4.0.1",
-  	"eslint-plugin-prettier": "^5.2.6",
-  	"eslint-plugin-promise": "^7.2.1",
-  	"eslint-plugin-react": "^7.37.5",
-  	"eslint-plugin-react-hooks": "^5.2.0",
-  	"eslint-plugin-security": "^3.0.1",
-  	"eslint-plugin-sonarjs": "^3.0.2",
-  	"eslint-plugin-unused-imports": "^4.1.4",
-  	globals: "^16.0.0",
-  	husky: "7.0.4",
-  	i18next: "21.7.0",
-  	jest: "27.5.1",
-  	"lint-staged": "12.4.1",
-  	minimatch: "^5.1.0",
-  	"mock-fs": "^5.2.0",
-  	prettier: "2.6.2",
-  	ramda: "0.29.0",
-  	rollup: "^4.24.0",
-  	"rollup-plugin-analyzer": "^4.0.0",
-  	"rollup-plugin-cleaner": "^1.0.0",
-  	"rollup-plugin-copy": "^3.5.0",
-  	"rollup-plugin-peer-deps-external": "^2.2.4",
-  	synckit: "^0.9.0"
-  };
-  var peerDependencies = {
-  	"@bigbinary/neeto-cist": "^1.0.3",
-  	"@bigbinary/neeto-commons-frontend": "4.13.38",
-  	eslint: "^9.25.1",
-  	i18next: "21.7.0",
-  	ramda: "0.29.0"
-  };
+  var version = "1.8.1";
   var packageJson = {
-  	name: name,
-  	version: version,
-  	main: main,
-  	license: license,
-  	scripts: scripts,
-  	"lint-staged": {
-  	"{package.json}": [
-  		"prettier --write",
-  		"eslint --fix --no-warn-ignored"
-  	],
-  	"**/*.js": [
-  		"prettier --write",
-  		"eslint --fix --no-warn-ignored"
-  	]
-  },
-  	files: files,
-  	engines: engines,
-  	dependencies: dependencies,
-  	devDependencies: devDependencies,
-  	peerDependencies: peerDependencies
-  };
+  	version: version};
 
   const prefix = "export default ";
   var jsonProcessor = {
@@ -459,7 +354,6 @@
     PROPERTY: "Property",
     RETURN_STATEMENT: "ReturnStatement",
     SPREAD_ELEMENT: "SpreadElement",
-    TEMPLATE_ELEMENT: "TemplateElement",
     TEMPLATE_LITERAL: "TemplateLiteral",
     UNARY_EXPRESSION: "UnaryExpression",
     VARIABLE_DECLARATION: "VariableDeclaration",
@@ -1865,8 +1759,8 @@
 
   var semver$1 = {exports: {}};
 
-  (function (module, exports) {
-  	exports = module.exports = SemVer;
+  (function (module, exports$1) {
+  	exports$1 = module.exports = SemVer;
 
   	var debug;
   	/* istanbul ignore next */
@@ -1885,7 +1779,7 @@
 
   	// Note: this is the semver.org version of the spec that it implements
   	// Not necessarily the package version of this code.
-  	exports.SEMVER_SPEC_VERSION = '2.0.0';
+  	exports$1.SEMVER_SPEC_VERSION = '2.0.0';
 
   	var MAX_LENGTH = 256;
   	var MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER ||
@@ -1897,10 +1791,10 @@
   	var MAX_SAFE_BUILD_LENGTH = MAX_LENGTH - 6;
 
   	// The actual regexps go on exports.re
-  	var re = exports.re = [];
-  	var safeRe = exports.safeRe = [];
-  	var src = exports.src = [];
-  	var t = exports.tokens = {};
+  	var re = exports$1.re = [];
+  	var safeRe = exports$1.safeRe = [];
+  	var src = exports$1.src = [];
+  	var t = exports$1.tokens = {};
   	var R = 0;
 
   	function tok (n) {
@@ -2158,7 +2052,7 @@
   	  }
   	}
 
-  	exports.parse = parse;
+  	exports$1.parse = parse;
   	function parse (version, options) {
   	  if (!options || typeof options !== 'object') {
   	    options = {
@@ -2191,19 +2085,19 @@
   	  }
   	}
 
-  	exports.valid = valid;
+  	exports$1.valid = valid;
   	function valid (version, options) {
   	  var v = parse(version, options);
   	  return v ? v.version : null
   	}
 
-  	exports.clean = clean;
+  	exports$1.clean = clean;
   	function clean (version, options) {
   	  var s = parse(version.trim().replace(/^[=v]+/, ''), options);
   	  return s ? s.version : null
   	}
 
-  	exports.SemVer = SemVer;
+  	exports$1.SemVer = SemVer;
 
   	function SemVer (version, options) {
   	  if (!options || typeof options !== 'object') {
@@ -2474,7 +2368,7 @@
   	  return this
   	};
 
-  	exports.inc = inc;
+  	exports$1.inc = inc;
   	function inc (version, release, loose, identifier) {
   	  if (typeof (loose) === 'string') {
   	    identifier = loose;
@@ -2488,7 +2382,7 @@
   	  }
   	}
 
-  	exports.diff = diff;
+  	exports$1.diff = diff;
   	function diff (version1, version2) {
   	  if (eq(version1, version2)) {
   	    return null
@@ -2511,7 +2405,7 @@
   	  }
   	}
 
-  	exports.compareIdentifiers = compareIdentifiers;
+  	exports$1.compareIdentifiers = compareIdentifiers;
 
   	var numeric = /^[0-9]+$/;
   	function compareIdentifiers (a, b) {
@@ -2530,93 +2424,93 @@
   	    : 1
   	}
 
-  	exports.rcompareIdentifiers = rcompareIdentifiers;
+  	exports$1.rcompareIdentifiers = rcompareIdentifiers;
   	function rcompareIdentifiers (a, b) {
   	  return compareIdentifiers(b, a)
   	}
 
-  	exports.major = major;
+  	exports$1.major = major;
   	function major (a, loose) {
   	  return new SemVer(a, loose).major
   	}
 
-  	exports.minor = minor;
+  	exports$1.minor = minor;
   	function minor (a, loose) {
   	  return new SemVer(a, loose).minor
   	}
 
-  	exports.patch = patch;
+  	exports$1.patch = patch;
   	function patch (a, loose) {
   	  return new SemVer(a, loose).patch
   	}
 
-  	exports.compare = compare;
+  	exports$1.compare = compare;
   	function compare (a, b, loose) {
   	  return new SemVer(a, loose).compare(new SemVer(b, loose))
   	}
 
-  	exports.compareLoose = compareLoose;
+  	exports$1.compareLoose = compareLoose;
   	function compareLoose (a, b) {
   	  return compare(a, b, true)
   	}
 
-  	exports.compareBuild = compareBuild;
+  	exports$1.compareBuild = compareBuild;
   	function compareBuild (a, b, loose) {
   	  var versionA = new SemVer(a, loose);
   	  var versionB = new SemVer(b, loose);
   	  return versionA.compare(versionB) || versionA.compareBuild(versionB)
   	}
 
-  	exports.rcompare = rcompare;
+  	exports$1.rcompare = rcompare;
   	function rcompare (a, b, loose) {
   	  return compare(b, a, loose)
   	}
 
-  	exports.sort = sort;
+  	exports$1.sort = sort;
   	function sort (list, loose) {
   	  return list.sort(function (a, b) {
-  	    return exports.compareBuild(a, b, loose)
+  	    return exports$1.compareBuild(a, b, loose)
   	  })
   	}
 
-  	exports.rsort = rsort;
+  	exports$1.rsort = rsort;
   	function rsort (list, loose) {
   	  return list.sort(function (a, b) {
-  	    return exports.compareBuild(b, a, loose)
+  	    return exports$1.compareBuild(b, a, loose)
   	  })
   	}
 
-  	exports.gt = gt;
+  	exports$1.gt = gt;
   	function gt (a, b, loose) {
   	  return compare(a, b, loose) > 0
   	}
 
-  	exports.lt = lt;
+  	exports$1.lt = lt;
   	function lt (a, b, loose) {
   	  return compare(a, b, loose) < 0
   	}
 
-  	exports.eq = eq;
+  	exports$1.eq = eq;
   	function eq (a, b, loose) {
   	  return compare(a, b, loose) === 0
   	}
 
-  	exports.neq = neq;
+  	exports$1.neq = neq;
   	function neq (a, b, loose) {
   	  return compare(a, b, loose) !== 0
   	}
 
-  	exports.gte = gte;
+  	exports$1.gte = gte;
   	function gte (a, b, loose) {
   	  return compare(a, b, loose) >= 0
   	}
 
-  	exports.lte = lte;
+  	exports$1.lte = lte;
   	function lte (a, b, loose) {
   	  return compare(a, b, loose) <= 0
   	}
 
-  	exports.cmp = cmp;
+  	exports$1.cmp = cmp;
   	function cmp (a, op, b, loose) {
   	  switch (op) {
   	    case '===':
@@ -2658,7 +2552,7 @@
   	  }
   	}
 
-  	exports.Comparator = Comparator;
+  	exports$1.Comparator = Comparator;
   	function Comparator (comp, options) {
   	  if (!options || typeof options !== 'object') {
   	    options = {
@@ -2790,7 +2684,7 @@
   	    oppositeDirectionsLessThan || oppositeDirectionsGreaterThan
   	};
 
-  	exports.Range = Range;
+  	exports$1.Range = Range;
   	function Range (range, options) {
   	  if (!options || typeof options !== 'object') {
   	    options = {
@@ -2934,7 +2828,7 @@
   	}
 
   	// Mostly just for testing and legacy API reasons
-  	exports.toComparators = toComparators;
+  	exports$1.toComparators = toComparators;
   	function toComparators (range, options) {
   	  return new Range(range, options).set.map(function (comp) {
   	    return comp.map(function (c) {
@@ -3245,7 +3139,7 @@
   	  return true
   	}
 
-  	exports.satisfies = satisfies;
+  	exports$1.satisfies = satisfies;
   	function satisfies (version, range, options) {
   	  try {
   	    range = new Range(range, options);
@@ -3255,7 +3149,7 @@
   	  return range.test(version)
   	}
 
-  	exports.maxSatisfying = maxSatisfying;
+  	exports$1.maxSatisfying = maxSatisfying;
   	function maxSatisfying (versions, range, options) {
   	  var max = null;
   	  var maxSV = null;
@@ -3277,7 +3171,7 @@
   	  return max
   	}
 
-  	exports.minSatisfying = minSatisfying;
+  	exports$1.minSatisfying = minSatisfying;
   	function minSatisfying (versions, range, options) {
   	  var min = null;
   	  var minSV = null;
@@ -3299,7 +3193,7 @@
   	  return min
   	}
 
-  	exports.minVersion = minVersion;
+  	exports$1.minVersion = minVersion;
   	function minVersion (range, loose) {
   	  range = new Range(range, loose);
 
@@ -3353,7 +3247,7 @@
   	  return null
   	}
 
-  	exports.validRange = validRange;
+  	exports$1.validRange = validRange;
   	function validRange (range, options) {
   	  try {
   	    // Return '*' instead of '' so that truthiness works.
@@ -3365,18 +3259,18 @@
   	}
 
   	// Determine if version is less than all the versions possible in the range
-  	exports.ltr = ltr;
+  	exports$1.ltr = ltr;
   	function ltr (version, range, options) {
   	  return outside(version, range, '<', options)
   	}
 
   	// Determine if version is greater than all the versions possible in the range.
-  	exports.gtr = gtr;
+  	exports$1.gtr = gtr;
   	function gtr (version, range, options) {
   	  return outside(version, range, '>', options)
   	}
 
-  	exports.outside = outside;
+  	exports$1.outside = outside;
   	function outside (version, range, hilo, options) {
   	  version = new SemVer(version, options);
   	  range = new Range(range, options);
@@ -3446,20 +3340,20 @@
   	  return true
   	}
 
-  	exports.prerelease = prerelease;
+  	exports$1.prerelease = prerelease;
   	function prerelease (version, options) {
   	  var parsed = parse(version, options);
   	  return (parsed && parsed.prerelease.length) ? parsed.prerelease : null
   	}
 
-  	exports.intersects = intersects;
+  	exports$1.intersects = intersects;
   	function intersects (r1, r2, options) {
   	  r1 = new Range(r1, options);
   	  r2 = new Range(r2, options);
   	  return r1.intersects(r2)
   	}
 
-  	exports.coerce = coerce;
+  	exports$1.coerce = coerce;
   	function coerce (version, options) {
   	  if (version instanceof SemVer) {
   	    return version
@@ -3822,7 +3716,7 @@
       var isOptions = m.body.indexOf(',') >= 0;
       if (!isSequence && !isOptions) {
         // {a},b}
-        if (m.post.match(/,.*\}/)) {
+        if (m.post.match(/,(?!,).*\}/)) {
           str = m.pre + '{' + m.body + escClose + m.post;
           return expand$1(str);
         }
@@ -4066,7 +3960,9 @@
 
   // replace stuff like \* with *
   const globUnescape = s => s.replace(/\\(.)/g, '$1');
+  const charUnescape = s => s.replace(/\\([^-\]])/g, '$1');
   const regExpEscape = s => s.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, '\\$&');
+  const braExpEscape = s => s.replace(/[[\]\\]/g, '\\$&');
 
   class Minimatch {
     constructor (pattern, options) {
@@ -4075,6 +3971,8 @@
       if (!options) options = {};
 
       this.options = options;
+      this.maxGlobstarRecursion = options.maxGlobstarRecursion !== undefined
+        ? options.maxGlobstarRecursion : 200;
       this.set = [];
       this.pattern = pattern;
       this.windowsPathsNoEscape = !!options.windowsPathsNoEscape ||
@@ -4152,7 +4050,7 @@
         negateOffset++;
       }
 
-      if (negateOffset) this.pattern = pattern.substr(negateOffset);
+      if (negateOffset) this.pattern = pattern.slice(negateOffset);
       this.negate = negate;
     }
 
@@ -4162,114 +4060,172 @@
     // out of pattern, then that's fine, as long as all
     // the parts match.
     matchOne (file, pattern, partial) {
-      var options = this.options;
+      if (pattern.indexOf(GLOBSTAR) !== -1) {
+        return this._matchGlobstar(file, pattern, partial, 0, 0)
+      }
+      return this._matchOne(file, pattern, partial, 0, 0)
+    }
 
-      this.debug('matchOne',
-        { 'this': this, file: file, pattern: pattern });
+    _matchGlobstar (file, pattern, partial, fileIndex, patternIndex) {
+      // find first globstar from patternIndex
+      let firstgs = -1;
+      for (let i = patternIndex; i < pattern.length; i++) {
+        if (pattern[i] === GLOBSTAR) { firstgs = i; break }
+      }
 
-      this.debug('matchOne', file.length, pattern.length);
+      // find last globstar
+      let lastgs = -1;
+      for (let i = pattern.length - 1; i >= 0; i--) {
+        if (pattern[i] === GLOBSTAR) { lastgs = i; break }
+      }
 
-      for (var fi = 0,
-          pi = 0,
-          fl = file.length,
-          pl = pattern.length
-          ; (fi < fl) && (pi < pl)
-          ; fi++, pi++) {
-        this.debug('matchOne loop');
-        var p = pattern[pi];
-        var f = file[fi];
+      const head = pattern.slice(patternIndex, firstgs);
+      const body = partial ? pattern.slice(firstgs + 1) : pattern.slice(firstgs + 1, lastgs);
+      const tail = partial ? [] : pattern.slice(lastgs + 1);
 
-        this.debug(pattern, p, f);
+      // check the head
+      if (head.length) {
+        const fileHead = file.slice(fileIndex, fileIndex + head.length);
+        if (!this._matchOne(fileHead, head, partial, 0, 0)) {
+          return false
+        }
+        fileIndex += head.length;
+      }
 
-        // should be impossible.
-        // some invalid regexp stuff in the set.
-        /* istanbul ignore if */
-        if (p === false) return false
-
-        if (p === GLOBSTAR) {
-          this.debug('GLOBSTAR', [pattern, p, f]);
-
-          // "**"
-          // a/**/b/**/c would match the following:
-          // a/b/x/y/z/c
-          // a/x/y/z/b/c
-          // a/b/x/b/x/c
-          // a/b/c
-          // To do this, take the rest of the pattern after
-          // the **, and see if it would match the file remainder.
-          // If so, return success.
-          // If not, the ** "swallows" a segment, and try again.
-          // This is recursively awful.
-          //
-          // a/**/b/**/c matching a/b/x/y/z/c
-          // - a matches a
-          // - doublestar
-          //   - matchOne(b/x/y/z/c, b/**/c)
-          //     - b matches b
-          //     - doublestar
-          //       - matchOne(x/y/z/c, c) -> no
-          //       - matchOne(y/z/c, c) -> no
-          //       - matchOne(z/c, c) -> no
-          //       - matchOne(c, c) yes, hit
-          var fr = fi;
-          var pr = pi + 1;
-          if (pr === pl) {
-            this.debug('** at the end');
-            // a ** at the end will just swallow the rest.
-            // We have found a match.
-            // however, it will not swallow /.x, unless
-            // options.dot is set.
-            // . and .. are *never* matched by **, for explosively
-            // exponential reasons.
-            for (; fi < fl; fi++) {
-              if (file[fi] === '.' || file[fi] === '..' ||
-                (!options.dot && file[fi].charAt(0) === '.')) return false
-            }
-            return true
+      // check the tail
+      let fileTailMatch = 0;
+      if (tail.length) {
+        if (tail.length + fileIndex > file.length) return false
+
+        const tailStart = file.length - tail.length;
+        if (this._matchOne(file, tail, partial, tailStart, 0)) {
+          fileTailMatch = tail.length;
+        } else {
+          // affordance for stuff like a/**/* matching a/b/
+          if (file[file.length - 1] !== '' ||
+              fileIndex + tail.length === file.length) {
+            return false
           }
+          if (!this._matchOne(file, tail, partial, tailStart - 1, 0)) {
+            return false
+          }
+          fileTailMatch = tail.length + 1;
+        }
+      }
 
-          // ok, let's see if we can swallow whatever we can.
-          while (fr < fl) {
-            var swallowee = file[fr];
+      // if body is empty (single ** between head and tail)
+      if (!body.length) {
+        let sawSome = !!fileTailMatch;
+        for (let i = fileIndex; i < file.length - fileTailMatch; i++) {
+          const f = String(file[i]);
+          sawSome = true;
+          if (f === '.' || f === '..' ||
+              (!this.options.dot && f.charAt(0) === '.')) {
+            return false
+          }
+        }
+        return partial || sawSome
+      }
+
+      // split body into segments at each GLOBSTAR
+      const bodySegments = [[[], 0]];
+      let currentBody = bodySegments[0];
+      let nonGsParts = 0;
+      const nonGsPartsSums = [0];
+      for (const b of body) {
+        if (b === GLOBSTAR) {
+          nonGsPartsSums.push(nonGsParts);
+          currentBody = [[], 0];
+          bodySegments.push(currentBody);
+        } else {
+          currentBody[0].push(b);
+          nonGsParts++;
+        }
+      }
 
-            this.debug('\nglobstar while', file, fr, pattern, pr, swallowee);
+      let idx = bodySegments.length - 1;
+      const fileLength = file.length - fileTailMatch;
+      for (const b of bodySegments) {
+        b[1] = fileLength - (nonGsPartsSums[idx--] + b[0].length);
+      }
 
-            // XXX remove this slice.  Just pass the start index.
-            if (this.matchOne(file.slice(fr), pattern.slice(pr), partial)) {
-              this.debug('globstar found match!', fr, fl, swallowee);
-              // found a match.
-              return true
-            } else {
-              // can't swallow "." or ".." ever.
-              // can only swallow ".foo" when explicitly asked.
-              if (swallowee === '.' || swallowee === '..' ||
-                (!options.dot && swallowee.charAt(0) === '.')) {
-                this.debug('dot detected!', file, fr, pattern, pr);
-                break
-              }
+      return !!this._matchGlobStarBodySections(
+        file, bodySegments, fileIndex, 0, partial, 0, !!fileTailMatch
+      )
+    }
 
-              // ** swallows a segment, and continue.
-              this.debug('globstar swallow a segment, and continue');
-              fr++;
-            }
+    // return false for "nope, not matching"
+    // return null for "not matching, cannot keep trying"
+    _matchGlobStarBodySections (
+      file, bodySegments, fileIndex, bodyIndex, partial, globStarDepth, sawTail
+    ) {
+      const bs = bodySegments[bodyIndex];
+      if (!bs) {
+        // just make sure there are no bad dots
+        for (let i = fileIndex; i < file.length; i++) {
+          sawTail = true;
+          const f = file[i];
+          if (f === '.' || f === '..' ||
+              (!this.options.dot && f.charAt(0) === '.')) {
+            return false
           }
-
-          // no match was found.
-          // However, in partial mode, we can't say this is necessarily over.
-          // If there's more *pattern* left, then
-          /* istanbul ignore if */
-          if (partial) {
-            // ran out of file
-            this.debug('\n>>> no match, partial?', file, fr, pattern, pr);
-            if (fr === fl) return true
+        }
+        return sawTail
+      }
+
+      const [body, after] = bs;
+      while (fileIndex <= after) {
+        const m = this._matchOne(
+          file.slice(0, fileIndex + body.length),
+          body,
+          partial,
+          fileIndex,
+          0
+        );
+        // if limit exceeded, no match. intentional false negative,
+        // acceptable break in correctness for security.
+        if (m && globStarDepth < this.maxGlobstarRecursion) {
+          const sub = this._matchGlobStarBodySections(
+            file, bodySegments,
+            fileIndex + body.length, bodyIndex + 1,
+            partial, globStarDepth + 1, sawTail
+          );
+          if (sub !== false) {
+            return sub
           }
+        }
+        const f = file[fileIndex];
+        if (f === '.' || f === '..' ||
+            (!this.options.dot && f.charAt(0) === '.')) {
           return false
         }
+        fileIndex++;
+      }
+      return partial || null
+    }
+
+    _matchOne (file, pattern, partial, fileIndex, patternIndex) {
+      let fi, pi, fl, pl;
+      for (
+        fi = fileIndex, pi = patternIndex, fl = file.length, pl = pattern.length
+        ; (fi < fl) && (pi < pl)
+        ; fi++, pi++
+      ) {
+        this.debug('matchOne loop');
+        const p = pattern[pi];
+        const f = file[fi];
+
+        this.debug(pattern, p, f);
+
+        // should be impossible.
+        // some invalid regexp stuff in the set.
+        /* istanbul ignore if */
+        if (p === false || p === GLOBSTAR) return false
 
         // something other than **
         // non-magic patterns just have to match exactly
         // patterns with magic have been turned into regexps.
-        var hit;
+        let hit;
         if (typeof p === 'string') {
           hit = f === p;
           this.debug('string match', p, f, hit);
@@ -4281,17 +4237,6 @@
         if (!hit) return false
       }
 
-      // Note: ending in / means that we'll get a final ""
-      // at the end of the pattern.  This can only match a
-      // corresponding "" at the end of the file.
-      // If the file ends in /, then it can only match a
-      // a pattern that ends in /, unless the pattern just
-      // doesn't have any more for it. But, a/b/ should *not*
-      // match "a/b/*", even though "" matches against the
-      // [^/]*? pattern, except in partial mode, where it might
-      // simply not be reached yet.
-      // However, a/b/ should still satisfy a/*
-
       // now either we fell off the end of the pattern, or we're done.
       if (fi === fl && pi === pl) {
         // ran out of pattern and filename at the same time.
@@ -4334,7 +4279,7 @@
       if (pattern === '') return ''
 
       let re = '';
-      let hasMagic = !!options.nocase;
+      let hasMagic = false;
       let escaping = false;
       // ? => one single character
       const patternListStack = [];
@@ -4347,11 +4292,23 @@
       let pl;
       let sp;
       // . and .. never match anything that doesn't start with .,
-      // even when options.dot is set.
-      const patternStart = pattern.charAt(0) === '.' ? '' // anything
-      // not (start or / followed by . or .. followed by / or end)
-      : options.dot ? '(?!(?:^|\\\/)\\.{1,2}(?:$|\\\/))'
-      : '(?!\\.)';
+      // even when options.dot is set.  However, if the pattern
+      // starts with ., then traversal patterns can match.
+      let dotTravAllowed = pattern.charAt(0) === '.';
+      let dotFileAllowed = options.dot || dotTravAllowed;
+      const patternStart = () =>
+        dotTravAllowed
+          ? ''
+          : dotFileAllowed
+          ? '(?!(?:^|\\/)\\.{1,2}(?:$|\\/))'
+          : '(?!\\.)';
+      const subPatternStart = (p) =>
+        p.charAt(0) === '.'
+          ? ''
+          : options.dot
+          ? '(?!(?:^|\\/)\\.{1,2}(?:$|\\/))'
+          : '(?!\\.)';
+
 
       const clearStateChar = () => {
         if (stateChar) {
@@ -4401,6 +4358,11 @@
           }
 
           case '\\':
+            if (inClass && pattern.charAt(i + 1) === '-') {
+              re += c;
+              continue
+            }
+
             clearStateChar();
             escaping = true;
           continue
@@ -4423,6 +4385,9 @@
               continue
             }
 
+            // coalesce consecutive non-globstar * characters
+            if (c === '*' && stateChar === '*') continue
+
             // if we already have a stateChar, then it means
             // that there was something like ** or +? in there.
             // Handle the stateChar, then proceed with this one.
@@ -4435,7 +4400,7 @@
             if (options.noext) clearStateChar();
           continue
 
-          case '(':
+          case '(': {
             if (inClass) {
               re += '(';
               continue
@@ -4446,46 +4411,64 @@
               continue
             }
 
-            patternListStack.push({
+            const plEntry = {
               type: stateChar,
               start: i - 1,
               reStart: re.length,
               open: plTypes[stateChar].open,
-              close: plTypes[stateChar].close
-            });
-            // negation is (?:(?!js)[^/]*)
-            re += stateChar === '!' ? '(?:(?!(?:' : '(?:';
+              close: plTypes[stateChar].close,
+            };
+            this.debug(this.pattern, '\t', plEntry);
+            patternListStack.push(plEntry);
+            // negation is (?:(?!(?:js)(?:<rest>))[^/]*)
+            re += plEntry.open;
+            // next entry starts with a dot maybe?
+            if (plEntry.start === 0 && plEntry.type !== '!') {
+              dotTravAllowed = true;
+              re += subPatternStart(pattern.slice(i + 1));
+            }
             this.debug('plType %j %j', stateChar, re);
             stateChar = false;
-          continue
+            continue
+          }
 
-          case ')':
-            if (inClass || !patternListStack.length) {
+          case ')': {
+            const plEntry = patternListStack[patternListStack.length - 1];
+            if (inClass || !plEntry) {
               re += '\\)';
               continue
             }
+            patternListStack.pop();
 
+            // closing an extglob
             clearStateChar();
             hasMagic = true;
-            pl = patternListStack.pop();
+            pl = plEntry;
             // negation is (?:(?!js)[^/]*)
             // The others are (?:<pattern>)<type>
             re += pl.close;
             if (pl.type === '!') {
-              negativeLists.push(pl);
+              negativeLists.push(Object.assign(pl, { reEnd: re.length }));
             }
-            pl.reEnd = re.length;
-          continue
+            continue
+          }
 
-          case '|':
-            if (inClass || !patternListStack.length) {
+          case '|': {
+            const plEntry = patternListStack[patternListStack.length - 1];
+            if (inClass || !plEntry) {
               re += '\\|';
               continue
             }
 
             clearStateChar();
             re += '|';
-          continue
+            // next subpattern can start with a dot?
+            if (plEntry.start === 0 && plEntry.type !== '!') {
+              dotTravAllowed = true;
+              re += subPatternStart(pattern.slice(i + 1));
+            }
+            continue
+          }
 
           // these are mostly the same in regexp and glob
           case '[':
@@ -4513,8 +4496,6 @@
               continue
             }
 
-            // handle the case where we left a class open.
-            // "[z-a]" is valid, equivalent to "\[z-a\]"
             // split where the last [ was, make sure we don't have
             // an invalid re. if so, re-walk the contents of the
             // would-be class to re-translate any characters that
@@ -4524,20 +4505,16 @@
             // to do safely.  For now, this is safe and works.
             cs = pattern.substring(classStart + 1, i);
             try {
-              RegExp('[' + cs + ']');
+              RegExp('[' + braExpEscape(charUnescape(cs)) + ']');
+              // looks good, finish up the class.
+              re += c;
             } catch (er) {
-              // not a valid class!
-              sp = this.parse(cs, SUBPARSE);
-              re = re.substr(0, reClassStart) + '\\[' + sp[0] + '\\]';
-              hasMagic = hasMagic || sp[1];
-              inClass = false;
-              continue
+              // out of order ranges in JS are errors, but in glob syntax,
+              // they're just a range that matches nothing.
+              re = re.substring(0, reClassStart) + '(?:$.)'; // match nothing ever
             }
-
-            // finish up the class.
             hasMagic = true;
             inClass = false;
-            re += c;
           continue
 
           default:
@@ -4561,9 +4538,9 @@
         // this is a huge pita.  We now have to re-walk
         // the contents of the would-be class to re-translate
         // any characters that were passed through as-is
-        cs = pattern.substr(classStart + 1);
+        cs = pattern.slice(classStart + 1);
         sp = this.parse(cs, SUBPARSE);
-        re = re.substr(0, reClassStart) + '\\[' + sp[0];
+        re = re.substring(0, reClassStart) + '\\[' + sp[0];
         hasMagic = hasMagic || sp[1];
       }
 
@@ -4630,14 +4607,16 @@
         // Handle nested stuff like *(*.js|!(*.json)), where open parens
         // mean that we should *not* include the ) in the bit that is considered
         // "after" the negated section.
-        const openParensBefore = nlBefore.split('(').length - 1;
+        const closeParensBefore = nlBefore.split(')').length;
+        const openParensBefore = nlBefore.split('(').length - closeParensBefore;
         let cleanAfter = nlAfter;
         for (let i = 0; i < openParensBefore; i++) {
           cleanAfter = cleanAfter.replace(/\)[+*?]?/, '');
         }
         nlAfter = cleanAfter;
 
-        const dollar = nlAfter === '' && isSub !== SUBPARSE ? '$' : '';
+        const dollar = nlAfter === '' && isSub !== SUBPARSE ? '(?:$|\\/)' : '';
+
         re = nlBefore + nlFirst + nlAfter + dollar + nlLast;
       }
 
@@ -4649,7 +4628,7 @@
       }
 
       if (addPatternStart) {
-        re = patternStart + re;
+        re = patternStart() + re;
       }
 
       // parsing just a piece of a larger pattern.
@@ -4657,6 +4636,11 @@
         return [re, hasMagic]
       }
 
+      // if it's nocase, and the lcase/uppercase don't match, it's magic
+      if (options.nocase && !hasMagic) {
+        hasMagic = pattern.toUpperCase() !== pattern.toLowerCase();
+      }
+
       // skip the regexp for non-magical patterns
       // unescape anything in it, though, so that it'll be
       // an exact match against a file etc.
@@ -7293,7 +7277,6 @@
   };
 
   ({
-    type: TYPES.VARIABLE_DECLARATION,
     declarations: [{
       type: TYPES.VARIABLE_DECLARATOR,
       init: {
@@ -7306,11 +7289,8 @@
     }]
   });
   ({
-    type: TYPES.EXPRESSION_STATEMENT,
     expression: {
-      type: TYPES.CALL_EXPRESSION,
       callee: {
-        type: TYPES.IDENTIFIER,
         name: ramda.test(/use[a-zA-z0-9].+/)
       }
     }
@@ -11748,7 +11728,6 @@
   // useCurrentUserStore()
   ({
     callee: {
-      type: TYPES.IDENTIFIER,
       name: ramda.test(/use[a-zA-z0-9].+Store/)
     }
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/eslint-plugin-neeto",
-  "version": "1.8.1",
+  "version": "1.8.2",
   "main": "dist/index.js",
   "license": "UNLICENSED",
   "scripts": {