@bigbinary/eslint-plugin-neeto 1.5.8 → 1.6.0

package/dist/index.js

@@ -615,13 +615,14 @@
   });
 
   const removeComments = json => json.replace(/\\"|"(?:\\"|[^"])*"|(\/\/.*|\/\*[\s\S]*?\*\/)/g, (m, g) => g ? "" : m);
-  const addNullSafeImport = (context, fixer) => {
+  const addNullSafeImport = (context, fixer, node) => {
     const importPattern = ramda.assocPath(["source", "value"], "neetocist", IMPORT_DECLARATION);
     return addFunctionImport({
       context,
       fixer,
       functions: ["nullSafe"],
-      importPattern
+      importPattern,
+      node
     });
   };
 
@@ -688,9 +689,10 @@
     context,
     fixer,
     functions,
-    importPattern
+    importPattern,
+    node
   }) => {
-    const root = context.getAncestors()[0];
+    const root = context.sourceCode.getAncestors(node)[0];
     const packageImport = root.body.find(neetoCist.matches(importPattern));
     if (packageImport) {
       const extraImports = functions.filter(func => !packageImport.specifiers.some(ramda.pathEq(func, ["imported", "name"])));
@@ -712,11 +714,12 @@
         context,
         fixer,
         functions: Array.isArray(functions) ? functions : [functions],
-        importPattern
+        importPattern,
+        node
       });
       if (imports) yield imports;
       if (importNullSafe) {
-        const nullSafeImport = addNullSafeImport(context, fixer);
+        const nullSafeImport = addNullSafeImport(context, fixer, node);
         if (nullSafeImport) yield nullSafeImport;
       }
       yield fixer.replaceText(node, fix);
@@ -1058,7 +1061,7 @@
     }) => value.cooked.includes("?"))
   };
 
-  const isRoutesImportPresent = context => context.getAncestors()[0].body.some(neetoCist.matches(ROUTES_IMPORT_PATTERN));
+  const isRoutesImportPresent = (context, node) => context.sourceCode.getAncestors(node)[0].body.some(neetoCist.matches(ROUTES_IMPORT_PATTERN));
   var noRoutesDestructureAndReassignment = {
     meta: {
       type: "problem",
@@ -1069,17 +1072,17 @@
     },
     create: context => ({
       VariableDeclaration(node) {
-        if (neetoCist.matches(DECALARATION_PATTERN$1, node) && isRoutesImportPresent(context)) {
+        if (neetoCist.matches(DECALARATION_PATTERN$1, node) && isRoutesImportPresent(context, node)) {
           context.report(node, ROUTES_HAS_ALREADY_BEEN_DECLARED);
         }
       },
       VariableDeclarator(node) {
-        if (neetoCist.matches(ASSIGNMENT_PATTERN, node) && isRoutesImportPresent(context)) {
+        if (neetoCist.matches(ASSIGNMENT_PATTERN, node) && isRoutesImportPresent(context, node)) {
           context.report(node, NO_ROUTES_ASSIGNMENT);
         }
       },
       AssignmentExpression(node) {
-        if (neetoCist.matches(REASSIGNMENT_PATTERN, node) && isRoutesImportPresent(context)) {
+        if (neetoCist.matches(REASSIGNMENT_PATTERN, node) && isRoutesImportPresent(context, node)) {
           context.report(node, NO_ROUTES_REASSIGNMENT);
         }
       }
@@ -4689,14 +4692,12 @@
   const findMatchedConfig = (context, configs) => {
     const fullFilePath = context.getFilename();
     const basePath = context.options[0].basePath;
-    const matchedConfig = configs.find(config => {
+    return configs.find(config => {
       const isIncluded = asArray(config.includes).some(pathPattern => minimatch$1(fullFilePath, basePath + pathPattern));
       if (config.includes && !isIncluded) return false;
       const isExcluded = asArray(config.excludes).some(pathPattern => minimatch$1(fullFilePath, basePath + pathPattern));
-      if (config.excludes && isExcluded) return false;
-      return true;
+      return !(config.excludes && isExcluded);
     });
-    return matchedConfig;
   };
   const checkFilenameCase = (context, node, filenameCase) => {
     const [filename] = getFilenameAndExtension(context);
@@ -4817,6 +4818,51 @@
       docs: {
         url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/file-name-and-export-name-standards.md",
         description: "Allows you to enforce a consistent naming pattern for the filenames and exports."
+      },
+      schema: {
+        type: "array",
+        items: [{
+          type: "object",
+          properties: {
+            basePath: {
+              type: "string"
+            },
+            default: {
+              type: "object",
+              properties: {
+                filenameCase: {
+                  type: "string"
+                },
+                exportnameCase: {
+                  type: "string"
+                }
+              }
+            },
+            configs: {
+              type: "array",
+              items: [{
+                filenameCase: {
+                  type: "string"
+                },
+                exportnameCase: {
+                  type: "string"
+                },
+                includes: {
+                  type: ["string", "array"],
+                  items: [{
+                    type: "string"
+                  }]
+                },
+                excludes: {
+                  type: ["string", "array"],
+                  items: [{
+                    type: "string"
+                  }]
+                }
+              }]
+            }
+          }
+        }]
       }
     },
     create: context => ({
@@ -5243,7 +5289,7 @@
     }
     const isJSXTextType = node.type === TYPES.JSX_TEXT;
     if (isJSXTextType) return true;
-    const ancestors = context.getAncestors(node);
+    const ancestors = context.sourceCode.getAncestors(node);
     const isMatchesNaturalLangRegex = NATURAL_LANGUAGE_REGEX.test(nodeValue);
     for (let i = ancestors.length - 1; i > 0; i--) {
       const parent = ancestors[i];
@@ -5446,6 +5492,29 @@
       docs: {
         url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/no-missing-localization.md",
         description: "Detects localization keys that do not have an associated value in the translations."
+      },
+      schema: {
+        type: "array",
+        items: [{
+          type: "object",
+          properties: {
+            translationsDir: {
+              type: "string"
+            },
+            languages: {
+              type: "array",
+              items: [{
+                type: "string"
+              }]
+            },
+            nanosTranslationDir: {
+              type: "array",
+              items: [{
+                type: "string"
+              }]
+            }
+          }
+        }]
       }
     },
     create: context => {
@@ -6538,7 +6607,8 @@
   const reportSuggestion$1 = ({
     context,
     historyMethodCall,
-    computeFix
+    computeFix,
+    node
   }) => context.report({
     node: historyMethodCall,
     message: CAN_BE_REPLACED_WITH_HANDLE_META_CLICK,
@@ -6554,7 +6624,8 @@
           context,
           fixer,
           functions: ["handleMetaClick"],
-          importPattern: REACT_UTILS_IMPORT_PATTERN$2
+          importPattern: REACT_UTILS_IMPORT_PATTERN$2,
+          node
         });
         if (importStatement) fixerArray.push(importStatement);
         return fixerArray;
@@ -6586,6 +6657,7 @@
       reportSuggestion$1({
         context,
         historyMethodCall,
+        node,
         computeFix: ({
           fixerArray,
           fixer
@@ -6857,6 +6929,17 @@
       docs: {
         url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/no-axios-import-outside-apis.md",
         description: `Axios should only be imported and used inside scripts within the "apis" directory`
+      },
+      schema: {
+        type: "array",
+        items: [{
+          type: "object",
+          patternProperties: {
+            ".*": {
+              type: "string"
+            }
+          }
+        }]
       }
     },
     create: context => ({
@@ -7107,7 +7190,8 @@
               context,
               fixer,
               functions: ["withT"],
-              importPattern: NEETO_COMMONS_REACT_UTILS_IMPORT_PATTERN
+              importPattern: NEETO_COMMONS_REACT_UTILS_IMPORT_PATTERN,
+              node
             });
             importWithT && fixers.push(importWithT);
             return fixers;
@@ -7174,6 +7258,17 @@
       docs: {
         url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/no-large-functions-inside-jsx.md",
         description: "Disallows the use of functions with large bodies, that exceed maxAllowedNoOfLines, directly inside JSX elements." + "The default value for maxAllowedNoOfLines is 4."
+      },
+      schema: {
+        type: "array",
+        items: [{
+          type: "object",
+          properties: {
+            maxAllowedNoOfLines: {
+              type: "number"
+            }
+          }
+        }]
       }
     },
     create: context => ({
@@ -7294,6 +7389,17 @@
       docs: {
         url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/no-multiple-components-in-a-file.md",
         description: "Do not have multiple component definitions that exceed maxAllowedNoOfLines in a single file." + "The default value for maxAllowedNoOfLines is 20."
+      },
+      schema: {
+        type: "array",
+        items: [{
+          type: "object",
+          properties: {
+            maxAllowedNoOfLines: {
+              type: "number"
+            }
+          }
+        }]
       }
     },
     create: context => ({
@@ -7775,14 +7881,14 @@
     const codeInsideBody = getCode$1(context, arrowFunctionExpression.body);
     const codeWithUseTranslation = insertTextAfterPosition(0, codeInsideBody, "const { t } = useTranslation();\n");
     const updatedProps = getPropsCode(context, arrowFunctionExpression, props);
-    const replacedCodeWithUseTranslation = `(${updatedProps}${ramda.isEmpty(restParams) ? "" : `${neetoCist.isNotEmpty(updatedProps) ? ", " : "{}, "}${restParams.map(param => getCode$1(context, param)).join(", ")}`}) => ${codeWithUseTranslation}`;
-    return replacedCodeWithUseTranslation;
+    return `(${updatedProps}${ramda.isEmpty(restParams) ? "" : `${neetoCist.isNotEmpty(updatedProps) ? ", " : "{}, "}${restParams.map(param => getCode$1(context, param)).join(", ")}`}) => ${codeWithUseTranslation}`;
   };
-  const createUseTranslationImport = (context, fixer) => addFunctionImport({
+  const createUseTranslationImport = (context, fixer, node) => addFunctionImport({
     context,
     fixer,
     functions: ["useTranslation"],
-    importPattern: REACT_I18_IMPORT_PATTERN
+    importPattern: REACT_I18_IMPORT_PATTERN,
+    node
   });
   const insertTextAfterPosition = (position, inputString, textToInsert) => {
     const firstCharacter = inputString.charAt(position);
@@ -7806,7 +7912,7 @@
       } else {
         fixers.push(fixer.replaceText(node.declarations[0].init, replacedCodeWithUseTranslation));
       }
-      const importUseTranslation = createUseTranslationImport(context, fixer);
+      const importUseTranslation = createUseTranslationImport(context, fixer, node);
       importUseTranslation && fixers.push(importUseTranslation);
       return fixers;
     }
@@ -7895,17 +8001,16 @@
       type: "problem",
       docs: {
         url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/prefix-neeto-ui-import-alias.md",
-        description: PREFIX_NEETO_UI_IMPORT_ALIAS_MESSAGE,
-        schema: {
-          type: "object",
-          description: "An object mapping aliases to paths.",
-          patternProperties: {
-            "*": {
-              type: "string"
-            }
+        description: PREFIX_NEETO_UI_IMPORT_ALIAS_MESSAGE
+      },
+      schema: [{
+        type: "object",
+        patternProperties: {
+          ".*": {
+            type: "string"
           }
         }
-      }
+      }]
     },
     create: context => ({
       ImportSpecifier(node) {
@@ -8303,8 +8408,8 @@
               fix: fixer => {
                 let fixToRemoveComma = null;
                 let fixToRemoveErrorNode = fixer.remove(property);
-                const tokenBefore = context.getTokenBefore(property);
-                const tokenAfter = context.getTokenAfter(property);
+                const tokenBefore = context.sourceCode.getTokenBefore(property);
+                const tokenAfter = context.sourceCode.getTokenAfter(property);
                 if (tokenAfter.value === ",") {
                   fixToRemoveComma = fixer.remove(tokenAfter);
                 } else if (tokenBefore.value === ",") {
@@ -9489,7 +9594,7 @@
             const fixerArray = [fixer.replaceText(expressionNode, fixString)];
             const importExists = neetoCist.existsBy(CLASSNAMES_IMPORT_PATTERN, getAllImports(node));
             if (!importExists) {
-              const addImport = fixer.insertTextBefore(context.getAncestors()[0], 'import classnames from "classnames";\n');
+              const addImport = fixer.insertTextBefore(context.sourceCode.getAncestors(node)[0], 'import classnames from "classnames";\n');
               fixerArray.push(addImport);
             }
             return fixerArray;
@@ -9740,7 +9845,8 @@
                   context,
                   fixer,
                   functions: ["createSubscription"],
-                  importPattern: NEETO_COMMONS_UTILS_IMPORT_PATTERN
+                  importPattern: NEETO_COMMONS_UTILS_IMPORT_PATTERN,
+                  node
                 });
                 if (addedImport) fixerArray.push(addedImport);
                 return fixerArray;
@@ -10247,7 +10353,8 @@
               context,
               fixer,
               functions: ["showThumbsUpToastr"],
-              importPattern: NEETO_COMMONS_UTILS_IMPORT_PATTERN
+              importPattern: NEETO_COMMONS_UTILS_IMPORT_PATTERN,
+              node
             });
             if (addImport) fixerArr.push(addImport);
             return fixerArr;
@@ -10487,14 +10594,15 @@
         context,
         fixer,
         functions: ["useMutationWithInvalidation"],
-        importPattern: REACT_UTILS_IMPORT_PATTERN$1
+        importPattern: REACT_UTILS_IMPORT_PATTERN$1,
+        node
       });
       fixerArray.push(addImport);
     }
     return fixerArray;
   };
   const getRemoveCommaFix = (context, fixer, onSuccess) => {
-    const tokenAfter = context.getTokenAfter(onSuccess);
+    const tokenAfter = context.sourceCode.getTokenAfter(onSuccess);
     return tokenAfter.value === "," ? fixer.remove(tokenAfter) : null;
   };
   const getVariables = (context, params) => {
@@ -10692,7 +10800,8 @@
                 context,
                 fixer,
                 functions: ["useQueryClient"],
-                importPattern: REACT_QUERY_IMPORT_PATTERN
+                importPattern: REACT_QUERY_IMPORT_PATTERN,
+                node
               });
               return [initializeQueryClient, addImport];
             }
@@ -10712,14 +10821,14 @@
         description: "Shows import paths that can be simplified using aliases configured by webpack.",
         schema: {
           type: "object",
-          description: "An object mapping aliases to paths.",
           patternProperties: {
-            "*": {
+            ".*": {
               type: "string"
             }
           }
         }
-      }
+      },
+      schema: false
     },
     create: context => ({
       ImportDeclaration(node) {
@@ -10752,6 +10861,21 @@
       docs: {
         url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/webpack-aliases-and-jsconfig-paths-should-be-in-sync.md",
         description: "Ensures that webpack alias and jsconfig are in sync"
+      },
+      schema: {
+        type: "array",
+        items: [{
+          type: "object",
+          properties: {
+            jsconfigFilePath: {
+              type: "string"
+            },
+            aliasFilePath: {
+              type: "string"
+            }
+          },
+          additionalProperties: false
+        }]
       }
     },
     create: context => {
@@ -11101,10 +11225,9 @@
     })
   };
 
-  const isImportedFromReact = context => {
-    const root = context.getAncestors()[0];
-    const isImportExist = root.body.some(neetoCist.matches(CREATE_CONTEXT_IMPORT_PATTERN));
-    return isImportExist;
+  const isImportedFromReact = (context, node) => {
+    const root = context.sourceCode.getAncestors(node)[0];
+    return root.body.some(neetoCist.matches(CREATE_CONTEXT_IMPORT_PATTERN));
   };
   var useZustandForGlobalStateManagement = {
     meta: {
@@ -11116,7 +11239,7 @@
     },
     create: context => ({
       CallExpression(node) {
-        if (neetoCist.matches(REACT_CREATE_CONTEXT_PATTERN, node) || neetoCist.matches(CREATE_CONTEXT_PATTERN, node) && isImportedFromReact(context)) {
+        if (neetoCist.matches(REACT_CREATE_CONTEXT_PATTERN, node) || neetoCist.matches(CREATE_CONTEXT_PATTERN, node) && isImportedFromReact(context, node)) {
           context.report({
             node,
             message: USE_ZUSTAND_FOR_GLOBAL_STATE_MANAGEMENT
@@ -11227,7 +11350,8 @@
               context,
               fixer,
               functions: ["withImmutableActions"],
-              importPattern: REACT_UTILS_IMPORT_PATTERN
+              importPattern: REACT_UTILS_IMPORT_PATTERN,
+              node
             });
             if (addImportFixer) fixerArray.push(addImportFixer);
             return fixerArray;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/eslint-plugin-neeto",
-  "version": "1.5.8",
+  "version": "1.6.0",
   "main": "dist/index.js",
   "license": "UNLICENSED",
   "scripts": {
@@ -38,7 +38,7 @@
     "@bigbinary/babel-preset-neeto": "^1.0.3",
     "@bigbinary/eslint-plugin-neeto": "1.5.5",
     "@bigbinary/neeto-cist": "^1.0.3",
-    "@bigbinary/neeto-commons-frontend": "4.12.3",
+    "@bigbinary/neeto-commons-frontend": "^4.14.0",
     "@rollup/plugin-alias": "^3.1.9",
     "@rollup/plugin-babel": "^6.0.4",
     "@rollup/plugin-commonjs": "^22.0.0",
@@ -57,20 +57,20 @@
     "babel-preset-typescript": "^7.0.0-alpha.19",
     "cheerio": "^1.0.0-rc.12",
     "command-line-args": "^5.2.1",
-    "eslint": "8.14.0",
-    "eslint-config-prettier": "8.5.0",
-    "eslint-plugin-cypress": "2.12.1",
-    "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jam3": "0.2.3",
-    "eslint-plugin-json": "3.1.0",
-    "eslint-plugin-prettier": "4.0.0",
-    "eslint-plugin-promise": "6.0.0",
-    "eslint-plugin-react": "7.29.4",
-    "eslint-plugin-react-hooks": "4.5.0",
-    "eslint-plugin-security": "^1.7.1",
-    "eslint-plugin-sonarjs": "^0.21.0",
-    "eslint-plugin-unused-imports": "2.0.0",
-    "eslint-plugin-xss": "^0.1.12",
+    "eslint": "^9.25.1",
+    "eslint-config-prettier": "^10.1.2",
+    "eslint-plugin-cypress": "^4.3.0",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-jam3": "^0.2.3",
+    "eslint-plugin-json": "^4.0.1",
+    "eslint-plugin-prettier": "^5.2.6",
+    "eslint-plugin-promise": "^7.2.1",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-security": "^3.0.1",
+    "eslint-plugin-sonarjs": "^3.0.2",
+    "eslint-plugin-unused-imports": "^4.1.4",
+    "globals": "^16.0.0",
     "husky": "7.0.4",
     "i18next": "21.7.0",
     "jest": "27.5.1",
@@ -89,7 +89,7 @@
   "peerDependencies": {
     "@bigbinary/neeto-cist": "^1.0.3",
     "@bigbinary/neeto-commons-frontend": "4.12.3",
-    "eslint": "8.14.0",
+    "eslint": "^9.25.1",
     "i18next": "21.7.0",
     "ramda": "0.29.0"
   }