@bigbinary/eslint-plugin-neeto 1.1.41 → 1.2.0

package/README.md

@@ -46,6 +46,7 @@ module.exports = {
 
 ## Exported rules
 
+- [no-unnecessary-classnames](./docs/src/rules/no-unnecessary-classnames.md)
 - [no-snake-case-destructuring-for-use-query-params-and-get-query-params](./docs/src/rules/no-snake-case-destructuring-for-use-query-params-and-get-query-params.md)
 - [no-local-storage](./docs/src/rules/no-local-storage.md)
 - [no-lowercase-on-translation](./docs/src/rules/no-lowercase-on-translation.md)

package/dist/index.js

@@ -42,6 +42,7 @@
   var commonResolve$2 = loadJS$2("node_modules/@bigbinary/neeto-commons-frontend/configs/webpack/resolve.js");
   var resolve$2 = ramda.mergeDeepLeft(projectResolve$2, commonResolve$2);
   var rules = {
+    "@bigbinary/neeto/no-unnecessary-classnames": "error",
     "@bigbinary/neeto/no-snake-case-destructuring-for-use-query-params-and-get-query-params": "warn",
     "@bigbinary/neeto/no-local-storage": "error",
     "@bigbinary/neeto/no-lowercase-on-translation": "warn",
@@ -453,10 +454,10 @@
     return "Do not use the package ".concat(packageName);
   };
   var exportedObjectShouldBe = function exportedObjectShouldBe(caseStyle) {
-    return "Exported object should be in ".concat(caseStyle, ". Refer https://www.youtube.com/watch?v=As9BzWsGJfY");
+    return "Exported object should be in ".concat(caseStyle, ". Refer https://youtu.be/uZtRIvo8-ww");
   };
   var filenameShouldBe = function filenameShouldBe(caseStyle) {
-    return "Filename should be in ".concat(caseStyle, ". Refer https://www.youtube.com/watch?v=As9BzWsGJfY");
+    return "Filename should be in ".concat(caseStyle, ". Refer https://youtu.be/uZtRIvo8-ww");
   };
   var moveToConstantsJs = function moveToConstantsJs(constantName) {
     return "Move the constant ".concat(constantName, " to a constants.js file.");
@@ -570,6 +571,7 @@
   var AVOID_SNAKE_CASE_DESTRUCTURING_USEQUERYPARAMS_OR_GETQUERYPARAMS = "Avoid destructuring snake-cased values from getQueryParams or useQueryParams";
   var PREFER_FUNCTION_REFERENCE = "Prefer passing function reference instead of creating a new function as the parameters and arguments are the same.";
   var JSX_PREFER_GUARD_CLAUSE = "Prefer adding a guard clause for conditional statements left of JSX statments in the last return statement of the function.";
+  var NO_UNNECESSARY_CLASSNAMES = "classnames usage is unnecessary";
 
   var PACKAGES_TO_CHECK = ["@bigbinary/neeto-molecules", "@bigbinary/neetoui", "@bigbinary/neeto-commons-frontend"];
 
@@ -4350,7 +4352,7 @@
           }, {}) : {};
           var translationsFilePath = path$2.join(context.options[0].translationsDir, "".concat(lng, ".json"));
           var translationsContent = parseJsonData(translationsFilePath);
-          var combinedContent = _objectSpread$2(_objectSpread$2({}, translationsContent), nanosContent[lng]);
+          var combinedContent = ramda.mergeDeepLeft(translationsContent, nanosContent[lng]);
           return {
             lng: lng,
             content: combinedContent
@@ -6607,7 +6609,7 @@
   };
 
   var SNAKE_CASE_WITHOUT_SINGLE_WORDS = /^[a-z]+_[a-z0-9_]+$/;
-  var PATTERN = {
+  var PATTERN$1 = {
     id: {
       type: "ObjectPattern",
       properties: ramda.any(neetoCist.matches({
@@ -6647,7 +6649,7 @@
     create: function create(context) {
       return {
         VariableDeclarator: function VariableDeclarator(node) {
-          if (neetoCist.matches(PATTERN, node)) {
+          if (neetoCist.matches(PATTERN$1, node)) {
             context.report({
               node: node,
               message: AVOID_SNAKE_CASE_DESTRUCTURING_USEQUERYPARAMS_OR_GETQUERYPARAMS
@@ -6658,6 +6660,57 @@
     }
   };
 
+  var CLASS_NAME = "className";
+  var CLASS_NAMES = ["classnames", "classNames"];
+  var PATTERN = neetoCist.matches({
+    name: {
+      name: CLASS_NAME
+    },
+    value: {
+      expression: {
+        type: TYPES.CALL_EXPRESSION,
+        callee: {
+          name: matchesAny(CLASS_NAMES)
+        },
+        arguments: _defineProperty({
+          length: 1
+        }, 0, {
+          type: matchesAny([TYPES.LITERAL, TYPES.TEMPLATE_LITERAL])
+        })
+      }
+    }
+  });
+
+  var noUnnecessaryClassnames = {
+    meta: {
+      type: "suggestion",
+      docs: {
+        url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/no-unnecessary-classnames.md",
+        description: "classnames usage is unnecessary"
+      },
+      fixable: "code"
+    },
+    create: function create(context) {
+      return {
+        JSXAttribute: function JSXAttribute(node) {
+          if (!neetoCist.matches(PATTERN, node)) return;
+          context.report({
+            node: node,
+            message: NO_UNNECESSARY_CLASSNAMES,
+            fix: function fix(fixer) {
+              var singleClass = node.value.expression.arguments[0];
+              var classText = context.getSourceCode().getText(singleClass);
+              if (singleClass.type === TYPES.TEMPLATE_LITERAL) {
+                classText = "{".concat(classText, "}");
+              }
+              return fixer.replaceTextRange([node.range[0], node.range[1]], "className=".concat(classText));
+            }
+          });
+        }
+      };
+    }
+  };
+
   // if (condition) statement;
   var SINGLE_LINE_IF_CONDITION_PATTERN = {
     parent: {
@@ -10456,6 +10509,7 @@
 
   var index = {
     rules: {
+      "no-unnecessary-classnames": noUnnecessaryClassnames,
       "no-snake-case-destructuring-for-use-query-params-and-get-query-params": noSnakeCaseDestructuringForUseQueryParamsAndGetQueryParams,
       "no-local-storage": noLocalStorage,
       "no-lowercase-on-translation": noLowercaseOnTranslation,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/eslint-plugin-neeto",
-  "version": "1.1.41",
+  "version": "1.2.0",
   "main": "dist/index.js",
   "license": "UNLICENSED",
   "scripts": {