@bigbinary/eslint-plugin-neeto 1.1.14 → 1.1.16

package/README.md

@@ -46,6 +46,8 @@ module.exports = {
 
 ## Exported rules
 
+- [no-large-functions-inside-jsx](./docs/src/rules/no-large-functions-inside-jsx.md)
+- [use-standard-date-time-formats](./docs/src/rules/use-standard-date-time-formats.md)
 - [no-dumb-components-with-use-translation](./docs/src/rules/no-dumb-components-with-use-translation.md)
 - [no-unnecessary-if-condition](./docs/src/rules/no-unnecessary-if-condition.md)
 - [api-connector-name-should-match-filename](./docs/src/rules/api-connector-name-should-match-filename.md)

package/dist/index.js

@@ -42,6 +42,8 @@
   var commonResolve$2 = loadJS$2("node_modules/@bigbinary/neeto-commons-frontend/configs/webpack/resolve.js");
   var resolve$2 = ramda.mergeDeepLeft(projectResolve$2, commonResolve$2);
   var rules = {
+    "@bigbinary/neeto/no-large-functions-inside-jsx": "error",
+    "@bigbinary/neeto/use-standard-date-time-formats": "error",
     "@bigbinary/neeto/no-dumb-components-with-use-translation": "error",
     "@bigbinary/neeto/api-connector-name-should-match-filename": "error",
     "@bigbinary/neeto/api-connector-should-use-default-export": "error",
@@ -405,7 +407,19 @@
       }
     }]
   };
+  var PROP_FUNCTION_PATTERN = {
+    value: {
+      type: TYPES.JSX_EXPRESSION_CONTAINER,
+      expression: {
+        type: TYPES.ARROW_FUNCTION_EXPRESSION,
+        body: {
+          type: TYPES.BLOCK_STATEMENT
+        }
+      }
+    }
+  };
   var NO_OF_LINES_ALLOWED_FOR_MULTIPLE_COMPONENTS_IN_A_FILE = 20;
+  var MAX_LINES_FOR_FUNCTIONS_INSIDE_JSX = 4;
 
   var ARGUMENT_LIMIT = 3;
   var API_ACTIONS_ARGUMENT_LIMIT = 2;
@@ -457,6 +471,10 @@
     var maxAllowedNoOfLines = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 20;
     return "Do not have multiple component definitions that exceed ".concat(maxAllowedNoOfLines, " lines in a single file.");
   };
+  var avoidLargeFunctionsInsideJsx = function avoidLargeFunctionsInsideJsx() {
+    var maxAllowedNoOfLines = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 4;
+    return "Avoid inline functions that exceed ".concat(maxAllowedNoOfLines, " lines directly inside JSX. Extract the function outside of JSX.");
+  };
   var suggestNeetoCommonsFunctionsAndHooks = function suggestNeetoCommonsFunctionsAndHooks(functionName, utilType, url) {
     return "Use \"".concat(functionName, "\" from \"@bigbinary/neeto-commons-frontend/").concat(utilType, "\" instead. Refer: ").concat(url);
   };
@@ -526,6 +544,7 @@
   var PROP_KEY_VALUE_DUPLICATE = "Prop key and value names should not be repeated";
   var USE_WITH_IMMUTABLE_ACTIONS_WRAPPER = 'Use "withImmutableActions" wrapper from "neeto-commons-frontend" inside zustand create. Refer: https://bit.ly/withimmutableactions';
   var USE_WITH_T_HOC_IN_DUMB_COMPONENTS = 'Use "withT" HOC from "neeto-commons-frontend" instead of useTranslation hook in Dumb components';
+  var USE_STANDARD_DATE_TIME_FORMATS = 'Use "dateFormat/timeFormat" from "@bigbinary/neeto-commons-frontend/utils" instead. Refer: https://github.com/bigbinary/neeto-commons-frontend/blob/main/docs/utils/README.md#dateformattimeformat';
 
   var PACKAGES_TO_CHECK = ["@bigbinary/neeto-molecules", "@bigbinary/neetoui", "@bigbinary/neeto-commons-frontend"];
 
@@ -6086,6 +6105,35 @@
     }
   };
 
+  var noLargeFunctionsInsideJsx = {
+    meta: {
+      type: "problem",
+      docs: {
+        url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/no-large-functions-inside-jsx.md",
+        description: "Disallows the use of functions with large bodies, that exceed maxAllowedNoOfLines, directly inside JSX elements." + "The default value for maxAllowedNoOfLines is 4."
+      }
+    },
+    create: function create(context) {
+      return {
+        JSXAttribute: function JSXAttribute(node) {
+          var _context$options$;
+          if (!pure.matches(PROP_FUNCTION_PATTERN, node)) return;
+          var functionBody = node.value.expression.body;
+          var _functionBody$loc = functionBody.loc,
+            start = _functionBody$loc.start,
+            end = _functionBody$loc.end;
+          var linesInsideBlock = end.line - (start.line + 1);
+          var maxAllowedNoOfLines = ((_context$options$ = context.options[0]) === null || _context$options$ === void 0 ? void 0 : _context$options$.maxAllowedNoOfLines) || MAX_LINES_FOR_FUNCTIONS_INSIDE_JSX;
+          if (linesInsideBlock <= maxAllowedNoOfLines) return;
+          context.report({
+            node: node,
+            message: avoidLargeFunctionsInsideJsx(maxAllowedNoOfLines)
+          });
+        }
+      };
+    }
+  };
+
   var noMultipleComponentsInAFile = {
     meta: {
       type: "problem",
@@ -25956,6 +26004,33 @@
     }
   };
 
+  var useStandardDateTimeFormats = {
+    meta: {
+      type: "problem",
+      docs: {
+        url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/use-standard-date-time-formats.md",
+        description: "Enforces the usage of standard date and time formats instead of dayjs().format()"
+      }
+    },
+    create: function create(context) {
+      var sourceCode = context.getSourceCode();
+      return {
+        CallExpression: function CallExpression(node) {
+          var callee = node.callee;
+          if (callee.type !== TYPES.MEMBER_EXPRESSION) return;
+          var expression = sourceCode.getText(callee);
+          if (!(expression.includes("dayjs") && expression.includes(".format"))) {
+            return;
+          }
+          context.report({
+            node: node,
+            message: USE_STANDARD_DATE_TIME_FORMATS
+          });
+        }
+      };
+    }
+  };
+
   var useWebpackAlias = {
     meta: {
       type: "suggestion",
@@ -26539,6 +26614,8 @@
 
   var index = {
     rules: {
+      "no-large-functions-inside-jsx": noLargeFunctionsInsideJsx,
+      "use-standard-date-time-formats": useStandardDateTimeFormats,
       "no-dumb-components-with-use-translation": noDumbComponentsWithUseTranslation,
       "api-connector-name-should-match-filename": apiConnectorNameShouldMatchFilename,
       "api-connector-should-use-default-export": apiConnectorShouldUseDefaultExport,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/eslint-plugin-neeto",
-  "version": "1.1.14",
+  "version": "1.1.16",
   "main": "dist/index.js",
   "license": "UNLICENSED",
   "scripts": {