@bigbinary/eslint-plugin-neeto 1.1.13 → 1.1.15

package/README.md

@@ -46,6 +46,7 @@ module.exports = {
 
 ## Exported rules
 
+- [use-standard-date-time-formats](./docs/src/rules/use-standard-date-time-formats.md)
 - [no-dumb-components-with-use-translation](./docs/src/rules/no-dumb-components-with-use-translation.md)
 - [no-unnecessary-if-condition](./docs/src/rules/no-unnecessary-if-condition.md)
 - [api-connector-name-should-match-filename](./docs/src/rules/api-connector-name-should-match-filename.md)

package/dist/index.js

@@ -42,6 +42,7 @@
   var commonResolve$2 = loadJS$2("node_modules/@bigbinary/neeto-commons-frontend/configs/webpack/resolve.js");
   var resolve$2 = ramda.mergeDeepLeft(projectResolve$2, commonResolve$2);
   var rules = {
+    "@bigbinary/neeto/use-standard-date-time-formats": "error",
     "@bigbinary/neeto/no-dumb-components-with-use-translation": "error",
     "@bigbinary/neeto/api-connector-name-should-match-filename": "error",
     "@bigbinary/neeto/api-connector-should-use-default-export": "error",
@@ -526,6 +527,7 @@
   var PROP_KEY_VALUE_DUPLICATE = "Prop key and value names should not be repeated";
   var USE_WITH_IMMUTABLE_ACTIONS_WRAPPER = 'Use "withImmutableActions" wrapper from "neeto-commons-frontend" inside zustand create. Refer: https://bit.ly/withimmutableactions';
   var USE_WITH_T_HOC_IN_DUMB_COMPONENTS = 'Use "withT" HOC from "neeto-commons-frontend" instead of useTranslation hook in Dumb components';
+  var USE_STANDARD_DATE_TIME_FORMATS = 'Use "dateFormat/timeFormat" from "@bigbinary/neeto-commons-frontend/utils" instead. Refer: https://github.com/bigbinary/neeto-commons-frontend/blob/main/docs/utils/README.md#dateformattimeformat';
 
   var PACKAGES_TO_CHECK = ["@bigbinary/neeto-molecules", "@bigbinary/neetoui", "@bigbinary/neeto-commons-frontend"];
 
@@ -5897,7 +5899,7 @@
     return _arrayWithHoles(arr) || _iterableToArray(arr) || _unsupportedIterableToArray$2(arr) || _nonIterableRest();
   }
 
-  var REACT_HOOKS_VARIABLE_DECLARATION_PATTERN = {
+  ({
     type: TYPES.VARIABLE_DECLARATION,
     declarations: [{
       type: TYPES.VARIABLE_DECLARATOR,
@@ -5909,8 +5911,8 @@
         }
       }
     }]
-  };
-  var REACT_HOOKS_CALL_PATTERN = {
+  });
+  ({
     type: TYPES.EXPRESSION_STATEMENT,
     expression: {
       type: TYPES.CALL_EXPRESSION,
@@ -5919,7 +5921,7 @@
         name: ramda.test(/use[a-zA-z0-9].+/)
       }
     }
-  };
+  });
 
   // import { functionName } from "neetocommons/react-utils";
   var NEETO_COMMONS_REACT_UTILS_IMPORT_PATTERN = {
@@ -5933,6 +5935,31 @@
     }]
   };
 
+  var BREAK_STATEMENT_PATTERN = {
+    type: TYPES.BREAK_STATEMENT
+  };
+  var RETURN_STATEMENT_PATTERN = {
+    type: TYPES.RETURN_STATEMENT
+  };
+  var ARRAY_LENGTH_TEST_PATTERN = {
+    test: {
+      right: {
+        type: TYPES.MEMBER_EXPRESSION,
+        property: {
+          name: "length"
+        }
+      }
+    }
+  };
+  var CHAR_AT_PATTERN = {
+    type: TYPES.CALL_EXPRESSION,
+    callee: {
+      property: {
+        name: ramda.includes(ramda.__, ["charAt", "charCodeAt"])
+      }
+    }
+  };
+
   var noDumbComponentsWithUseTranslation = {
     meta: {
       type: "suggestion",
@@ -5950,12 +5977,13 @@
             arrowFunctionExpression = _node$declarations[0].init;
           var blockStatement = arrowFunctionExpression.body;
           if (!blockStatement.body) return;
-          var useTranslationHook = pure.findBy(USE_TRANSLATION_HOOK_PATTERN, blockStatement.body);
-          if (!useTranslationHook) return;
-          var hasHooksOtherThanTranslationHook = blockStatement.body.some(function (node) {
-            return (pure.matches(REACT_HOOKS_CALL_PATTERN, node) || pure.matches(REACT_HOOKS_VARIABLE_DECLARATION_PATTERN, node)) && !pure.matches(USE_TRANSLATION_HOOK_PATTERN, node);
-          });
-          if (hasHooksOtherThanTranslationHook) return;
+          if (blockStatement.body.length !== 2) return;
+          var _blockStatement$body = _slicedToArray(blockStatement.body, 2),
+            firstStatement = _blockStatement$body[0],
+            secondStatement = _blockStatement$body[1];
+          if (!(pure.matches(USE_TRANSLATION_HOOK_PATTERN, firstStatement) && pure.matches(RETURN_STATEMENT_PATTERN, secondStatement))) {
+            return;
+          }
           context.report({
             node: node,
             message: USE_WITH_T_HOC_IN_DUMB_COMPONENTS,
@@ -5979,7 +6007,7 @@
                 return "";
               };
               var blockStatementCode = getCode$1(context, blockStatement);
-              var useTranslationHookCode = getCode$1(context, useTranslationHook);
+              var useTranslationHookCode = getCode$1(context, firstStatement);
               var body = blockStatementCode.replace(useTranslationHookCode, "");
               var withTWrap = "withT((".concat(getPropsCode()).concat(pure.isNotEmpty(restParams) ? ", ".concat(restParams.map(function (param) {
                 return getCode$1(context, param);
@@ -7787,31 +7815,6 @@
     }
   };
 
-  var BREAK_STATEMENT_PATTERN = {
-    type: TYPES.BREAK_STATEMENT
-  };
-  var RETURN_STATEMENT_PATTERN = {
-    type: TYPES.RETURN_STATEMENT
-  };
-  var ARRAY_LENGTH_TEST_PATTERN = {
-    test: {
-      right: {
-        type: TYPES.MEMBER_EXPRESSION,
-        property: {
-          name: "length"
-        }
-      }
-    }
-  };
-  var CHAR_AT_PATTERN = {
-    type: TYPES.CALL_EXPRESSION,
-    callee: {
-      property: {
-        name: ramda.includes(ramda.__, ["charAt", "charCodeAt"])
-      }
-    }
-  };
-
   var isForLoopReplacable = function isForLoopReplacable(node) {
     return ramda.not(patternExistsDeep(BREAK_STATEMENT_PATTERN, node.body) || patternExistsDeep(RETURN_STATEMENT_PATTERN, node.body) || patternExistsDeep(CHAR_AT_PATTERN, node.body));
   };
@@ -25955,6 +25958,33 @@
     }
   };
 
+  var useStandardDateTimeFormats = {
+    meta: {
+      type: "problem",
+      docs: {
+        url: "https://github.com/bigbinary/eslint-plugin-neeto/blob/main/docs/src/rules/use-standard-date-time-formats.md",
+        description: "Enforces the usage of standard date and time formats instead of dayjs().format()"
+      }
+    },
+    create: function create(context) {
+      var sourceCode = context.getSourceCode();
+      return {
+        CallExpression: function CallExpression(node) {
+          var callee = node.callee;
+          if (callee.type !== TYPES.MEMBER_EXPRESSION) return;
+          var expression = sourceCode.getText(callee);
+          if (!(expression.includes("dayjs") && expression.includes(".format"))) {
+            return;
+          }
+          context.report({
+            node: node,
+            message: USE_STANDARD_DATE_TIME_FORMATS
+          });
+        }
+      };
+    }
+  };
+
   var useWebpackAlias = {
     meta: {
       type: "suggestion",
@@ -26538,6 +26568,7 @@
 
   var index = {
     rules: {
+      "use-standard-date-time-formats": useStandardDateTimeFormats,
       "no-dumb-components-with-use-translation": noDumbComponentsWithUseTranslation,
       "api-connector-name-should-match-filename": apiConnectorNameShouldMatchFilename,
       "api-connector-should-use-default-export": apiConnectorShouldUseDefaultExport,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/eslint-plugin-neeto",
-  "version": "1.1.13",
+  "version": "1.1.15",
   "main": "dist/index.js",
   "license": "UNLICENSED",
   "scripts": {