@bigbinary/eslint-plugin-neeto 1.1.12 → 1.1.14

package/dist/index.js

@@ -525,6 +525,7 @@
   var DIFFERENT_PROPS_MUST_BE_OUTSIDE = "Props with different key and value should be outside the spread attribute";
   var PROP_KEY_VALUE_DUPLICATE = "Prop key and value names should not be repeated";
   var USE_WITH_IMMUTABLE_ACTIONS_WRAPPER = 'Use "withImmutableActions" wrapper from "neeto-commons-frontend" inside zustand create. Refer: https://bit.ly/withimmutableactions';
+  var USE_WITH_T_HOC_IN_DUMB_COMPONENTS = 'Use "withT" HOC from "neeto-commons-frontend" instead of useTranslation hook in Dumb components';
 
   var PACKAGES_TO_CHECK = ["@bigbinary/neeto-molecules", "@bigbinary/neetoui", "@bigbinary/neeto-commons-frontend"];
 
@@ -5896,7 +5897,7 @@
     return _arrayWithHoles(arr) || _iterableToArray(arr) || _unsupportedIterableToArray$2(arr) || _nonIterableRest();
   }
 
-  var REACT_HOOKS_VARIABLE_DECLARATION_PATTERN = {
+  ({
     type: TYPES.VARIABLE_DECLARATION,
     declarations: [{
       type: TYPES.VARIABLE_DECLARATOR,
@@ -5908,8 +5909,8 @@
         }
       }
     }]
-  };
-  var REACT_HOOKS_CALL_PATTERN = {
+  });
+  ({
     type: TYPES.EXPRESSION_STATEMENT,
     expression: {
       type: TYPES.CALL_EXPRESSION,
@@ -5918,7 +5919,7 @@
         name: ramda.test(/use[a-zA-z0-9].+/)
       }
     }
-  };
+  });
 
   // import { functionName } from "neetocommons/react-utils";
   var NEETO_COMMONS_REACT_UTILS_IMPORT_PATTERN = {
@@ -5932,6 +5933,31 @@
     }]
   };
 
+  var BREAK_STATEMENT_PATTERN = {
+    type: TYPES.BREAK_STATEMENT
+  };
+  var RETURN_STATEMENT_PATTERN = {
+    type: TYPES.RETURN_STATEMENT
+  };
+  var ARRAY_LENGTH_TEST_PATTERN = {
+    test: {
+      right: {
+        type: TYPES.MEMBER_EXPRESSION,
+        property: {
+          name: "length"
+        }
+      }
+    }
+  };
+  var CHAR_AT_PATTERN = {
+    type: TYPES.CALL_EXPRESSION,
+    callee: {
+      property: {
+        name: ramda.includes(ramda.__, ["charAt", "charCodeAt"])
+      }
+    }
+  };
+
   var noDumbComponentsWithUseTranslation = {
     meta: {
       type: "suggestion",
@@ -5949,15 +5975,16 @@
             arrowFunctionExpression = _node$declarations[0].init;
           var blockStatement = arrowFunctionExpression.body;
           if (!blockStatement.body) return;
-          var useTranslationHook = pure.findBy(USE_TRANSLATION_HOOK_PATTERN, blockStatement.body);
-          if (!useTranslationHook) return;
-          var hasHooksOtherThanTranslationHook = blockStatement.body.some(function (node) {
-            return (pure.matches(REACT_HOOKS_CALL_PATTERN, node) || pure.matches(REACT_HOOKS_VARIABLE_DECLARATION_PATTERN, node)) && !pure.matches(USE_TRANSLATION_HOOK_PATTERN, node);
-          });
-          if (hasHooksOtherThanTranslationHook) return;
+          if (blockStatement.body.length !== 2) return;
+          var _blockStatement$body = _slicedToArray(blockStatement.body, 2),
+            firstStatement = _blockStatement$body[0],
+            secondStatement = _blockStatement$body[1];
+          if (!(pure.matches(USE_TRANSLATION_HOOK_PATTERN, firstStatement) && pure.matches(RETURN_STATEMENT_PATTERN, secondStatement))) {
+            return;
+          }
           context.report({
             node: node,
-            message: "Use withT HOC instead of useTranslation hook",
+            message: USE_WITH_T_HOC_IN_DUMB_COMPONENTS,
             fix: function fix(fixer) {
               var fixers = [];
               var _arrowFunctionExpress = _toArray(arrowFunctionExpression.params),
@@ -5978,7 +6005,7 @@
                 return "";
               };
               var blockStatementCode = getCode$1(context, blockStatement);
-              var useTranslationHookCode = getCode$1(context, useTranslationHook);
+              var useTranslationHookCode = getCode$1(context, firstStatement);
               var body = blockStatementCode.replace(useTranslationHookCode, "");
               var withTWrap = "withT((".concat(getPropsCode()).concat(pure.isNotEmpty(restParams) ? ", ".concat(restParams.map(function (param) {
                 return getCode$1(context, param);
@@ -7786,31 +7813,6 @@
     }
   };
 
-  var BREAK_STATEMENT_PATTERN = {
-    type: TYPES.BREAK_STATEMENT
-  };
-  var RETURN_STATEMENT_PATTERN = {
-    type: TYPES.RETURN_STATEMENT
-  };
-  var ARRAY_LENGTH_TEST_PATTERN = {
-    test: {
-      right: {
-        type: TYPES.MEMBER_EXPRESSION,
-        property: {
-          name: "length"
-        }
-      }
-    }
-  };
-  var CHAR_AT_PATTERN = {
-    type: TYPES.CALL_EXPRESSION,
-    callee: {
-      property: {
-        name: ramda.includes(ramda.__, ["charAt", "charCodeAt"])
-      }
-    }
-  };
-
   var isForLoopReplacable = function isForLoopReplacable(node) {
     return ramda.not(patternExistsDeep(BREAK_STATEMENT_PATTERN, node.body) || patternExistsDeep(RETURN_STATEMENT_PATTERN, node.body) || patternExistsDeep(CHAR_AT_PATTERN, node.body));
   };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigbinary/eslint-plugin-neeto",
-  "version": "1.1.12",
+  "version": "1.1.14",
   "main": "dist/index.js",
   "license": "UNLICENSED",
   "scripts": {