@bifravst/aws-cdk-lambda-helpers 2.0.1 → 2.2.0

package/dist/src/findDependencies.d.ts

@@ -1,9 +1,22 @@
 /**
  * Resolve project-level dependencies for the given file using TypeScript compiler API
  */
-export declare const findDependencies: ({ sourceFilePath, tsConfigFilePath, imports: importsArg, visited: visitedArg, }: {
+export declare const findDependencies: (args: {
     sourceFilePath: string;
-    tsConfigFilePath?: string;
     imports?: string[];
     visited?: string[];
-}) => string[];
+    packages?: Set<string>;
+    tsConfigFilePath?: string;
+    importsSubpathPatterns?: Record<string, string>;
+}) => {
+    dependencies: string[];
+    /**
+     * A map of import subpath patterns to their resolved paths
+     * @see https://nodejs.org/api/packages.html#subpath-patterns
+     */
+    importsSubpathPatterns: Record<string, string>;
+    /**
+     * The external packages that the source file depends on
+     */
+    packages: Set<string>;
+};

package/dist/src/findDependencies.js

@@ -4,58 +4,71 @@ import ts, {} from 'typescript';
 /**
  * Resolve project-level dependencies for the given file using TypeScript compiler API
  */
-export const findDependencies = ({ sourceFilePath, tsConfigFilePath, imports: importsArg, visited: visitedArg, }) => {
-    const visited = visitedArg ?? [];
-    const imports = importsArg ?? [];
+export const findDependencies = (args) => {
+    const sourceFilePath = args.sourceFilePath;
+    const visited = args.visited ?? [];
+    const dependencies = args.imports ?? [];
+    const packages = args.packages ?? new Set();
+    let importsSubpathPatterns = args.importsSubpathPatterns ?? {};
     if (visited.includes(sourceFilePath))
-        return imports;
+        return { dependencies, importsSubpathPatterns, packages };
+    const tsConfigFilePath = args.tsConfigFilePath;
     const tsConfig = tsConfigFilePath !== undefined
         ? JSON.parse(readFileSync(tsConfigFilePath, 'utf-8').toString())
         : undefined;
     const fileNode = ts.createSourceFile(sourceFilePath, readFileSync(sourceFilePath, 'utf-8').toString(), ts.ScriptTarget.ES2022, 
     /*setParentNodes */ true);
     const parseChild = (node) => {
-        if (node.kind !== ts.SyntaxKind.ImportDeclaration)
+        if (node.kind !== ts.SyntaxKind.ImportDeclaration &&
+            node.kind !== ts.SyntaxKind.ExportDeclaration)
             return;
         const moduleSpecifier = node.moduleSpecifier.text;
-        const file = resolve({
+        const { resolvedPath: file, importsSubpathPatterns: updatedImportsSubpathPatterns, } = resolve({
             moduleSpecifier,
             sourceFilePath,
             tsConfigFilePath,
             tsConfig,
+            importsSubpathPatterns,
         });
+        importsSubpathPatterns = updatedImportsSubpathPatterns;
         try {
             const s = statSync(file);
             if (!s.isDirectory())
-                imports.push(file);
+                dependencies.push(file);
         }
         catch {
             // Module or file not found
             visited.push(file);
+            packages.add(moduleSpecifier);
         }
     };
     ts.forEachChild(fileNode, parseChild);
     visited.push(sourceFilePath);
-    for (const file of imports) {
+    for (const file of dependencies) {
         findDependencies({
             sourceFilePath: file,
-            imports,
+            imports: dependencies,
             visited,
             tsConfigFilePath,
+            importsSubpathPatterns,
+            packages,
         });
     }
-    return imports;
+    return { dependencies, importsSubpathPatterns, packages };
 };
-const resolve = ({ moduleSpecifier, sourceFilePath, tsConfigFilePath, tsConfig, }) => {
+const resolve = ({ moduleSpecifier, sourceFilePath, tsConfigFilePath, tsConfig, importsSubpathPatterns, }) => {
     if (moduleSpecifier.startsWith('.'))
-        return (path
-            .resolve(path.parse(sourceFilePath).dir, moduleSpecifier)
-            // In ECMA Script modules, all imports from local files must have an extension.
-            // See https://nodejs.org/api/esm.html#mandatory-file-extensions
-            // So we need to replace the `.js` in the import specification to find the TypeScript source for the file.
-            // Example: import { Network, notifyClients } from './notifyClients.js'
-            // The source file for that is actually in './notifyClients.ts'
-            .replace(/\.js$/, '.ts'));
+        return {
+            resolvedPath: path
+                .resolve(path.parse(sourceFilePath).dir, moduleSpecifier)
+                // In ECMA Script modules, all imports from local files must have an extension.
+                // See https://nodejs.org/api/esm.html#mandatory-file-extensions
+                // So we need to replace the `.js` in the import specification to find the TypeScript source for the file.
+                // Example: import { Network, notifyClients } from './notifyClients.js'
+                // The source file for that is actually in './notifyClients.ts'
+                .replace(/\.js$/, '.ts'),
+            importsSubpathPatterns,
+        };
     if (tsConfigFilePath !== undefined &&
         tsConfig?.compilerOptions?.paths !== undefined) {
         for (const [key, value] of Object.entries(tsConfig.compilerOptions.paths)) {
@@ -64,7 +77,18 @@ const resolve = ({ moduleSpecifier, sourceFilePath, tsConfigFilePath, tsConfig,
                 continue;
             // Exact match
             if (moduleSpecifier === key) {
-                return path.join(path.parse(tsConfigFilePath).dir, tsConfig.compilerOptions.baseUrl, resolvedPath);
+                const fullResolvedPath = path.join(path.parse(tsConfigFilePath).dir, tsConfig.compilerOptions.baseUrl, resolvedPath);
+                return {
+                    resolvedPath: fullResolvedPath,
+                    importsSubpathPatterns: {
+                        ...importsSubpathPatterns,
+                        [key]: [
+                            tsConfig.compilerOptions.baseUrl,
+                            path.sep,
+                            resolvedPath.replace(/\.ts$/, '.js'),
+                        ].join(''),
+                    },
+                };
             }
             // Wildcard match
             if (!key.includes('*'))
@@ -73,11 +97,24 @@ const resolve = ({ moduleSpecifier, sourceFilePath, tsConfigFilePath, tsConfig,
             const maybeMatch = rx.exec(moduleSpecifier);
             if (maybeMatch?.groups?.wildcard === undefined)
                 continue;
-            return (path
-                .resolve(path.parse(tsConfigFilePath).dir, tsConfig.compilerOptions.baseUrl, resolvedPath.replace('*', maybeMatch.groups.wildcard))
-                // Same as above, replace `.js` with `.ts`
-                .replace(/\.js$/, '.ts'));
+            return {
+                resolvedPath: path
+                    .resolve(path.parse(tsConfigFilePath).dir, tsConfig.compilerOptions.baseUrl, resolvedPath.replace('*', maybeMatch.groups.wildcard))
+                    // Same as above, replace `.js` with `.ts`
+                    .replace(/\.js$/, '.ts'),
+                importsSubpathPatterns: {
+                    ...importsSubpathPatterns,
+                    [key]: [
+                        tsConfig.compilerOptions.baseUrl,
+                        path.sep,
+                        resolvedPath.replace(/\.ts$/, '.js'),
+                    ].join(''),
+                },
+            };
         }
     }
-    return moduleSpecifier;
+    return {
+        resolvedPath: moduleSpecifier,
+        importsSubpathPatterns,
+    };
 };

package/dist/src/findDependencies.spec.js

@@ -5,12 +5,30 @@ import { URL } from 'node:url';
 import { findDependencies } from './findDependencies.js';
 const __dirname = new URL('.', import.meta.url).pathname;
 void describe('findDependencies()', () => {
+    void it('should return a list of external dependencies', () => {
+        const { packages } = findDependencies({
+            sourceFilePath: path.join(__dirname, '..', 'cdk', 'lambda.ts'),
+        });
+        assert.equal(packages.has('aws-lambda'), true, "Should include the 'aws-lambda' package");
+        assert.equal(packages.has('id128'), true, "Should include the 'id128' package");
+    });
     void it('should honor tsconfig.json paths', () => {
-        const dependencies = findDependencies({
+        const { dependencies } = findDependencies({
             sourceFilePath: path.join(__dirname, 'test-data', 'resolve-paths', 'lambda.ts'),
             tsConfigFilePath: path.join(__dirname, 'test-data', 'resolve-paths', 'tsconfig.json'),
         });
         assert.equal(dependencies.includes(path.join(__dirname, 'test-data', 'resolve-paths', 'foo', 'index.ts')), true, 'Should include the index.ts file');
+        assert.equal(dependencies.includes(path.join(__dirname, 'test-data', 'resolve-paths', 'foo', '1.ts')), true, 'Should include the module referenced in the index.ts file');
         assert.equal(dependencies.includes(path.join(__dirname, 'test-data', 'resolve-paths', 'foo', '2.ts')), true, 'Should include the module file');
     });
+    void it('should return an import map', () => {
+        const { importsSubpathPatterns } = findDependencies({
+            sourceFilePath: path.join(__dirname, 'test-data', 'resolve-paths', 'lambda.ts'),
+            tsConfigFilePath: path.join(__dirname, 'test-data', 'resolve-paths', 'tsconfig.json'),
+        });
+        assert.deepEqual(importsSubpathPatterns, {
+            '#foo': './foo/index.js',
+            '#foo/*': './foo/*',
+        });
+    });
 });

package/dist/src/packLambda.js

@@ -22,10 +22,11 @@ const removeCommonAncestor = (parentDir) => (filePath) => {
  * In the bundle we only include code that's not in the layer.
  */
 export const packLambda = async ({ sourceFilePath, zipFilePath, tsConfigFilePath, debug, progress, }) => {
-    const deps = findDependencies({
+    const { dependencies: deps, importsSubpathPatterns, packages, } = findDependencies({
         sourceFilePath,
         tsConfigFilePath,
     });
+    debug?.(`dependencies`, [...packages].join(', '));
     const lambdaFiles = [sourceFilePath, ...deps];
     const zipfile = new yazl.ZipFile();
     const stripCommon = removeCommonAncestor(commonParent(lambdaFiles));
@@ -61,6 +62,8 @@ export const packLambda = async ({ sourceFilePath, zipFilePath, tsConfigFilePath
     // Mark it as ES module
     zipfile.addBuffer(Buffer.from(JSON.stringify({
         type: 'module',
+        imports: importsSubpathPatterns,
+        dependencies: Object.fromEntries(packages.values().map((pkg) => [pkg, '*'])),
     }), 'utf-8'), 'package.json');
     progress?.(`added`, 'package.json');
     await new Promise((resolve) => {

package/dist/src/test-data/resolve-paths/foo/1.d.ts

@@ -0,0 +1 @@
+export declare const foo: () => number;

package/dist/src/test-data/resolve-paths/foo/1.js

@@ -0,0 +1 @@
+export const foo = () => 42;

package/dist/src/test-data/resolve-paths/foo/2.d.ts

@@ -0,0 +1 @@
+export declare const foo2: () => number;

package/dist/src/test-data/resolve-paths/foo/2.js

@@ -0,0 +1 @@
+export const foo2 = () => 17;

package/dist/src/test-data/resolve-paths/foo/index.d.ts

@@ -0,0 +1 @@
+export { foo } from './1.js';

package/dist/src/test-data/resolve-paths/foo/index.js

@@ -0,0 +1 @@
+export { foo } from './1.js';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bifravst/aws-cdk-lambda-helpers",
-  "version": "2.0.1",
+  "version": "2.2.0",
   "description": "Helper functions which simplify working with TypeScript lambdas for AWS CDK.",
   "exports": {
     ".": {
@@ -51,7 +51,7 @@
   "author": "Nordic Semiconductor ASA | nordicsemi.no",
   "license": "BSD-3-Clause",
   "devDependencies": {
-    "@aws-sdk/client-cloudformation": "3.691.0",
+    "@aws-sdk/client-cloudformation": "3.693.0",
     "@bifravst/cloudformation-helpers": "9.1.1",
     "@bifravst/eslint-config-typescript": "6.1.18",
     "@bifravst/from-env": "3.0.2",
@@ -113,7 +113,7 @@
     "yazl": "3.3.0"
   },
   "peerDependencies": {
-    "@bifravst/aws-ssm-settings-helpers": "^1.2.61",
+    "@bifravst/aws-ssm-settings-helpers": "^1.2.63",
     "aws-cdk-lib": "^2.167.0",
     "constructs": "^10.4.2"
   }