@biffo/cli 0.314.3 → 0.315.0

package/_skeletons/plugin-template/.github/workflows/ci.yml

@@ -1,8 +1,13 @@
 name: CI
 
 # Scaled down from biffo-template's own root .github/workflows/ci.yml for a
-# single Python package: a plugin repo (per ADR-0003) extends the SDK and
-# has no JS/TS of its own.
+# single Python package extending the SDK (per ADR-0003), plus the founder-
+# facing frontend bundle a `user_frontend` plugin ships in `web/` (ADR-0021
+# §2). It is deliberately NOT scaled down to zero JS/TS: this skeleton's own
+# `web/` is exactly that bundle, and the `frontend` job below is what proves a
+# freshly scaffolded plugin builds it with no edits — see A2:
+# biffo-template#2009. `web-admin/` (the separate `admin_ingress` surface) is
+# untouched here; its own CI wiring is tracked separately.
 #
 # It DOES have Terraform. This comment used to claim the opposite — "no
 # Terraform of its own; Terraform, if a plugin ships any, is provisioned by the
@@ -24,6 +29,9 @@ concurrency:
 
 env:
   PYTHON_VERSION: '3.13'
+  # Matches biffo-template's own root ci.yml NODE_VERSION (#2009) — the
+  # `frontend` job below is the only consumer of this in the skeleton today.
+  NODE_VERSION: '22'
 
 jobs:
   lint:
@@ -160,6 +168,58 @@ jobs:
         with:
           files: coverage.xml
 
+  frontend:
+    name: Frontend (web/)
+    runs-on: ${{ vars.RUNNER_LABEL || 'ubuntu-latest' }}
+    timeout-minutes: 20
+    # Proves the `user_frontend` bundle (ADR-0021 §2, biffo.plugin.json's
+    # "dir": "web/dist") actually builds. Before this job existed, the
+    # manifest declared it and nothing in this skeleton's own CI checked it —
+    # the exact drift docs/guides/development-practices.md records for
+    # web-admin/ ("nothing checked the frontend's lint, types, tests or
+    # whether it built"), here fixed at the source rather than patched
+    # downstream in every scaffolded plugin (biffo-template#2009).
+    #
+    # `web/` is its own package (its own package.json + lockfile), not a
+    # pnpm workspace member of this repo — `--ignore-workspace` matches
+    # deploy-app.yml's own build of this same directory (grep
+    # `plugin_dir/web` there), for the same reason: without it pnpm silently
+    # installs this repo's root deps instead and skips `web/` entirely.
+    steps:
+      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v5
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: pnpm
+          cache-dependency-path: web/pnpm-lock.yaml
+      - id: install
+        working-directory: web
+        run: pnpm install --ignore-workspace --frozen-lockfile
+      - name: Lint
+        if: ${{ !cancelled() && steps.install.outcome == 'success' }}
+        working-directory: web
+        run: pnpm run lint
+      - name: Type check
+        if: ${{ !cancelled() && steps.install.outcome == 'success' }}
+        working-directory: web
+        run: pnpm run typecheck
+      # Build BEFORE test, deliberately — web/src/base-path.test.ts's second
+      # assertion reads dist/index.html and skips itself (with a visible
+      # warning, not a silent pass) when dist/ is absent. Running the real
+      # build first is what turns that assertion from a permanent no-op into
+      # an actual check of the built asset paths, catching the exact class of
+      # bug (a `base` pasted from a sibling) that no other local gate caught
+      # for web-admin/'s equivalent (see the `frontend` job's header comment).
+      - name: Build
+        if: ${{ !cancelled() && steps.install.outcome == 'success' }}
+        working-directory: web
+        run: pnpm run build
+      - name: Test
+        if: ${{ !cancelled() && steps.install.outcome == 'success' }}
+        working-directory: web
+        run: pnpm run test
+
   validate-manifest:
     name: Validate biffo.plugin.json
     runs-on: ${{ vars.RUNNER_LABEL || 'ubuntu-latest' }}

package/_skeletons/plugin-template/web/_gitignore

@@ -0,0 +1,5 @@
+# Dependencies
+node_modules
+
+# Build output
+dist

package/_skeletons/plugin-template/web/eslint.config.js

@@ -0,0 +1,8 @@
+import js from '@eslint/js'
+import tseslint from 'typescript-eslint'
+
+export default tseslint.config(
+  { ignores: ['dist'] },
+  js.configs.recommended,
+  ...tseslint.configs.recommended,
+)

package/_skeletons/plugin-template/web/index.html

@@ -0,0 +1,12 @@
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>example-plugin</title>
+  </head>
+  <body>
+    <div id="root"></div>
+    <script type="module" src="/src/main.tsx"></script>
+  </body>
+</html>

package/_skeletons/plugin-template/web/package.json

@@ -0,0 +1,40 @@
+{
+  "name": "example-plugin-web",
+  "version": "0.0.0",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "dev": "vite",
+    "build": "tsc -b && vite build",
+    "typecheck": "tsc --noEmit",
+    "lint": "eslint .",
+    "test": "vitest run"
+  },
+  "dependencies": {
+    "@biffo/design-tokens": "^0.152.0",
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0"
+  },
+  "devDependencies": {
+    "@testing-library/dom": "^10.4.1",
+    "@testing-library/jest-dom": "^6.9.1",
+    "@testing-library/react": "^16.3.2",
+    "@types/node": "^26.1.2",
+    "@types/react": "^19.0.7",
+    "@types/react-dom": "^19.0.3",
+    "@vitejs/plugin-react": "^4.7.0",
+    "eslint": "^9.18.0",
+    "jsdom": "^30.0.1",
+    "typescript": "^5.7.3",
+    "typescript-eslint": "^8.20.0",
+    "vite": "^6.4.3",
+    "vitest": "^4.1.0"
+  },
+  "pnpm": {
+    "overrides": {
+      "brace-expansion@<5.0.9": ">=5.0.9",
+      "js-yaml@<4.3.1": ">=4.3.1 <5",
+      "nanoid@<3.3.17": ">=3.3.17 <4"
+    }
+  }
+}