@biffo/cli 0.301.19 → 0.301.21
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -424,8 +424,16 @@ export function deliberateClosingReferences(text, { code = true } = {}) {
|
|
|
424
424
|
* carried only `Refs #133`. The issue closed on merge anyway. The lesson
|
|
425
425
|
* recorded then: *keeping a denial out of the commit is not sufficient —
|
|
426
426
|
* GitHub's linker reads the PR description text on its own.*
|
|
427
|
-
* - #1238 / #1021 (2026-08-03) —
|
|
428
|
-
*
|
|
427
|
+
* - biffo-template#1238 / biffo-template#1021 (2026-08-03) — this repo's own
|
|
428
|
+
* issues, not an external one: `- **Does not close #1021.**` in the body,
|
|
429
|
+
* `Refs #1021` in the commit, #1021 closed by the squash-merge. (#1872
|
|
430
|
+
* re-checked this entry against the wrong repo — tabsii-platform, where no
|
|
431
|
+
* such pair exists at that date — and, not finding it there, filed a
|
|
432
|
+
* doubt. Re-verified directly against biffo-template's own #1021/#1238:
|
|
433
|
+
* the pairing, the quoted lines and the date all check out exactly as
|
|
434
|
+
* recorded. The two bare `#N`s were ambiguous next to the other entries'
|
|
435
|
+
* explicit `tabsii-platform#76`/`tabsii-crm#133` qualifiers, which is the
|
|
436
|
+
* actual defect #1872 found — now spelled out with the repo name.)
|
|
429
437
|
*
|
|
430
438
|
* The recorded fix each time was a *practice*: "never write a closing keyword
|
|
431
439
|
* in prose". Three occurrences produced a rule and no mechanism, and the
|
|
@@ -661,9 +669,10 @@ function formatNegatedFailure({ negated }) {
|
|
|
661
669
|
...negated.map((n) => ` ${n.source}, line ${n.lineNumber}: ${n.line}`),
|
|
662
670
|
'',
|
|
663
671
|
'This has now happened four times (tabsii-platform#76, tabsii-crm#133,',
|
|
664
|
-
'#1021 via #1238 — see #1245). Keeping the
|
|
665
|
-
'message is not enough: GitHub reads the PR
|
|
666
|
-
'(#1334) a commit message on its own,
|
|
672
|
+
'biffo-template#1021 via biffo-template#1238 — see #1245). Keeping the',
|
|
673
|
+
'denial out of the commit message is not enough: GitHub reads the PR',
|
|
674
|
+
'description on its own — and (#1334) a commit message on its own,',
|
|
675
|
+
'independent of the body.',
|
|
667
676
|
'',
|
|
668
677
|
'Rewrite the line so no closing keyword sits in front of the reference:',
|
|
669
678
|
...refs.map((r) => ` - \`Refs ${r}\`, or "leaves ${r} open"`),
|
|
@@ -424,8 +424,16 @@ export function deliberateClosingReferences(text, { code = true } = {}) {
|
|
|
424
424
|
* carried only `Refs #133`. The issue closed on merge anyway. The lesson
|
|
425
425
|
* recorded then: *keeping a denial out of the commit is not sufficient —
|
|
426
426
|
* GitHub's linker reads the PR description text on its own.*
|
|
427
|
-
* - #1238 / #1021 (2026-08-03) —
|
|
428
|
-
*
|
|
427
|
+
* - biffo-template#1238 / biffo-template#1021 (2026-08-03) — this repo's own
|
|
428
|
+
* issues, not an external one: `- **Does not close #1021.**` in the body,
|
|
429
|
+
* `Refs #1021` in the commit, #1021 closed by the squash-merge. (#1872
|
|
430
|
+
* re-checked this entry against the wrong repo — tabsii-platform, where no
|
|
431
|
+
* such pair exists at that date — and, not finding it there, filed a
|
|
432
|
+
* doubt. Re-verified directly against biffo-template's own #1021/#1238:
|
|
433
|
+
* the pairing, the quoted lines and the date all check out exactly as
|
|
434
|
+
* recorded. The two bare `#N`s were ambiguous next to the other entries'
|
|
435
|
+
* explicit `tabsii-platform#76`/`tabsii-crm#133` qualifiers, which is the
|
|
436
|
+
* actual defect #1872 found — now spelled out with the repo name.)
|
|
429
437
|
*
|
|
430
438
|
* The recorded fix each time was a *practice*: "never write a closing keyword
|
|
431
439
|
* in prose". Three occurrences produced a rule and no mechanism, and the
|
|
@@ -661,9 +669,10 @@ function formatNegatedFailure({ negated }) {
|
|
|
661
669
|
...negated.map((n) => ` ${n.source}, line ${n.lineNumber}: ${n.line}`),
|
|
662
670
|
'',
|
|
663
671
|
'This has now happened four times (tabsii-platform#76, tabsii-crm#133,',
|
|
664
|
-
'#1021 via #1238 — see #1245). Keeping the
|
|
665
|
-
'message is not enough: GitHub reads the PR
|
|
666
|
-
'(#1334) a commit message on its own,
|
|
672
|
+
'biffo-template#1021 via biffo-template#1238 — see #1245). Keeping the',
|
|
673
|
+
'denial out of the commit message is not enough: GitHub reads the PR',
|
|
674
|
+
'description on its own — and (#1334) a commit message on its own,',
|
|
675
|
+
'independent of the body.',
|
|
667
676
|
'',
|
|
668
677
|
'Rewrite the line so no closing keyword sits in front of the reference:',
|
|
669
678
|
...refs.map((r) => ` - \`Refs ${r}\`, or "leaves ${r} open"`),
|