@biffo/cli 0.198.4 → 0.198.6

package/_skeletons/sibling-template/apps/frontend/src/app/layout.tsx

@@ -1,9 +1,16 @@
 import type { Metadata } from 'next'
 import type { ReactNode } from 'react'
+import { SIBLING_TITLE } from '@/lib/branding'
 import './globals.css'
 
 export const metadata: Metadata = {
-  title: 'Sibling App',
+  // Derived from this sibling's own name at build time — see lib/branding.ts.
+  // `title.template` composes per-page titles for free: a page exporting
+  // `metadata = { title: 'Weekly' }` then renders "<Sibling> - Weekly".
+  title: {
+    default: SIBLING_TITLE,
+    template: `${SIBLING_TITLE} - %s`,
+  },
 }
 
 export default function RootLayout({ children }: { children: ReactNode }) {

package/_skeletons/sibling-template/apps/frontend/src/lib/branding.test.ts

@@ -0,0 +1,35 @@
+import { describe, expect, it } from 'vitest'
+
+import { formatSiblingTitle } from './branding'
+
+// Regression coverage for biffo-template#963: the skeleton's root layout used
+// to hard-code `metadata.title = 'Sibling App'`, so every sibling scaffolded
+// from it shipped that literal in its deployed <title>. The title is now
+// derived from NEXT_PUBLIC_SIBLING_NAME (the same build-time variable
+// `page.tsx` reads), and this is that derivation.
+describe('formatSiblingTitle', () => {
+  it('capitalises a single-word sibling name', () => {
+    expect(formatSiblingTitle('reports')).toBe('Reports')
+  })
+
+  it('splits hyphenated and underscored names into words', () => {
+    expect(formatSiblingTitle('field-ops')).toBe('Field Ops')
+    expect(formatSiblingTitle('tabsii_crm')).toBe('Tabsii Crm')
+    expect(formatSiblingTitle('a-b-c')).toBe('A B C')
+  })
+
+  it('leaves an already-capitalised name alone', () => {
+    expect(formatSiblingTitle('Reports')).toBe('Reports')
+  })
+
+  it('tolerates stray separators without emitting empty words', () => {
+    expect(formatSiblingTitle('--field--ops--')).toBe('Field Ops')
+  })
+
+  it('never returns the old hard-coded placeholder, even with no name set', () => {
+    for (const missing of [undefined, '', '   ', '---']) {
+      expect(formatSiblingTitle(missing)).toBe('Sibling')
+      expect(formatSiblingTitle(missing)).not.toBe('Sibling App')
+    }
+  })
+})

package/_skeletons/sibling-template/apps/frontend/src/lib/branding.ts

@@ -0,0 +1,51 @@
+/**
+ * Sibling branding (issue #963).
+ *
+ * The skeleton's root layout used to hard-code `metadata.title = 'Sibling App'`,
+ * and nothing at `biffo sibling create` time ever touched it — so every sibling
+ * ever scaffolded was born mislabeled in every browser tab, visibly in the
+ * deployed `out/index.html`, until a human noticed and fixed it by hand.
+ *
+ * Instead, derive it from the sibling's own name the same way `page.tsx`
+ * already does: the build-time `NEXT_PUBLIC_SIBLING_NAME`. That variable is
+ * already wired end to end — `biffo sibling create` writes the repo variable
+ * `PROJECT_NAME`, `.github/workflows/deploy.yml` passes it to the frontend
+ * build as `NEXT_PUBLIC_SIBLING_NAME`, and `apps/frontend/.env.example` is
+ * templated with the sibling's name at create time for local runs. The
+ * frontend builds with `output: 'export'`, so the value is baked into the
+ * static bundle; there is nothing to read at runtime.
+ *
+ * This mirrors `apps/portal/src/lib/branding.ts` upstream (issue #389), which
+ * solved the identical problem for the portal with a build-time env var rather
+ * than a scaffold-time source patch. Reading an env var beats regex-patching a
+ * `.tsx` file at create time: one mechanism, no fragile source rewrite, and it
+ * keeps working when the sibling is later renamed.
+ *
+ * The title is the sibling's OWN name only, never `<core project> - <sibling>`.
+ * The template is deliberately brand-agnostic and has no reliable way to know
+ * an instance's brand (as opposed to its `project.name`) at sibling-create
+ * time. A sibling that wants a brand prefix owns its own `layout.tsx` and can
+ * add one.
+ */
+
+/**
+ * Turn a project slug into something presentable in a browser tab:
+ * `reports` → `Reports`, `field-ops` → `Field Ops`, `tabsii_crm` → `Tabsii Crm`.
+ *
+ * Deliberately dumb and deterministic — it does not try to guess acronyms
+ * (`crm` → `CRM`), because guessing wrong is worse than being plain and a
+ * sibling that cares can override the title outright.
+ */
+export function formatSiblingTitle(rawName: string | undefined): string {
+  const words = (rawName ?? '')
+    .split(/[-_\s]+/)
+    .filter((word) => word.length > 0)
+    .map((word) => word.charAt(0).toUpperCase() + word.slice(1))
+
+  // Fallback for a frontend run with no env at all (a bare `pnpm dev` before
+  // `.env.example` is copied). Matches page.tsx's own fallback for the same
+  // variable, and is deliberately NOT the old 'Sibling App' literal.
+  return words.length > 0 ? words.join(' ') : 'Sibling'
+}
+
+export const SIBLING_TITLE = formatSiblingTitle(process.env['NEXT_PUBLIC_SIBLING_NAME'])

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@biffo/cli",
-  "version": "0.198.4",
+  "version": "0.198.6",
   "description": "Biffo project scaffolding CLI",
   "license": "MIT",
   "type": "module",