@bian-womp/spark-workbench 0.3.52 → 0.3.54

package/lib/cjs/index.cjs

@@ -1206,6 +1206,14 @@ class LocalGraphRunner extends AbstractGraphRunner {
         this.emit("transport", { runnerId: this.runnerId, state: "local" });
     }
     build(def, opts) {
+        // Rebuilding should not leave the previous runtime alive.
+        // In practice, launch() calls build() and can be triggered multiple times for the same UI "flow".
+        // Disposing here avoids multiple GraphRuntime instances accumulating and emitting events.
+        if (this.runtime) {
+            console.info(`[LocalGraphRunner] Disposing previous runtime before building new one`);
+            this.runtime.dispose();
+            this.runtime = undefined;
+        }
         const builder = new sparkGraph.GraphBuilder(this.registry);
         this.runtime = builder.build(def, opts);
         // Signal UI that freshly built graph should be considered invalidated
@@ -3922,6 +3930,7 @@ function WorkbenchProvider({ wb, runner, overrides, uiVersion, children, }) {
     const [registryErrors, setRegistryErrors] = React.useState([]);
     const [inputValidationErrors, setInputValidationErrors] = React.useState([]);
     const [registryVersion, setRegistryVersion] = React.useState(0);
+    const [registryReady, setRegistryReady] = React.useState(false);
     const clearSystemErrors = React.useCallback(() => setSystemErrors([]), []);
     const clearRegistryErrors = React.useCallback(() => setRegistryErrors([]), []);
     const clearInputValidationErrors = React.useCallback(() => setInputValidationErrors([]), []);
@@ -4619,6 +4628,7 @@ function WorkbenchProvider({ wb, runner, overrides, uiVersion, children, }) {
         // Registry updates: swap registry and refresh graph validation/UI
         const offRunnerRegistry = runner.on("registry", async (registry) => {
             wb.setRegistry(registry);
+            setRegistryReady(true);
         });
         const offFlowViewport = runner.on("viewport", (event) => {
             const viewport = event.viewport;
@@ -4627,6 +4637,17 @@ function WorkbenchProvider({ wb, runner, overrides, uiVersion, children, }) {
             }
         });
         const offRunnerTransport = runner.on("transport", (t) => {
+            // Remote registry is only considered ready once we've received at least one "registry" event.
+            // Reset readiness whenever transport is not stable.
+            if (t.state === "local") {
+                setRegistryReady(true);
+            }
+            else if (t.state === "connecting" || t.state === "retrying") {
+                setRegistryReady(false);
+            }
+            else if (t.state === "disconnected") {
+                setRegistryReady(false);
+            }
             if (t.state === "disconnected") {
                 console.info("[WorkbenchContext] Transport disconnected, resetting node status");
                 // Reinitialize node status with invalidated=true for all nodes
@@ -4821,6 +4842,7 @@ function WorkbenchProvider({ wb, runner, overrides, uiVersion, children, }) {
         triggerExternal,
         uiVersion,
         registryVersion,
+        registryReady,
         overrides,
         getNodeDisplayName,
         setNodeName,
@@ -4862,6 +4884,7 @@ function WorkbenchProvider({ wb, runner, overrides, uiVersion, children, }) {
         runner,
         uiVersion,
         registryVersion,
+        registryReady,
         overrides,
         getNodeDisplayName,
         setNodeName,