@bian-womp/spark-workbench 0.3.14 → 0.3.15

package/lib/cjs/index.cjs

@@ -1385,6 +1385,13 @@ function excludeViewportFromUIState(uiState) {
 // Counter for generating readable runner IDs
 let remoteRunnerCounter = 0;
 class RemoteGraphRunner extends AbstractGraphRunner {
+    /**
+     * Generate cache key that includes io type to prevent collisions
+     * between input and output handles with the same name
+     */
+    getCacheKey(nodeId, handle, io) {
+        return `${nodeId}.${io}.${handle}`;
+    }
     /**
      * Fetch full registry description from remote and register it locally.
      * Simplified with straightforward retry loop.
@@ -1503,14 +1510,6 @@ class RemoteGraphRunner extends AbstractGraphRunner {
                 if (attempt < this.MAX_REGISTRY_FETCH_ATTEMPTS) {
                     const delayMs = this.INITIAL_RETRY_DELAY_MS * Math.pow(2, attempt - 1);
                     console.warn(`Failed to fetch registry (attempt ${attempt}/${this.MAX_REGISTRY_FETCH_ATTEMPTS}), retrying in ${delayMs}ms...`, lastError);
-                    // Emit error event for UI feedback
-                    this.emit("error", {
-                        kind: "registry",
-                        message: `Registry fetch failed (attempt ${attempt}/${this.MAX_REGISTRY_FETCH_ATTEMPTS}), retrying...`,
-                        err: lastError,
-                        attempt,
-                        maxAttempts: this.MAX_REGISTRY_FETCH_ATTEMPTS,
-                    });
                     // Wait before retrying
                     await new Promise((resolve) => setTimeout(resolve, delayMs));
                 }
@@ -1737,8 +1736,7 @@ class RemoteGraphRunner extends AbstractGraphRunner {
                 const snap = await client.api.snapshot();
                 for (const [nodeId, map] of Object.entries(snap.inputs || {})) {
                     for (const [handle, value] of Object.entries(map || {})) {
-                        this.valueCache.set(`${nodeId}.${handle}`, {
-                            io: "input",
+                        this.valueCache.set(this.getCacheKey(nodeId, handle, "input"), {
                             value,
                         });
                         this.emit("value", { nodeId, handle, value, io: "input" });
@@ -1746,8 +1744,7 @@ class RemoteGraphRunner extends AbstractGraphRunner {
                 }
                 for (const [nodeId, map] of Object.entries(snap.outputs || {})) {
                     for (const [handle, value] of Object.entries(map || {})) {
-                        this.valueCache.set(`${nodeId}.${handle}`, {
-                            io: "output",
+                        this.valueCache.set(this.getCacheKey(nodeId, handle, "output"), {
                             value,
                         });
                         this.emit("value", { nodeId, handle, value, io: "output" });
@@ -1768,8 +1765,7 @@ class RemoteGraphRunner extends AbstractGraphRunner {
         const eng = client.engine;
         if (!this.listenersBound) {
             eng.on("value", (e) => {
-                this.valueCache.set(`${e.nodeId}.${e.handle}`, {
-                    io: e.io,
+                this.valueCache.set(this.getCacheKey(e.nodeId, e.handle, e.io), {
                     value: e.value,
                     runtimeTypeId: e.runtimeTypeId,
                 });
@@ -1938,8 +1934,7 @@ class RemoteGraphRunner extends AbstractGraphRunner {
         // Hydrate inputs
         for (const [nodeId, map] of Object.entries(snapshot.inputs || {})) {
             for (const [handle, value] of Object.entries(map || {})) {
-                this.valueCache.set(`${nodeId}.${handle}`, {
-                    io: "input",
+                this.valueCache.set(this.getCacheKey(nodeId, handle, "input"), {
                     value,
                 });
                 this.emit("value", {
@@ -1954,8 +1949,7 @@ class RemoteGraphRunner extends AbstractGraphRunner {
         // Hydrate outputs
         for (const [nodeId, map] of Object.entries(snapshot.outputs || {})) {
             for (const [handle, value] of Object.entries(map || {})) {
-                this.valueCache.set(`${nodeId}.${handle}`, {
-                    io: "output",
+                this.valueCache.set(this.getCacheKey(nodeId, handle, "output"), {
                     value,
                 });
                 this.emit("value", {
@@ -2001,9 +1995,9 @@ class RemoteGraphRunner extends AbstractGraphRunner {
             const desc = this.registry.nodes.get(n.typeId);
             const handles = Object.keys(resolved ?? desc?.outputs ?? {});
             for (const h of handles) {
-                const key = `${n.nodeId}.${h}`;
+                const key = this.getCacheKey(n.nodeId, h, "output");
                 const rec = cache.get(key);
-                if (rec && rec.io === "output") {
+                if (rec) {
                     if (!out[n.nodeId])
                         out[n.nodeId] = {};
                     out[n.nodeId][h] = rec.value;
@@ -2026,8 +2020,8 @@ class RemoteGraphRunner extends AbstractGraphRunner {
                 .filter((e) => e.target.nodeId === n.nodeId)
                 .map((e) => e.target.handle));
             for (const h of handles) {
-                const rec = cache.get(`${n.nodeId}.${h}`);
-                if (rec && rec.io === "input")
+                const rec = cache.get(this.getCacheKey(n.nodeId, h, "input"));
+                if (rec)
                     cur[h] = rec.value;
             }
             // Merge staged only for non-inbound handles so UI doesn't override runtime values