@bian-womp/spark-workbench 0.2.76 → 0.2.78

package/lib/cjs/index.cjs

@@ -193,6 +193,13 @@ class InMemoryWorkbench extends AbstractWorkbench {
         }
         return { ok: issues.every((i) => i.level !== "error"), issues };
     }
+    setInputs(nodeId, inputs, options) {
+        this.emit("graphChanged", {
+            def: this.def,
+            change: { type: "setInputs", nodeId, inputs },
+            ...options,
+        });
+    }
     addNode(node, options) {
         const id = node.nodeId ??
             this.genId("n", new Set(this.def.nodes.map((n) => n.nodeId)));
@@ -1362,7 +1369,7 @@ class RemoteGraphRunner extends AbstractGraphRunner {
         this.emit("status", { running: true, engine: this.runningKind });
         // Re-apply staged inputs using client.setInputs for consistency
         for (const [nodeId, map] of Object.entries(this.stagedInputs)) {
-            await client.setInputs(nodeId, map).catch(() => {
+            await eng.setInputs(nodeId, map).catch(() => {
                 // Ignore errors during launch - inputs will be set when user calls setInputs
             });
         }
@@ -1408,7 +1415,7 @@ class RemoteGraphRunner extends AbstractGraphRunner {
         this.emit("status", { running: true, engine: this.runningKind });
         // Re-apply staged inputs using client.setInputs for consistency
         for (const [nodeId, map] of Object.entries(currentInputs)) {
-            await client.setInputs(nodeId, map).catch(() => {
+            await eng.setInputs(nodeId, map).catch(() => {
                 // Ignore errors during engine switch - inputs will be set when user calls setInputs
             });
         }
@@ -1437,10 +1444,9 @@ class RemoteGraphRunner extends AbstractGraphRunner {
                 this.stagedInputs[nodeId][handle] = value;
             }
         }
-        // Use transport.request instead of transport.send for consistency
-        const client = await this.ensureClient();
         try {
-            await client.setInputs(nodeId, inputs, options);
+            const client = await this.ensureClient();
+            await client.getEngine()?.setInputs(nodeId, inputs, options);
         }
         catch (err) {
             // Emit synthetic events if connection fails
@@ -1452,36 +1458,15 @@ class RemoteGraphRunner extends AbstractGraphRunner {
     }
     async copyOutputs(fromNodeId, toNodeId, options) {
         const client = await this.ensureClient();
-        await client.copyOutputs(fromNodeId, toNodeId, options);
+        await client.getEngine()?.copyOutputs(fromNodeId, toNodeId, options);
     }
-    async setViewport(viewport) {
+    async triggerExternal(nodeId, event, options) {
         const client = await this.ensureClient();
-        const transport = client.transport;
-        if (transport && transport.send) {
-            transport.send({
-                seq: Date.now(),
-                ts: Date.now(),
-                message: {
-                    type: "SetViewport",
-                    payload: { viewport },
-                },
-            });
-        }
+        await client.getEngine()?.triggerExternal(nodeId, event, options);
     }
-    triggerExternal(nodeId, event, options) {
-        // If engine exists, call directly; otherwise ensure client (fire-and-forget)
-        if (this.engine) {
-            this.engine.triggerExternal(nodeId, event, options);
-        }
-        else {
-            this.ensureClient()
-                .then((client) => {
-                client.getEngine().triggerExternal(nodeId, event, options);
-            })
-                .catch(() => {
-                // Silently fail if connection not available
-            });
-        }
+    async setViewport(viewport) {
+        const client = await this.ensureClient();
+        await client.setViewport(viewport);
     }
     async coerce(from, to, value) {
         const client = await this.ensureClient();
@@ -2554,7 +2539,7 @@ async function upload(parsed, wb, runner) {
         runner.build(wb.export());
         if (inputs && typeof inputs === "object") {
             for (const [nodeId, map] of Object.entries(inputs)) {
-                runner.setInputs(nodeId, map);
+                runner.setInputs(nodeId, map, { dry: true });
             }
         }
     }
@@ -2850,10 +2835,6 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
                         [handle]: now,
                     },
                 }));
-                setNodeStatus((s) => ({
-                    ...s,
-                    [nodeId]: { ...s[nodeId], invalidated: true },
-                }));
                 // Clear validation errors for this input when a valid value is set
                 setInputValidationErrors((prev) => prev.filter((err) => !(err.nodeId === nodeId && err.handle === handle)));
             }
@@ -2959,30 +2940,6 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
             // If resolvedHandles are included in the event, use them directly (more efficient)
             if (e?.resolvedHandles && Object.keys(e.resolvedHandles).length > 0) {
                 applyResolvedHandles(e.resolvedHandles);
-                // Mark nodes whose handles changed as invalid
-                const affectedNodeIds = Object.keys(e.resolvedHandles);
-                if (affectedNodeIds.length > 0) {
-                    setNodeStatus((prev) => {
-                        const next = { ...prev };
-                        for (const id of affectedNodeIds) {
-                            const cur = next[id] ?? (next[id] = { activeRuns: 0, activeRunIds: [] });
-                            next[id] = { ...cur, invalidated: true };
-                        }
-                        return next;
-                    });
-                }
-            }
-            // For broader invalidations (e.g. registry-changed, graph-updated), mark all nodes invalid
-            if (e?.reason === "registry-changed" || e?.reason === "graph-updated") {
-                setNodeStatus((prev) => {
-                    const next = { ...prev };
-                    for (const n of def.nodes) {
-                        const cur = next[n.nodeId] ??
-                            (next[n.nodeId] = { activeRuns: 0, activeRunIds: [] });
-                        next[n.nodeId] = { ...cur, invalidated: true };
-                    }
-                    return next;
-                });
             }
             return add("runner", "invalidate")(e);
         });
@@ -3015,7 +2972,6 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
                                 ? [...currentRunIds, runId]
                                 : currentRunIds,
                             progress: 0,
-                            invalidated: false,
                         },
                     };
                 });
@@ -3118,16 +3074,6 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
         const offWbGraphUiChangedForLog = wb.on("graphUiChanged", add("workbench", "graphUiChanged"));
         const offWbValidationChanged = wb.on("validationChanged", add("workbench", "validationChanged"));
         // Ensure newly added nodes start as invalidated until first evaluation
-        const offWbAddNode = wb.on("graphChanged", (e) => {
-            const change = e.change;
-            if (change?.type === "addNode" && typeof change.nodeId === "string") {
-                const id = change.nodeId;
-                setNodeStatus((s) => ({
-                    ...s,
-                    [id]: { ...s[id], invalidated: true },
-                }));
-            }
-        });
         const offWbGraphChangedForUpdate = wb.on("graphChanged", async (event) => {
             // Build detailed reason from change type
             let reason = "graph-changed";
@@ -3152,6 +3098,10 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
                     reason = "update-edge-type";
                 }
             }
+            if (event.change?.type === "setInputs") {
+                const { nodeId, inputs } = event.change;
+                await runner.setInputs(nodeId, inputs, { dry: event.dry });
+            }
             if (!runner.isRunning()) {
                 if (event.commit) {
                     await saveUiRuntimeMetadata();
@@ -3159,9 +3109,8 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
                         console.error("[WorkbenchContext] Error committing:", err);
                         return undefined;
                     });
-                    if (history) {
+                    if (history)
                         wb.setHistory(history);
-                    }
                 }
                 return;
             }
@@ -3184,7 +3133,7 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
                         }
                     }
                 }
-                else {
+                else if (event.change?.type !== "setInputs") {
                     await runner.update(event.def, { dry: event.dry });
                 }
                 if (event.commit) {
@@ -3317,7 +3266,6 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, overrides, uiVer
             offWbGraphUiChanged();
             offWbValidationChanged();
             offWbError();
-            offWbAddNode();
             offWbGraphChangedForUpdate();
             offWbdSetValidation();
             offWbSelectionChanged();
@@ -5289,7 +5237,7 @@ function WorkbenchStudioCanvas({ setRegistry, autoScroll, onAutoScrollChange, ex
             catch { }
             if (inputs) {
                 for (const [nodeId, map] of Object.entries(inputs)) {
-                    runner.setInputs(nodeId, map);
+                    runner.setInputs(nodeId, map, { dry: true });
                 }
             }
         };
@@ -5355,7 +5303,7 @@ function WorkbenchStudioCanvas({ setRegistry, autoScroll, onAutoScrollChange, ex
         // Set initial inputs if provided
         if (inputs) {
             for (const [nodeId, map] of Object.entries(inputs)) {
-                runner.setInputs(nodeId, map);
+                runner.setInputs(nodeId, map, { dry: true });
             }
         }
         runAutoLayout();
@@ -5455,7 +5403,7 @@ function WorkbenchStudioCanvas({ setRegistry, autoScroll, onAutoScrollChange, ex
             return;
         // If raw is undefined, pass it through to delete the input value
         if (raw === undefined) {
-            runner.setInputs(selectedNodeId, { [handle]: undefined });
+            wb.setInputs(selectedNodeId, { [handle]: undefined }, { commit: true });
             return;
         }
         const typeId = sparkGraph.getInputTypeId(effectiveHandles.inputs, handle);
@@ -5534,8 +5482,8 @@ function WorkbenchStudioCanvas({ setRegistry, autoScroll, onAutoScrollChange, ex
                 value = raw;
             }
         }
-        runner.setInputs(selectedNodeId, { [handle]: value });
-    }, [selectedNodeId, def.edges, effectiveHandles, runner]);
+        wb.setInputs(selectedNodeId, { [handle]: value }, { commit: true });
+    }, [selectedNodeId, def.edges, effectiveHandles, wb]);
     const setInput = React.useMemo(() => {
         if (overrides?.setInput) {
             return overrides.setInput(baseSetInput, {