@bian-womp/spark-workbench 0.1.11 → 0.1.13

package/lib/cjs/index.cjs

@@ -343,19 +343,9 @@ class GraphRunner {
             if (!this.runtime)
                 return;
             // Prevent mid-run churn while wiring changes are applied
-            try {
-                this.runtime.pause();
-            }
-            catch {
-                console.error("Failed to pause runtime");
-            }
+            this.runtime.pause();
             this.runtime.update(def, this.registry);
-            try {
-                this.runtime.resume();
-            }
-            catch {
-                console.error("Failed to resume runtime");
-            }
+            this.runtime.resume();
             this.emit("invalidate", { reason: "graph-updated" });
             return;
         }
@@ -409,9 +399,7 @@ class GraphRunner {
             this.runningKind = opts.engine;
             this.emit("status", { running: true, engine: this.runningKind });
             for (const [nodeId, map] of Object.entries(this.stagedInputs)) {
-                for (const [handle, value] of Object.entries(map)) {
-                    this.engine.setInput(nodeId, handle, value);
-                }
+                this.engine.setInputs(nodeId, map);
             }
             return;
         }
@@ -439,9 +427,7 @@ class GraphRunner {
             this.runningKind = "push";
             this.emit("status", { running: true, engine: this.runningKind });
             for (const [nodeId, map] of Object.entries(this.stagedInputs)) {
-                for (const [handle, value] of Object.entries(map)) {
-                    this.engine.setInput(nodeId, handle, value);
-                }
+                this.engine.setInputs(nodeId, map);
             }
         });
     }
@@ -457,6 +443,51 @@ class GraphRunner {
             this.emit("value", { nodeId, handle, value, io: "input" });
         }
     }
+    // Batch update multiple inputs on a node and trigger a single run
+    setInputs(nodeId, inputs) {
+        if (!inputs)
+            return;
+        if (!this.stagedInputs[nodeId])
+            this.stagedInputs[nodeId] = {};
+        Object.assign(this.stagedInputs[nodeId], inputs);
+        // Local running: pause, set all inputs, resume, schedule a single recompute
+        if (this.backend.kind === "local" && this.engine && this.runtime) {
+            this.runtime.pause();
+            try {
+                for (const [handle, value] of Object.entries(inputs)) {
+                    this.engine.setInput(nodeId, handle, value);
+                }
+            }
+            finally {
+                this.runtime.resume();
+                try {
+                    this.runtime.__unsafe_scheduleInputsChanged(nodeId);
+                }
+                catch { }
+            }
+        }
+        // Remote running: forward inputs individually (no batch API available)
+        else if (this.engine && this.backend.kind !== "local") {
+            // Prefer batch if supported by remote engine
+            if (this.engine instanceof sparkRemote.RemoteEngine) {
+                this.engine.setInputs(nodeId, inputs);
+            }
+            else {
+                console.warn("Remote engine does not support setInputs");
+                for (const [handle, value] of Object.entries(inputs)) {
+                    this.engine.setInput(nodeId, handle, value);
+                }
+            }
+        }
+        // Not running: emit value events so UI reflects staged values
+        else if (!this.engine) {
+            // Not running: emit a single synthetic value event per handle; UI will coalesce
+            console.warn("Remote engine does not exists");
+            for (const [handle, value] of Object.entries(inputs)) {
+                this.emit("value", { nodeId, handle, value, io: "input" });
+            }
+        }
+    }
     async step() {
         if (this.backend.kind !== "local")
             return; // unsupported remotely
@@ -817,7 +848,7 @@ function toReactFlow(def, positions, registry, opts) {
     })
         .map((e) => {
         const st = opts.edgeStatus?.[e.id];
-        const isRunning = !!st?.running;
+        const isRunning = !!st?.activeRuns;
         const hasError = !!st?.lastError;
         const isInvalidEdge = !!opts.edgeValidation?.[e.id];
         const style = hasError || isInvalidEdge
@@ -848,7 +879,7 @@ function getNodeBorderClassNames(args) {
     const hasError = !!status.lastError;
     const hasValidationError = issues.some((i) => i?.level === "error");
     const hasValidationWarning = !hasValidationError && issues.length > 0;
-    const isRunning = !!status.running;
+    const isRunning = !!status.activeRuns;
     const isInvalid = !!status.invalidated && !isRunning && !hasError;
     const borderWidth = selected ? "border-2" : "border";
     const borderStyle = isInvalid ? "border-dashed" : "border-solid";
@@ -963,7 +994,7 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, children, }) {
                 const nodeId = e?.nodeId;
                 setNodeStatus((s) => ({
                     ...s,
-                    [nodeId]: { ...(s[nodeId] ?? {}), invalidated: true },
+                    [nodeId]: { ...s[nodeId], invalidated: true },
                 }));
             }
             return add("runner", "value")(e);
@@ -975,7 +1006,7 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, children, }) {
                 const edgeId = edgeError.edgeId;
                 setEdgeStatus((s) => ({
                     ...s,
-                    [edgeId]: { ...(s[edgeId] ?? {}), lastError: edgeError.err },
+                    [edgeId]: { ...s[edgeId], lastError: edgeError.err },
                 }));
             }
             else if (nodeError.nodeId) {
@@ -983,7 +1014,7 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, children, }) {
                 setNodeStatus((s) => ({
                     ...s,
                     [nodeId]: {
-                        ...(s[nodeId] ?? {}),
+                        ...s[nodeId],
                         lastError: nodeError.err,
                     },
                 }));
@@ -995,7 +1026,7 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, children, }) {
                 setNodeStatus((s) => {
                     const next = {};
                     for (const n of wb.export().nodes) {
-                        next[n.nodeId] = { ...(s[n.nodeId] ?? {}), invalidated: true };
+                        next[n.nodeId] = { ...s[n.nodeId], invalidated: true };
                     }
                     return next;
                 });
@@ -1007,47 +1038,61 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, children, }) {
                 return;
             if (s.kind === "node-start") {
                 const id = s.nodeId;
-                setNodeStatus((prev) => ({
-                    ...prev,
-                    [id]: {
-                        ...(prev[id] ?? {}),
-                        running: true,
-                        progress: 0,
-                        invalidated: false,
-                    },
-                }));
+                setNodeStatus((prev) => {
+                    const current = prev[id]?.activeRuns ?? 0;
+                    return {
+                        ...prev,
+                        [id]: {
+                            ...prev[id],
+                            activeRuns: current + 1,
+                            progress: 0,
+                            invalidated: false,
+                        },
+                    };
+                });
             }
             else if (s.kind === "node-progress") {
                 const id = s.nodeId;
                 setNodeStatus((prev) => ({
                     ...prev,
                     [id]: {
-                        ...(prev[id] ?? {}),
-                        running: true,
+                        ...prev[id],
                         progress: Number(s.progress) || 0,
                     },
                 }));
             }
             else if (s.kind === "node-done") {
                 const id = s.nodeId;
-                setNodeStatus((prev) => ({
-                    ...prev,
-                    [id]: { ...(prev[id] ?? {}), running: false },
-                }));
+                setNodeStatus((prev) => {
+                    const current = prev[id]?.activeRuns ?? 0;
+                    return {
+                        ...prev,
+                        [id]: {
+                            ...prev[id],
+                            activeRuns: current - 1,
+                        },
+                    };
+                });
             }
             else if (s.kind === "edge-start") {
                 const id = s.edgeId;
-                setEdgeStatus((prev) => ({
-                    ...prev,
-                    [id]: { ...(prev[id] ?? {}), running: true },
-                }));
+                setEdgeStatus((prev) => {
+                    const current = prev[id]?.activeRuns ?? 0;
+                    return {
+                        ...prev,
+                        [id]: { ...prev[id], activeRuns: current + 1 },
+                    };
+                });
             }
             else if (s.kind === "edge-done") {
                 const id = s.edgeId;
-                setEdgeStatus((prev) => ({
-                    ...prev,
-                    [id]: { ...(prev[id] ?? {}), running: false },
-                }));
+                setEdgeStatus((prev) => {
+                    const current = prev[id]?.activeRuns ?? 0;
+                    return {
+                        ...prev,
+                        [id]: { ...prev[id], activeRuns: current - 1 },
+                    };
+                });
             }
             return add("runner", "stats")(s);
         });
@@ -1059,7 +1104,7 @@ function WorkbenchProvider({ wb, runner, registry, setRegistry, children, }) {
                 const id = change.nodeId;
                 setNodeStatus((s) => ({
                     ...s,
-                    [id]: { ...(s[id] ?? {}), invalidated: true },
+                    [id]: { ...s[id], invalidated: true },
                 }));
             }
         });
@@ -1411,7 +1456,7 @@ const DefaultNode = React.memo(function DefaultNode({ id, data, selected, isConn
     const { typeId, showValues, inputValues, outputValues, toString } = data;
     const inputEntries = data.inputHandles ?? [];
     const outputEntries = data.outputHandles ?? [];
-    const status = data.status ?? {};
+    const status = data.status ?? { activeRuns: 0 };
     const validation = data.validation ?? {
         inputs: [],
         outputs: [],
@@ -1426,7 +1471,7 @@ const DefaultNode = React.memo(function DefaultNode({ id, data, selected, isConn
     const hasError = !!status.lastError;
     const hasValidationError = validation.issues.some((i) => i.level === "error");
     const hasValidationWarning = !hasValidationError && validation.issues.length > 0;
-    const isRunning = !!status.running;
+    const isRunning = !!status.activeRuns;
     const isInvalid = !!status.invalidated && !isRunning && !hasError;
     // Border color encodes severity; thickness encodes selection; style (dashed) encodes invalidated
     const borderWidth = selected ? "border-2" : "border";