@bian-womp/spark-graph 0.1.18 → 0.1.19

package/lib/cjs/index.cjs

@@ -380,6 +380,16 @@ function isTypedOutput(v) {
         typeof v === "object" &&
         Object.prototype.hasOwnProperty.call(v, "__spark_type"));
 }
+function getInputTypeId(inputs, handle) {
+    const v = inputs ? inputs[handle] : undefined;
+    if (!v)
+        return undefined;
+    return typeof v === "string" ? v : v.typeId;
+}
+function isInputPrivate(inputs, handle) {
+    const v = inputs ? inputs[handle] : undefined;
+    return !!(v && typeof v === "object" && v.private);
+}
 
 class GraphRuntime {
     constructor() {
@@ -452,7 +462,7 @@ class GraphRuntime {
             if (dstNode) {
                 const dstDesc = registry.nodes.get(dstNode.typeId);
                 if (dstDesc) {
-                    dstDeclared = dstDesc.inputs[e.target.handle];
+                    dstDeclared = getInputTypeId(dstDesc.inputs, e.target.handle);
                 }
             }
             // Attach dynamic convert/convertAsync aware of union sources and typed outputs
@@ -1105,7 +1115,7 @@ class GraphRuntime {
             if (dstNode) {
                 const dstDesc = registry.nodes.get(dstNode.typeId);
                 if (dstDesc) {
-                    dstDeclared = dstDesc.inputs[e.target.handle];
+                    dstDeclared = getInputTypeId(dstDesc.inputs, e.target.handle);
                 }
             }
             const { convert, convertAsync } = GraphRuntime.buildEdgeConverters(srcDeclared, dstDeclared, registry);
@@ -1343,7 +1353,20 @@ class GraphBuilder {
                     });
                 }
                 if (dstType) {
-                    const declaredIn = dstType.inputs[e.target.handle];
+                    // Private inputs should not accept edges
+                    if (isInputPrivate(dstType.inputs, e.target.handle)) {
+                        issues.push({
+                            level: "error",
+                            code: "INPUT_PRIVATE",
+                            message: `Edge ${e.id} targets private input ${dstNode.typeId}.${e.target.handle}`,
+                            data: {
+                                edgeId: e.id,
+                                nodeId: dstNode.nodeId,
+                                input: e.target.handle,
+                            },
+                        });
+                    }
+                    const declaredIn = getInputTypeId(dstType.inputs, e.target.handle);
                     if (declaredIn && effectiveTypeId) {
                         // If source is a union, ensure each variant can reach declaredIn
                         if (srcNode) {
@@ -1421,7 +1444,8 @@ class GraphBuilder {
                 ? this.registry.nodes.get(innerNode.typeId)
                 : undefined;
             const typeId = innerDesc ? innerDesc.inputs[map.handle] : undefined;
-            inputTypes[outerIn] = typeId ?? "untyped";
+            inputTypes[outerIn] =
+                typeof typeId === "string" ? typeId : typeId?.typeId ?? "untyped";
         }
         for (const [outerOut, map] of Object.entries(exposure.outputs)) {
             const innerNode = def.nodes.find((n) => n.nodeId === map.nodeId);
@@ -2411,6 +2435,8 @@ exports.createSimpleGraphDef = createSimpleGraphDef;
 exports.createSimpleGraphRegistry = createSimpleGraphRegistry;
 exports.createValidationGraphDef = createValidationGraphDef;
 exports.createValidationGraphRegistry = createValidationGraphRegistry;
+exports.getInputTypeId = getInputTypeId;
+exports.isInputPrivate = isInputPrivate;
 exports.isTypedOutput = isTypedOutput;
 exports.registerDelayNode = registerDelayNode;
 exports.registerProgressNodes = registerProgressNodes;