@beyondwork/docx-react-component 1.0.87 → 1.0.89

package/src/ui-tailwind/tw-review-workspace.tsx

@@ -68,6 +68,11 @@ import { useLayoutFacetRenderSignal } from "./review-workspace/use-layout-facet-
 import { useScrollRootCapture } from "./review-workspace/use-scroll-root-capture.ts";
 import { usePmSurfaceCapture } from "./review-workspace/use-pm-surface-capture.ts";
 import { TwReviewWorkspaceNavigator } from "./review-workspace/tw-review-workspace-navigator.tsx";
+import {
+  createDefaultWorkflowScopeLayerKeys,
+  workflowScopePosturesForLayerKeys,
+  type WorkflowScopeLayerKey,
+} from "./workflow-scope-layers";
 
 export {
   FRAME_PX_PER_TWIP_AT_96DPI,
@@ -174,6 +179,13 @@ export function TwReviewWorkspace(inputProps: TwReviewWorkspaceProps) {
     useRef<TwWorkspaceChromeHostController | null>(null);
   const [shellModeOverride, setShellModeOverride] =
     useState<ShellHeaderMode | null>(null);
+  const [workflowLayerFilters, setWorkflowLayerFilters] = useState<
+    ReadonlySet<WorkflowScopeLayerKey>
+  >(createDefaultWorkflowScopeLayerKeys);
+  const visibleScopePostures = useMemo(
+    () => workflowScopePosturesForLayerKeys(workflowLayerFilters),
+    [workflowLayerFilters],
+  );
   // P8.11 — body slot wrapping `{props.document}` (the PM surface) + scroll
   // root ref.  The chrome layer's `TwPageStackChromeLayer` needs both to
   // measure per-page rects and to reparent PM's DOM node across band
@@ -533,12 +545,10 @@ export function TwReviewWorkspace(inputProps: TwReviewWorkspaceProps) {
         )
         : null;
 
-  // Audit §2.5 — context band mounts as a composition-level sibling of
-  // the toolbar so the workspace row becomes
-  //   [toolbar left cluster] · [context band] · [toolbar right cluster]
-  // and the band can render mode-owned content (Phase B.3 additive mount;
-  // Phase D migrates role-action contents into the band and retires the
-  // legacy inline role region inside TwToolbar).
+  // Audit §2.5 — context band mounts as a composition-level sibling below
+  // the shell header only when the active mode has meaningful mode-owned
+  // content. Plain editor mode keeps its authoring controls in the toolbar
+  // and intentionally does not render an empty "Edit" ribbon.
   //
   // `resolveChromeComposition` is pure but each call allocates new Sets +
   // arrays.  `TwReviewWorkspace` re-renders on every PM transaction (the
@@ -573,6 +583,9 @@ export function TwReviewWorkspace(inputProps: TwReviewWorkspaceProps) {
     modeOverride: shellModeOverride === "more" ? "more" : undefined,
   });
   const showHealthRailTab = composition.rail.visibleTabs.has("health");
+  const showContextBand =
+    chromeVisibility.toolbar &&
+    (composition.mode === "more" || viewState.editorRole !== "editor");
 
   const arbiter = useWorkspaceArbiter();
 
@@ -591,18 +604,12 @@ export function TwReviewWorkspace(inputProps: TwReviewWorkspaceProps) {
          * decoupling this branch.
          */}
         {/*
-         * Chrome Closure Pass · Task 1 (designsystem.md §6.3) — the
-         * role-action region used to render inline in the toolbar's
-         * center subregion. It now lives inside `TwContextBand` so the
-         * workspace row reads
-         *   [shell header] · [TwContextBand carrying role actions] · [TwToolbar (formatting only)]
-         * matching §8.8.1's "Workspace context row / mode-owned band"
-         * row. Callbacks below mirror what was previously threaded
-         * through `ChromePresetToolbar` to `TwRoleActionRegion`; the
-         * toolbar still receives `role` for `isChromeItemOwnedByRoleRegion`
-         * deferral but no longer renders the region itself.
+         * Chrome Closure Pass · Task 1 (designsystem.md §6.3) — review,
+         * workflow, and More mode actions live in `TwContextBand`; editor
+         * mode stays toolbar-only unless a future pass adds real contextual
+         * authoring content.
          */}
-        {chromeVisibility.toolbar ? (
+        {showContextBand ? (
           <TwContextBand mode={composition.mode}>
             {composition.mode === "more" ? (
               <TwMoreContextBandContent
@@ -615,7 +622,7 @@ export function TwReviewWorkspace(inputProps: TwReviewWorkspaceProps) {
                   props.onActiveRailTabChange?.("health");
                 }}
                 onOpenOutline={() => setNavOpen(true)}
-                onOpenSearch={props.reviewRailFooter?.onSearch}
+                onOpenSearch={props.onOpenInlineFind ?? props.reviewRailFooter?.onSearch}
               />
             ) : viewState.editorRole ? (
               <TwRoleActionRegion
@@ -1167,6 +1174,7 @@ export function TwReviewWorkspace(inputProps: TwReviewWorkspaceProps) {
                             onSetColumnWidth={props.onSetColumnWidth}
                             onSetRowHeight={props.onSetRowHeight}
                             activeScopeId={activeScopeId}
+                            visibleScopePostures={visibleScopePostures}
                             editorRole={viewState.editorRole}
                             scopeCardScopeTagEditor={props.scopeCardScopeTagEditor}
                             onScopeStripeClick={handleScopeStripeClick}
@@ -1273,6 +1281,8 @@ export function TwReviewWorkspace(inputProps: TwReviewWorkspaceProps) {
               // `getAllScopeRailSegments` (methods removed in v40 / Slice 4C).
               scopeRailSegments: props.workflowFacet?.getAllRailSegments() ?? [],
               activeScopeId,
+              workflowLayerFilters,
+              onWorkflowLayerFiltersChange: setWorkflowLayerFilters,
               onOpenScope: (segment) => {
                 handleScopeStripeClick({ scopeId: segment.scopeId });
               },

package/src/ui-tailwind/workflow-scope-layers.ts

@@ -0,0 +1,70 @@
+import type { ScopeRailPosture } from "../api/public-types";
+
+export type WorkflowScopeLayerKey =
+  | "edit"
+  | "suggest"
+  | "comment"
+  | "view"
+  | "candidate"
+  | "blocked";
+
+export interface WorkflowScopeLayerFilter {
+  key: WorkflowScopeLayerKey;
+  label: string;
+  postures: readonly ScopeRailPosture[];
+}
+
+export const WORKFLOW_SCOPE_LAYER_FILTERS: readonly WorkflowScopeLayerFilter[] = [
+  { key: "edit", label: "Edit", postures: ["edit"] },
+  { key: "suggest", label: "Suggest", postures: ["suggest"] },
+  { key: "comment", label: "Comment", postures: ["comment"] },
+  { key: "view", label: "Review", postures: ["view"] },
+  { key: "candidate", label: "Scheduled", postures: ["candidate"] },
+  { key: "blocked", label: "Blocked", postures: ["preserve-only", "blocked-import"] },
+];
+
+export function createDefaultWorkflowScopeLayerKeys(): ReadonlySet<WorkflowScopeLayerKey> {
+  return new Set(WORKFLOW_SCOPE_LAYER_FILTERS.map((filter) => filter.key));
+}
+
+export function workflowScopeLayerKeyForPosture(
+  posture: ScopeRailPosture,
+): WorkflowScopeLayerKey {
+  if (posture === "preserve-only" || posture === "blocked-import") {
+    return "blocked";
+  }
+  return posture;
+}
+
+export function isWorkflowScopePostureVisible(
+  posture: ScopeRailPosture,
+  enabledLayers: ReadonlySet<WorkflowScopeLayerKey>,
+): boolean {
+  return enabledLayers.has(workflowScopeLayerKeyForPosture(posture));
+}
+
+export function workflowScopePosturesForLayerKeys(
+  enabledLayers: ReadonlySet<WorkflowScopeLayerKey>,
+): ReadonlySet<ScopeRailPosture> {
+  const postures = new Set<ScopeRailPosture>();
+  for (const filter of WORKFLOW_SCOPE_LAYER_FILTERS) {
+    if (!enabledLayers.has(filter.key)) continue;
+    for (const posture of filter.postures) {
+      postures.add(posture);
+    }
+  }
+  return postures;
+}
+
+export function toggleWorkflowScopeLayerKey(
+  current: ReadonlySet<WorkflowScopeLayerKey>,
+  key: WorkflowScopeLayerKey,
+): ReadonlySet<WorkflowScopeLayerKey> {
+  const next = new Set(current);
+  if (next.has(key)) {
+    next.delete(key);
+  } else {
+    next.add(key);
+  }
+  return next;
+}