@beyondwork/docx-react-component 1.0.36 → 1.0.38

package/src/ui/WordReviewEditor.tsx

@@ -48,6 +48,8 @@ import type {
   StyleCatalogSnapshot,
   SurfaceBlockSnapshot,
   SurfaceInlineSegment,
+  TableOp,
+  TableOpResult,
   TrackedChangeEntrySnapshot,
   TocRefreshResult,
   UpdateFieldsResult,
@@ -113,6 +115,7 @@ import {
 import {
   applyTableStructureOperation,
   getTableStructureContext,
+  type TableStructureOperation,
 } from "../core/commands/table-structure-commands.ts";
 import {
   deleteSelectionOrBackward,
@@ -165,6 +168,7 @@ import {
   useRuntimeValue,
 } from "./runtime-snapshot-selectors.ts";
 import type { MarkupDisplay } from "./headless/comment-decoration-model";
+import { resolveScopedChromePolicy } from "./headless/scoped-chrome-policy";
 import type {
   SelectionToolbarAnchor,
   SelectionToolbarModel,
@@ -577,6 +581,8 @@ export function __createWordReviewEditorRefBridge(
     getRuntimeContextAnalytics: (query) => {
       return clonePublicValue(runtime.getRuntimeContextAnalytics(query));
     },
+    layout: runtime.layout,
+    tables: buildTablesFacet(runtime, mountedSurface ?? null),
     goToNextReviewItem: () => {
       return clonePublicValue(navigateReviewQueue(runtime, "next"));
     },
@@ -1391,6 +1397,8 @@ export const WordReviewEditor = forwardRef<WordReviewEditorRef, WordReviewEditor
         getRuntimeContextAnalytics: (query) => {
           return clonePublicValue(activeRuntime.getRuntimeContextAnalytics(query));
         },
+        layout: activeRuntime.layout,
+        tables: buildTablesFacet(activeRuntime, surfaceRef.current ?? null),
         goToNextReviewItem: () => {
           return clonePublicValue(navigateMountedReviewQueue("next"));
         },
@@ -1670,6 +1678,14 @@ export const WordReviewEditor = forwardRef<WordReviewEditorRef, WordReviewEditor
       snapshot.comments.activeCommentId
         ? snapshot.comments.threads.find((thread) => thread.commentId === snapshot.comments.activeCommentId)
         : undefined;
+    const scopedChromePolicy = resolveScopedChromePolicy({
+      preset: effectiveChromePreset,
+      compactMode: false,
+      capabilities,
+      interactionGuardSnapshot,
+      workflowScopeSnapshot,
+      activeListContext: viewState.activeListContext,
+    });
     const selectionToolbar = buildSelectionToolbarModel({
       snapshot,
       viewState,
@@ -1736,6 +1752,7 @@ export const WordReviewEditor = forwardRef<WordReviewEditorRef, WordReviewEditor
       preferListStructureContext: viewState.workspaceMode === "page",
       addCommentDisabledReason,
       suppressedSuggestionRevisionId,
+      scopedChromePolicy,
     });
     const selectionToolbarSelectionKey = useMemo(
       () =>
@@ -2241,6 +2258,9 @@ export const WordReviewEditor = forwardRef<WordReviewEditorRef, WordReviewEditor
         workflowMetadata={workflowMarkupSnapshot?.metadata}
         onSelectionToolbarAnchorChange={handleSelectionToolbarAnchorChange}
         {...editorCallbacks}
+        dispatchRuntimeCommand={(command) =>
+          activeRuntime.applyActiveStoryTextCommand(command as never)
+        }
         onCommentActivated={(commentId) => {
           activeRuntime.openComment(commentId);
           setActiveRailTab("comments");
@@ -2285,6 +2305,7 @@ export const WordReviewEditor = forwardRef<WordReviewEditorRef, WordReviewEditor
         activeRevisionId={activeRevisionId}
         showTrackedChanges={showTrackedChanges}
         workflowScopeSnapshot={workflowScopeSnapshot}
+        layoutFacet={activeRuntime.layout}
         interactionGuardSnapshot={interactionGuardSnapshot}
         chromePreset={effectiveChromePreset}
         chromeOptions={chromeOptions}
@@ -3373,28 +3394,19 @@ function applyRuntimeImageReposition(
 function applyRuntimeTableStructureOperation(
   runtime: WordReviewEditorRuntime,
   mountedSurface: TwProseMirrorSurfaceRef | null | undefined,
-  operation:
-    | { type: "add-row-before" }
-    | { type: "add-row-after" }
-    | { type: "add-column-before" }
-    | { type: "add-column-after" }
-    | { type: "delete-row" }
-    | { type: "delete-column" }
-    | { type: "delete-table" }
-    | { type: "merge-cells" }
-    | { type: "split-cell" }
-    | { type: "set-cell-background"; color: string },
-): void {
+  operation: TableStructureOperation,
+): { changed: boolean; coercedReason: string | null } {
   if (isSelectionSuggesting(runtime)) {
+    const coercedReason = `Table operation "${operation.type}" is not supported in suggesting mode.`;
     runtime.emitBlockedCommand(`table.${operation.type}`, [{
       code: "unsupported_surface",
-      message: `Table operation "${operation.type}" is not supported in suggesting mode.`,
+      message: coercedReason,
     }]);
-    return;
+    return { changed: false, coercedReason };
   }
   const context = getStoryMutationContext(runtime, `table.${operation.type}`);
   if (!context) {
-    return;
+    return { changed: false, coercedReason: "No active mutation context." };
   }
 
   const result = applyTableStructureOperation(
@@ -3404,6 +3416,78 @@ function applyRuntimeTableStructureOperation(
     operation,
   );
   dispatchStoryMutationResult(runtime, context, result, context.timestamp);
+  return {
+    changed: result.changed,
+    coercedReason: result.changed ? null : "Op was a no-op against the active selection.",
+  };
+}
+
+/**
+ * Translate a public-API `TableOp` (kebab-case `kind` discriminator) to
+ * the internal `TableStructureOperation` (`type` discriminator). The
+ * shape values are identical aside from the discriminator name.
+ */
+export function __publicTableOpToInternal(op: TableOp): TableStructureOperation {
+  return publicTableOpToInternal(op);
+}
+
+function publicTableOpToInternal(op: TableOp): TableStructureOperation {
+  const { kind, ...rest } = op as { kind: string } & Record<string, unknown>;
+  if (kind === "insert") {
+    throw new Error(
+      "TableOp kind \"insert\" is not routed through ref.tables.apply; use ref.insertTable(...).",
+    );
+  }
+  return { type: kind, ...rest } as TableStructureOperation;
+}
+
+/**
+ * Build the `ref.tables` facet: a typed dispatch boundary + capability
+ * read. Delegates every op through the same `applyRuntimeTableStructureOperation`
+ * helper the flat ref verbs use, so there is exactly one server-side path
+ * for every table mutation.
+ */
+function buildTablesFacet(
+  runtime: WordReviewEditorRuntime,
+  mountedSurface: TwProseMirrorSurfaceRef | null,
+) {
+  const getCapabilities = () => {
+    const snapshot = runtime.getRenderSnapshot();
+    const document = runtime.getSessionState().canonicalDocument;
+    return (
+      clonePublicValue(
+        getTableStructureContext(
+          document,
+          snapshot,
+          mountedSurface?.getTableSelection() ?? null,
+        ),
+      ) ?? null
+    );
+  };
+  return {
+    apply(op: TableOp): TableOpResult {
+      if (op.kind === "insert") {
+        applyRuntimeInsertTable(runtime, { rows: op.rows, columns: op.columns });
+        return {
+          changed: true,
+          coercedReason: null,
+          capabilities: getCapabilities(),
+        };
+      }
+      const internal = publicTableOpToInternal(op);
+      const outcome = applyRuntimeTableStructureOperation(
+        runtime,
+        mountedSurface,
+        internal,
+      );
+      return {
+        changed: outcome.changed,
+        coercedReason: outcome.coercedReason,
+        capabilities: getCapabilities(),
+      };
+    },
+    getCapabilities,
+  };
 }
 
 function applyRuntimeTextCommand(

package/src/ui/editor-runtime-boundary.ts

@@ -34,6 +34,7 @@ import {
   type DocumentRuntimeEvent,
   type DocumentRuntime,
 } from "../runtime/document-runtime.ts";
+import { createInertLayoutFacet } from "../runtime/layout/index.ts";
 import { loadDocxEditorSession } from "../io/docx-session.ts";
 import {
   decodePersistedSourcePackageBytes,
@@ -738,6 +739,7 @@ function createLoadingRuntimeBridge(input: {
   viewState: EditorViewStateSnapshot;
   navigation: DocumentNavigationSnapshot;
 }): WordReviewEditorRuntime {
+  const inertLayoutFacet = createInertLayoutFacet();
   const emptyFieldSnapshot: FieldSnapshot = {
     totalCount: 0,
     supportedCount: 0,
@@ -772,7 +774,13 @@ function createLoadingRuntimeBridge(input: {
     getCanonicalDocument: () => input.sessionState.canonicalDocument,
     getSourcePackage: () => input.sessionState.sourcePackage,
     replaceText: () => undefined,
-    applyActiveStoryTextCommand: () => undefined,
+    applyActiveStoryTextCommand: () => ({
+      kind: "rejected",
+      newRevisionToken: "",
+      blockedReasons: [
+        { code: "runtime_loading", message: "Document runtime is not ready yet." },
+      ],
+    }),
     dispatch: () => undefined,
     undo: () => undefined,
     redo: () => undefined,
@@ -801,6 +809,7 @@ function createLoadingRuntimeBridge(input: {
     setZoom: () => undefined,
     getPageLayoutSnapshot: () => null,
     getDocumentNavigationSnapshot: () => input.navigation,
+    layout: inertLayoutFacet,
     getCurrentLocation: () => null,
     getLocationForSelection: () => null,
     getLocationForAnchor: () => null,

package/src/ui/editor-shell-view.tsx

@@ -55,6 +55,12 @@ export interface EditorShellViewProps {
   activeRevisionId?: string;
   showTrackedChanges: boolean;
   workflowScopeSnapshot?: WorkflowScopeSnapshot | null;
+  /**
+   * Runtime-owned layout facet passed through to the workspace so the
+   * ChromeOverlay (scope rail, workflow dock, etc.) can render over the
+   * document column and the review rail's Workflow tab can read segments.
+   */
+  layoutFacet?: import("../runtime/layout/index.ts").WordReviewEditorLayoutFacet;
   interactionGuardSnapshot?: InteractionGuardSnapshot;
   chromePreset?: WordReviewEditorChromePreset;
   chromeOptions?: Partial<WordReviewEditorChromeOptions>;

package/src/ui/editor-surface-controller.tsx

@@ -60,6 +60,9 @@ export interface EditorSurfaceControllerProps {
   activeWorkflowWorkItemId?: string | null;
   activeWorkflowScopeIds?: readonly string[];
   workflowMetadata?: readonly WorkflowMetadataMarkup[];
+  dispatchRuntimeCommand?: (
+    command: import("../ui-tailwind/editor-surface/fast-text-edit-lane.ts").LaneRuntimeCommand,
+  ) => import("../api/public-types.ts").TextCommandAck;
 }
 
 export const EditorSurfaceController = forwardRef<