@bevel-software/platform-shared 0.32.0 → 0.34.0

package/src/workflow/events.ts

@@ -101,6 +101,24 @@ export interface FsTreeChangedEvent {
   branch: string;
 }
 
+/**
+ * A document's text could not be extracted, just now: the parser refused it,
+ * or the extraction outlived its budget. Emitted once per FRESH failure —
+ * never for one answered from memory — so a person looking at the file's row
+ * in the explorer is told in place, and nothing is kept for later.
+ *
+ * `reason` follows "Could not be read:" in the explorer's notice. It names the
+ * file and quotes the parser; like every kind that names a path on a
+ * workspace, it is delivered only to sessions whose person may read `path`
+ * (the events route's delivery rule, judged by the access rules).
+ */
+export interface DocumentUnreadableEvent {
+  kind: 'document-unreadable';
+  workspaceId: string;
+  path: string;
+  reason: string;
+}
+
 /**
  * A commit landed locally but could not be pushed to the remote.
  *
@@ -201,6 +219,12 @@ export interface AgentToolCallEvent {
 
 // ── Global ───────────────────────────────────────────────────────────────────
 
+/**
+ * A change request was opened. Reaches EVERY session, so it says only that a
+ * request exists: its number, its branches and who opened it — no title and
+ * no paths, which a person may not be allowed to read. A reader fetches the
+ * request, and sees of it what the request routes show them.
+ */
 export interface ChangeRequestOpenedEvent {
   kind: 'change-request-opened';
   number: number;
@@ -208,7 +232,6 @@ export interface ChangeRequestOpenedEvent {
   target: string;
   /** Hash of the author's email (matches the marker in the CR body); null when unattributable. */
   authorIdHash: string | null;
-  title: string;
 }
 
 export interface ChangeRequestMergedEvent {
@@ -221,6 +244,16 @@ export interface ChangeRequestRejectedEvent {
   number: number;
 }
 
+/**
+ * A request's title or description was edited. Carries no text: every
+ * viewer re-reads the request through the list and detail endpoints it
+ * already uses, which apply its own read rules.
+ */
+export interface ChangeRequestEditedEvent {
+  kind: 'change-request-edited';
+  number: number;
+}
+
 /**
  * An apply did NOT land, announced to EVERY session — the counterpart of the
  * user-scoped `change-request-merge-failed` below, which only the clicker gets.
@@ -282,7 +315,14 @@ export interface ChangeRequestMergeFailedEvent {
 export interface ApprovalChangedEvent {
   kind: 'approval-changed';
   number: number;
+  /** The approved file, KB-repo-relative. */
   path: string;
+  /**
+   * The request's target branch: the event names a path, and whether a
+   * session's person may hear of it is judged by their read access to that
+   * path at the target — the same rule the request's own detail is scoped by.
+   */
+  targetBranch: string;
   approverUserId: string;
   change: 'added' | 'removed';
 }
@@ -341,6 +381,7 @@ export type WorkflowEventPayload =
   | LockAcquiredEvent
   | LockReleasedEvent
   | FsTreeChangedEvent
+  | DocumentUnreadableEvent
   | GitSyncFailedEvent
   | GitSyncRecoveredEvent
   | BranchSwitchedEvent
@@ -349,6 +390,7 @@ export type WorkflowEventPayload =
   | ChangeRequestOpenedEvent
   | ChangeRequestMergedEvent
   | ChangeRequestRejectedEvent
+  | ChangeRequestEditedEvent
   | ChangeRequestMergeFailedEvent
   | ChangeRequestApplyFailedEvent
   | ApprovalChangedEvent
@@ -366,6 +408,7 @@ export function isWorkspaceScoped(
     e.kind === 'lock-acquired' ||
     e.kind === 'lock-released' ||
     e.kind === 'fs-tree-changed' ||
+    e.kind === 'document-unreadable' ||
     e.kind === 'git-sync-failed' ||
     e.kind === 'git-sync-recovered'
   );

package/src/workflow/interface.ts

@@ -18,7 +18,7 @@
  */
 
 import type { AuthUser } from '../auth/types.js';
-import type { ChangeRequestApplyFailureKind } from '../git/pr.types.js';
+import type { ChangeRequestApplyFailureKind, UpdateChangeRequestFields } from '../git/pr.types.js';
 import type {
   AcquireLockResult,
   Branch,
@@ -28,7 +28,6 @@ import type {
   Change,
   ChangeInput,
   ChangeRequest,
-  ChangeRequestComment,
   ChangeRequestDetail,
   ChangeRequestUpdateResult,
   ChangeRequestState,
@@ -42,10 +41,9 @@ import type {
   MergeBranchOutcome,
   MergeChangeRequestOutcome,
   OpenChangeRequestInput,
-  PostChangeRequestCommentInput,
   UpdateBranchOutcome,
 } from './types.js';
-import type { MergeResolution } from '../git/types.js';
+import type { BranchCounts, MergeResolution } from '../git/types.js';
 
 export interface IWorkflowService {
   // ── Branches ──────────────────────────────────────────────────────────────
@@ -111,6 +109,12 @@ export interface IWorkflowService {
   // `createBranch` + URL navigation covers the "start a new draft" intent.
   /** Current branch's workspace status — currently just the branch name + upstream sync state. */
   branchStatus(workspaceId: string): Promise<BranchWorkspaceStatus>;
+  /**
+   * Commits the workspace's own branch is ahead of and behind its upstream
+   * (or, with none, the nearest protected branch); null when neither
+   * resolves. Counted for this one branch: a branch listing carries no counts.
+   */
+  branchCounts(workspaceId: string): Promise<BranchCounts>;
   // `discardWorkingChanges` removed: under save=share the working tree is
   // never dirty, so there is nothing for "undo my unsaved edits" to undo.
   /**
@@ -554,17 +558,6 @@ export interface IWorkflowService {
     number: number,
   ): Promise<ChangeRequestUpdateResult>;
 
-  // Comments
-  listComments(number: number): Promise<ChangeRequestComment[]>;
-  postComment(
-    number: number,
-    user: AuthUser,
-    input: PostChangeRequestCommentInput,
-    headSha: string,
-  ): Promise<ChangeRequestComment>;
-  editComment(commentId: string, number: number, user: AuthUser, body: string): Promise<ChangeRequestComment>;
-  deleteComment(commentId: string, number: number, user: AuthUser): Promise<void>;
-
   // Approvals — per-file, tied to the file's current change. New changes
   // invalidate approvals on the affected file.
   approveFile(
@@ -644,6 +637,18 @@ export interface IWorkflowService {
    */
   deleteChangeRequest(number: number, user: AuthUser): Promise<void>;
 
+  /**
+   * Change an OPEN request's title and/or description. Its author, an admin,
+   * or the holder of write on every changed file — the people who may close
+   * it; anyone else gets a worded 403, and a merged or closed request a
+   * worded 409.
+   */
+  updateChangeRequest(
+    number: number,
+    user: AuthUser,
+    input: UpdateChangeRequestFields,
+  ): Promise<ChangeRequest>;
+
   /**
    * Reject a change request without merging. Authorized for the author or
    * for users with write permission to every changed file on the target

package/src/workflow/types.ts

@@ -22,14 +22,13 @@ import type {
   WorkingTreeStatus,
 } from '../git/types.js';
 import type {
+  AccessRequestLevel,
   CancelPrResult,
   FileApprovalState,
   MergePrResult,
   PullRequestDetail,
   PullRequestState,
   PullRequestSummary,
-  PostPrCommentInput,
-  PrReviewComment,
   PullRequestFile,
 } from '../git/pr.types.js';
 
@@ -147,8 +146,6 @@ export type ChangedFile = PullRequestFile;
 export type FileApproval = FileApprovalState;
 export type MergeChangeRequestResult = MergePrResult;
 export type CancelChangeRequestResult = CancelPrResult;
-export type ChangeRequestComment = PrReviewComment;
-export type PostChangeRequestCommentInput = PostPrCommentInput;
 
 /**
  * One open change request proposing files under a folder, as a folder delete
@@ -189,16 +186,23 @@ export interface FolderChangeRequestRemoval {
  * `targetBranch` into `sourceBranch` as part of opening, so callers don't
  * pass a head SHA — the workflow resolves the head itself.
  *
- * `title` + `description` are the change request's metadata; the description
- * is plain text (no GitHub-flavoured markdown affordances exposed at this
- * layer). The implementation may still render this as the PR body when the
- * underlying GitHub PR is created.
+ * `title` + `description` are the change request's metadata. The description
+ * is stored exactly as given and IS the request's body: Hexis appends nothing
+ * of its own to it.
  */
 export interface OpenChangeRequestInput {
   sourceBranch: string;
   targetBranch: string;
   title: string;
   description?: string;
+  /**
+   * The access-request flow's own facts about the request it opens: the level
+   * asked for and the person's note, kept on the request's row rather than in
+   * its prose. Only that flow sets it — the open route and the agent's
+   * `open_change_request` build their input field by field and never forward
+   * it.
+   */
+  accessRequest?: { level: AccessRequestLevel; note?: string };
 }
 
 /**

package/src/workspace/kb-layout.ts

@@ -531,9 +531,18 @@ export function withLinkedSkillRoots(
   return out;
 }
 
+/**
+ * Whether the repo-relative `path` is `root` itself or lies in the subtree
+ * `root` names — the one containment test for KB paths named by a list of
+ * roots (a plugin's linked skills, an agent configuration's entries).
+ */
+export function pathUnderRoot(path: string, root: string): boolean {
+  return path === root || path.startsWith(`${root}/`);
+}
+
 /** Whether `skillPath` (a skill folder) falls under `root` (a skill folder or a folder of skills). */
 export function skillUnderRoot(skillPath: string, root: string): boolean {
-  return skillPath === root || skillPath.startsWith(`${root}/`);
+  return pathUnderRoot(skillPath, root);
 }
 
 /**