@bevel-software/platform-core-frontend 0.26.0 → 0.28.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (206) hide show
  1. package/package.json +2 -2
  2. package/src/core/CoreAppShell.tsx +87 -25
  3. package/src/core/ProductName.tsx +49 -0
  4. package/src/core/__tests__/ProductName.test.tsx +46 -0
  5. package/src/core/__tests__/ShellRoutes.test.tsx +22 -0
  6. package/src/core/__tests__/core-contributions.test.ts +16 -0
  7. package/src/core/core-contributions.ts +17 -0
  8. package/src/core/maker-url.ts +30 -0
  9. package/src/core/registry.ts +78 -1
  10. package/src/index.css +23 -5
  11. package/src/index.ts +5 -0
  12. package/src/lib/__tests__/latest-request.test.ts +48 -0
  13. package/src/lib/latest-request.ts +45 -0
  14. package/src/modules/access/__tests__/ManageAccessDialog.no-sso-invite.test.tsx +222 -0
  15. package/src/modules/access/__tests__/ManageAccessDialog.proposal.test.tsx +1 -1
  16. package/src/modules/access/api.ts +19 -3
  17. package/src/modules/access/components/ManageAccessDialog.tsx +61 -8
  18. package/src/modules/admin/__tests__/AdminRolesPage.fixed-admin.test.tsx +16 -1
  19. package/src/modules/admin/__tests__/RolesCorruptedBanner.test.tsx +70 -0
  20. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +284 -39
  21. package/src/modules/admin/components/AdminRolesPage.tsx +13 -14
  22. package/src/modules/admin/components/RolesCorruptedBanner.tsx +9 -4
  23. package/src/modules/admin/components/UserAccountsPage.tsx +91 -107
  24. package/src/modules/admin/services/roles.api.ts +14 -1
  25. package/src/modules/auth/__tests__/LoginScreen.test.tsx +80 -5
  26. package/src/modules/auth/__tests__/sso-strict-probe.test.ts +66 -0
  27. package/src/modules/auth/components/LoginScreen.tsx +101 -73
  28. package/src/modules/auth/services/account.api.ts +59 -3
  29. package/src/modules/auth/services/sso.ts +30 -10
  30. package/src/modules/auth/state/use-sign-in-methods.ts +41 -0
  31. package/src/modules/change-requests/__tests__/ChangeRequestDialog.sync-banner.test.tsx +176 -0
  32. package/src/modules/change-requests/__tests__/ChangeRequestDialog.unreadable.test.tsx +68 -0
  33. package/src/modules/change-requests/__tests__/ChangeRequestLink.test.tsx +182 -0
  34. package/src/modules/change-requests/__tests__/FileChangeBoxes.test.tsx +1 -1
  35. package/src/modules/change-requests/__tests__/readFileOnBranch.test.ts +79 -0
  36. package/src/modules/change-requests/components/ChangeBox.tsx +6 -1
  37. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +45 -15
  38. package/src/modules/change-requests/components/ChangeRequestLink.tsx +151 -0
  39. package/src/modules/change-requests/components/CrFileTree.tsx +2 -1
  40. package/src/modules/change-requests/components/FileChangeBoxes.tsx +4 -2
  41. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +6 -3
  42. package/src/modules/change-requests/services/change-requests.api.ts +15 -2
  43. package/src/modules/change-requests/utils/readFailure.ts +22 -0
  44. package/src/modules/embed/__tests__/EmbedLinkPage.test.tsx +74 -0
  45. package/src/modules/embed/__tests__/EmbedView.test.tsx +473 -0
  46. package/src/modules/embed/__tests__/embed-config.test.ts +128 -0
  47. package/src/modules/embed/__tests__/embed-host.test.ts +111 -0
  48. package/src/modules/embed/__tests__/mcp-app-view.test.ts +295 -0
  49. package/src/modules/embed/__tests__/mount.test.tsx +157 -0
  50. package/src/modules/embed/components/EmbedLinkPage.tsx +109 -0
  51. package/src/modules/embed/components/EmbedView.tsx +545 -0
  52. package/src/modules/embed/embed-config.ts +132 -0
  53. package/src/modules/embed/embed-host.ts +120 -0
  54. package/src/modules/embed/mount.tsx +80 -0
  55. package/src/modules/embed/services/embed-token.ts +22 -0
  56. package/src/modules/embed/services/embed.api.ts +158 -0
  57. package/src/modules/git/__tests__/BranchSwitcher.test.tsx +202 -4
  58. package/src/modules/git/__tests__/GitSyncFailedBanner.test.tsx +59 -1
  59. package/src/modules/git/__tests__/PullNeededBanner.test.tsx +39 -22
  60. package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +7 -2
  61. package/src/modules/git/branch-delete-menu-item.tsx +24 -0
  62. package/src/modules/git/components/BranchSwitcher.tsx +29 -5
  63. package/src/modules/git/components/GitSyncFailedBanner.tsx +53 -15
  64. package/src/modules/git/components/HistoryVersionPreview.tsx +5 -3
  65. package/src/modules/git/components/PullNeededBanner.tsx +15 -49
  66. package/src/modules/git/hooks/useAutoPullUpdates.ts +9 -5
  67. package/src/modules/git/index.ts +15 -0
  68. package/src/modules/git/services/__tests__/error-messages.test.ts +67 -0
  69. package/src/modules/git/services/__tests__/pull-failure.test.ts +36 -0
  70. package/src/modules/git/services/error-messages.ts +58 -1
  71. package/src/modules/git/services/pull-failure.ts +68 -0
  72. package/src/modules/git/state/branch-delete-confirm.ts +46 -0
  73. package/src/modules/layout/__tests__/HeaderAlignment.test.tsx +1 -0
  74. package/src/modules/layout/__tests__/breakpoints.test.ts +7 -1
  75. package/src/modules/layout/breakpoints.ts +8 -0
  76. package/src/modules/library/__tests__/PluginExtras.test.tsx +9 -9
  77. package/src/modules/library/__tests__/PluginPage.test.tsx +8 -1
  78. package/src/modules/library/__tests__/SkillsTree.test.tsx +13 -4
  79. package/src/modules/library/components/LibraryPage.tsx +22 -0
  80. package/src/modules/library/components/PluginExtras.tsx +23 -6
  81. package/src/modules/library/components/PluginPage.tsx +6 -1
  82. package/src/modules/library/routes/LibraryRoutes.tsx +8 -7
  83. package/src/modules/library/services/plugins.api.ts +4 -1
  84. package/src/modules/library/state/plugins-revision.ts +28 -0
  85. package/src/modules/onboarding/__tests__/InviteButton.test.tsx +214 -0
  86. package/src/modules/onboarding/__tests__/agent-connection-api.test.ts +55 -0
  87. package/src/modules/onboarding/__tests__/creator-welcome.test.tsx +87 -82
  88. package/src/modules/onboarding/__tests__/first-page-prompt.test.ts +164 -0
  89. package/src/modules/onboarding/__tests__/get-started-column.test.tsx +1458 -0
  90. package/src/modules/onboarding/__tests__/invite-dialog.test.tsx +811 -0
  91. package/src/modules/onboarding/__tests__/invite-emails.test.ts +247 -0
  92. package/src/modules/onboarding/__tests__/onboarding.test.tsx +226 -193
  93. package/src/modules/onboarding/__tests__/starter-pack-card.test.tsx +136 -0
  94. package/src/modules/onboarding/components/CreatorWelcomePage.tsx +7 -11
  95. package/src/modules/onboarding/components/EmailChipsInput.tsx +138 -0
  96. package/src/modules/onboarding/components/GetStartedColumn.tsx +670 -0
  97. package/src/modules/onboarding/components/InviteButton.tsx +139 -0
  98. package/src/modules/onboarding/components/InviteDialog.tsx +741 -0
  99. package/src/modules/onboarding/components/RootLanding.tsx +8 -24
  100. package/src/modules/onboarding/components/StarterPackCard.tsx +98 -0
  101. package/src/modules/onboarding/components/WelcomePage.tsx +65 -154
  102. package/src/modules/onboarding/first-page-prompt.ts +123 -0
  103. package/src/modules/onboarding/invite-emails.ts +313 -0
  104. package/src/modules/onboarding/services/agent-connection.api.ts +53 -0
  105. package/src/modules/onboarding/services/starter-packs.api.ts +83 -0
  106. package/src/modules/onboarding/state/agent-connection.ts +167 -0
  107. package/src/modules/onboarding/state/invite-dialog.context.ts +35 -0
  108. package/src/modules/onboarding/state/invite-dialog.tsx +39 -0
  109. package/src/modules/onboarding/state/onboarding.ts +133 -59
  110. package/src/modules/onboarding/state/starter-packs.ts +169 -0
  111. package/src/modules/settings/settings-nav-items.tsx +8 -3
  112. package/src/modules/setup/__tests__/setup.first-run-storage.test.tsx +389 -0
  113. package/src/modules/setup/__tests__/setup.github.test.tsx +5 -5
  114. package/src/modules/setup/__tests__/setup.kept-draft.test.tsx +1 -1
  115. package/src/modules/setup/__tests__/setup.repository-change.test.tsx +1 -1
  116. package/src/modules/setup/__tests__/setup.repository.test.tsx +21 -21
  117. package/src/modules/setup/__tests__/setup.test.tsx +56 -15
  118. package/src/modules/setup/__tests__/useConnectionProbe.test.tsx +123 -0
  119. package/src/modules/setup/components/FirstRunStorage.tsx +560 -0
  120. package/src/modules/setup/components/SetupGate.tsx +46 -1
  121. package/src/modules/setup/components/SetupScreen.tsx +81 -84
  122. package/src/modules/setup/hooks/useConnectionProbe.ts +93 -0
  123. package/src/modules/setup/services/setup.api.ts +3 -3
  124. package/src/modules/setup/utils/suggested-branch.ts +27 -0
  125. package/src/modules/toolbar/commands/__tests__/actions.test.tsx +210 -0
  126. package/src/modules/toolbar/commands/actions.tsx +330 -0
  127. package/src/modules/toolbar/commands/command-menu.ts +44 -0
  128. package/src/modules/toolbar/commands/useCommandActions.ts +71 -0
  129. package/src/modules/toolbar/commands/useCommandShortcuts.ts +121 -0
  130. package/src/modules/toolbar/components/AppSwitcher.tsx +125 -22
  131. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +1 -1
  132. package/src/modules/toolbar/components/ProfileMenu.tsx +9 -4
  133. package/src/modules/toolbar/components/SearchPalette.tsx +540 -0
  134. package/src/modules/toolbar/components/Toolbar.tsx +10 -0
  135. package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +230 -52
  136. package/src/modules/toolbar/components/__tests__/ProfileMenu.test.tsx +64 -0
  137. package/src/modules/toolbar/components/__tests__/SearchPalette.test.tsx +864 -0
  138. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +57 -2
  139. package/src/modules/toolbar/search/__tests__/rank.test.ts +93 -0
  140. package/src/modules/toolbar/search/__tests__/sources.test.ts +131 -0
  141. package/src/modules/toolbar/search/rank.ts +111 -0
  142. package/src/modules/toolbar/search/sources.ts +169 -0
  143. package/src/modules/workflow/hooks/useFileLock.ts +10 -7
  144. package/src/modules/workflow/services/__tests__/lock.api.test.ts +41 -0
  145. package/src/modules/workflow/services/lock.api.ts +17 -2
  146. package/src/modules/workspace/__tests__/useWorkspaceState.test.ts +49 -1
  147. package/src/modules/workspace/components/EditorTabs.tsx +39 -15
  148. package/src/modules/workspace/components/FileExplorer.tsx +39 -6
  149. package/src/modules/workspace/components/FilePaneCard.tsx +6 -2
  150. package/src/modules/workspace/components/FileRoute.tsx +12 -7
  151. package/src/modules/workspace/components/FileViewer.tsx +271 -74
  152. package/src/modules/workspace/components/KbPageHeader.tsx +13 -6
  153. package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +88 -21
  154. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +92 -4
  155. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +23 -3
  156. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +330 -6
  157. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +17 -2
  158. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +11 -16
  159. package/src/modules/workspace/components/renderers/DownloadFileButton.tsx +6 -0
  160. package/src/modules/workspace/components/renderers/EmailRenderer.tsx +23 -21
  161. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +13 -29
  162. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +9 -2
  163. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +8 -0
  164. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +14 -19
  165. package/src/modules/workspace/components/renderers/PptxRenderer.tsx +11 -17
  166. package/src/modules/workspace/components/renderers/ToolRenderer.tsx +35 -7
  167. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -17
  168. package/src/modules/workspace/components/renderers/__tests__/EmailRenderer.links.test.tsx +73 -0
  169. package/src/modules/workspace/components/renderers/__tests__/ToolRenderer.scaffold.test.tsx +64 -0
  170. package/src/modules/workspace/components/renderers/__tests__/ToolRenderer.surface.test.tsx +82 -0
  171. package/src/modules/workspace/components/renderers/__tests__/bridgeHarness.ts +99 -0
  172. package/src/modules/workspace/components/renderers/__tests__/htmlSandbox.test.ts +129 -35
  173. package/src/modules/workspace/components/renderers/__tests__/htmlViewsGuide.test.ts +149 -0
  174. package/src/modules/workspace/components/renderers/__tests__/kbMarkdownLinkPolicy.test.tsx +100 -0
  175. package/src/modules/workspace/components/renderers/htmlSandbox.ts +76 -20
  176. package/src/modules/workspace/components/renderers/index.ts +26 -0
  177. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +51 -1
  178. package/src/modules/workspace/components/renderers/rendererRawRead.ts +53 -0
  179. package/src/modules/workspace/components/renderers/rendererSurface.ts +109 -0
  180. package/src/modules/workspace/components/renderers/rendererWorkspace.ts +8 -2
  181. package/src/modules/workspace/hooks/__tests__/useCreatePage.test.ts +137 -0
  182. package/src/modules/workspace/hooks/__tests__/useKnowledgeWriteTarget.test.ts +302 -0
  183. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +126 -21
  184. package/src/modules/workspace/hooks/useCreatePage.ts +206 -0
  185. package/src/modules/workspace/hooks/useKnowledgeWriteTarget.ts +238 -0
  186. package/src/modules/workspace/hooks/useWorkspaceImageResolver.ts +24 -7
  187. package/src/modules/workspace/hooks/useWorkspaceState.ts +42 -8
  188. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +10 -0
  189. package/src/modules/workspace/routing/__tests__/md-links-parity.test.tsx +113 -0
  190. package/src/modules/workspace/routing/kb-routes.ts +66 -12
  191. package/src/modules/workspace/state/editable-page.ts +42 -0
  192. package/src/modules/workspace/state/workspace.context.ts +13 -4
  193. package/src/modules/workspace/utils/__tests__/display-file-name.test.ts +60 -0
  194. package/src/modules/workspace/utils/__tests__/fileTree.test.ts +75 -0
  195. package/src/modules/workspace/utils/__tests__/treeConfirm.test.ts +16 -0
  196. package/src/modules/workspace/utils/display-file-name.ts +102 -0
  197. package/src/modules/workspace/utils/fileTree.ts +49 -14
  198. package/src/modules/workspace/utils/treeConfirm.ts +15 -0
  199. package/src/shared/__tests__/no-builtin-confirm.test.ts +102 -0
  200. package/src/shared/components/ConfirmProvider.tsx +156 -0
  201. package/src/shared/components/Dialog.tsx +7 -0
  202. package/src/shared/components/__tests__/ConfirmProvider.test.tsx +198 -0
  203. package/src/shared/components/confirm-context.ts +94 -0
  204. package/src/shared/components/index.ts +3 -0
  205. package/src/modules/onboarding/components/WelcomeRoute.tsx +0 -57
  206. package/src/modules/onboarding/welcome-state.ts +0 -36
@@ -0,0 +1,302 @@
1
+ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
2
+ import { act, renderHook, waitFor } from '@testing-library/react';
3
+ import type { FileTreeEntry } from '@bevel-software/platform-shared';
4
+
5
+ /**
6
+ * Where New page writes, through the hook alone: the top of Knowledge, else
7
+ * the folder on screen, else the first folder the person may write in file
8
+ * tree order — asked of the batch access endpoint (at most 500 paths a call):
9
+ * who may write on a protected branch, who may read on a draft.
10
+ */
11
+
12
+ type Verb = 'write' | 'owner' | 'read';
13
+ const { batch, workspace, merged } = vi.hoisted(() => ({
14
+ batch: vi.fn<(workspaceId: string, paths: string[], verb?: Verb) => Promise<{ results: Record<string, boolean> }>>(),
15
+ workspace: {
16
+ current: {
17
+ workspaceId: 'ws-1',
18
+ workspaceBranch: 'target-company-state' as string | null,
19
+ kbDirName: 'kb',
20
+ openFilePath: null as string | null,
21
+ },
22
+ },
23
+ merged: { tree: null as FileTreeEntry | null },
24
+ }));
25
+ vi.mock('../../../access/api', async (importOriginal) => ({
26
+ ...(await importOriginal<typeof import('../../../access/api')>()),
27
+ fetchFileAccessBatch: batch,
28
+ }));
29
+ vi.mock('../../state/workspace.context', async (importOriginal) => ({
30
+ ...(await importOriginal<typeof import('../../state/workspace.context')>()),
31
+ useWorkspace: () => workspace.current,
32
+ }));
33
+ vi.mock('../useMergedWorkspaceTree', () => ({
34
+ useMergedWorkspaceTree: () => ({ tree: merged.tree, suggestionOnlyPaths: new Map(), withheld: 0 }),
35
+ }));
36
+
37
+ import { useKnowledgeWriteTarget } from '../useKnowledgeWriteTarget';
38
+
39
+ const ROOT = 'kb/KnowledgeBase';
40
+ const DRAFT = 'alice/draft';
41
+ let writable = new Set<string>();
42
+ let readable = new Set<string>();
43
+
44
+ const dir = (relativePath: string, children: FileTreeEntry[] = []): FileTreeEntry => ({
45
+ name: relativePath.split('/').pop()!,
46
+ relativePath,
47
+ type: 'directory',
48
+ children,
49
+ });
50
+ const file = (relativePath: string): FileTreeEntry => ({
51
+ name: relativePath.split('/').pop()!,
52
+ relativePath,
53
+ type: 'file',
54
+ });
55
+ const tree = (...children: FileTreeEntry[]) => dir('kb', [dir(ROOT, children)]);
56
+
57
+ /** Product, Sales (with Team), Support — plus a page, and a dot-folder that is no place for one. */
58
+ const FOLDERS = tree(
59
+ file(`${ROOT}/Guide.md`),
60
+ dir(`${ROOT}/.hidden`),
61
+ dir(`${ROOT}/Product`),
62
+ dir(`${ROOT}/Sales`, [dir(`${ROOT}/Sales/Team`), file(`${ROOT}/Sales/a.md`)]),
63
+ dir(`${ROOT}/Support`),
64
+ );
65
+
66
+ function show(over: Partial<typeof workspace.current> = {}, shownTree: FileTreeEntry | null = FOLDERS) {
67
+ workspace.current = { ...workspace.current, ...over };
68
+ merged.tree = shownTree;
69
+ }
70
+
71
+ async function settledTarget(over: Partial<typeof workspace.current> = {}, shownTree?: FileTreeEntry | null) {
72
+ show(over, shownTree);
73
+ const hook = renderHook(() => useKnowledgeWriteTarget(ROOT));
74
+ await waitFor(() => expect(hook.result.current.settled).toBe(true));
75
+ return hook;
76
+ }
77
+
78
+ beforeEach(() => {
79
+ writable = new Set();
80
+ readable = new Set();
81
+ workspace.current = { workspaceId: 'ws-1', workspaceBranch: 'target-company-state', kbDirName: 'kb', openFilePath: null };
82
+ merged.tree = FOLDERS;
83
+ batch.mockReset().mockImplementation(async (_ws, paths, verb = 'write') => ({
84
+ results: Object.fromEntries(paths.map((p) => [p, (verb === 'read' ? readable : writable).has(p)])),
85
+ }));
86
+ });
87
+
88
+ /** The verb every batch call so far asked — one question per branch kind. */
89
+ const verbsAsked = () => new Set(batch.mock.calls.map((c) => c[2] ?? 'write'));
90
+
91
+ afterEach(() => {
92
+ vi.useRealTimers();
93
+ });
94
+
95
+ describe('useKnowledgeWriteTarget on a protected branch', () => {
96
+ it('takes the top of Knowledge when it may be written, whatever is on screen', async () => {
97
+ writable = new Set(['KnowledgeBase', 'KnowledgeBase/Support']);
98
+ const { result } = await settledTarget({ openFilePath: `${ROOT}/Support/FAQ.md` });
99
+ expect(result.current.folder).toBe(ROOT);
100
+ });
101
+
102
+ it('else the folder on screen, asking every folder repo-relative and once, depth first, without dot-folders', async () => {
103
+ writable = new Set(['KnowledgeBase/Sales', 'KnowledgeBase/Support']);
104
+ const { result } = await settledTarget({ openFilePath: `${ROOT}/Support/FAQ.md` });
105
+ expect(result.current.folder).toBe(`${ROOT}/Support`);
106
+ expect(batch).toHaveBeenCalledWith(
107
+ 'ws-1',
108
+ ['KnowledgeBase', 'KnowledgeBase/Support', 'KnowledgeBase/Product', 'KnowledgeBase/Sales', 'KnowledgeBase/Sales/Team'],
109
+ 'write',
110
+ );
111
+ expect(verbsAsked()).toEqual(new Set(['write']));
112
+ });
113
+
114
+ it('else the first folder in tree order', async () => {
115
+ writable = new Set(['KnowledgeBase/Sales', 'KnowledgeBase/Support']);
116
+ const { result } = await settledTarget({ openFilePath: `${ROOT}/Product/Roadmap.md` });
117
+ expect(result.current.folder).toBe(`${ROOT}/Sales`);
118
+ });
119
+
120
+ it('settles on nothing when there is nowhere to write', async () => {
121
+ const { result } = await settledTarget();
122
+ expect(result.current.folder).toBeNull();
123
+ });
124
+
125
+ it('asks in pages the endpoint accepts, stopping at the first that answers', async () => {
126
+ const many = Array.from({ length: 1010 }, (_, i) => dir(`${ROOT}/F${i}`));
127
+ writable = new Set(['KnowledgeBase/F503', 'KnowledgeBase/F1005']);
128
+ const { result } = await settledTarget({}, tree(...many));
129
+ expect(result.current.folder).toBe(`${ROOT}/F503`);
130
+ expect(batch).toHaveBeenCalledTimes(2);
131
+ for (const call of batch.mock.calls) expect(call[1].length).toBeLessThanOrEqual(500);
132
+ });
133
+
134
+ it('settles on nothing when the request fails', async () => {
135
+ batch.mockRejectedValue(new Error('HTTP 500'));
136
+ const { result } = await settledTarget();
137
+ expect(result.current.folder).toBeNull();
138
+ });
139
+
140
+ it('a recheck overtaken by a newer question answers with the newer answer, never a folder of what was left', async () => {
141
+ vi.useFakeTimers();
142
+ writable = new Set(['KnowledgeBase/Sales']);
143
+ show({ openFilePath: `${ROOT}/Sales/a.md` });
144
+ const { result, rerender } = renderHook(() => useKnowledgeWriteTarget(ROOT));
145
+ await act(async () => {
146
+ await vi.advanceTimersByTimeAsync(0);
147
+ });
148
+ expect(result.current.folder).toBe(`${ROOT}/Sales`);
149
+
150
+ // Every later question answers only when told to, in any order.
151
+ const pending: Array<(r: { results: Record<string, boolean> }) => void> = [];
152
+ batch.mockImplementation(() => new Promise((resolve) => pending.push(resolve)));
153
+ // A create asks again (first question)...
154
+ const asked = result.current.recheck();
155
+ // ...and the person moves to a page in Support before it answers (second question, after the debounce).
156
+ show({ openFilePath: `${ROOT}/Support/b.md` });
157
+ rerender();
158
+ await act(async () => {
159
+ await vi.advanceTimersByTimeAsync(300);
160
+ });
161
+ expect(pending).toHaveLength(2);
162
+ // The first answers: Sales, where they were. Then the second: Support.
163
+ await act(async () => {
164
+ pending[0]!({ results: { 'KnowledgeBase/Sales': true } });
165
+ await vi.advanceTimersByTimeAsync(0);
166
+ pending[1]!({ results: { 'KnowledgeBase/Support': true } });
167
+ await vi.advanceTimersByTimeAsync(0);
168
+ });
169
+ expect(await asked).toBe(`${ROOT}/Support`);
170
+ expect(result.current.folder).toBe(`${ROOT}/Support`);
171
+ });
172
+
173
+ it('a recheck that answers for a page left during the debounce asks again for the page on screen', async () => {
174
+ vi.useFakeTimers();
175
+ writable = new Set(['KnowledgeBase/Sales', 'KnowledgeBase/Support']);
176
+ show({ openFilePath: `${ROOT}/Sales/a.md` });
177
+ const { result, rerender } = renderHook(() => useKnowledgeWriteTarget(ROOT));
178
+ await act(async () => {
179
+ await vi.advanceTimersByTimeAsync(0);
180
+ });
181
+ // Top of Knowledge is not writable, so the folder follows the page on screen.
182
+ expect(result.current.folder).toBe(`${ROOT}/Sales`);
183
+
184
+ const pending: Array<() => void> = [];
185
+ batch.mockImplementation(
186
+ (_ws, paths) =>
187
+ new Promise((resolve) =>
188
+ pending.push(() => resolve({ results: Object.fromEntries(paths.map((p) => [p, writable.has(p)])) })),
189
+ ),
190
+ );
191
+ // A create asks about Sales...
192
+ const asked = result.current.recheck();
193
+ // ...the person opens a page in Support, and the Sales answer comes back
194
+ // inside the debounce, before any question about Support was asked.
195
+ show({ openFilePath: `${ROOT}/Support/b.md` });
196
+ rerender();
197
+ await act(async () => {
198
+ pending.shift()!();
199
+ await vi.advanceTimersByTimeAsync(0);
200
+ });
201
+ // Not handed Sales: it asked again, about Support.
202
+ expect(pending).toHaveLength(1);
203
+ await act(async () => {
204
+ pending.shift()!();
205
+ await vi.advanceTimersByTimeAsync(0);
206
+ });
207
+ expect(await asked).toBe(`${ROOT}/Support`);
208
+ // And `resolve` answers the current folder without asking again.
209
+ const calls = batch.mock.calls.length;
210
+ expect(await result.current.resolve()).toBe(`${ROOT}/Support`);
211
+ expect(batch.mock.calls.length).toBe(calls);
212
+ // Let the debounced question the page change scheduled answer too.
213
+ await act(async () => {
214
+ await vi.advanceTimersByTimeAsync(300);
215
+ while (pending.length) pending.shift()!();
216
+ await vi.advanceTimersByTimeAsync(0);
217
+ });
218
+ });
219
+
220
+ it('asks at once the first time, and debounces a tree change after that', async () => {
221
+ vi.useFakeTimers();
222
+ show();
223
+ const { result, rerender } = renderHook(() => useKnowledgeWriteTarget(ROOT));
224
+ await act(async () => {
225
+ await vi.advanceTimersByTimeAsync(0);
226
+ });
227
+ expect(result.current.settled).toBe(true);
228
+ expect(result.current.folder).toBeNull();
229
+ expect(batch).toHaveBeenCalledTimes(1);
230
+
231
+ // An admin shares Support; the tree changes with it.
232
+ writable = new Set(['KnowledgeBase/Support']);
233
+ show({}, tree(dir(`${ROOT}/Product`), dir(`${ROOT}/Support`)));
234
+ rerender();
235
+ await act(async () => {
236
+ await vi.advanceTimersByTimeAsync(200);
237
+ });
238
+ expect(batch).toHaveBeenCalledTimes(1);
239
+ await act(async () => {
240
+ await vi.advanceTimersByTimeAsync(100);
241
+ });
242
+ expect(batch).toHaveBeenCalledTimes(2);
243
+ expect(result.current.folder).toBe(`${ROOT}/Support`);
244
+ });
245
+ });
246
+
247
+ /**
248
+ * A draft branch: no write grant is needed, only read where the page lands,
249
+ * and the tree shows folders the person may not read when something inside
250
+ * them is shared — so every candidate is asked, in the same order and the
251
+ * same pages, about reading.
252
+ */
253
+ describe('useKnowledgeWriteTarget on a draft branch', () => {
254
+ it('takes the top of Knowledge when it may be read, asking no write check', async () => {
255
+ readable = new Set(['KnowledgeBase', 'KnowledgeBase/Support']);
256
+ const { result } = await settledTarget({ workspaceBranch: DRAFT, openFilePath: `${ROOT}/Support/FAQ.md` });
257
+ expect(result.current.folder).toBe(ROOT);
258
+ expect(batch).toHaveBeenCalledWith(
259
+ 'ws-1',
260
+ ['KnowledgeBase', 'KnowledgeBase/Support', 'KnowledgeBase/Product', 'KnowledgeBase/Sales', 'KnowledgeBase/Sales/Team'],
261
+ 'read',
262
+ );
263
+ expect(verbsAsked()).toEqual(new Set(['read']));
264
+ });
265
+
266
+ it('passes over a top shown only for what is inside it, to the folder on screen, else the first in tree order', async () => {
267
+ readable = new Set(['KnowledgeBase/Sales/Team', 'KnowledgeBase/Support']);
268
+ const onScreen = await settledTarget({ workspaceBranch: DRAFT, openFilePath: `${ROOT}/Support/FAQ.md` });
269
+ expect(onScreen.result.current.folder).toBe(`${ROOT}/Support`);
270
+ onScreen.unmount();
271
+ const elsewhere = await settledTarget({ workspaceBranch: DRAFT, openFilePath: `${ROOT}/Product/Roadmap.md` });
272
+ expect(elsewhere.result.current.folder).toBe(`${ROOT}/Sales/Team`);
273
+ });
274
+
275
+ it('settles on nothing when nothing may be read', async () => {
276
+ const { result } = await settledTarget({ workspaceBranch: DRAFT });
277
+ expect(result.current.folder).toBeNull();
278
+ });
279
+
280
+ it('asks in the pages the endpoint accepts, stopping at the first that answers', async () => {
281
+ const many = Array.from({ length: 1010 }, (_, i) => dir(`${ROOT}/F${i}`));
282
+ readable = new Set(['KnowledgeBase/F503', 'KnowledgeBase/F1005']);
283
+ const { result } = await settledTarget({ workspaceBranch: DRAFT }, tree(...many));
284
+ expect(result.current.folder).toBe(`${ROOT}/F503`);
285
+ // The top and F0…F498, then F499…F998: two pages, never the third.
286
+ expect(batch).toHaveBeenCalledTimes(2);
287
+ for (const call of batch.mock.calls) expect(call[1].length).toBeLessThanOrEqual(500);
288
+ expect(verbsAsked()).toEqual(new Set(['read']));
289
+ });
290
+
291
+ it('asks nothing when the tree shows no Knowledge folder', async () => {
292
+ const { result } = await settledTarget({ workspaceBranch: DRAFT }, dir('kb', [dir('kb/Skills')]));
293
+ expect(result.current.folder).toBeNull();
294
+ expect(batch).not.toHaveBeenCalled();
295
+ });
296
+
297
+ it('settles on nothing when the request fails', async () => {
298
+ batch.mockRejectedValue(new Error('HTTP 500'));
299
+ const { result } = await settledTarget({ workspaceBranch: DRAFT });
300
+ expect(result.current.folder).toBeNull();
301
+ });
302
+ });
@@ -1,5 +1,6 @@
1
1
  import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
2
- import { renderHook, act, waitFor } from '@testing-library/react';
2
+ import { renderHook, act, waitFor, screen, within, fireEvent } from '@testing-library/react';
3
+ import { ConfirmProvider } from '../../../../shared/components';
3
4
 
4
5
  // Build a single error class shared between the mock module and the tests.
5
6
  // Hoisted so vi.mock can reach it during module initialization, before the
@@ -102,7 +103,10 @@ describe('useWorkspaceState multi-tab', () => {
102
103
  });
103
104
 
104
105
  async function mountReady() {
105
- const { result } = renderHook(() => useWorkspaceState());
106
+ // The unsaved-work questions are the app's own dialog, hosted here.
107
+ const { result } = renderHook(() => useWorkspaceState(), {
108
+ wrapper: ({ children }: { children: ReactNode }) => <ConfirmProvider>{children}</ConfirmProvider>,
109
+ });
106
110
  await waitFor(() => expect(result.current.workspaceId).toBe('ws-1'));
107
111
  return result;
108
112
  }
@@ -143,29 +147,112 @@ describe('useWorkspaceState multi-tab', () => {
143
147
  expect(tabA?.isDirty).toBe(true);
144
148
  });
145
149
 
146
- it('closeTab prompts when the tab is dirty', async () => {
150
+ /** Answer the app's open dialog by pressing one of its buttons. */
151
+ async function answer(button: string, text?: RegExp) {
152
+ const dialog = await screen.findByRole('dialog');
153
+ if (text) expect(dialog.textContent).toMatch(text);
154
+ // A per-tab question is never one you can switch off.
155
+ expect(within(dialog).queryByText("Don't ask again")).toBeNull();
156
+ fireEvent.click(within(dialog).getByRole('button', { name: button }));
157
+ }
158
+
159
+ it("closeTab asks in the app's dialog when the tab is dirty; Cancel keeps it, Close closes it", async () => {
160
+ // The browser's dialogs suppressed: a stubbed confirm that always says no
161
+ // must never be what answers.
147
162
  const confirmSpy = vi.spyOn(window, 'confirm').mockReturnValue(false);
148
163
  const result = await mountReady();
149
164
  await act(async () => { await result.current.addTab('Knowledge/A.md'); });
150
165
  await act(async () => { result.current.setHasUnsavedFileChanges?.(true); });
151
166
 
152
167
  const tabA = result.current.openTabs[0];
153
- await act(async () => {
154
- const result1 = await result.current.closeTab(tabA);
155
- expect(result1.closed).toBe(false);
156
- });
157
- expect(confirmSpy).toHaveBeenCalledWith(
158
- 'You have unsaved changes in A.md. Close anyway?',
159
- );
168
+ let closing!: Promise<{ closed: boolean }>;
169
+ act(() => { closing = result.current.closeTab(tabA); });
170
+ await answer('Cancel', /You have unsaved changes in A\.md\. Close anyway\?/);
171
+ await act(async () => { expect((await closing).closed).toBe(false); });
172
+ expect(screen.queryByRole('dialog')).toBeNull();
160
173
  expect(result.current.openTabs).toHaveLength(1);
161
174
 
162
- confirmSpy.mockReturnValue(true);
163
- await act(async () => {
164
- const result2 = await result.current.closeTab(tabA);
165
- expect(result2.closed).toBe(true);
166
- });
175
+ act(() => { closing = result.current.closeTab(tabA); });
176
+ await answer('Close anyway');
177
+ await act(async () => { expect((await closing).closed).toBe(true); });
167
178
  expect(result.current.openTabs).toHaveLength(0);
168
179
  expect(result.current.activeTab).toBeNull();
180
+ expect(confirmSpy).not.toHaveBeenCalled();
181
+ });
182
+
183
+ it('closeTab counts Escape as Cancel', async () => {
184
+ const result = await mountReady();
185
+ await act(async () => { await result.current.addTab('Knowledge/A.md'); });
186
+ await act(async () => { result.current.setHasUnsavedFileChanges?.(true); });
187
+ let closing!: Promise<{ closed: boolean }>;
188
+ act(() => { closing = result.current.closeTab(result.current.openTabs[0]); });
189
+ await screen.findByRole('dialog');
190
+ fireEvent.keyDown(document, { key: 'Escape' });
191
+ await act(async () => { expect((await closing).closed).toBe(false); });
192
+ expect(result.current.openTabs).toHaveLength(1);
193
+ });
194
+
195
+ it('closeTab asks once when the same dirty tab is closed twice while asking', async () => {
196
+ const result = await mountReady();
197
+ await act(async () => { await result.current.addTab('Knowledge/A.md'); });
198
+ await act(async () => { result.current.setHasUnsavedFileChanges?.(true); });
199
+ const tabA = result.current.openTabs[0];
200
+ let first!: Promise<{ closed: boolean }>;
201
+ let second!: Promise<{ closed: boolean }>;
202
+ act(() => {
203
+ first = result.current.closeTab(tabA);
204
+ second = result.current.closeTab(tabA);
205
+ });
206
+ await act(async () => { expect((await second).closed).toBe(false); });
207
+ await answer('Close anyway');
208
+ await act(async () => { expect((await first).closed).toBe(true); });
209
+ expect(screen.queryByRole('dialog')).toBeNull();
210
+ expect(result.current.openTabs).toHaveLength(0);
211
+ });
212
+
213
+ it('closeTab closes nothing when the workspace moved to another branch while it asked', async () => {
214
+ apiMocks.getOrCreateWorkspace.mockResolvedValue({
215
+ ...WORKSPACE_FIXTURE,
216
+ workspace: { ...WORKSPACE_FIXTURE.workspace, id: 'main' },
217
+ });
218
+ const { result } = renderHook(() => useWorkspaceState(), {
219
+ wrapper: ({ children }: { children: ReactNode }) => <ConfirmProvider>{children}</ConfirmProvider>,
220
+ });
221
+ await waitFor(() => expect(result.current.workspaceId).toBe('main'));
222
+ act(() => { result.current.setPersistenceBranch('main'); });
223
+ await act(async () => { await result.current.addTab('Knowledge/A.md'); });
224
+ await act(async () => { result.current.setHasUnsavedFileChanges?.(true); });
225
+ let closing!: Promise<{ closed: boolean }>;
226
+ act(() => { closing = result.current.closeTab(result.current.openTabs[0]); });
227
+ await screen.findByRole('dialog');
228
+
229
+ // The person switches branch with the question still up, and the same
230
+ // path is open there.
231
+ apiMocks.getOrCreateWorkspace.mockResolvedValue({
232
+ ...WORKSPACE_FIXTURE,
233
+ workspace: { ...WORKSPACE_FIXTURE.workspace, id: 'alice%2Fdraft' },
234
+ });
235
+ act(() => { result.current.setPersistenceBranch('alice/draft'); });
236
+ await waitFor(() => expect(result.current.workspaceId).toBe('alice%2Fdraft'));
237
+ await act(async () => { await result.current.addTab('Knowledge/A.md'); });
238
+
239
+ await answer('Close anyway');
240
+ await act(async () => { expect((await closing).closed).toBe(false); });
241
+ expect(result.current.openTabs.map((t) => t.path)).toEqual(['Knowledge/A.md']);
242
+ });
243
+
244
+ it('a bulk close pinned to a workspace that moved on closes nothing', async () => {
245
+ const result = await mountReady();
246
+ await act(async () => { await result.current.addTab('Knowledge/A.md'); });
247
+ let outcome!: { closed: boolean };
248
+ await act(async () => {
249
+ outcome = await result.current.closeTab(result.current.openTabs[0], {
250
+ skipConfirm: true,
251
+ workspaceId: 'some-other-branch',
252
+ });
253
+ });
254
+ expect(outcome.closed).toBe(false);
255
+ expect(result.current.openTabs).toHaveLength(1);
169
256
  });
170
257
 
171
258
  it('closeTab activates the left neighbor when closing the active tab', async () => {
@@ -202,20 +289,38 @@ describe('useWorkspaceState multi-tab', () => {
202
289
  expect(result.current.openTabs.map((t) => t.path)).toEqual(['keep.md']);
203
290
  });
204
291
 
205
- it('deleteEntry sweeps tabs under a deleted directory and prompts once for dirty', async () => {
206
- const confirmSpy = vi.spyOn(window, 'confirm').mockReturnValue(true);
292
+ it('deleteEntry sweeps tabs under a deleted directory and asks once for dirty', async () => {
293
+ const confirmSpy = vi.spyOn(window, 'confirm').mockReturnValue(false);
207
294
  const result = await mountReady();
208
295
  await act(async () => { await result.current.addTab('Knowledge/keep.md'); });
209
296
  await act(async () => { await result.current.addTab('OldDir/a.md'); });
210
297
  await act(async () => { result.current.setHasUnsavedFileChanges?.(true); });
211
298
  await act(async () => { await result.current.addTab('OldDir/b.md'); });
212
299
 
213
- await act(async () => { await result.current.deleteEntry('OldDir'); });
300
+ let deleting!: Promise<unknown>;
301
+ act(() => { deleting = result.current.deleteEntry('OldDir'); });
302
+ // Today's bulk question, by basename, not full path.
303
+ await answer('Close anyway', /You have unsaved changes in:\n {2}- a\.md\nClose anyway\?/);
304
+ await act(async () => { await deleting; });
214
305
 
215
- expect(confirmSpy).toHaveBeenCalledTimes(1);
216
- // Bulk-confirm message uses basename, not full path.
217
- expect(confirmSpy.mock.calls[0][0]).toMatch(/a\.md/);
306
+ expect(screen.queryAllByRole('dialog')).toHaveLength(0);
307
+ expect(apiMocks.deleteFile).toHaveBeenCalledWith('ws-1', 'OldDir');
218
308
  expect(result.current.openTabs.map((t) => t.path)).toEqual(['Knowledge/keep.md']);
309
+ expect(confirmSpy).not.toHaveBeenCalled();
310
+ });
311
+
312
+ it('deleteEntry keeps everything when the unsaved-tabs question is cancelled', async () => {
313
+ const result = await mountReady();
314
+ await act(async () => { await result.current.addTab('OldDir/a.md'); });
315
+ await act(async () => { result.current.setHasUnsavedFileChanges?.(true); });
316
+
317
+ let deleting!: Promise<unknown>;
318
+ act(() => { deleting = result.current.deleteEntry('OldDir'); });
319
+ await answer('Cancel');
320
+ await act(async () => { expect(await deleting).toBe(false); });
321
+
322
+ expect(apiMocks.deleteFile).not.toHaveBeenCalled();
323
+ expect(result.current.openTabs.map((t) => t.path)).toEqual(['OldDir/a.md']);
219
324
  });
220
325
 
221
326
  it('moveEntry rewrites tab paths in place', async () => {