@bevel-software/platform-core-backend 0.35.0 → 0.37.0

package/src/modules/plugins/join-requests.service.ts

@@ -2,7 +2,7 @@ import {
   isJoinBranchFor,
   type AuthUser,
   type ChangeRequest,
-  type IWorkflowService,
+  type IVersionControlService,
 } from '@bevel-software/platform-shared';
 import { type WorkspaceService } from '../workspace/index.js';
 import { logger } from '../../shared/logging.js';
@@ -57,7 +57,7 @@ export interface JoinRequest {
 export class JoinRequestsService implements IAccessRequestLifecycle {
   constructor(
     private readonly workspaceService: WorkspaceService,
-    private readonly workflow: IWorkflowService,
+    private readonly versionControl: IVersionControlService,
     private readonly kb: Pick<KbContext, 'defaultBranch' | 'defaultWorkspaceId'>,
     /**
      * Read-only, and asked one question only: does this person already hold
@@ -284,7 +284,7 @@ export class JoinRequestsService implements IAccessRequestLifecycle {
   private async settle(cr: ChangeRequest, actor: AuthUser): Promise<void> {
     const wsId = this.kb.defaultWorkspaceId();
     try {
-      await this.workflow.rejectChangeRequest(
+      await this.versionControl.rejectChangeRequest(
         cr.number,
         actor,
         cr.state,
@@ -301,7 +301,7 @@ export class JoinRequestsService implements IAccessRequestLifecycle {
       return;
     }
     try {
-      await this.workflow.deleteBranch(wsId, cr.branch, actor);
+      await this.versionControl.deleteBranch(wsId, cr.branch, actor);
     } catch (err) {
       // The request is closed either way; a leftover branch is cosmetic and
       // the author can still delete it themselves.

package/src/modules/plugins/plugin-rename.service.ts

@@ -246,7 +246,7 @@ export class PluginRenameService {
       );
     } catch (err) {
       // One failure is NOT a failed commit: the commit landed locally and only
-      // the push did not (the typed hand-off the workflow throws). Restoring
+      // the push did not (the typed hand-off the version-control service throws). Restoring
       // the old bytes then would stack an uncommitted inverse of a real
       // commit; the recovery flow owns that state, so it is left alone — and
       // since the tree DID change, every cache keyed on the old identity is

package/src/modules/plugins/plugins.routes.ts

@@ -8,10 +8,10 @@ import {
   type AuthUser,
   type ChangeRequest,
   type ChangeRequestState,
-  type IWorkflowService,
+  type IVersionControlService,
 } from '@bevel-software/platform-shared';
 import type { IAccessControl } from '../access/index.js';
-import { WorkflowDomainError } from '../../shared/domain-errors.js';
+import { VersionControlDomainError } from '../../shared/domain-errors.js';
 import { domainErrorBody } from '../../shared/http-errors.js';
 import { pluginFolderBelowRoot } from './plugins.service.js';
 import type { KbContext } from '../../shared/kb-context.js';
@@ -209,7 +209,7 @@ export function createPluginCreationRoutes(
 export function createPluginsRoutes(
   pluginIndex: IPluginIndexService,
   accessControl: IAccessControl,
-  workflow: IWorkflowService,
+  versionControl: IVersionControlService,
   joinRequests: JoinRequestsService,
   /**
    * Where a join request is RECORDED, and what finishes it afterwards. The
@@ -257,7 +257,7 @@ export function createPluginsRoutes(
           res.status(err.status).json({ error: err.message, ...err.payload });
           return;
         }
-        if (err instanceof WorkflowDomainError) {
+        if (err instanceof VersionControlDomainError) {
           res.status(err.status).json(domainErrorBody(err));
           return;
         }
@@ -290,7 +290,7 @@ export function createPluginsRoutes(
         res.status(err.status).json({ error: err.message, ...err.payload });
         return;
       }
-      if (err instanceof WorkflowDomainError) {
+      if (err instanceof VersionControlDomainError) {
         res.status(err.status).json(domainErrorBody(err));
         return;
       }
@@ -403,7 +403,7 @@ export function createPluginsRoutes(
       // requested" and let the next load repair it.
       let mine: ChangeRequest[] = [];
       try {
-        mine = await workflow.listChangeRequestsAuthoredBy(email);
+        mine = await versionControl.listChangeRequestsAuthoredBy(email);
       } catch (err) {
         log.warn(`join-request lookup failed: ${err instanceof Error ? err.message : String(err)}`);
       }
@@ -624,7 +624,7 @@ export function createPluginsRoutes(
       // already on the wire, and the job records its own outcome on the row.
       void joinRequestJobs.start(record);
     } catch (err) {
-      if (err instanceof WorkflowDomainError) {
+      if (err instanceof VersionControlDomainError) {
         res.status(err.status).json(domainErrorBody(err));
         return;
       }
@@ -678,7 +678,7 @@ export function createPluginsRoutes(
     try {
       const ctx = await requireManager(req, res, () => res.json({ requests: [] }));
       if (!ctx) return;
-      const crs = await workflow.listChangeRequests();
+      const crs = await versionControl.listChangeRequests();
       res.json({
         requests: await joinRequests.list(joinKeyOf(ctx.plugin), folderTarget(ctx.folder), crs, ctx.user),
       });
@@ -705,7 +705,7 @@ export function createPluginsRoutes(
         res.status(400).json({ error: 'Invalid change request number' });
         return;
       }
-      const cr = await workflow.getChangeRequest(crNumber);
+      const cr = await versionControl.getChangeRequest(crNumber);
       if (!cr) {
         res.status(404).json({ error: 'Not found' });
         return;