@bevel-software/platform-core-backend 0.34.0 → 0.36.1

package/src/modules/{workflow → version-control}/git/__tests__/git.service.changedFilesForPr.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService, parseNameStatusZ, parseNumstatZ, withoutPlaceholderRename } from '../git.service.js';
 import { WorkspaceMutex } from '../../../kb-fs/mutex.js';
 
@@ -127,7 +127,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -174,7 +174,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     // What the detail does first: resolve (and fetch) the two SHAs.
@@ -226,7 +226,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -264,7 +264,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     await runGit(repo, ['commit', '-m', 'folders']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/new-folders']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
 
     const files = await git.changedFilesForPr(workspaceId, 'current-company-state', 'alice/new-folders');
     expect(files.map((f) => f.path)).toEqual(['Reports/q3.md']);
@@ -293,7 +293,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     await runGit(repo, ['commit', '-m', 'emptied']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/emptied']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
 
     const files = await git.changedFilesForPr(workspaceId, 'current-company-state', 'alice/emptied');
     expect(files.map((f) => ({ path: f.path, status: f.status, previousPath: f.previousPath }))).toEqual([
@@ -306,7 +306,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
   it('pathExistsAtRef answers for files and folders at a ref, and false for what is not there', async () => {
     const { repo } = await seedWorkspace(root, workspaceId);
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     await fs.mkdir(path.join(repo, 'Docs'));
     await fs.writeFile(path.join(repo, 'Docs/.gitkeep'), '');
     await runGit(repo, ['add', '-A']);
@@ -336,7 +336,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -417,7 +417,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     await pushedElsewhere(upstream, 'brief.pdf');
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     expect(
@@ -430,7 +430,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     const other = await pushedElsewhere(upstream, 'brief.pdf');
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     // The clone now knows the branch — this stands in for the one fetch a
@@ -467,7 +467,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     await pushedElsewhere(upstream, 'brief.pdf');
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     // Nothing has refreshed this clone since the branch was pushed.
@@ -505,7 +505,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     }
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
       new PrunedMidCall(),
     );
@@ -567,7 +567,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'move it']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/moved']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary, paths } = await bothViews(git, 'alice/moved');
 
     expect(summary).toEqual(['GTM/note.md<=Engineering/note.md']);
@@ -593,7 +593,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'mixed']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/mixed']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary } = await bothViews(git, 'alice/mixed');
     expect(summary).toEqual(detail);
     expect(summary).toContain('new-home.md<=old-home.md');
@@ -610,7 +610,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'config + folder']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/config']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary, paths } = await bothViews(git, 'alice/config');
     expect(summary).toEqual(['Reports/q3.md<=']);
     expect(summary).toEqual(detail);
@@ -633,7 +633,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'emptied']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/emptied']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary } = await bothViews(git, 'alice/emptied');
     // `withoutPlaceholderRename` runs on both sides, so neither reports a
     // rename onto `.gitkeep` and neither loses the removed file.

package/src/modules/{workflow → version-control}/git/__tests__/git.service.changedPathsMemo.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
 import { WorkspaceMutex } from '../../../kb-fs/mutex.js';
 
@@ -93,7 +93,7 @@ describe('a change request is diffed once per pair of commits', () => {
     } as unknown as WorkspaceService;
     svc = new GitService(
       workspace,
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext({ branchModel: { defaultBranch: 'main', protectedBranches: ['main'] } }),
       new WorkspaceMutex(),
     );

package/src/modules/{workflow → version-control}/git/__tests__/git.service.commitChanges.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
 
 /**
@@ -49,11 +49,11 @@ function stubWorkspaceService(workspaceId: string, workspaceDir: string): Worksp
   } as unknown as WorkspaceService;
 }
 
-function makeValidator(): WorkflowHooks {
+function makeValidator(): VersionControlHooks {
   const report = { ok: true, mustFix: [], warnings: [], rawOutput: '' };
   // A clean-report commit-validation hook — the seam GitService consults
   // where it used to call the injected validator.
-  const hooks = new WorkflowHooks();
+  const hooks = new VersionControlHooks();
   hooks.onCommitValidation(vi.fn(async () => report));
   return hooks;
 }

package/src/modules/{workflow → version-control}/git/__tests__/git.service.commitFile.strayPath.test.ts

@@ -7,9 +7,9 @@ import path from 'node:path';
 import os from 'node:os';
 import type { AuthUser } from '@bevel-software/platform-shared';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
-import { WorkflowValidationError } from '../../../../shared/domain-errors.js';
+import { VersionControlValidationError } from '../../../../shared/domain-errors.js';
 
 /**
  * `commitFile` on a path whose bytes sit BESIDE the repository.
@@ -87,14 +87,14 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('throws instead of returning null when the file exists at the workspace root and not in the clone', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     // The prefix-less write the agent made: beside the clone, not inside it.
     await fs.mkdir(path.join(workspaceDir, 'KnowledgeBase/Reviews'), { recursive: true });
     await fs.writeFile(path.join(workspaceDir, 'KnowledgeBase/Reviews/PR-12.html'), '<p>review</p>');
     const headBefore = await runGit(repo, ['rev-parse', 'HEAD']);
 
     const attempt = svc.commitFile(workspaceId, USER, 'KnowledgeBase/Reviews/PR-12.html');
-    await expect(attempt).rejects.toBeInstanceOf(WorkflowValidationError);
+    await expect(attempt).rejects.toBeInstanceOf(VersionControlValidationError);
     await expect(attempt).rejects.toThrow('"knowledge-base/KnowledgeBase/Reviews/PR-12.html"');
 
     // Nothing landed, and the stray is left where it is for someone to recover.
@@ -104,19 +104,19 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('still returns null for a clean, committed path (the honest no-op)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/A.md`)).toBeNull();
   });
 
   it('still returns null for a path that exists nowhere (a queued re-apply of a committed deletion)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/Gone.md`)).toBeNull();
   });
 
   it('still returns null for a repo-relative path that is clean inside the clone (the form internal callers pass)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, 'Knowledge/A.md')).toBeNull();
   });
 
@@ -125,7 +125,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
     // a repo-relative caller's no-op stays honest whatever else sits beside
     // the clone under the same name.
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     await fs.mkdir(path.join(workspaceDir, 'Knowledge'), { recursive: true });
     await fs.writeFile(path.join(workspaceDir, 'Knowledge/A.md'), 'a copy beside the clone\n');
     expect(await svc.commitFile(workspaceId, USER, 'Knowledge/A.md')).toBeNull();
@@ -138,7 +138,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
     // toggles read-only, so the stat below still succeeds): nothing to prove.
     if (process.getuid?.() === 0 || process.platform === 'win32') return;
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     const strayDir = path.join(workspaceDir, 'KnowledgeBase');
     await fs.mkdir(strayDir, { recursive: true });
     await fs.writeFile(path.join(strayDir, 'PR-12.html'), 'x');
@@ -153,7 +153,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('still commits a prefixed path inside the clone', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     await fs.writeFile(path.join(repo, 'Knowledge/B.md'), 'b\n');
     const committed = await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/B.md`);
     expect(committed).not.toBeNull();

package/src/modules/{workflow → version-control}/git/__tests__/git.service.commitFile.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
 
 /**
@@ -69,12 +69,12 @@ function stubWorkspaceService(workspaceId: string, workspaceDir: string): Worksp
   } as unknown as WorkspaceService;
 }
 
-function makeValidator(): { hooks: WorkflowHooks; runValidation: ReturnType<typeof vi.fn> } {
+function makeValidator(): { hooks: VersionControlHooks; runValidation: ReturnType<typeof vi.fn> } {
   const report = { ok: true, mustFix: [], warnings: [], rawOutput: '' };
   const runValidation = vi.fn(async () => report);
   // Registered as a commit-validation hook — the seam GitService consults
   // where it used to call the injected validator.
-  const hooks = new WorkflowHooks();
+  const hooks = new VersionControlHooks();
   hooks.onCommitValidation(() => runValidation());
   return { hooks, runValidation };
 }

package/src/modules/{workflow → version-control}/git/__tests__/git.service.createBranch.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
 
 const execFileAsync = promisify(execFile);
@@ -90,7 +90,7 @@ describe('GitService.createBranch', () => {
     const { upstream } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -133,7 +133,7 @@ describe('GitService.createBranch', () => {
     const repo = path.join(root, workspaceId, 'knowledge-base');
     const svc = new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 

package/src/modules/{workflow → version-control}/git/__tests__/git.service.deleteBranch.test.ts

@@ -7,14 +7,14 @@ import path from 'node:path';
 import os from 'node:os';
 import type { AuthUser } from '@bevel-software/platform-shared';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import type { IAccessControl } from '../../../access/access-control.interface.js';
 import { GitService } from '../git.service.js';
 import {
   BranchAuthorshipError,
   BranchDeleteRefusedError,
   ProtectedBranchError,
-  WorkflowValidationError,
+  VersionControlValidationError,
 } from '../../../../shared/domain-errors.js';
 
 const execFileAsync = promisify(execFile);
@@ -160,7 +160,7 @@ describe('GitService.deleteBranch — authorship + remote delete', () => {
   function makeService(): GitService {
     return new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
   }
@@ -276,7 +276,7 @@ describe('GitService.deleteBranch — authorship + remote delete', () => {
     const svc = makeService();
     await expect(
       svc.deleteBranch(workspaceId, 'alice/my-draft', ALICE),
-    ).rejects.toBeInstanceOf(WorkflowValidationError);
+    ).rejects.toBeInstanceOf(VersionControlValidationError);
   });
 
   it('onlyIfNoRemote: true bypasses the authorship check (orphan-tidy-up path stays open)', async () => {
@@ -305,7 +305,7 @@ describe('GitService.deleteBranch — authorship + remote delete', () => {
 
     await expect(
       svc.deleteBranch(workspaceId, 'alice/my-draft', ALICE, { onlyIfNoRemote: true }),
-    ).rejects.toBeInstanceOf(WorkflowValidationError);
+    ).rejects.toBeInstanceOf(VersionControlValidationError);
   });
 
   // Admin-can-delete: when the user is in the `Admin` role per `roles.yaml`
@@ -315,7 +315,7 @@ describe('GitService.deleteBranch — authorship + remote delete', () => {
   function makeServiceWithAccess(ac: IAccessControl): GitService {
     return new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
       undefined,
       ac,
@@ -391,7 +391,7 @@ describe('GitService — branch state for a checked delete', () => {
   function makeService(): GitService {
     return new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
   }

package/src/modules/{workflow → version-control}/git/__tests__/git.service.diffFileAtCommit.test.ts

@@ -6,9 +6,9 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
-import { WorkflowValidationError } from '../../../../shared/domain-errors.js';
+import { VersionControlValidationError } from '../../../../shared/domain-errors.js';
 
 const execFileAsync = promisify(execFile);
 const PROCESS_MAP_DIR = 'knowledge-base';
@@ -108,7 +108,7 @@ describe('GitService.diffFileAtCommit', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -125,7 +125,7 @@ describe('GitService.diffFileAtCommit', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -141,7 +141,7 @@ describe('GitService.diffFileAtCommit', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -157,7 +157,7 @@ describe('GitService.diffFileAtCommit', () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -170,13 +170,13 @@ describe('GitService.diffFileAtCommit', () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
     await expect(
       svc.diffFileAtCommit(workspaceId, '../etc/passwd', 'abcdef1'),
-    ).rejects.toBeInstanceOf(WorkflowValidationError);
+    ).rejects.toBeInstanceOf(VersionControlValidationError);
   });
 
   // Regression: pathspec literal handling. `git show <sha> -- '[New] memo.md'`
@@ -187,7 +187,7 @@ describe('GitService.diffFileAtCommit', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     await runGit(repo, ['commit', '--allow-empty', '-m', 'init']);

package/src/modules/{workflow → version-control}/git/__tests__/git.service.diffFileBetweenBranches.test.ts

@@ -6,9 +6,9 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
-import { WorkflowValidationError, BranchNameError } from '../../../../shared/domain-errors.js';
+import { VersionControlValidationError, BranchNameError } from '../../../../shared/domain-errors.js';
 import { GitRunError, type IGitRunner } from '../../../../shared/git.contract.js';
 import { NodeGitRunner } from '../node-git-runner.js';
 
@@ -101,7 +101,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -121,7 +121,7 @@ describe('GitService.diffFileBetweenBranches', () => {
 
   it('asks the caller\'s verdict at the two commits served, before the path is described at either', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext());
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext());
     await commitFile(repo, 'Knowledge/Foo.md', 'line one\n', 'base');
     await commitFile(repo, 'Docs/a.md', 'a\n', 'a folder');
     const base = (await execFileAsync('git', ['rev-parse', 'HEAD'], { cwd: repo })).stdout.trim();
@@ -141,7 +141,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     // A folder the caller may not read is refused as unreadable, never as a folder.
     const refuse = async (s: unknown): Promise<void> => {
       asked.push(s);
-      throw new WorkflowValidationError('not yours to read');
+      throw new VersionControlValidationError('not yours to read');
     };
     await expect(svc.diffFileBetweenBranches(workspaceId, 'Docs', 'current-company-state', 'alice/edit-foo', refuse)).rejects.toThrow(/not yours to read/);
     expect(asked).toEqual([sides, sides]);
@@ -165,7 +165,7 @@ describe('GitService.diffFileBetweenBranches', () => {
         return inner.run(cwd, args, opts as never);
       },
     } as unknown as IGitRunner;
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext(), undefined, null, gitRunner);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext(), undefined, null, gitRunner);
     const asked: unknown[] = [];
     const authorize = async (s: unknown): Promise<void> => { asked.push(s); };
     for (const f of [
@@ -186,7 +186,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -208,7 +208,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -230,7 +230,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -272,7 +272,7 @@ describe('GitService.diffFileBetweenBranches', () => {
 
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -297,7 +297,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -322,7 +322,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -347,7 +347,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -370,7 +370,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -392,7 +392,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -417,7 +417,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -428,7 +428,7 @@ describe('GitService.diffFileBetweenBranches', () => {
         'current-company-state',
         'current-company-state',
       ),
-    ).rejects.toBeInstanceOf(WorkflowValidationError);
+    ).rejects.toBeInstanceOf(VersionControlValidationError);
   });
 
   it('rejects an unknown branch', async () => {
@@ -436,7 +436,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     await commitFile(repo, 'Knowledge/Foo.md', 'base\n', 'base');
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -447,14 +447,14 @@ describe('GitService.diffFileBetweenBranches', () => {
         'current-company-state',
         'does-not-exist',
       ),
-    ).rejects.toBeInstanceOf(WorkflowValidationError);
+    ).rejects.toBeInstanceOf(VersionControlValidationError);
   });
 
   it('rejects a path-traversal attempt', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -465,14 +465,14 @@ describe('GitService.diffFileBetweenBranches', () => {
         'current-company-state',
         'target-company-state',
       ),
-    ).rejects.toBeInstanceOf(WorkflowValidationError);
+    ).rejects.toBeInstanceOf(VersionControlValidationError);
   });
 
   it('rejects a branch name with shell metacharacters', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -494,7 +494,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     await runGit(repo, ['commit', '--allow-empty', '-m', 'init']);