@bevel-software/platform-core-backend 0.33.0 → 0.34.0

package/src/shared/path-order.ts

@@ -1,12 +1,25 @@
 /**
- * The ONE ordering of repository paths: component by component, each
- * component by `localeCompare`, a shorter path before its extensions. It is
- * exactly the order a directory walk that sorts each level's entries visits
- * them in — so a consumer that must agree with the walk on "first by path"
- * (plugin discovery keeps the first of two folders sharing a slug; principal
- * synthesis must pick the same one) sorts with this and nothing else. A
- * whole-string `localeCompare` does not agree: it weighs the separator
- * against the next character (`a-b/x` before `a/b/x`), the walk never does.
+ * The TWO orderings of repository paths, and which consumer takes which:
+ *
+ * - {@link comparePathComponents} is the platform's own walk order — component
+ *   by component, each by `localeCompare`, a shorter path before its
+ *   extensions — exactly the order a directory walk that sorts each level's
+ *   entries visits them in. A consumer that must agree with THAT walk on
+ *   "first by path" (plugin discovery keeps the first of two folders sharing a
+ *   slug; principal synthesis must pick the same one) sorts with it and
+ *   nothing else.
+ * - {@link compareSearchPaths} is ripgrep's walk order (`--sort path`):
+ *   component by component, each by its UTF-8 bytes. A `grep` answer is
+ *   assembled from several ripgrep runs and a document pass, and it has to
+ *   sort as ripgrep itself sorts, or the search could not tell which files a
+ *   run has passed. The two orders differ where collation and bytes do
+ *   (`B.md` sorts before `a.md` by bytes, after it by collation), which is why
+ *   a grep answer and the explorer tree can list two siblings the other way
+ *   round. Nothing but the search uses it.
+ *
+ * Both agree on the shape: a whole-string compare does not — it weighs the
+ * separator against the next character (`a-b/x` before `a/b/x`), a walk never
+ * does.
  *
  * TOTAL over distinct paths: two components the collation cannot tell apart
  * (a precomposed `é` and its decomposed spelling) fall through to code-unit
@@ -31,3 +44,19 @@ function compareComponent(a: string, b: string): number {
   if (order !== 0) return order;
   return a < b ? -1 : a > b ? 1 : 0;
 }
+
+/**
+ * The order every `grep` search answers in — ripgrep's: path component by
+ * component, each compared by its UTF-8 bytes, so a folder's files come before
+ * a sibling file whose name extends the folder's. See the note above on how it
+ * differs from {@link comparePathComponents}, and why the search needs it.
+ */
+export function compareSearchPaths(a: string, b: string): number {
+  const as = a.split('/');
+  const bs = b.split('/');
+  for (let i = 0; i < Math.min(as.length, bs.length); i++) {
+    const c = Buffer.compare(Buffer.from(as[i]!, 'utf8'), Buffer.from(bs[i]!, 'utf8'));
+    if (c !== 0) return c;
+  }
+  return as.length - bs.length;
+}

package/starter-packs/engineering/Plugins/engineering-starter/access.md

@@ -9,7 +9,7 @@ read:
 # manifest. A starter plugin is for the whole team, so everyone may use it
 # and admins change it. To narrow it, replace `everyone` under `read:` with a
 # role from roles.yaml (as `role/<Name>`, so a group of the same name can
-# never stand in for it), a group from groups.yaml, or a person as
+# never stand in for it), a group as `group/<Name>`, or a person as
 # `Name <email>`. Keep this block pure YAML; explanations go in `#` lines.
 read:
   - everyone

package/starter-packs/general/Plugins/general-starter/access.md

@@ -9,7 +9,7 @@ read:
 # manifest. A starter plugin is for the whole team, so everyone may use it
 # and admins change it. To narrow it, replace `everyone` under `read:` with a
 # role from roles.yaml (as `role/<Name>`, so a group of the same name can
-# never stand in for it), a group from groups.yaml, or a person as
+# never stand in for it), a group as `group/<Name>`, or a person as
 # `Name <email>`. Keep this block pure YAML; explanations go in `#` lines.
 read:
   - everyone

package/starter-packs/operations/Plugins/operations-starter/access.md

@@ -9,7 +9,7 @@ read:
 # manifest. A starter plugin is for the whole team, so everyone may use it
 # and admins change it. To narrow it, replace `everyone` under `read:` with a
 # role from roles.yaml (as `role/<Name>`, so a group of the same name can
-# never stand in for it), a group from groups.yaml, or a person as
+# never stand in for it), a group as `group/<Name>`, or a person as
 # `Name <email>`. Keep this block pure YAML; explanations go in `#` lines.
 read:
   - everyone

package/starter-packs/sales/Plugins/sales-starter/access.md

@@ -9,7 +9,7 @@ read:
 # manifest. A starter plugin is for the whole team, so everyone may use it
 # and admins change it. To narrow it, replace `everyone` under `read:` with a
 # role from roles.yaml (as `role/<Name>`, so a group of the same name can
-# never stand in for it), a group from groups.yaml, or a person as
+# never stand in for it), a group as `group/<Name>`, or a person as
 # `Name <email>`. Keep this block pure YAML; explanations go in `#` lines.
 read:
   - everyone

package/starter-packs/support/Plugins/support-starter/access.md

@@ -9,7 +9,7 @@ read:
 # manifest. A starter plugin is for the whole team, so everyone may use it
 # and admins change it. To narrow it, replace `everyone` under `read:` with a
 # role from roles.yaml (as `role/<Name>`, so a group of the same name can
-# never stand in for it), a group from groups.yaml, or a person as
+# never stand in for it), a group as `group/<Name>`, or a person as
 # `Name <email>`. Keep this block pure YAML; explanations go in `#` lines.
 read:
   - everyone

package/dist/modules/workspace/bounded-matcher.d.ts

@@ -1,73 +0,0 @@
-import { type IPatternMatcher, type IPatternSearch } from './pattern-matcher.contract.js';
-/**
- * The one place a CALLER'S regular expression is run (see
- * {@link IPatternMatcher}).
- *
- * The pattern never runs on the request thread: the lines go to a worker, the
- * worker answers which of them match, and a search whose matching outlives its
- * budget has its worker terminated (which interrupts even a regex
- * mid-backtrack) and is answered with {@link PatternTooExpensiveError}.
- * Nothing partial is returned: a search that blew its budget answers the 400
- * alone.
- *
- * The semantics are the engine's own — the worker compiles the same source with
- * the same flags and calls `test` on each line — so a pattern within budget
- * matches exactly the lines it always did.
- *
- * The pool is this instance's own (its mechanics are the shared
- * {@link WorkerPool}; the regex worker below is this kind's): the composition
- * root builds one per graph and closes it when the graph stops, so no worker
- * outlives what it served.
- */
-export interface WorkerPatternMatcherOptions {
-    /** Matching time one search may spend, summed over every file it searches. Default 5 s. */
-    budgetMs?: number;
-    /** Workers kept for searches at once; a search past this waits for one to free up. Default 4. */
-    poolMax?: number;
-    /**
-     * Searches that may wait for a worker at once. A waiting search holds the
-     * lines it was handed, so the queue is capped: past it a search is refused
-     * with a 503 rather than piling file contents up in memory. Default 16.
-     */
-    maxWaiting?: number;
-    /**
-     * Longest pattern accepted. The pattern is compiled on the request thread
-     * (that is how a syntax error earns its 400 there), so its length is what
-     * bounds that. Default 1000.
-     */
-    maxPatternLength?: number;
-    /**
-     * Characters handed to the worker in one message. Posting a message copies
-     * it on the request thread, so a large file goes over in pieces of about
-     * this size rather than in one copy that would stall every other request.
-     * A single line longer than this is not posted at all: it is written into
-     * shared memory this many characters at a time, yielding between pieces,
-     * and the worker reads it from there. Default 1 MB.
-     */
-    batchChars?: number;
-    /**
-     * Lines handed to the worker in one message. Each line is an entry the
-     * copy has to walk whatever its length, so a file of empty lines is bounded
-     * by this, not by `batchChars`. Default 10,000.
-     */
-    batchLines?: number;
-}
-export declare class WorkerPatternMatcher implements IPatternMatcher {
-    private readonly budgetMs;
-    private readonly maxPatternLength;
-    private readonly batchChars;
-    private readonly batchLines;
-    private readonly pool;
-    private readonly lease;
-    constructor(opts?: WorkerPatternMatcherOptions);
-    search(source: string, flags: string): IPatternSearch;
-    close(): Promise<void>;
-    /**
-     * Where the batch starting at `from` ends: about `batchChars` characters on,
-     * at most `batchLines` lines on, and never empty. A batch of one line past
-     * `batchChars` is handed over through shared memory instead (see
-     * {@link BoundedSearch.matchBatch}).
-     */
-    private batchEnd;
-}
-//# sourceMappingURL=bounded-matcher.d.ts.map

package/dist/modules/workspace/bounded-matcher.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"bounded-matcher.d.ts","sourceRoot":"","sources":["../../../src/modules/workspace/bounded-matcher.ts"],"names":[],"mappings":"AAGA,OAAO,EACL,KAAK,eAAe,EACpB,KAAK,cAAc,EAGpB,MAAM,+BAA+B,CAAC;AAEvC;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,WAAW,2BAA2B;IAC1C,2FAA2F;IAC3F,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,iGAAiG;IACjG,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB;;;;OAIG;IACH,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB;;;;OAIG;IACH,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B;;;;;;;OAOG;IACH,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB;;;;OAIG;IACH,UAAU,CAAC,EAAE,MAAM,CAAC;CACrB;AA4CD,qBAAa,oBAAqB,YAAW,eAAe;IAC1D,OAAO,CAAC,QAAQ,CAAC,QAAQ,CAAS;IAClC,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CAAS;IAC1C,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAS;IACpC,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAS;IACpC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAa;IAClC,OAAO,CAAC,QAAQ,CAAC,KAAK,CAAQ;gBAElB,IAAI,GAAE,2BAAgC;IAwBlD,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,cAAc;IAgBrD,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAItB;;;;;OAKG;IACH,OAAO,CAAC,QAAQ;CAOjB"}

package/dist/modules/workspace/bounded-matcher.js

@@ -1,200 +0,0 @@
-import { Worker } from 'node:worker_threads';
-import { exchange, MAX_TIMER_MS, sizingOption, WorkerPool } from './worker-pool.js';
-import { ToolError } from '../tool-helpers/index.js';
-import { PatternTooExpensiveError, SearchBusyError, } from './pattern-matcher.contract.js';
-/**
- * Slack on top of the remaining budget before a batch is given up on: the
- * budget counts only the worker's own matching time, so handing the lines over
- * and the answer back must not be what trips it.
- */
-const TRANSFER_GRACE_MS = 250;
-/** The worker: compiles the pattern it is handed and answers the indices of the lines it matches. */
-const WORKER_SOURCE = `
-const { parentPort } = require('node:worker_threads');
-const { performance } = require('node:perf_hooks');
-let cached = { key: null, re: null };
-parentPort.on('message', ({ source, flags, lines, shared, limit }) => {
-  try {
-    // One line too long to post, written into shared memory as raw UTF-16 code units.
-    if (shared) lines = [Buffer.from(shared).toString('utf16le')];
-    const key = flags + '/' + source;
-    if (cached.key !== key) cached = { key, re: new RegExp(source, flags) };
-    const re = cached.re;
-    const started = performance.now();
-    const hits = [];
-    for (let i = 0; i < lines.length && hits.length < limit; i++) {
-      re.lastIndex = 0;
-      if (re.test(lines[i])) hits.push(i);
-    }
-    parentPort.postMessage({ hits, elapsed: performance.now() - started });
-  } catch (err) {
-    parentPort.postMessage({ error: String(err && err.message ? err.message : err) });
-  }
-});
-`;
-export class WorkerPatternMatcher {
-    budgetMs;
-    maxPatternLength;
-    batchChars;
-    batchLines;
-    pool;
-    lease;
-    constructor(opts = {}) {
-        this.budgetMs = option('budgetMs', opts.budgetMs ?? 5_000, 1, MAX_TIMER_MS - TRANSFER_GRACE_MS);
-        this.pool = new WorkerPool(() => new Worker(WORKER_SOURCE, { eval: true }), {
-            // A pool of none would leave every search waiting for a worker that never comes.
-            poolMax: option('poolMax', opts.poolMax ?? 4, 1),
-            // No queue at all is allowed: every search past the pool is refused busy.
-            maxWaiting: option('maxWaiting', opts.maxWaiting ?? 16, 0),
-        }, () => new SearchBusyError());
-        this.maxPatternLength = option('maxPatternLength', opts.maxPatternLength ?? 1_000, 1);
-        this.batchChars = option('batchChars', opts.batchChars ?? 1_000_000, 1);
-        this.batchLines = option('batchLines', opts.batchLines ?? 10_000, 1);
-        this.lease = {
-            acquire: () => this.pool.acquire(),
-            release: (w) => this.pool.release(w),
-            discard: (w) => this.pool.discard(w),
-            batchEnd: (lines, from) => this.batchEnd(lines, from),
-            batchChars: this.batchChars,
-        };
-    }
-    search(source, flags) {
-        if (source.length > this.maxPatternLength) {
-            throw new ToolError(`Pattern too long: ${source.length} characters, and a search pattern may have at most ${this.maxPatternLength}.`, 400, { code: 'pattern_too_long' });
-        }
-        try {
-            new RegExp(source, flags);
-        }
-        catch (err) {
-            throw new ToolError(`Invalid regex: ${err.message}`, 400);
-        }
-        return new BoundedSearch(this.lease, source, flags, this.budgetMs);
-    }
-    close() {
-        return this.pool.close();
-    }
-    /**
-     * Where the batch starting at `from` ends: about `batchChars` characters on,
-     * at most `batchLines` lines on, and never empty. A batch of one line past
-     * `batchChars` is handed over through shared memory instead (see
-     * {@link BoundedSearch.matchBatch}).
-     */
-    batchEnd(lines, from) {
-        let to = from;
-        let chars = 0;
-        const last = Math.min(lines.length, from + this.batchLines);
-        while (to < last && (to === from || chars + lines[to].length <= this.batchChars))
-            chars += lines[to++].length;
-        return to;
-    }
-}
-/** One search: a caller's pattern, matched off the event loop under one budget. */
-class BoundedSearch {
-    pool;
-    source;
-    flags;
-    budgetMs;
-    spentMs = 0;
-    constructor(pool, source, flags, budgetMs) {
-        this.pool = pool;
-        this.source = source;
-        this.flags = flags;
-        this.budgetMs = budgetMs;
-    }
-    async matchingLines(lines, limit) {
-        if (limit <= 0 || lines.length === 0)
-            return [];
-        if (this.spentMs >= this.budgetMs)
-            throw new PatternTooExpensiveError(this.source, this.budgetMs);
-        const w = await this.pool.acquire();
-        const hits = [];
-        try {
-            for (let from = 0; from < lines.length && hits.length < limit;) {
-                const to = this.pool.batchEnd(lines, from);
-                for (const i of await this.matchBatch(w, lines.slice(from, to), limit - hits.length))
-                    hits.push(from + i);
-                from = to;
-            }
-        }
-        catch (err) {
-            // Terminating is what stops a regex mid-backtrack; the pool replaces it.
-            this.pool.discard(w);
-            throw err;
-        }
-        this.pool.release(w);
-        return hits;
-    }
-    /**
-     * One handoff to the worker, charged to this search's budget. No handoff
-     * copies more than `batchChars` characters on the request thread at once: a
-     * line longer than that goes over in shared memory, not in the message.
-     */
-    async matchBatch(w, lines, limit) {
-        if (this.spentMs >= this.budgetMs)
-            throw new PatternTooExpensiveError(this.source, this.budgetMs);
-        const oversized = lines.length === 1 && lines[0].length > this.pool.batchChars;
-        const payload = oversized ? { shared: await shareLine(w, lines[0], this.pool.batchChars) } : { lines };
-        const remaining = this.budgetMs - this.spentMs;
-        const reply = await run(w, { source: this.source, flags: this.flags, ...payload, limit }, remaining + TRANSFER_GRACE_MS);
-        if (reply === 'timeout') {
-            this.spentMs = this.budgetMs;
-            throw new PatternTooExpensiveError(this.source, this.budgetMs);
-        }
-        if ('error' in reply)
-            throw new ToolError(`Invalid regex: ${reply.error}`, 400);
-        this.spentMs += reply.elapsed;
-        if (this.spentMs > this.budgetMs)
-            throw new PatternTooExpensiveError(this.source, this.budgetMs);
-        return reply.hits;
-    }
-}
-/**
- * A line as raw UTF-16 code units in shared memory, which a message hands the
- * worker without copying. It is written `chunkChars` at a time with a turn of
- * the event loop between, so a line of any length never holds the request
- * thread for longer than one chunk. Raw code units keep the line exact, lone
- * surrogates included.
- *
- * The worker it is meant for can be terminated by `close()` during those turns,
- * before {@link run} listens for its exit; a message posted to it then would
- * never be answered. So its exit is watched here too: writing stops and the
- * search is answered busy, as one terminated under `run` is.
- */
-async function shareLine(w, line, chunkChars) {
-    let exited = false;
-    const onExit = () => {
-        exited = true;
-    };
-    w.once('exit', onExit);
-    try {
-        const shared = new SharedArrayBuffer(line.length * 2);
-        const bytes = Buffer.from(shared);
-        for (let at = 0; at < line.length && !exited; at += chunkChars) {
-            if (at > 0)
-                await new Promise((resolve) => setImmediate(resolve));
-            bytes.write(line.slice(at, at + chunkChars), at * 2, 'utf16le');
-        }
-        if (exited)
-            throw new SearchBusyError();
-        return shared;
-    }
-    finally {
-        w.off('exit', onExit);
-    }
-}
-async function run(w, message, timeoutMs) {
-    const outcome = await exchange(w, message, timeoutMs);
-    if ('reply' in outcome)
-        return outcome.reply;
-    if ('timeout' in outcome)
-        return 'timeout';
-    if ('error' in outcome)
-        throw outcome.error;
-    // Terminated under the search by `close()`: answered as busy, not left hanging until the timer.
-    throw new SearchBusyError();
-}
-/** A sizing option as given, refused at construction unless it is an integer from `min` to `max`. */
-function option(name, value, min, max = Number.MAX_SAFE_INTEGER) {
-    return sizingOption('WorkerPatternMatcher', name, value, min, max);
-}
-//# sourceMappingURL=bounded-matcher.js.map

package/dist/modules/workspace/bounded-matcher.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"bounded-matcher.js","sourceRoot":"","sources":["../../../src/modules/workspace/bounded-matcher.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAC;AAC7C,OAAO,EAAE,QAAQ,EAAE,YAAY,EAAE,YAAY,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAC;AACpF,OAAO,EAAE,SAAS,EAAE,MAAM,0BAA0B,CAAC;AACrD,OAAO,EAGL,wBAAwB,EACxB,eAAe,GAChB,MAAM,+BAA+B,CAAC;AAwDvC;;;;GAIG;AACH,MAAM,iBAAiB,GAAG,GAAG,CAAC;AAE9B,qGAAqG;AACrG,MAAM,aAAa,GAAG;;;;;;;;;;;;;;;;;;;;;;CAsBrB,CAAC;AAYF,MAAM,OAAO,oBAAoB;IACd,QAAQ,CAAS;IACjB,gBAAgB,CAAS;IACzB,UAAU,CAAS;IACnB,UAAU,CAAS;IACnB,IAAI,CAAa;IACjB,KAAK,CAAQ;IAE9B,YAAY,OAAoC,EAAE;QAChD,IAAI,CAAC,QAAQ,GAAG,MAAM,CAAC,UAAU,EAAE,IAAI,CAAC,QAAQ,IAAI,KAAK,EAAE,CAAC,EAAE,YAAY,GAAG,iBAAiB,CAAC,CAAC;QAChG,IAAI,CAAC,IAAI,GAAG,IAAI,UAAU,CACxB,GAAG,EAAE,CAAC,IAAI,MAAM,CAAC,aAAa,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,EAC/C;YACE,iFAAiF;YACjF,OAAO,EAAE,MAAM,CAAC,SAAS,EAAE,IAAI,CAAC,OAAO,IAAI,CAAC,EAAE,CAAC,CAAC;YAChD,0EAA0E;YAC1E,UAAU,EAAE,MAAM,CAAC,YAAY,EAAE,IAAI,CAAC,UAAU,IAAI,EAAE,EAAE,CAAC,CAAC;SAC3D,EACD,GAAG,EAAE,CAAC,IAAI,eAAe,EAAE,CAC5B,CAAC;QACF,IAAI,CAAC,gBAAgB,GAAG,MAAM,CAAC,kBAAkB,EAAE,IAAI,CAAC,gBAAgB,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC;QACtF,IAAI,CAAC,UAAU,GAAG,MAAM,CAAC,YAAY,EAAE,IAAI,CAAC,UAAU,IAAI,SAAS,EAAE,CAAC,CAAC,CAAC;QACxE,IAAI,CAAC,UAAU,GAAG,MAAM,CAAC,YAAY,EAAE,IAAI,CAAC,UAAU,IAAI,MAAM,EAAE,CAAC,CAAC,CAAC;QACrE,IAAI,CAAC,KAAK,GAAG;YACX,OAAO,EAAE,GAAG,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE;YAClC,OAAO,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;YACpC,OAAO,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;YACpC,QAAQ,EAAE,CAAC,KAAK,EAAE,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,KAAK,EAAE,IAAI,CAAC;YACrD,UAAU,EAAE,IAAI,CAAC,UAAU;SAC5B,CAAC;IACJ,CAAC;IAED,MAAM,CAAC,MAAc,EAAE,KAAa;QAClC,IAAI,MAAM,CAAC,MAAM,GAAG,IAAI,CAAC,gBAAgB,EAAE,CAAC;YAC1C,MAAM,IAAI,SAAS,CACjB,qBAAqB,MAAM,CAAC,MAAM,sDAAsD,IAAI,CAAC,gBAAgB,GAAG,EAChH,GAAG,EACH,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAC7B,CAAC;QACJ,CAAC;QACD,IAAI,CAAC;YACH,IAAI,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;QAC5B,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,MAAM,IAAI,SAAS,CAAC,kBAAmB,GAAa,CAAC,OAAO,EAAE,EAAE,GAAG,CAAC,CAAC;QACvE,CAAC;QACD,OAAO,IAAI,aAAa,CAAC,IAAI,CAAC,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAC;IACrE,CAAC;IAED,KAAK;QACH,OAAO,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,CAAC;IAC3B,CAAC;IAED;;;;;OAKG;IACK,QAAQ,CAAC,KAAe,EAAE,IAAY;QAC5C,IAAI,EAAE,GAAG,IAAI,CAAC;QACd,IAAI,KAAK,GAAG,CAAC,CAAC;QACd,MAAM,IAAI,GAAG,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC,MAAM,EAAE,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC;QAC5D,OAAO,EAAE,GAAG,IAAI,IAAI,CAAC,EAAE,KAAK,IAAI,IAAI,KAAK,GAAG,KAAK,CAAC,EAAE,CAAE,CAAC,MAAM,IAAI,IAAI,CAAC,UAAU,CAAC;YAAE,KAAK,IAAI,KAAK,CAAC,EAAE,EAAE,CAAE,CAAC,MAAM,CAAC;QAChH,OAAO,EAAE,CAAC;IACZ,CAAC;CACF;AAED,mFAAmF;AACnF,MAAM,aAAa;IAIE;IACA;IACA;IACA;IANX,OAAO,GAAG,CAAC,CAAC;IAEpB,YACmB,IAAW,EACX,MAAc,EACd,KAAa,EACb,QAAgB;QAHhB,SAAI,GAAJ,IAAI,CAAO;QACX,WAAM,GAAN,MAAM,CAAQ;QACd,UAAK,GAAL,KAAK,CAAQ;QACb,aAAQ,GAAR,QAAQ,CAAQ;IAChC,CAAC;IAEJ,KAAK,CAAC,aAAa,CAAC,KAAe,EAAE,KAAa;QAChD,IAAI,KAAK,IAAI,CAAC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,EAAE,CAAC;QAChD,IAAI,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,QAAQ;YAAE,MAAM,IAAI,wBAAwB,CAAC,IAAI,CAAC,MAAM,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAC;QAClG,MAAM,CAAC,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC;QACpC,MAAM,IAAI,GAAa,EAAE,CAAC;QAC1B,IAAI,CAAC;YACH,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,GAAG,KAAK,CAAC,MAAM,IAAI,IAAI,CAAC,MAAM,GAAG,KAAK,GAAI,CAAC;gBAChE,MAAM,EAAE,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC;gBAC3C,KAAK,MAAM,CAAC,IAAI,MAAM,IAAI,CAAC,UAAU,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,CAAC,EAAE,KAAK,GAAG,IAAI,CAAC,MAAM,CAAC;oBAAE,IAAI,CAAC,IAAI,CAAC,IAAI,GAAG,CAAC,CAAC,CAAC;gBAC1G,IAAI,GAAG,EAAE,CAAC;YACZ,CAAC;QACH,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,yEAAyE;YACzE,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC;YACrB,MAAM,GAAG,CAAC;QACZ,CAAC;QACD,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC;QACrB,OAAO,IAAI,CAAC;IACd,CAAC;IAED;;;;OAIG;IACK,KAAK,CAAC,UAAU,CAAC,CAAS,EAAE,KAAe,EAAE,KAAa;QAChE,IAAI,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,QAAQ;YAAE,MAAM,IAAI,wBAAwB,CAAC,IAAI,CAAC,MAAM,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAC;QAClG,MAAM,SAAS,GAAG,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,KAAK,CAAC,CAAC,CAAE,CAAC,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC;QAChF,MAAM,OAAO,GAAG,SAAS,CAAC,CAAC,CAAC,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC,CAAE,EAAE,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,EAAE,CAAC;QACxG,MAAM,SAAS,GAAG,IAAI,CAAC,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC;QAC/C,MAAM,KAAK,GAAG,MAAM,GAAG,CAAC,CAAC,EAAE,EAAE,MAAM,EAAE,IAAI,CAAC,MAAM,EAAE,KAAK,EAAE,IAAI,CAAC,KAAK,EAAE,GAAG,OAAO,EAAE,KAAK,EAAE,EAAE,SAAS,GAAG,iBAAiB,CAAC,CAAC;QACzH,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;YACxB,IAAI,CAAC,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC;YAC7B,MAAM,IAAI,wBAAwB,CAAC,IAAI,CAAC,MAAM,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAC;QACjE,CAAC;QACD,IAAI,OAAO,IAAI,KAAK;YAAE,MAAM,IAAI,SAAS,CAAC,kBAAkB,KAAK,CAAC,KAAK,EAAE,EAAE,GAAG,CAAC,CAAC;QAChF,IAAI,CAAC,OAAO,IAAI,KAAK,CAAC,OAAO,CAAC;QAC9B,IAAI,IAAI,CAAC,OAAO,GAAG,IAAI,CAAC,QAAQ;YAAE,MAAM,IAAI,wBAAwB,CAAC,IAAI,CAAC,MAAM,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAC;QACjG,OAAO,KAAK,CAAC,IAAI,CAAC;IACpB,CAAC;CACF;AAED;;;;;;;;;;;GAWG;AACH,KAAK,UAAU,SAAS,CAAC,CAAS,EAAE,IAAY,EAAE,UAAkB;IAClE,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,MAAM,MAAM,GAAG,GAAG,EAAE;QAClB,MAAM,GAAG,IAAI,CAAC;IAChB,CAAC,CAAC;IACF,CAAC,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACvB,IAAI,CAAC;QACH,MAAM,MAAM,GAAG,IAAI,iBAAiB,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;QACtD,MAAM,KAAK,GAAG,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAClC,KAAK,IAAI,EAAE,GAAG,CAAC,EAAE,EAAE,GAAG,IAAI,CAAC,MAAM,IAAI,CAAC,MAAM,EAAE,EAAE,IAAI,UAAU,EAAE,CAAC;YAC/D,IAAI,EAAE,GAAG,CAAC;gBAAE,MAAM,IAAI,OAAO,CAAO,CAAC,OAAO,EAAE,EAAE,CAAC,YAAY,CAAC,OAAO,CAAC,CAAC,CAAC;YACxE,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,EAAE,EAAE,GAAG,UAAU,CAAC,EAAE,EAAE,GAAG,CAAC,EAAE,SAAS,CAAC,CAAC;QAClE,CAAC;QACD,IAAI,MAAM;YAAE,MAAM,IAAI,eAAe,EAAE,CAAC;QACxC,OAAO,MAAM,CAAC;IAChB,CAAC;YAAS,CAAC;QACT,CAAC,CAAC,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACxB,CAAC;AACH,CAAC;AAED,KAAK,UAAU,GAAG,CAAC,CAAS,EAAE,OAAe,EAAE,SAAiB;IAC9D,MAAM,OAAO,GAAG,MAAM,QAAQ,CAAQ,CAAC,EAAE,OAAO,EAAE,SAAS,CAAC,CAAC;IAC7D,IAAI,OAAO,IAAI,OAAO;QAAE,OAAO,OAAO,CAAC,KAAK,CAAC;IAC7C,IAAI,SAAS,IAAI,OAAO;QAAE,OAAO,SAAS,CAAC;IAC3C,IAAI,OAAO,IAAI,OAAO;QAAE,MAAM,OAAO,CAAC,KAAK,CAAC;IAC5C,gGAAgG;IAChG,MAAM,IAAI,eAAe,EAAE,CAAC;AAC9B,CAAC;AAED,qGAAqG;AACrG,SAAS,MAAM,CAAC,IAAY,EAAE,KAAa,EAAE,GAAW,EAAE,GAAG,GAAG,MAAM,CAAC,gBAAgB;IACrF,OAAO,YAAY,CAAC,sBAAsB,EAAE,IAAI,EAAE,KAAK,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC;AACrE,CAAC"}

package/src/modules/workspace/__tests__/bounded-matcher.test.ts

@@ -1,213 +0,0 @@
-import { Worker } from 'node:worker_threads';
-import { afterEach, describe, expect, it, vi } from 'vitest';
-import { WorkerPatternMatcher, type WorkerPatternMatcherOptions } from '../bounded-matcher.js';
-import { PatternTooExpensiveError } from '../pattern-matcher.contract.js';
-
-/** The QA finding's pattern, and a 40-character line it backtracks on for ever. */
-const CATASTROPHIC = '^(a+)+$';
-const LONG_LINE = `${'a'.repeat(39)}!`;
-/** The ticket's per-search budget (Razvan, 2026-10-15). */
-const FIVE_SECONDS = 5_000;
-
-let matchers: WorkerPatternMatcher[] = [];
-/** A matcher of the test's own, closed after it — the defaults unless a test says otherwise. */
-function matcher(opts?: WorkerPatternMatcherOptions): WorkerPatternMatcher {
-  const m = new WorkerPatternMatcher(opts);
-  matchers.push(m);
-  return m;
-}
-afterEach(async () => {
-  await Promise.all(matchers.map((m) => m.close()));
-  matchers = [];
-});
-
-/**
- * The longest the event loop went without running a timer while `work` ran.
- * A pattern run on the loop would show the whole match time here.
- */
-async function longestStall(work: () => Promise<unknown>): Promise<number> {
-  let last = Date.now();
-  let worst = 0;
-  const tick = setInterval(() => {
-    const now = Date.now();
-    worst = Math.max(worst, now - last);
-    last = now;
-  }, 10);
-  try {
-    await work().catch(() => {});
-  } finally {
-    clearInterval(tick);
-  }
-  return Math.max(worst, Date.now() - last);
-}
-
-describe('WorkerPatternMatcher', () => {
-  it('stops a catastrophic pattern over a 40-character line with the worded 400 in its 5 s budget, and never stalls the loop', async () => {
-    expect(LONG_LINE).toHaveLength(40);
-    const started = Date.now();
-    let caught: unknown;
-    const stall = await longestStall(async () => {
-      try {
-        await matcher().search(CATASTROPHIC, '').matchingLines([LONG_LINE], 200);
-      } catch (err) {
-        caught = err;
-      }
-    });
-    const took = Date.now() - started;
-    expect(caught).toBeInstanceOf(PatternTooExpensiveError);
-    expect((caught as PatternTooExpensiveError).status).toBe(400);
-    expect((caught as Error).message).toMatch(/^Pattern too expensive: /);
-    expect((caught as Error).message).toContain('simpler pattern');
-    expect((caught as Error).message).toContain("this search's 5 s budget");
-    expect(took).toBeGreaterThanOrEqual(FIVE_SECONDS - 100);
-    expect(took).toBeLessThan(FIVE_SECONDS + 2_000);
-    expect(stall).toBeLessThan(500);
-  });
-
-  it('answers ordinary patterns with exactly the lines RegExp#test matches', async () => {
-    const m = matcher();
-    const lines = ['hello world', 'Getting started', 'aaa', 'line 42', '', 'foo|bar', 'bar baz', LONG_LINE];
-    for (const [source, flags] of [
-      ['world', ''],
-      ['^aaa$', ''],
-      ['getting started', 'i'],
-      ['[0-9]+', ''],
-      ['foo|baz', ''],
-      ['^$', ''],
-      ['a+!$', ''],
-    ] as const) {
-      const re = new RegExp(source, flags);
-      const expected = lines.flatMap((l, i) => (re.test(l) ? [i] : []));
-      expect(await m.search(source, flags).matchingLines(lines, 1000), `/${source}/${flags}`).toEqual(expected);
-    }
-  });
-
-  it('returns only the first `limit` matches', async () => {
-    expect(await matcher().search('x', '').matchingLines(['x', 'y', 'x', 'x'], 2)).toEqual([0, 2]);
-  });
-
-  it('refuses a sizing that could never serve a search when it is built, not when a search hangs on it', () => {
-    expect(() => new WorkerPatternMatcher({ poolMax: 0 })).toThrow(/poolMax must be an integer from 1 /);
-    // Past the longest delay setTimeout honours, the timer would fire after 1 ms and stop every search.
-    expect(() => new WorkerPatternMatcher({ budgetMs: 2_147_483_647 })).toThrow(/budgetMs must be an integer from 1 to 2147483397/);
-    expect(() => new WorkerPatternMatcher({ poolMax: 1.5 })).toThrow(RangeError);
-    expect(() => new WorkerPatternMatcher({ budgetMs: 0 })).toThrow(/budgetMs/);
-    expect(() => new WorkerPatternMatcher({ maxWaiting: -1 })).toThrow(/maxWaiting/);
-    expect(() => new WorkerPatternMatcher({ batchChars: Number.NaN })).toThrow(/batchChars/);
-    expect(() => new WorkerPatternMatcher({ batchLines: 0 })).toThrow(/batchLines/);
-    expect(() => matcher({ maxWaiting: 0 })).not.toThrow();
-  });
-
-  it('serves an ordinary search under the largest budget the timer can hold', async () => {
-    expect(await matcher({ budgetMs: 2_147_483_647 - 250 }).search('b', '').matchingLines(['a', 'b'], 10)).toEqual([1]);
-  });
-
-  it('refuses invalid syntax with the 400 grep always gave', () => {
-    expect(() => matcher().search('(', '')).toThrow(/^Invalid regex: /);
-  });
-
-  it('refuses a pattern too long to compile on the request thread, and accepts one at the limit', () => {
-    const m = matcher({ maxPatternLength: 10 });
-    expect(() => m.search('a'.repeat(11), '')).toThrow(/^Pattern too long: /);
-    expect(() => m.search('a'.repeat(10), '')).not.toThrow();
-  });
-
-  it('hands a large file over in batches and answers the same line numbers, up to `limit`', async () => {
-    const m = matcher({ batchChars: 100 });
-    const filler = 'x'.repeat(9);
-    const lines = Array.from({ length: 250 }, (_, i) => (i % 7 === 0 ? `hit ${i}` : filler));
-    const expected = lines.flatMap((l, i) => (l.startsWith('hit') ? [i] : []));
-    expect(expected.at(-1)! * filler.length).toBeGreaterThan(200);
-    expect(await m.search('^hit', '').matchingLines(lines, 10_000)).toEqual(expected);
-    expect(await m.search('^hit', '').matchingLines(lines, 3)).toEqual(expected.slice(0, 3));
-  });
-
-  it('caps a batch by its line count too, so a file of empty lines never goes over in one message', async () => {
-    const m = matcher({ batchLines: 100 });
-    const lines = Array.from({ length: 1_050 }, (_, i) => (i % 97 === 0 ? 'hit' : ''));
-    const expected = lines.flatMap((l, i) => (l === 'hit' ? [i] : []));
-    const posted = vi.spyOn(Worker.prototype, 'postMessage');
-    try {
-      expect(await m.search('^hit$', '').matchingLines(lines, 10_000)).toEqual(expected);
-      expect(await m.search('^$', '').matchingLines(lines, 10_000)).toHaveLength(lines.length - expected.length);
-      const postedLines = posted.mock.calls.map(([msg]) => ((msg as { lines?: string[] }).lines ?? []).length);
-      expect(postedLines.filter((n) => n > 0)).toHaveLength(2 * 11);
-      expect(Math.max(...postedLines)).toBeLessThanOrEqual(100);
-    } finally {
-      posted.mockRestore();
-    }
-  });
-
-  it('hands a line longer than one batch over in shared memory, never in a message, and matches it exactly', async () => {
-    const m = matcher({ batchChars: 100 });
-    // A lone surrogate included: the line must reach the worker code unit for code unit.
-    const long = `${'x'.repeat(1_000)}\uD800 tail ${'y'.repeat(500)}`;
-    const lines = ['short', long, 'z'.repeat(400), 'end tail'];
-    const posted = vi.spyOn(Worker.prototype, 'postMessage');
-    try {
-      for (const pattern of ['tail', '\\uD800 tail', '^x+\\uD800', 'y{500}$', '^z+$', 'nowhere']) {
-        const re = new RegExp(pattern);
-        const expected = lines.flatMap((l, i) => (re.test(l) ? [i] : []));
-        expect(await m.search(pattern, '').matchingLines(lines, 10_000)).toEqual(expected);
-      }
-      const postedChars = posted.mock.calls.map(([msg]) =>
-        ((msg as { lines?: string[] }).lines ?? []).reduce((n, l) => n + l.length, 0),
-      );
-      expect(postedChars.length).toBeGreaterThan(0);
-      expect(Math.max(...postedChars)).toBeLessThanOrEqual(100);
-    } finally {
-      posted.mockRestore();
-    }
-  });
-
-  it('refuses a search with 503 once the queue for a worker is full, rather than holding its lines', async () => {
-    const m = matcher({ budgetMs: 500, poolMax: 2, maxWaiting: 2 });
-    // Every worker held by a pattern that runs out its budget, the queue filled behind them.
-    const holding = Promise.allSettled(Array.from({ length: 2 }, () => m.search(CATASTROPHIC, '').matchingLines([LONG_LINE], 1)));
-    await new Promise((r) => setTimeout(r, 100));
-    const queued = Array.from({ length: 2 }, () => m.search('b', '').matchingLines(['b'], 1));
-    await expect(m.search('b', '').matchingLines(['b'], 1)).rejects.toMatchObject({
-      status: 503,
-      details: { code: 'search_busy' },
-    });
-    // The queued searches are served once the workers come free.
-    expect(await Promise.all(queued)).toEqual(queued.map(() => [0]));
-    expect((await holding).every((r) => r.status === 'rejected')).toBe(true);
-  });
-
-  it('stops two expensive searches at once, and a search started meanwhile still answers', async () => {
-    const m = matcher({ budgetMs: 500 });
-    const results = await Promise.allSettled([
-      m.search(CATASTROPHIC, '').matchingLines([LONG_LINE], 10),
-      m.search('(a|aa)+$', '').matchingLines([`${'a'.repeat(60)}!`], 10),
-      m.search('aaa', '').matchingLines(['xaaay'], 10),
-    ]);
-    expect(results[0]).toMatchObject({ status: 'rejected', reason: expect.any(PatternTooExpensiveError) });
-    expect(results[1]).toMatchObject({ status: 'rejected', reason: expect.any(PatternTooExpensiveError) });
-    expect(results[2]).toEqual({ status: 'fulfilled', value: [0] });
-    // The terminated workers were replaced: the pool still serves.
-    expect(await m.search('b', '').matchingLines(['a', 'b'], 10)).toEqual([1]);
-  });
-
-  it('ends its workers on close: a search running then, and one after, is answered busy', async () => {
-    const m = matcher();
-    const running = m.search(CATASTROPHIC, '').matchingLines([LONG_LINE], 1);
-    await new Promise((r) => setTimeout(r, 100));
-    const started = Date.now();
-    await m.close();
-    await expect(running).rejects.toMatchObject({ status: 503, details: { code: 'search_busy' } });
-    expect(Date.now() - started).toBeLessThan(1_000);
-    await expect(m.search('b', '').matchingLines(['b'], 1)).rejects.toMatchObject({ status: 503 });
-  });
-
-  it('answers busy at once when closed while a long line is still being written to shared memory', async () => {
-    // A line of a million characters written ten at a time: many turns of the loop to close in.
-    const m = matcher({ budgetMs: 3_000, batchChars: 10 });
-    const running = m.search('nowhere', '').matchingLines(['a'.repeat(1_000_000)], 1);
-    await new Promise((r) => setTimeout(r, 20));
-    const started = Date.now();
-    await m.close();
-    await expect(running).rejects.toMatchObject({ status: 503, details: { code: 'search_busy' } });
-    expect(Date.now() - started).toBeLessThan(1_000);
-  });
-});