@bevel-software/platform-core-backend 0.25.0 → 0.26.0

package/src/modules/workflow/agent-tools/__tests__/workflow.tools.test.ts

@@ -85,6 +85,9 @@ const externalApiKeyService = {
     t === 'bevel_key' ? { user: { id: 'user-A', email: 'e@x', name: 'N' }, tokenId: 'tok' } : null,
 } as never;
 const authService = { getUserById: async (id: string) => ({ id, email: 'e@x', name: 'N' }) } as never;
+/** A declined change request: no sha records what it proposed, so it has no head. */
+const DECLINED_CR = 21;
+
 const workspaceService = {
   getOrCreateForUser: async () => ({ id: WS }),
   getWorkspacePath: async () => '/tmp/ws',
@@ -117,12 +120,15 @@ const workflowService = {
   releaseLock: async (ws: string, branch: string, path: string) => {
     calls.push(['releaseLock', ws, branch, path]);
   },
+  // #21 is DECLINED: the service reads such a row from nothing (no sha records
+  // what it proposed), so its detail carries no head — which is what the comment
+  // tool has to anchor to. Every other number is an ordinary open request.
   getChangeRequestDetail: async (number: number) => ({
     number,
     url: `https://bevel.example.com/change-requests/${number}`,
-    headSha: 'head-1',
+    headSha: number === DECLINED_CR ? '' : 'head-1',
     approvals: [],
-    state: 'open',
+    state: number === DECLINED_CR ? 'closed' : 'open',
     title: 'T',
     base: 'main',
   }),
@@ -229,6 +235,21 @@ describe('registerWorkflowTools', () => {
     expect(commentBody.changeRequest).not.toHaveProperty('urlNote');
   });
 
+  // A comment anchors to a commit. A declined request records none — nothing
+  // durable says what it proposed, so it is read from nothing and its detail
+  // carries no head. Say so, rather than letting the service's `head sha is
+  // required` come back as a 400 about an argument the caller never passed.
+  it('post_change_request_comment says why a declined request takes no comment', async () => {
+    const base = await start();
+    const res = await post(`${base}/api/agent/tools/post_change_request_comment`, writeTok(), { number: DECLINED_CR, body: 'why was this turned down?' });
+    expect(res.status).toBe(409);
+    expect(((await res.json()) as { error: string }).error).toMatch(
+      new RegExp(`#${DECLINED_CR} is closed and has no commit to anchor a comment to`),
+    );
+    // Nothing was written: the refusal happens before the service is asked.
+    expect(calls.some((c) => c[0] === 'postComment')).toBe(false);
+  });
+
   // An agent proposes and syncs; a person merges.
   describe('merging', () => {
     it('merge_change_request is gone: its old path answers who merges now, and never merges', async () => {