@bevel-software/platform-core-backend 0.20.0 → 0.21.0

package/src/modules/workflow/agent-tools/workflow.tools.ts

@@ -1,10 +1,10 @@
 import type { Router, RequestHandler } from 'express';
-import { DEFAULT_BRANCH, PROTECTED_BRANCHES } from '@bevel-software/platform-shared';
 import type { IToolRegistry, JsonSchema } from '../../tool-registry/tool.contract.js';
 import { ToolError, type ToolContext, type ToolHandler } from '../../tool-helpers/tool.contract.js';
 import { toolDef, withBranchInput } from '../../tool-helpers/tool-def.js';
 import type { ToolHandlerFactory } from '../../tool-helpers/tool-handler.js';
 import { requireInternalSource } from '../../tool-auth/tool-auth.middleware.js';
+import type { KbContext } from '../../../shared/kb-context.js';
 import { workspaceIdForBranch } from '../../../shared/workspace-id.js';
 import { assertInsideRepo, normalizePathArgs } from '../../kb-fs/repo-path.js';
 import { RETIRED_TOOL_MESSAGES } from '@bevel-software/platform-mcp-core';
@@ -14,9 +14,10 @@ function stripKbDir(path: string, kbDirName: string): string {
   return path.startsWith(`${kbDirName}/`) ? path.slice(kbDirName.length + 1) : path;
 }
 
-// A function, not a constant: the branch model is applied during boot, and a
-// module-scope capture would freeze this at the empty set that exists before it.
-const protectedInline = () => [...PROTECTED_BRANCHES].map((b) => `\`${b}\``).join(' / ');
+// Read at call time, not captured: the branch model is applied during boot,
+// and a value taken at registration would be the empty set that exists before it.
+const protectedInline = (kb: Pick<KbContext, 'protectedBranches'>) =>
+  [...kb.protectedBranches].map((b) => `\`${b}\``).join(' / ');
 
 // Output sub-schemas for the git-aliased workflow payloads (Branch, Change,
 // ChangeRequestComment, …). Defined once and referenced by the individual tool
@@ -131,9 +132,10 @@ export function registerWorkflowTools(
   router: Router,
   toolAuth: RequestHandler,
   toolHandler: ToolHandlerFactory,
-  /** The clone folder at the workspace root; `save_file` refuses a path outside it. */
-  kbDirName: string,
+  /** The clone folder at the workspace root (`save_file` refuses a path outside it) and the branch model. */
+  kb: Pick<KbContext, 'kbDirName' | 'defaultBranch' | 'defaultWorkspaceId' | 'protectedBranches'>,
 ): void {
+  const { kbDirName } = kb;
   const mount = (spec: {
     name: string;
     description: string;
@@ -180,7 +182,7 @@ export function registerWorkflowTools(
   // just to run a global op. Falls back to the default branch on a cold start
   // with no workspaces yet.
   const repoGlobalWorkspaceId = async (ctx: ToolContext): Promise<string> =>
-    (await ctx.workspaceService.findAnyWorkspaceId()) ?? workspaceIdForBranch(DEFAULT_BRANCH);
+    (await ctx.workspaceService.findAnyWorkspaceId()) ?? kb.defaultWorkspaceId();
 
   mount({
     name: 'list_branches',
@@ -303,7 +305,7 @@ export function registerWorkflowTools(
     name: 'create_branch',
     description:
       'Create a new unprotected draft named `name`, forked from the existing branch `branch`. The ' +
-      `backend rejects protected names (${protectedInline()}) and filesystem-invalid names — surface ` +
+      `backend rejects protected names (${protectedInline(kb)}) and filesystem-invalid names — surface ` +
       'those errors verbatim. Convention: `<email-localpart>/<kebab-slug>`. Does NOT switch the ' +
       'agent onto the new draft.',
     // `branch` here is the fork BASE — its own meaning — so skip the generic
@@ -356,7 +358,7 @@ export function registerWorkflowTools(
       type: 'object',
       properties: {
         sourceBranch: { type: 'string', minLength: 1, description: 'The draft branch carrying the changes.' },
-        targetBranch: { type: 'string', minLength: 1, description: `The branch to apply to (e.g. '${DEFAULT_BRANCH}').` },
+        targetBranch: { type: 'string', minLength: 1, description: `The branch to apply to (e.g. '${kb.defaultBranch}').` },
         title: { type: 'string', minLength: 1, maxLength: 256, description: 'Short imperative title (≤256 chars).' },
         description: { type: 'string', description: 'Optional markdown body shown verbatim to reviewers.' },
       },

package/src/modules/workflow/git/__tests__/git.service.accessGating.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -140,7 +141,7 @@ async function makeSvc(
   const svc = new GitService(
     stubWorkspaceService(workspaceId, workspaceDir),
     new WorkflowHooks(),
-    'knowledge-base',
+    testKbContext(),
     undefined,
     ac ?? null,
   );
@@ -262,7 +263,7 @@ describe('GitService — push gate uses origin/<branch> (not HEAD or working tre
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
       undefined,
       ac,
     );
@@ -306,7 +307,7 @@ describe('GitService — push gate uses origin/<branch> (not HEAD or working tre
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
       undefined,
       ac,
     );
@@ -337,7 +338,7 @@ describe('GitService — push gate uses origin/<branch> (not HEAD or working tre
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
       undefined,
       ac,
     );

package/src/modules/workflow/git/__tests__/git.service.changedFilesForPr.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -127,7 +128,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     const files = await git.changedFilesForPr(
@@ -174,7 +175,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
     // What the detail does first: resolve (and fetch) the two SHAs.
     const pinned = await git.resolvePrShas(workspaceId, 'current-company-state', 'alice/feature');
@@ -226,7 +227,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     const files = await git.changedFilesForPr(
@@ -263,7 +264,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     await runGit(repo, ['commit', '-m', 'folders']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/new-folders']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), 'knowledge-base');
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
 
     const files = await git.changedFilesForPr(workspaceId, 'current-company-state', 'alice/new-folders');
     expect(files.map((f) => f.path)).toEqual(['Reports/q3.md']);
@@ -292,7 +293,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     await runGit(repo, ['commit', '-m', 'emptied']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/emptied']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), 'knowledge-base');
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
 
     const files = await git.changedFilesForPr(workspaceId, 'current-company-state', 'alice/emptied');
     expect(files.map((f) => ({ path: f.path, status: f.status, previousPath: f.previousPath }))).toEqual([
@@ -305,7 +306,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
   it('pathExistsAtRef answers for files and folders at a ref, and false for what is not there', async () => {
     const { repo } = await seedWorkspace(root, workspaceId);
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), 'knowledge-base');
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
     await fs.mkdir(path.join(repo, 'Docs'));
     await fs.writeFile(path.join(repo, 'Docs/.gitkeep'), '');
     await runGit(repo, ['add', '-A']);
@@ -336,7 +337,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     const mergeBase = await git.mergeBaseForPr(workspaceId, 'current-company-state', 'alice/feature');
@@ -417,7 +418,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
     expect(
       await git.changedPathsForPr(workspaceId, 'current-company-state', 'biz/proposal'),
@@ -430,7 +431,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
     // The clone now knows the branch — this stands in for the one fetch a
     // list does for the whole clone before asking about every request.
@@ -467,7 +468,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
     // Nothing has refreshed this clone since the branch was pushed.
     expect(
@@ -505,7 +506,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
       new PrunedMidCall(),
     );
 

package/src/modules/workflow/git/__tests__/git.service.commitChanges.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -70,7 +71,7 @@ describe('GitService.commitChanges', () => {
 
   it('commits many dirty files + a delete as ONE commit attributed to the user', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     // The caller writes the batch to disk first (the git layer never writes content).
     await fs.mkdir(path.join(repo, 'Product/Knowledge'), { recursive: true });
@@ -97,7 +98,7 @@ describe('GitService.commitChanges', () => {
 
   it('returns null on a clean tree (nothing to commit)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     const change = await svc.commitChanges(workspaceId, USER, 'no-op');
     expect(change).toBeNull();
@@ -105,7 +106,7 @@ describe('GitService.commitChanges', () => {
 
   it('onlyPaths scopes the commit — an unrelated dirty file is NOT swept in', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     // The batch's own file, plus a CONCURRENT save's bytes whose commit is
     // still queued — the shared per-branch workspace makes this ordinary.
@@ -127,7 +128,7 @@ describe('GitService.commitChanges', () => {
 
   it('onlyPaths keeps a staged RENAME whole — old path deletion rides the scoped commit', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     // A staged rename shows as one `R` porcelain record (new-path + old-path).
     // The scope names only the NEW path; the old path must ride along or the
@@ -148,7 +149,7 @@ describe('GitService.commitChanges', () => {
 
   it('a REAL `git add` failure aborts the scoped commit — only the pathspec miss is tolerated', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     await fs.writeFile(path.join(repo, 'Old.md'), 'new bytes\n');
     // Hold git's index lock: `git add` now fails with a real error (index
@@ -172,7 +173,7 @@ describe('GitService.commitChanges', () => {
     // pathspecs were passed on the command line — the scoped path feeds them
     // via `--pathspec-from-file=-` on stdin instead.
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     const dir = 'Product/Knowledge/A Rather Long Folder Name To Inflate The Pathspec Bytes';
     await fs.mkdir(path.join(repo, dir), { recursive: true });
@@ -202,7 +203,7 @@ describe('GitService.commitChanges', () => {
 
   it('a big batch containing a fully-staged deletion still commits (per-path fallback)', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     // Stage Old.md's deletion fully — the batched `git add` then has nothing
     // in the worktree to match for it and fails with the ONE expected miss,
@@ -226,7 +227,7 @@ describe('GitService.commitChanges', () => {
 
   it('onlyPaths with nothing of its own dirty is a no-op even when other files are dirty', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), PROCESS_MAP_DIR);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), makeValidator(), testKbContext({ kbDirName: PROCESS_MAP_DIR }));
 
     await fs.writeFile(path.join(repo, 'Old.md'), 'someone else mid-save\n');
     const change = await svc.commitChanges(workspaceId, USER, 'Sync directory groups', [

package/src/modules/workflow/git/__tests__/git.service.commitFile.strayPath.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -86,7 +87,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('throws instead of returning null when the file exists at the workspace root and not in the clone', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), KB);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
     // The prefix-less write the agent made: beside the clone, not inside it.
     await fs.mkdir(path.join(workspaceDir, 'KnowledgeBase/Reviews'), { recursive: true });
     await fs.writeFile(path.join(workspaceDir, 'KnowledgeBase/Reviews/PR-12.html'), '<p>review</p>');
@@ -103,19 +104,19 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('still returns null for a clean, committed path (the honest no-op)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), KB);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/A.md`)).toBeNull();
   });
 
   it('still returns null for a path that exists nowhere (a queued re-apply of a committed deletion)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), KB);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/Gone.md`)).toBeNull();
   });
 
   it('still returns null for a repo-relative path that is clean inside the clone (the form internal callers pass)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), KB);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, 'Knowledge/A.md')).toBeNull();
   });
 
@@ -124,7 +125,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
     // a repo-relative caller's no-op stays honest whatever else sits beside
     // the clone under the same name.
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), KB);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
     await fs.mkdir(path.join(workspaceDir, 'Knowledge'), { recursive: true });
     await fs.writeFile(path.join(workspaceDir, 'Knowledge/A.md'), 'a copy beside the clone\n');
     expect(await svc.commitFile(workspaceId, USER, 'Knowledge/A.md')).toBeNull();
@@ -137,7 +138,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
     // toggles read-only, so the stat below still succeeds): nothing to prove.
     if (process.getuid?.() === 0 || process.platform === 'win32') return;
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), KB);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
     const strayDir = path.join(workspaceDir, 'KnowledgeBase');
     await fs.mkdir(strayDir, { recursive: true });
     await fs.writeFile(path.join(strayDir, 'PR-12.html'), 'x');
@@ -152,7 +153,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('still commits a prefixed path inside the clone', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), KB);
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
     await fs.writeFile(path.join(repo, 'Knowledge/B.md'), 'b\n');
     const committed = await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/B.md`);
     expect(committed).not.toBeNull();

package/src/modules/workflow/git/__tests__/git.service.commitFile.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -95,7 +96,7 @@ describe('GitService.commitFile — skipValidator', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       hooks,
-      'knowledge-base',
+      testKbContext(),
     );
 
     await fs.writeFile(path.join(repo, 'Foo.md'), 'reverted content\n');
@@ -112,7 +113,7 @@ describe('GitService.commitFile — skipValidator', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       hooks,
-      'knowledge-base',
+      testKbContext(),
     );
 
     await fs.writeFile(path.join(repo, 'Bar.md'), 'new content\n');
@@ -136,7 +137,7 @@ describe('GitService.commitFile — skipValidator', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       hooks,
-      'knowledge-base',
+      testKbContext(),
     );
 
     // Shape mirrors the reported filename (bracketed status prefix carrying a
@@ -167,7 +168,7 @@ describe('GitService.commitFile — skipValidator', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       hooks,
-      'knowledge-base',
+      testKbContext(),
     );
 
     // Synthetic segments matching the SHAPE of real deep-KB naming (numbered
@@ -206,7 +207,7 @@ describe('GitService.commitFile — skipValidator', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       hooks,
-      'knowledge-base',
+      testKbContext(),
     );
 
     const relPath = '[Approved] config.md';

package/src/modules/workflow/git/__tests__/git.service.createBranch.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -90,7 +91,7 @@ describe('GitService.createBranch', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     const info = await svc.createBranch(workspaceId, 'alice/new-draft');
@@ -133,7 +134,7 @@ describe('GitService.createBranch', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await svc.createBranch(workspaceId, 'alice/new-draft');

package/src/modules/workflow/git/__tests__/git.service.deleteBranch.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -159,7 +160,7 @@ describe('GitService.deleteBranch — authorship + remote delete', () => {
     return new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
   }
 
@@ -263,7 +264,7 @@ describe('GitService.deleteBranch — authorship + remote delete', () => {
     return new GitService(
       stubWorkspaceService(workspaceId, path.join(root, workspaceId)),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
       undefined,
       ac,
     );

package/src/modules/workflow/git/__tests__/git.service.diffFileAtCommit.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -108,7 +109,7 @@ describe('GitService.diffFileAtCommit', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Foo.md', 'line one\n', 'A');
@@ -125,7 +126,7 @@ describe('GitService.diffFileAtCommit', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Foo.md', 'root line\n', 'root');
@@ -141,7 +142,7 @@ describe('GitService.diffFileAtCommit', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/file2.md', 'base\n', 'add file2');
@@ -157,7 +158,7 @@ describe('GitService.diffFileAtCommit', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await expect(
@@ -170,7 +171,7 @@ describe('GitService.diffFileAtCommit', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await expect(
@@ -187,7 +188,7 @@ describe('GitService.diffFileAtCommit', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
     await runGit(repo, ['commit', '--allow-empty', '-m', 'init']);
     const user = { id: 'u', name: 'Test', email: 't@x.com' };

package/src/modules/workflow/git/__tests__/git.service.diffFileBetweenBranches.test.ts

@@ -1,4 +1,5 @@
 import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { testKbContext } from '../../../../__tests__/kb-context.js';
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import fs from 'node:fs/promises';
@@ -99,7 +100,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Foo.md', 'line one\n', 'base');
@@ -121,7 +122,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Same.md', 'unchanged\n', 'base');
@@ -143,7 +144,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Old.md', 'going away\n', 'base');
@@ -165,7 +166,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Seed.md', 'seed\n', 'base');
@@ -207,7 +208,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     const diff = await svc.diffFileBetweenBranches(
@@ -232,7 +233,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Foo.md', 'baseline\n', 'base');
@@ -257,7 +258,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Foo.md', 'baseline\n', 'base');
@@ -282,7 +283,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Seed.md', 'seed\n', 'base');
@@ -305,7 +306,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Seed.md', 'seed\n', 'base');
@@ -327,7 +328,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await commitFile(repo, 'Knowledge/Foo.md', 'baseline\n', 'base');
@@ -352,7 +353,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await expect(
@@ -371,7 +372,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await expect(
@@ -389,7 +390,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await expect(
@@ -407,7 +408,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
 
     await expect(
@@ -429,7 +430,7 @@ describe('GitService.diffFileBetweenBranches', () => {
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
       new WorkflowHooks(),
-      'knowledge-base',
+      testKbContext(),
     );
     await runGit(repo, ['commit', '--allow-empty', '-m', 'init']);
     const user = { id: 'u', name: 'Test', email: 't@x.com' };