@better-update/cli 0.3.0 → 0.3.2

package/src/lib/build-profile.ts

@@ -1,234 +0,0 @@
-import { Effect } from "effect";
-
-import { BuildProfileError } from "./exit-codes";
-import { asRecord } from "./record";
-
-export type Platform = "ios" | "android";
-
-export type IosDistribution = "app-store" | "ad-hoc" | "development" | "enterprise";
-
-export interface IosProfile {
-  readonly buildConfiguration?: string;
-  readonly distribution: IosDistribution;
-  readonly scheme?: string;
-}
-
-export type AndroidDistribution = "play-store" | "direct";
-
-export interface AndroidProfile {
-  readonly buildType?: "debug" | "release";
-  readonly format: "apk" | "aab";
-  readonly flavor?: string;
-  readonly distribution: AndroidDistribution;
-}
-
-export interface BuildProfile {
-  readonly name: string;
-  readonly environment: string;
-  readonly ios?: IosProfile;
-  readonly android?: AndroidProfile;
-}
-
-export type RawRuntimeVersion = string | { readonly policy: string };
-
-export interface AppMeta {
-  readonly bundleId: string | undefined;
-  readonly androidPackage: string | undefined;
-  readonly appVersion: string | undefined;
-  readonly buildNumber: string | undefined;
-  readonly rawRuntimeVersion: RawRuntimeVersion | undefined;
-}
-
-export interface RuntimeVersionMeta {
-  readonly appVersion: string | undefined;
-  readonly rawRuntimeVersion: RawRuntimeVersion | undefined;
-}
-
-export const asString = (value: unknown): string | undefined =>
-  typeof value === "string" ? value : undefined;
-
-const getBetterUpdateExtra = (
-  appJson: Record<string, unknown>,
-): Record<string, unknown> | undefined => {
-  const expo = asRecord(appJson["expo"]);
-  const extra = asRecord(expo?.["extra"]);
-  return asRecord(extra?.["betterUpdate"]);
-};
-
-const VALID_IOS_DISTRIBUTIONS: readonly IosDistribution[] = [
-  "app-store",
-  "ad-hoc",
-  "development",
-  "enterprise",
-];
-
-const isIosDistribution = (value: string): value is IosDistribution =>
-  (VALID_IOS_DISTRIBUTIONS as readonly string[]).includes(value);
-
-const readIosProfile = (raw: unknown): IosProfile | undefined => {
-  const iosRaw = asRecord(raw);
-  if (!iosRaw) {
-    return undefined;
-  }
-  const distributionRaw = asString(iosRaw["distribution"]);
-  if (!distributionRaw) {
-    return undefined;
-  }
-  if (!isIosDistribution(distributionRaw)) {
-    return undefined;
-  }
-  const distribution: IosDistribution = distributionRaw;
-  const buildConfiguration = asString(iosRaw["buildConfiguration"]);
-  const scheme = asString(iosRaw["scheme"]);
-  return {
-    distribution,
-    ...(buildConfiguration === undefined ? {} : { buildConfiguration }),
-    ...(scheme === undefined ? {} : { scheme }),
-  };
-};
-
-const resolveAndroidDistribution = (
-  raw: string | undefined,
-  format: "apk" | "aab",
-): AndroidDistribution => {
-  if (raw === "play-store" || raw === "direct") {
-    return raw;
-  }
-  return format === "aab" ? "play-store" : "direct";
-};
-
-const readAndroidProfile = (raw: unknown): AndroidProfile | undefined => {
-  const androidRaw = asRecord(raw);
-  if (!androidRaw) {
-    return undefined;
-  }
-  const formatValue = asString(androidRaw["format"]);
-  const format = formatValue === "apk" || formatValue === "aab" ? formatValue : undefined;
-  if (!format) {
-    return undefined;
-  }
-  const buildTypeValue = asString(androidRaw["buildType"]);
-  const buildType =
-    buildTypeValue === "debug" || buildTypeValue === "release" ? buildTypeValue : undefined;
-  const flavor = asString(androidRaw["flavor"]);
-  const distribution = resolveAndroidDistribution(asString(androidRaw["distribution"]), format);
-  return {
-    format,
-    distribution,
-    ...(buildType === undefined ? {} : { buildType }),
-    ...(flavor === undefined ? {} : { flavor }),
-  };
-};
-
-export const readBuildProfile = (
-  appJson: Record<string, unknown>,
-  profileName: string,
-): Effect.Effect<BuildProfile, BuildProfileError> =>
-  Effect.gen(function* () {
-    const betterUpdate = getBetterUpdateExtra(appJson);
-    const profiles = asRecord(betterUpdate?.["profiles"]);
-    if (!profiles) {
-      return yield* new BuildProfileError({
-        message: "No build profiles defined. Add expo.extra.betterUpdate.profiles to app.json.",
-      });
-    }
-    const profileRaw = asRecord(profiles[profileName]);
-    if (!profileRaw) {
-      return yield* new BuildProfileError({
-        message: `Build profile "${profileName}" not found in app.json.`,
-      });
-    }
-    const environment = asString(profileRaw["environment"]) ?? "production";
-    const ios = readIosProfile(profileRaw["ios"]);
-    const android = readAndroidProfile(profileRaw["android"]);
-    return {
-      name: profileName,
-      environment,
-      ...(ios === undefined ? {} : { ios }),
-      ...(android === undefined ? {} : { android }),
-    };
-  });
-
-export const readRuntimeVersionMeta = (
-  appJson: Record<string, unknown>,
-): Effect.Effect<RuntimeVersionMeta, BuildProfileError> =>
-  Effect.gen(function* () {
-    const expo = asRecord(appJson["expo"]);
-    if (!expo) {
-      return yield* new BuildProfileError({
-        message: "Missing expo section in app.json.",
-      });
-    }
-
-    return {
-      appVersion: asString(expo["version"]),
-      rawRuntimeVersion: readRawRuntimeVersion(expo["runtimeVersion"]),
-    };
-  });
-
-export const readAppMeta = (
-  appJson: Record<string, unknown>,
-  platform: Platform,
-): Effect.Effect<AppMeta, BuildProfileError> =>
-  Effect.gen(function* () {
-    const expo = asRecord(appJson["expo"]);
-    if (!expo) {
-      return yield* new BuildProfileError({
-        message: "Missing expo section in app.json.",
-      });
-    }
-
-    if (platform === "ios") {
-      const ios = asRecord(expo["ios"]);
-      if (!ios) {
-        return yield* new BuildProfileError({
-          message:
-            "Missing expo.ios section in app.json. Required for iOS builds (bundleIdentifier).",
-        });
-      }
-    } else {
-      const android = asRecord(expo["android"]);
-      if (!android) {
-        return yield* new BuildProfileError({
-          message:
-            "Missing expo.android section in app.json. Required for Android builds (package).",
-        });
-      }
-    }
-
-    const iosSection = asRecord(expo["ios"]);
-    const androidSection = asRecord(expo["android"]);
-    const buildNumber =
-      platform === "ios"
-        ? asString(iosSection?.["buildNumber"])
-        : asStringOrNumber(androidSection?.["versionCode"]);
-    return {
-      bundleId: asString(iosSection?.["bundleIdentifier"]),
-      androidPackage: asString(androidSection?.["package"]),
-      appVersion: asString(expo["version"]),
-      buildNumber,
-      rawRuntimeVersion: readRawRuntimeVersion(expo["runtimeVersion"]),
-    };
-  });
-
-const asStringOrNumber = (value: unknown): string | undefined => {
-  if (typeof value === "string") {
-    return value;
-  }
-  if (typeof value === "number" && Number.isFinite(value)) {
-    return String(value);
-  }
-  return undefined;
-};
-
-const readRawRuntimeVersion = (value: unknown): RawRuntimeVersion | undefined => {
-  if (typeof value === "string") {
-    return value;
-  }
-  const record = asRecord(value);
-  const policy = asString(record?.["policy"]);
-  if (policy) {
-    return { policy };
-  }
-  return undefined;
-};

package/src/lib/cli-schemas.ts

@@ -1,39 +0,0 @@
-import { Args, Options } from "@effect/cli";
-import { ParseResult, Schema } from "effect";
-
-export const RolloutPercentage = Schema.Number.pipe(
-  Schema.int(),
-  Schema.between(1, 100),
-).annotations({
-  message: () => "Rollout percentage must be between 1 and 100.",
-  identifier: "RolloutPercentage",
-});
-
-export const rolloutPercentageOption = (name: string): Options.Options<number> =>
-  Options.integer(name).pipe(Options.withSchema(RolloutPercentage));
-
-export const KeyValuePair = Schema.Struct({
-  key: Schema.String,
-  value: Schema.String,
-});
-export type KeyValuePair = Schema.Schema.Type<typeof KeyValuePair>;
-
-export const KeyValueFromString = Schema.transformOrFail(Schema.String, KeyValuePair, {
-  strict: true,
-  decode: (input, _options, ast) => {
-    const eqIndex = input.indexOf("=");
-    if (eqIndex <= 0) {
-      return ParseResult.fail(
-        new ParseResult.Type(ast, input, "Invalid format. Use KEY=VALUE (e.g. API_KEY=abc123)"),
-      );
-    }
-    return ParseResult.succeed({
-      key: input.slice(0, eqIndex),
-      value: input.slice(eqIndex + 1),
-    });
-  },
-  encode: ({ key, value }) => ParseResult.succeed(`${key}=${value}`),
-});
-
-export const keyValueArg = (name: string): Args.Args<KeyValuePair> =>
-  Args.text({ name }).pipe(Args.withSchema(KeyValueFromString));

package/src/lib/command-errors.ts

@@ -1,60 +0,0 @@
-import { Effect } from "effect";
-
-import { exitWith } from "../application/command-exit";
-import { formatCause } from "./format-error";
-
-import type { CliRuntime } from "../services/cli-runtime";
-
-type ExitCode = 1 | 2 | 3 | 4 | 5 | 6;
-
-interface TaggedError {
-  readonly message: string;
-}
-
-type Handler = (error: TaggedError) => Effect.Effect<void, never, CliRuntime>;
-
-const BASE_TAG_MAP: Record<string, ExitCode> = {
-  AuthRequiredError: 3,
-  ProjectNotLinkedError: 4,
-  NotFound: 1,
-  Conflict: 1,
-  Forbidden: 1,
-  BadRequest: 2,
-};
-
-const SYSTEM_TAG_MESSAGE: Record<string, (error: TaggedError) => string> = {
-  SystemError: (error) => `Filesystem error: ${error.message}`,
-  BadArgument: (error) => `Invalid argument: ${error.message}`,
-};
-
-const SYSTEM_TAG_CODE: Record<string, ExitCode> = {
-  SystemError: 6,
-  BadArgument: 6,
-};
-
-export const makeCommandErrorHandler = (
-  extras: Record<string, ExitCode> = {},
-): (<Success, Requirements>(
-  effect: Effect.Effect<Success, unknown, Requirements>,
-) => Effect.Effect<Success, never, Requirements | CliRuntime>) => {
-  const combined = { ...BASE_TAG_MAP, ...extras };
-  const handlers: Record<string, Handler> = {};
-  for (const [tag, code] of Object.entries(combined)) {
-    const systemFormat = SYSTEM_TAG_MESSAGE[tag];
-    const resolvedCode = SYSTEM_TAG_CODE[tag] ?? code;
-    handlers[tag] = (error) =>
-      exitWith(resolvedCode, systemFormat ? systemFormat(error) : error.message);
-  }
-
-  return <Success, Requirements>(
-    effect: Effect.Effect<Success, unknown, Requirements>,
-  ): Effect.Effect<Success, never, Requirements | CliRuntime> => {
-    const piped = effect.pipe(
-      // eslint-disable-next-line typescript/no-unsafe-type-assertion -- Effect.catchTags tag-inference requires a literal object; we accept a dynamic handler map so tags are chosen at runtime
-      Effect.catchTags(handlers as never),
-      Effect.catchAll((cause) => exitWith(1, formatCause(cause))),
-    );
-    // eslint-disable-next-line typescript/no-unsafe-type-assertion -- catchTags narrowing lost when handlers is dynamic; re-narrow at the boundary
-    return piped as Effect.Effect<Success, never, Requirements | CliRuntime>;
-  };
-};

package/src/lib/credentials-downloader.ts

@@ -1,181 +0,0 @@
-import { fromBase64 } from "@better-update/encoding";
-import { FileSystem } from "@effect/platform";
-import { Effect } from "effect";
-
-import type { PlatformError } from "@effect/platform/Error";
-
-import { MissingCredentialsError } from "./exit-codes";
-
-import type { ApiClient } from "../services/api-client";
-import type { IosDistribution } from "./build-profile";
-
-export interface DownloadIosCredentialsOptions {
-  readonly projectId: string;
-  readonly bundleIdentifier: string;
-  readonly distribution: IosDistribution;
-  readonly tempDir: string;
-}
-
-export interface IosCredentials {
-  readonly p12Path: string;
-  readonly p12Password: string;
-  readonly profilePath: string;
-  readonly profileFilename: string;
-  readonly teamId: string;
-}
-
-const IOS_DISTRIBUTION_TO_TYPE = {
-  "app-store": "APP_STORE",
-  "ad-hoc": "AD_HOC",
-  development: "DEVELOPMENT",
-  enterprise: "ENTERPRISE",
-} as const satisfies Record<IosDistribution, "APP_STORE" | "AD_HOC" | "DEVELOPMENT" | "ENTERPRISE">;
-
-const bindHint =
-  "Bind the bundle via the dashboard (Credentials → iOS Bundle Configurations) and make sure a distribution certificate, provisioning profile, and ASC API key are attached.";
-
-const permissionHint = "Ask an org admin to grant the build-credentials download permission.";
-
-const androidBindHint =
-  "Register the package in the dashboard (Credentials → Android Build Credentials) and bind a keystore to the default group.";
-
-interface TaggedCause {
-  readonly _tag: string;
-  readonly message?: string;
-}
-
-const hasTag = (cause: unknown): cause is TaggedCause =>
-  typeof cause === "object" && cause !== null && "_tag" in cause;
-
-const resolveErrorToMissingCredentials = (
-  cause: unknown,
-  platform: "ios" | "android",
-): MissingCredentialsError => {
-  const tag = hasTag(cause) ? cause._tag : null;
-  const message = hasTag(cause) && typeof cause.message === "string" ? cause.message : null;
-  const platformLabel = platform === "ios" ? "iOS" : "Android";
-  const bind = platform === "ios" ? bindHint : androidBindHint;
-
-  if (tag === "Forbidden") {
-    return new MissingCredentialsError({
-      message: message ?? `Permission denied when resolving ${platformLabel} build credentials`,
-      hint: permissionHint,
-    });
-  }
-  if (tag === "NotFound") {
-    return new MissingCredentialsError({
-      message: message ?? `No ${platformLabel} build credentials configured`,
-      hint: bind,
-    });
-  }
-  if (tag === "BadRequest") {
-    return new MissingCredentialsError({
-      message: message ?? `${platformLabel} build credentials are misconfigured`,
-      hint: bind,
-    });
-  }
-  return new MissingCredentialsError({
-    message: message ?? `Failed to resolve ${platformLabel} build credentials`,
-    hint: bind,
-  });
-};
-
-export const downloadIosCredentials = (
-  api: ApiClient,
-  options: DownloadIosCredentialsOptions,
-): Effect.Effect<IosCredentials, MissingCredentialsError | PlatformError, FileSystem.FileSystem> =>
-  Effect.gen(function* () {
-    const fs = yield* FileSystem.FileSystem;
-
-    const resolved = yield* api.buildCredentials
-      .resolve({
-        path: { projectId: options.projectId },
-        payload: {
-          platform: "ios" as const,
-          bundleIdentifier: options.bundleIdentifier,
-          distributionType: IOS_DISTRIBUTION_TO_TYPE[options.distribution],
-        },
-      })
-      .pipe(Effect.mapError((cause) => resolveErrorToMissingCredentials(cause, "ios")));
-
-    if (resolved.platform !== "ios") {
-      return yield* Effect.fail(
-        new MissingCredentialsError({
-          message: "Server returned non-iOS credentials for an iOS build request",
-          hint: bindHint,
-        }),
-      );
-    }
-
-    const p12Path = `${options.tempDir}/signing.p12`;
-    const profileFilename = `${resolved.provisioningProfile.uuid ?? "profile"}.mobileprovision`;
-    const profilePath = `${options.tempDir}/${profileFilename}`;
-
-    yield* fs.writeFile(p12Path, fromBase64(resolved.distributionCertificate.p12Base64));
-    yield* fs.writeFile(
-      profilePath,
-      fromBase64(resolved.provisioningProfile.mobileprovisionBase64),
-    );
-
-    return {
-      p12Path,
-      p12Password: resolved.distributionCertificate.p12Password,
-      profilePath,
-      profileFilename,
-      teamId: resolved.provisioningProfile.teamId,
-    };
-  });
-
-export interface DownloadAndroidCredentialsOptions {
-  readonly projectId: string;
-  readonly applicationIdentifier: string;
-  readonly tempDir: string;
-}
-
-export interface AndroidCredentials {
-  readonly keystorePath: string;
-  readonly storePassword: string;
-  readonly keyAlias: string;
-  readonly keyPassword: string;
-}
-
-export const downloadAndroidCredentials = (
-  api: ApiClient,
-  options: DownloadAndroidCredentialsOptions,
-): Effect.Effect<
-  AndroidCredentials,
-  MissingCredentialsError | PlatformError,
-  FileSystem.FileSystem
-> =>
-  Effect.gen(function* () {
-    const fs = yield* FileSystem.FileSystem;
-
-    const resolved = yield* api.buildCredentials
-      .resolve({
-        path: { projectId: options.projectId },
-        payload: {
-          platform: "android" as const,
-          applicationIdentifier: options.applicationIdentifier,
-        },
-      })
-      .pipe(Effect.mapError((cause) => resolveErrorToMissingCredentials(cause, "android")));
-
-    if (resolved.platform !== "android") {
-      return yield* Effect.fail(
-        new MissingCredentialsError({
-          message: "Server returned non-Android credentials for an Android build request",
-          hint: androidBindHint,
-        }),
-      );
-    }
-
-    const keystorePath = `${options.tempDir}/upload.keystore`;
-    yield* fs.writeFile(keystorePath, fromBase64(resolved.keystore.keystoreBase64));
-
-    return {
-      keystorePath,
-      storePassword: resolved.keystore.storePassword,
-      keyAlias: resolved.keystore.keyAlias,
-      keyPassword: resolved.keystore.keyPassword,
-    };
-  });