@benvargas/pi-openai-verbosity 1.0.1 → 1.1.1

package/README.md

@@ -20,8 +20,9 @@ pi has since shipped an upstream fix: OpenAI Codex Responses requests now defaul
 explicit verbosity is provided.
 
 That upstream change addresses the original `gpt-5.5` issue, but it also means pi now defaults every
-`openai-codex` model to `low`. That may not be ideal for all model slugs. For example, you may prefer `low` on
-`gpt-5.5`, but `medium` on an older or different model such as `gpt-5.3-codex`.
+`openai-codex` model to `low`. That may not be ideal for all model slugs. For example, the Codex CLI's own
+default for `gpt-5.4-mini` is `medium`, not `low`, and you may prefer `high` on a model you use for
+long-form writing.
 
 This extension now provides the missing user-facing control: per-slug verbosity settings for pi's
 `openai-codex` provider.
@@ -73,20 +74,27 @@ reloads the config file.
 Config files follow pi's project-over-global pattern:
 
 - Project: `<repo>/.pi/extensions/pi-openai-verbosity.json`
-- Global: `~/.pi/agent/extensions/pi-openai-verbosity.json`
+- Global: `<agent-dir>/extensions/pi-openai-verbosity.json`
 
-If neither exists, the extension writes a default global config on first run.
+The global path uses pi's agent directory — `~/.pi/agent` by default, or wherever `PI_CODING_AGENT_DIR`
+points if you have relocated it.
+
+Older versions of this extension always used `~/.pi/agent`, even when `PI_CODING_AGENT_DIR` was set. If you
+have relocated the agent directory and it contains no config, a config left at the legacy
+`~/.pi/agent/extensions/pi-openai-verbosity.json` path is still honored; it is read in place and never
+modified. A config in the relocated directory takes precedence once you create one there.
+
+If no config exists at any of these locations, the extension writes a default global config on first run.
 
 Example config:
 
 ```json
 {
   "models": {
+    "openai-codex/gpt-5.6-sol": "low",
     "openai-codex/gpt-5.5": "low",
-    "openai-codex/gpt-5.4": "low",
-    "openai-codex/gpt-5.3-codex": "medium",
-    "openai-codex/gpt-5.3-codex-spark": "medium",
-    "openai-codex/gpt-5.2": "medium"
+    "openai-codex/gpt-5.4-mini": "medium",
+    "openai-codex/gpt-5.3-codex-spark": "medium"
   }
 }
 ```
@@ -100,24 +108,63 @@ native default behavior applies.
 
 ## Default Config
 
-By default, the extension preserves the original workaround behavior and sets known supported OpenAI Codex models
-to `low`:
+By default, the extension mirrors the Codex CLI's own per-model verbosity defaults for every model in pi's
+`openai-codex` catalog. That means `low` everywhere except `gpt-5.4-mini`, whose upstream default is `medium`
+(pi's blanket fallback would otherwise force it to `low`):
 
 ```json
 {
   "models": {
+    "openai-codex/gpt-5.3-codex-spark": "low",
     "openai-codex/gpt-5.4": "low",
+    "openai-codex/gpt-5.4-mini": "medium",
     "openai-codex/gpt-5.5": "low",
-    "openai-codex/gpt-5.4-mini": "low",
-    "openai-codex/gpt-5.3-codex": "low",
-    "openai-codex/gpt-5.3-codex-spark": "low",
-    "openai-codex/gpt-5.2": "low",
-    "openai-codex/codex-auto-review": "low"
+    "openai-codex/gpt-5.6-luna": "low",
+    "openai-codex/gpt-5.6-sol": "low",
+    "openai-codex/gpt-5.6-terra": "low"
   }
 }
 ```
 
-You can change any value to `medium` or `high` to override pi's native low-verbosity default for that model.
+You can change any value to override the default for that model. If you have an existing config file from an
+older version of this extension, your file's entries win over these defaults, and entries for model slugs pi no
+longer exposes are simply ignored.
+
+## Why not `samplingParams`?
+
+pi 0.84.0 added `samplingParams`, which lets you pass arbitrary OpenAI-compatible parameters through
+`models.json`, model overrides, and extension providers. Reading those release notes, it is natural to assume
+this extension is now redundant and that you can write:
+
+```json
+{
+  "modelOverrides": {
+    "openai-codex/gpt-5.5": {
+      "samplingParams": { "text": { "verbosity": "medium" } }
+    }
+  }
+}
+```
+
+**On `openai-codex` this silently does nothing.** There is no error and no warning; the setting is simply never
+applied. `samplingParams` is explicitly scoped to OpenAI-*compatible* adapters — pi-ai documents it as "only
+applied by OpenAI-compatible adapters (completions, responses, Azure responses); other APIs ignore it" — and
+the Codex adapter is not one of them. It builds its own request and hardcodes `text: { verbosity: ... }`,
+defaulting to `low`.
+
+So for the `openai-codex` provider, this extension remains the only way to set per-model verbosity.
+
+### If you use `samplingParams` on the plain `openai` provider
+
+There it *is* applied, but the merge is a shallow top-level `Object.assign`. That means:
+
+```json
+{ "samplingParams": { "text": { "verbosity": "medium" } } }
+```
+
+replaces the **entire** `text` object rather than merging into it, discarding any other `text` fields pi had
+already set. This extension deliberately does the opposite: it preserves existing `text` fields and replaces
+only `text.verbosity`.
 
 ## Debugging
 
@@ -131,7 +178,7 @@ matching and rewriting a request, set `PI_OPENAI_VERBOSITY_DEBUG_LOG` to a JSONL
 ```bash
 PI_OPENAI_VERBOSITY_DEBUG_LOG=/tmp/pi-openai-verbosity.jsonl \
   pi -e npm:@benvargas/pi-openai-verbosity \
-  --model openai-codex/gpt-5.3-codex \
+  --model openai-codex/gpt-5.6-sol \
   -p "Reply in one short sentence."
 ```
 
@@ -148,7 +195,9 @@ delete it when you are done debugging.
 
 - This extension only changes outgoing provider request payloads.
 - Existing `text` fields are preserved, and only `text.verbosity` is replaced.
-- Only the `openai-codex` provider is supported.
+- Only the `openai-codex` provider is supported. pi 0.84.0's `samplingParams` does not reach that provider, so
+  this extension remains the only per-model verbosity control for it — see
+  [Why not `samplingParams`?](#why-not-samplingparams).
 - This extension is most useful if you want different verbosity settings for different OpenAI Codex model slugs.
 
 ## Uninstall

package/extensions/index.ts

@@ -4,26 +4,34 @@
  * Sets OpenAI Responses `text.verbosity` for configured models via the
  * `before_provider_request` hook. Config precedence is project
  * `.pi/extensions/pi-openai-verbosity.json` over global
- * `~/.pi/agent/extensions/pi-openai-verbosity.json`.
+ * `<agent-dir>/extensions/pi-openai-verbosity.json`, where the agent
+ * directory comes from pi's getAgentDir (honoring PI_CODING_AGENT_DIR).
+ * Older versions always used `~/.pi/agent`; when the agent directory is
+ * relocated and has no config, a config at that legacy path is still read
+ * (in place, never modified) so existing settings keep working.
  */
 import { appendFileSync, existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { homedir } from "node:os";
 import { dirname, join } from "node:path";
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { getAgentDir } from "@earendil-works/pi-coding-agent";
 
 const VERBOSITY_COMMAND = "openai-verbosity";
 const VERBOSITY_CONFIG_BASENAME = "pi-openai-verbosity.json";
 const VERBOSITY_COMMAND_ARGS = ["status"] as const;
 const DEBUG_LOG_ENV = "PI_OPENAI_VERBOSITY_DEBUG_LOG";
 const SUPPORTED_PROVIDERS = ["openai-codex"] as const;
+// Mirrors the Codex CLI upstream defaults for every model in pi's openai-codex
+// catalog. pi itself falls back to `low` for all codex requests, which matches
+// upstream everywhere except gpt-5.4-mini (upstream default: medium).
 const DEFAULT_MODEL_VERBOSITY = {
+	"openai-codex/gpt-5.3-codex-spark": "low",
 	"openai-codex/gpt-5.4": "low",
+	"openai-codex/gpt-5.4-mini": "medium",
 	"openai-codex/gpt-5.5": "low",
-	"openai-codex/gpt-5.4-mini": "low",
-	"openai-codex/gpt-5.3-codex": "low",
-	"openai-codex/gpt-5.3-codex-spark": "low",
-	"openai-codex/gpt-5.2": "low",
-	"openai-codex/codex-auto-review": "low",
+	"openai-codex/gpt-5.6-luna": "low",
+	"openai-codex/gpt-5.6-sol": "low",
+	"openai-codex/gpt-5.6-terra": "low",
 } as const;
 
 type TextVerbosity = "low" | "medium" | "high";
@@ -97,16 +105,23 @@ function getConfigCwd(ctx: ExtensionContext): string {
 	return ctx.cwd || process.cwd();
 }
 
+// The second parameter keeps its pre-0.84 homeDir meaning so existing callers of the
+// exported helpers are unaffected. The agentDir default mirrors pi's getAgentDir():
+// PI_CODING_AGENT_DIR when set, otherwise `<homeDir>/.pi/agent` (which also preserves
+// the old behavior when a caller injects a custom homeDir without setting the env var).
 function getConfigPaths(
 	cwd: string,
 	homeDir: string = homedir(),
+	agentDir: string = process.env.PI_CODING_AGENT_DIR ? getAgentDir() : join(homeDir, ".pi", "agent"),
 ): {
 	projectConfigPath: string;
 	globalConfigPath: string;
+	legacyGlobalConfigPath: string;
 } {
 	return {
 		projectConfigPath: join(cwd, ".pi", "extensions", VERBOSITY_CONFIG_BASENAME),
-		globalConfigPath: join(homeDir, ".pi", "agent", "extensions", VERBOSITY_CONFIG_BASENAME),
+		globalConfigPath: join(agentDir, "extensions", VERBOSITY_CONFIG_BASENAME),
+		legacyGlobalConfigPath: join(homeDir, ".pi", "agent", "extensions", VERBOSITY_CONFIG_BASENAME),
 	};
 }
 
@@ -139,20 +154,32 @@ function writeConfigFile(filePath: string, config: VerbosityConfigFile): void {
 	}
 }
 
-function ensureDefaultConfigFile(projectConfigPath: string, globalConfigPath: string): void {
-	if (existsSync(projectConfigPath) || existsSync(globalConfigPath)) {
+function ensureDefaultConfigFile(
+	projectConfigPath: string,
+	globalConfigPath: string,
+	legacyGlobalConfigPath: string,
+): void {
+	if (existsSync(projectConfigPath) || existsSync(globalConfigPath) || existsSync(legacyGlobalConfigPath)) {
 		return;
 	}
 	writeConfigFile(globalConfigPath, DEFAULT_CONFIG_FILE);
 }
 
-function resolveVerbosityConfig(cwd: string, homeDir: string = homedir()): ResolvedVerbosityConfig {
-	const { projectConfigPath, globalConfigPath } = getConfigPaths(cwd, homeDir);
-	ensureDefaultConfigFile(projectConfigPath, globalConfigPath);
+function resolveVerbosityConfig(cwd: string, homeDir: string = homedir(), agentDir?: string): ResolvedVerbosityConfig {
+	const { projectConfigPath, globalConfigPath, legacyGlobalConfigPath } = getConfigPaths(cwd, homeDir, agentDir);
+	ensureDefaultConfigFile(projectConfigPath, globalConfigPath, legacyGlobalConfigPath);
+
+	// Configs written before this extension honored PI_CODING_AGENT_DIR live at the
+	// legacy ~/.pi/agent path; fall back to that file (read in place, never migrated)
+	// when the relocated agent directory has no config of its own.
+	const globalSourcePath =
+		!existsSync(globalConfigPath) && globalConfigPath !== legacyGlobalConfigPath && existsSync(legacyGlobalConfigPath)
+			? legacyGlobalConfigPath
+			: globalConfigPath;
 
-	const globalConfig = readConfigFile(globalConfigPath) ?? {};
+	const globalConfig = readConfigFile(globalSourcePath) ?? {};
 	const projectConfig = readConfigFile(projectConfigPath) ?? {};
-	const selectedConfigPath = existsSync(projectConfigPath) ? projectConfigPath : globalConfigPath;
+	const selectedConfigPath = existsSync(projectConfigPath) ? projectConfigPath : globalSourcePath;
 
 	return {
 		configPath: selectedConfigPath,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@benvargas/pi-openai-verbosity",
-  "version": "1.0.1",
+  "version": "1.1.1",
   "description": "Per-model OpenAI Codex text verbosity overrides for pi",
   "keywords": [
     "pi",
@@ -11,7 +11,7 @@
     "codex",
     "openai-codex",
     "gpt-5.5",
-    "gpt-5.3-codex",
+    "gpt-5.6-sol",
     "verbosity",
     "text-verbosity",
     "per-model"