npm - @bendyline/gilde - Versions diffs - 0.1.40 → 0.1.42 - Mend

@bendyline/gilde 0.1.40 → 0.1.42

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (150) hide show

package/authoring/tactical/evals/accessibility-retrofit.json ADDED Viewed

@@ -0,0 +1,230 @@
+{
+  "schemaVersion": 1,
+  "title": "Accessibility retrofit on a seeded page",
+  "objective": "The craftbook drives a real accessibility retrofit of a page seeded with five concrete violations: missing alt text on two meaningful images, a placeholder-as-label email input, a div-as-button control with no keyboard path, a heading jump from h1 to h4, and a decorative divider whose empty alt must survive untouched. Every repair is verified mechanically by string-parsing the fixed markup.",
+  "tags": [
+    "code",
+    "accessibility",
+    "a11y",
+    "tactical-fleet"
+  ],
+  "prompt": "Use the Accessibility Retrofit craftbook on this site: readers using screen readers and keyboards report the Field Notes page is unusable — images carry no descriptions, the signup field has no label, and the Join the list control cannot be reached or activated with the keyboard. Audit index.html, fix every violation at its real site in the markup, and verify the result.",
+  "setup": {
+    "projectName": "Acme Field Notes",
+    "about": "A small static newsletter site: index.html plus styles.css and a few inline SVG images. No build step and no test suite.",
+    "files": [
+      {
+        "path": "package.json",
+        "content": "{\n  \"name\": \"field-notes\",\n  \"private\": true,\n  \"version\": \"1.0.0\",\n  \"type\": \"module\"\n}\n"
+      },
+      {
+        "path": "index.html",
+        "content": "<!doctype html>\n<html lang=\"en\">\n<head>\n<meta charset=\"utf-8\">\n<meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n<title>Acme Field Notes</title>\n<link rel=\"stylesheet\" href=\"styles.css\">\n</head>\n<body>\n<div class=\"masthead\">\n  <h1>Acme Field Notes</h1>\n  <img src=\"images/divider.svg\" class=\"divider\" alt=\"\">\n</div>\n<div class=\"content\">\n  <h4>Latest dispatch</h4>\n  <img src=\"images/harvest-crew.svg\" class=\"feature\">\n  <p>The harvest crew finished the north field on Tuesday, two days ahead of schedule, and moved on to the orchard rows.</p>\n  <h4>Sign up for dispatches</h4>\n  <p>Get the weekly note by email.</p>\n  <input type=\"email\" placeholder=\"Your email address\">\n  <div class=\"button\" onclick=\"joinList()\">Join the list</div>\n  <p id=\"joined-note\" hidden>You are on the list.</p>\n  <h4>From the archive</h4>\n  <img src=\"images/seed-chart.svg\" class=\"feature\">\n  <p>Germination rates for the last five seasons, charted by seed lot and sowing week.</p>\n</div>\n<script>\nfunction joinList() {\n  document.getElementById('joined-note').hidden = false;\n}\n</script>\n</body>\n</html>\n"
+      },
+      {
+        "path": "styles.css",
+        "content": "body { margin: 0; font-family: Georgia, serif; color: #222; background: #faf8f4; }\n.masthead { padding: 2rem 1.5rem 0; }\n.divider { width: 100%; height: 12px; }\n.content { max-width: 40rem; padding: 1rem 1.5rem 3rem; }\n.feature { max-width: 100%; }\n.button { display: inline-block; padding: 0.5rem 1rem; background: #2e5d3b; color: #fff; cursor: pointer; }\n.button:hover { background: #234a2e; }\ninput[type=\"email\"] { padding: 0.5rem; width: 16rem; }\n"
+      },
+      {
+        "path": "images/harvest-crew.svg",
+        "content": "<svg xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 320 180\"><rect width=\"320\" height=\"180\" fill=\"#dce8d8\"/><text x=\"16\" y=\"95\" font-size=\"16\">Harvest crew walking the north field at dawn</text></svg>\n"
+      },
+      {
+        "path": "images/seed-chart.svg",
+        "content": "<svg xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 320 180\"><rect width=\"320\" height=\"180\" fill=\"#e8e2d4\"/><text x=\"16\" y=\"95\" font-size=\"16\">Germination rate by season, 2021 to 2025</text></svg>\n"
+      },
+      {
+        "path": "images/divider.svg",
+        "content": "<svg xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 320 12\"><line x1=\"0\" y1=\"6\" x2=\"320\" y2=\"6\" stroke=\"#b8b0a0\" stroke-width=\"2\"/></svg>\n"
+      },
+      {
+        "path": "tests/verify-retrofit.mjs",
+        "surface": "harness",
+        "content": "import assert from 'node:assert/strict';\nimport { readFileSync } from 'node:fs';\n\nconst html = readFileSync('index.html', 'utf8');\n\nfunction imgTag(src) {\n  const tags = [...html.matchAll(/<img\\b[^>]*>/gi)].map((m) => m[0]);\n  const tag = tags.find((t) => t.includes(src));\n  assert.ok(tag, `an img referencing ${src} still exists`);\n  return tag;\n}\nfunction altOf(tag, src) {\n  const alt = tag.match(/\\balt\\s*=\\s*(\"([^\"]*)\"|'([^']*)')/i);\n  assert.ok(alt, `image ${src} carries an alt attribute`);\n  return alt[2] ?? alt[3] ?? '';\n}\n\n// 1) Meaningful images: specific, non-empty alt text.\nfor (const src of ['harvest-crew', 'seed-chart']) {\n  const alt = altOf(imgTag(src), src).trim();\n  assert.ok(alt.length >= 10, `alt for ${src} must be specific, got \"${alt}\"`);\n  assert.ok(!/^(image|photo|picture|graphic|img)$/i.test(alt), `alt for ${src} must not be filler`);\n  assert.ok(!/^(an? )?(image|photo|picture) of/i.test(alt), `alt for ${src} must not open with \"image of\"`);\n}\nconsole.log('A11YRETRO_ORACLE alts ok');\n\n// 2) The decorative divider keeps an EMPTY alt - no sprayed description.\nassert.equal(altOf(imgTag('divider'), 'divider').trim(), '', 'decorative divider keeps alt=\"\"');\nconsole.log('A11YRETRO_ORACLE decorative ok');\n\n// 3) The email input is labeled by a real label whose for resolves to its id.\nconst labels = [...html.matchAll(/<label\\b[^>]*\\bfor\\s*=\\s*[\"']([^\"']+)[\"'][^>]*>/gi)];\nassert.ok(labels.length >= 1, 'a label element with a for attribute exists');\nconst paired = labels.filter((m) => new RegExp(`<input\\\\b[^>]*\\\\bid\\\\s*=\\\\s*[\"']${m[1]}[\"']`, 'i').test(html));\nassert.ok(paired.length >= 1, \"a label's for attribute resolves to a real input id\");\nconsole.log('A11YRETRO_ORACLE label ok');\n\n// 4) The join control is a real button, or carries complete ARIA button semantics.\nconst join = html.match(/<([a-z0-9]+)\\b([^>]*)>\\s*Join the list/i);\nassert.ok(join, 'the \"Join the list\" control still exists');\nconst [, joinTag, joinAttrs] = join;\nif (joinTag.toLowerCase() !== 'button') {\n  assert.ok(/\\brole\\s*=\\s*[\"']button[\"']/i.test(joinAttrs), 'non-button control carries role=\"button\"');\n  assert.ok(/\\btabindex\\s*=\\s*[\"']0[\"']/i.test(joinAttrs), 'non-button control is focusable via tabindex=\"0\"');\n  const keyWired = /\\bonkey(?:down|up|press)\\s*=/i.test(joinAttrs) || /addEventListener\\s*\\(\\s*[\"']key(?:down|up|press)[\"']/i.test(html);\n  assert.ok(keyWired, 'non-button control has keyboard activation wired');\n}\nconsole.log('A11YRETRO_ORACLE control ok');\n\n// 5) Heading order is monotonic from a single h1.\nconst levels = [...html.matchAll(/<h([1-6])\\b[^>]*>/gi)].map((m) => Number(m[1]));\nassert.ok(levels.length >= 3, 'the page keeps its headings');\nassert.equal(levels[0], 1, 'the page starts at h1');\nfor (let i = 1; i < levels.length; i++) {\n  assert.ok(levels[i] <= levels[i - 1] + 1, `heading level jumps from h${levels[i - 1]} to h${levels[i]}`);\n}\nconsole.log('A11YRETRO_ORACLE headings ok');\n\n// 6) The join behavior target survives the retrofit.\nassert.ok(/joined-note/.test(html), 'the joined-note behavior target survives');\nconsole.log('A11YRETRO_ORACLE done');\n"
+      }
+    ],
+    "craftbookParams": {
+      "workPath": "tasks/eval"
+    }
+  },
+  "success": {
+    "summary": "All five seeded violations are repaired at their real sites in index.html — specific alts on the meaningful images, an empty alt preserved on the decorative divider, a paired label, a keyboard-operable join control, monotonic headings — and every fleet artifact exists with honest citations.",
+    "deliverables": [
+      {
+        "path": "tasks/eval/audit.md",
+        "kind": "markdown-notes",
+        "artifact": true,
+        "minBytes": 600,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/audit.md",
+            "pattern": "^##\\s+Scope[\\s\\S]*^##\\s+Violations[\\s\\S]*^##\\s+Priorities",
+            "flags": "im",
+            "label": "audit sections in order"
+          },
+          {
+            "kind": "tableShape",
+            "file": "tasks/eval/audit.md",
+            "requiredColumns": [
+              "File",
+              "Issue",
+              "Priority"
+            ],
+            "minRows": 3,
+            "artifact": true
+          },
+          {
+            "kind": "citationsResolve",
+            "file": "tasks/eval/audit.md",
+            "minCitations": 2,
+            "artifact": true
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/audit.md",
+            "pattern": "index\\.html",
+            "label": "the audit names the real page"
+          }
+        ]
+      },
+      {
+        "path": "tasks/eval/fix-notes.md",
+        "kind": "markdown-notes",
+        "artifact": true,
+        "minBytes": 700,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/fix-notes.md",
+            "pattern": "^##\\s+Problem[\\s\\S]*^##\\s+Change[\\s\\S]*^##\\s+Files touched[\\s\\S]*^##\\s+Per-violation disposition[\\s\\S]*^##\\s+Risk[\\s\\S]*^##\\s+How to verify",
+            "flags": "im",
+            "label": "fix-notes sections in order"
+          },
+          {
+            "kind": "citationsResolve",
+            "file": "tasks/eval/fix-notes.md",
+            "minCitations": 2,
+            "artifact": true
+          }
+        ]
+      },
+      {
+        "path": "tasks/eval/validation.md",
+        "kind": "markdown-notes",
+        "artifact": true,
+        "minBytes": 500,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/validation.md",
+            "pattern": "^##\\s+Per-item verification[\\s\\S]*^##\\s+Keyboard walk[\\s\\S]*^##\\s+Result",
+            "flags": "im",
+            "label": "validation sections in order"
+          }
+        ]
+      },
+      {
+        "path": "tasks/eval/review.md",
+        "kind": "markdown-report",
+        "artifact": true,
+        "minBytes": 400,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/review.md",
+            "pattern": "Verdict:\\s*(?:PASS|REVISE)",
+            "flags": "i",
+            "label": "explicit reviewer verdict"
+          }
+        ]
+      }
+    ],
+    "checks": [
+      {
+        "kind": "notContains",
+        "file": "index.html",
+        "pattern": "<img\\b(?![^>]*\\balt\\s*=)[^>]*>",
+        "label": "no image is missing its alt attribute"
+      },
+      {
+        "kind": "htmlLint",
+        "file": "index.html"
+      },
+      {
+        "kind": "nodeScriptPasses",
+        "script": "tests/verify-retrofit.mjs",
+        "timeoutMs": 60000,
+        "requiredOutput": [
+          {
+            "pattern": "A11YRETRO_ORACLE alts ok",
+            "label": "meaningful images carry specific alt text"
+          },
+          {
+            "pattern": "A11YRETRO_ORACLE decorative ok",
+            "label": "the decorative divider keeps its empty alt"
+          },
+          {
+            "pattern": "A11YRETRO_ORACLE label ok",
+            "label": "the label's for pairs with a real input id"
+          },
+          {
+            "pattern": "A11YRETRO_ORACLE control ok",
+            "label": "the join control is keyboard-operable"
+          },
+          {
+            "pattern": "A11YRETRO_ORACLE headings ok",
+            "label": "heading order is monotonic"
+          }
+        ]
+      }
+    ],
+    "taskNotes": {
+      "minBytes": 120,
+      "checks": [
+        {
+          "kind": "contains",
+          "file": "task-notes.md",
+          "pattern": "\\bDONE\\b[\\s\\S]*(validation\\.md|fix-notes\\.md|audit\\.md)",
+          "flags": "i",
+          "label": "DONE note names the deliverables"
+        }
+      ]
+    },
+    "taskGraph": {
+      "requireCraftbookTask": true,
+      "requireTerminalStep": true
+    },
+    "unchangedFixtures": [
+      "package.json",
+      "images/harvest-crew.svg",
+      "images/seed-chart.svg",
+      "images/divider.svg"
+    ]
+  },
+  "rubric": {
+    "artifact": {
+      "path": "tasks/eval/fix-notes.md",
+      "kind": "markdown"
+    },
+    "axes": [
+      {
+        "name": "Real-site repair",
+        "description": "Violations were fixed in the actual markup with semantic elements preferred over ARIA bolt-ons — a real button and a real label rather than aria-label sprayed on divs."
+      },
+      {
+        "name": "Classification judgment",
+        "description": "Meaningful versus decorative images were classified correctly: specific purposeful alt text for the content images, an empty alt preserved on the divider, and the decorative call stated in the notes."
+      },
+      {
+        "name": "Honest verification trail",
+        "description": "Audit, fix-notes, and validation reconcile item for item, and validation separates what was inspected in the code from what was actually exercised."
+      }
+    ]
+  },
+  "qualityFocus": [
+    "real-site fixes over ARIA theater",
+    "content vs decorative image judgment",
+    "enforced review loop"
+  ]
+}

package/authoring/tactical/evals/apply-review-findings.json ADDED Viewed

@@ -0,0 +1,290 @@
+{
+  "schemaVersion": 1,
+  "title": "Apply review findings with a reconciled ledger",
+  "objective": "The craftbook drives a real findings pass: three seeded review findings (unvalidated numeric input, a swallowed error, a misleading error message) read from an artifacts-drawer findings file, triaged against the current code, fixed at their actual sites, and verified per finding - with behavior probes proving each one genuinely closed and the neighborhood suite still green.",
+  "tags": [
+    "code",
+    "review-findings",
+    "bug-fix",
+    "tactical-fleet"
+  ],
+  "prompt": "Use the Apply Review Findings craftbook: last week's code review left three findings in the artifacts drawer at reviews/findings.json. Triage them against the current code, fix what is real at the real sites, and account for every finding.",
+  "setup": {
+    "projectName": "Order Intake",
+    "about": "A tiny order-intake library (quantity parsing, config loading, discounts). Tests run with `npm run test` (node --test).",
+    "files": [
+      {
+        "path": "package.json",
+        "content": "{\n  \"name\": \"intake\",\n  \"private\": true,\n  \"version\": \"1.0.0\",\n  \"type\": \"module\",\n  \"scripts\": {\n    \"test\": \"node --test\"\n  }\n}\n",
+        "modelInput": false
+      },
+      {
+        "path": "src/quantity.js",
+        "content": "export function parseQuantity(raw) {\n  return parseInt(raw, 10);\n}\n\nexport function clampQuantity(qty, max) {\n  return Math.min(qty, max);\n}\n"
+      },
+      {
+        "path": "src/config.js",
+        "content": "import { readFileSync } from 'node:fs';\n\nexport function loadConfig(path) {\n  try {\n    return JSON.parse(readFileSync(path, 'utf8'));\n  } catch (err) {\n    return {};\n  }\n}\n"
+      },
+      {
+        "path": "src/discount.js",
+        "content": "export function applyDiscount(total, percent) {\n  if (percent < 0 || percent > 100) {\n    throw new Error('quantity out of range');\n  }\n  return Math.round(total * (1 - percent / 100) * 100) / 100;\n}\n"
+      },
+      {
+        "path": "tests/intake.test.mjs",
+        "content": "import assert from 'node:assert/strict';\nimport { test } from 'node:test';\nimport { parseQuantity } from '../src/quantity.js';\nimport { applyDiscount } from '../src/discount.js';\nimport { loadConfig } from '../src/config.js';\n\ntest('parseQuantity reads plain integers', () => {\n  assert.equal(parseQuantity('3'), 3);\n  assert.equal(parseQuantity('12'), 12);\n});\n\ntest('applyDiscount takes a percentage off', () => {\n  assert.equal(applyDiscount(100, 10), 90);\n  assert.equal(applyDiscount(80, 0), 80);\n});\n\ntest('loadConfig falls back to defaults for a missing file', () => {\n  assert.deepEqual(loadConfig('no-such-config.json'), {});\n});\n",
+        "modelInput": false
+      },
+      {
+        "path": "reviews/findings.json",
+        "surface": "artifact",
+        "content": "[\n  {\n    \"id\": \"RV-1\",\n    \"file\": \"src/quantity.js\",\n    \"severity\": \"major\",\n    \"title\": \"parseQuantity accepts invalid numeric input\",\n    \"detail\": \"parseInt returns NaN for non-numeric input, and negative or zero values pass through unchecked, so downstream order math silently corrupts. parseQuantity must return only positive integers and throw a RangeError naming the rejected value for anything else.\",\n    \"verify\": \"parseQuantity('abc'), parseQuantity('-2'), and parseQuantity('0') must throw; parseQuantity('3') must still return 3.\"\n  },\n  {\n    \"id\": \"RV-2\",\n    \"file\": \"src/config.js\",\n    \"severity\": \"major\",\n    \"title\": \"loadConfig swallows JSON syntax errors\",\n    \"detail\": \"The catch returns {} for every failure, so a corrupt config file silently behaves like an empty one and a bad deploy ships. Only a missing file may fall back to {}; a parse failure must propagate to the caller.\",\n    \"verify\": \"loadConfig on a file containing invalid JSON must throw; loadConfig on a missing path must still return {}.\"\n  },\n  {\n    \"id\": \"RV-3\",\n    \"file\": \"src/discount.js\",\n    \"severity\": \"minor\",\n    \"title\": \"applyDiscount raises a misleading error message\",\n    \"detail\": \"An out-of-range percent raises 'quantity out of range', so support keeps chasing phantom quantity bugs. The message must describe the discount percent that was rejected.\",\n    \"verify\": \"applyDiscount(100, 150) must throw with a message that mentions the discount or percent, not quantity.\"\n  }\n]\n"
+      },
+      {
+        "path": "tests/verify-findings.mjs",
+        "surface": "harness",
+        "content": "import assert from 'node:assert/strict';\nimport { execFileSync } from 'node:child_process';\nimport { rmSync, writeFileSync } from 'node:fs';\nimport { join } from 'node:path';\nimport { parseQuantity } from '../src/quantity.js';\nimport { loadConfig } from '../src/config.js';\nimport { applyDiscount } from '../src/discount.js';\n\nconst root = process.cwd();\n\n// RV-1: parseQuantity accepts only positive integers, and still parses them.\nassert.equal(parseQuantity('3'), 3, \"parseQuantity('3') must still return 3\");\nassert.equal(parseQuantity('12'), 12, \"parseQuantity('12') must still return 12\");\nassert.throws(() => parseQuantity('abc'), \"parseQuantity('abc') must throw\");\nassert.throws(() => parseQuantity('-2'), \"parseQuantity('-2') must throw\");\nassert.throws(() => parseQuantity('0'), \"parseQuantity('0') must throw\");\nconsole.log('FINDINGS_ORACLE rv1 closed');\n\n// RV-2: a corrupt config raises; a missing config still falls back to {}.\nconst corruptPath = join(root, '.oracle-corrupt-config.json');\nwriteFileSync(corruptPath, '{ not json');\nassert.throws(() => loadConfig(corruptPath), 'a corrupt config must raise, not vanish into defaults');\nrmSync(corruptPath, { force: true });\nassert.deepEqual(loadConfig(join(root, 'no-such-config.json')), {}, 'a missing config must still fall back to {}');\nconsole.log('FINDINGS_ORACLE rv2 closed');\n\n// RV-3: the out-of-range message describes the discount, not the quantity.\nlet threw = false;\nlet message = '';\ntry {\n  applyDiscount(100, 150);\n} catch (err) {\n  threw = true;\n  message = String((err && err.message) || err);\n}\nassert.ok(threw, 'applyDiscount(100, 150) must throw');\nassert.match(message, /discount|percent/i, 'the error must describe the discount percent');\nassert.ok(!/quantity/i.test(message), 'the error must not blame quantity');\nassert.equal(applyDiscount(100, 10), 90, 'valid discounts must still work');\nassert.equal(applyDiscount(80, 0), 80, 'a zero discount must still be allowed');\nconsole.log('FINDINGS_ORACLE rv3 closed');\n\n// The neighborhood suite stays green after the findings pass.\nexecFileSync(process.execPath, ['--test'], { cwd: root, stdio: 'pipe', timeout: 30000 });\nconsole.log('FINDINGS_ORACLE suite green');\nconsole.log('FINDINGS_ORACLE done');\n"
+      }
+    ],
+    "craftbookParams": {
+      "workPath": "tasks/eval",
+      "findingsPath": "reviews/findings.json"
+    }
+  },
+  "success": {
+    "summary": "All three seeded findings are genuinely closed at their real sites (validated quantity input, propagating config parse errors, an honest discount message), the neighborhood tests stay green, and the finding ids reconcile across triage, fix notes, and verification.",
+    "deliverables": [
+      {
+        "path": "tasks/eval/triage.md",
+        "kind": "markdown-notes",
+        "artifact": true,
+        "minBytes": 600,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/triage.md",
+            "pattern": "^##\\s+Findings read[\\s\\S]*^##\\s+Will fix[\\s\\S]*^##\\s+Deferred[\\s\\S]*^##\\s+Clusters",
+            "flags": "im",
+            "label": "triage sections in order"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/triage.md",
+            "pattern": "\\bRV-1\\b",
+            "label": "finding RV-1 triaged"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/triage.md",
+            "pattern": "\\bRV-2\\b",
+            "label": "finding RV-2 triaged"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/triage.md",
+            "pattern": "\\bRV-3\\b",
+            "label": "finding RV-3 triaged"
+          },
+          {
+            "kind": "citationsResolve",
+            "file": "tasks/eval/triage.md",
+            "minCitations": 2,
+            "artifact": true
+          }
+        ]
+      },
+      {
+        "path": "tasks/eval/fix-notes.md",
+        "kind": "markdown-notes",
+        "artifact": true,
+        "minBytes": 700,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/fix-notes.md",
+            "pattern": "^##\\s+Problem[\\s\\S]*^##\\s+Change[\\s\\S]*^##\\s+Files touched[\\s\\S]*^##\\s+Per-finding disposition[\\s\\S]*^##\\s+Risk[\\s\\S]*^##\\s+How to verify",
+            "flags": "im",
+            "label": "fix-notes sections in order"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/fix-notes.md",
+            "pattern": "\\bRV-1\\b",
+            "label": "disposition for RV-1"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/fix-notes.md",
+            "pattern": "\\bRV-2\\b",
+            "label": "disposition for RV-2"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/fix-notes.md",
+            "pattern": "\\bRV-3\\b",
+            "label": "disposition for RV-3"
+          },
+          {
+            "kind": "citationsResolve",
+            "file": "tasks/eval/fix-notes.md",
+            "minCitations": 2,
+            "artifact": true
+          }
+        ]
+      },
+      {
+        "path": "tasks/eval/validation.md",
+        "kind": "markdown-notes",
+        "artifact": true,
+        "minBytes": 450,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/validation.md",
+            "pattern": "^##\\s+Per-finding verification[\\s\\S]*^##\\s+Result",
+            "flags": "im",
+            "label": "validation sections in order"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/validation.md",
+            "pattern": "\\bRV-1\\b",
+            "label": "verification for RV-1"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/validation.md",
+            "pattern": "\\bRV-2\\b",
+            "label": "verification for RV-2"
+          },
+          {
+            "kind": "contains",
+            "file": "tasks/eval/validation.md",
+            "pattern": "\\bRV-3\\b",
+            "label": "verification for RV-3"
+          },
+          {
+            "kind": "citationsResolve",
+            "file": "tasks/eval/validation.md",
+            "minCitations": 2,
+            "artifact": true
+          }
+        ]
+      },
+      {
+        "path": "tasks/eval/review.md",
+        "kind": "markdown-report",
+        "artifact": true,
+        "minBytes": 400,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "tasks/eval/review.md",
+            "pattern": "Verdict:\\s*(?:PASS|REVISE)",
+            "flags": "i",
+            "label": "explicit reviewer verdict"
+          }
+        ]
+      }
+    ],
+    "checks": [
+      {
+        "kind": "notContains",
+        "file": "src/discount.js",
+        "pattern": "quantity out of range",
+        "label": "the misleading discount message is gone (RV-3)"
+      },
+      {
+        "kind": "notContains",
+        "file": "src/config.js",
+        "pattern": "catch\\s*(?:\\([^)]*\\))?\\s*\\{\\s*return\\s*\\{\\s*\\}",
+        "label": "the blanket error swallow is gone (RV-2)"
+      },
+      {
+        "kind": "sourceParses",
+        "file": "src/quantity.js"
+      },
+      {
+        "kind": "sourceParses",
+        "file": "src/config.js"
+      },
+      {
+        "kind": "sourceParses",
+        "file": "src/discount.js"
+      },
+      {
+        "kind": "nodeRuns",
+        "file": "tests/intake.test.mjs",
+        "timeoutMs": 30000
+      },
+      {
+        "kind": "nodeScriptPasses",
+        "script": "tests/verify-findings.mjs",
+        "timeoutMs": 60000,
+        "requiredOutput": [
+          {
+            "pattern": "FINDINGS_ORACLE rv1 closed",
+            "label": "invalid quantities are rejected (RV-1)"
+          },
+          {
+            "pattern": "FINDINGS_ORACLE rv2 closed",
+            "label": "corrupt configs raise, missing configs default (RV-2)"
+          },
+          {
+            "pattern": "FINDINGS_ORACLE rv3 closed",
+            "label": "the discount error names the discount (RV-3)"
+          },
+          {
+            "pattern": "FINDINGS_ORACLE suite green",
+            "label": "the neighborhood suite stays green"
+          }
+        ]
+      }
+    ],
+    "taskNotes": {
+      "minBytes": 120,
+      "checks": [
+        {
+          "kind": "contains",
+          "file": "task-notes.md",
+          "pattern": "\\bDONE\\b[\\s\\S]*validation\\.md",
+          "flags": "i",
+          "label": "DONE note names the validation deliverable"
+        }
+      ]
+    },
+    "taskGraph": {
+      "requireCraftbookTask": true,
+      "requireTerminalStep": true
+    },
+    "unchangedFixtures": [
+      "package.json",
+      "tests/intake.test.mjs"
+    ]
+  },
+  "rubric": {
+    "artifact": {
+      "path": "tasks/eval/fix-notes.md",
+      "kind": "markdown"
+    },
+    "axes": [
+      {
+        "name": "Triage honesty",
+        "description": "Every finding is judged against the code as it stands, with a defensible category and no invented or dropped findings."
+      },
+      {
+        "name": "Real closure",
+        "description": "Each fix lands at the actual cited site and genuinely resolves what the finding describes - validation added, errors propagated, messages made truthful - with the smallest correct change."
+      },
+      {
+        "name": "Ledger discipline",
+        "description": "The same finding ids flow through triage, fix notes, and verification with consistent outcomes, and verification honestly separates what was run from what was only read."
+      }
+    ]
+  },
+  "qualityFocus": [
+    "per-finding accountability",
+    "smallest correct change",
+    "honest verification"
+  ]
+}