@bendyline/gilde 0.1.19 → 0.1.21

package/data/craftbook-templates/pu/pull-request-review/manifest.json

@@ -4,7 +4,7 @@
   "id": "pull-request-review",
   "role": "maintenance-review",
   "name": "Pull Request Review",
-  "description": "Staff-engineer-style PR review. Defaults to the open pull request for the project's checked-out branch, walks its per-file diff, applies a safety/quality checklist, and posts a structured summary. Requires a GitHub-connected project on a feature branch.",
+  "description": "Staff-engineer-style PR review. Defaults to the open pull request for the project's checked-out branch when one exists, accepts an explicit PR number from any branch, walks the full diff, and produces a structured local verdict. Requires a GitHub-connected project.",
   "tags": [
     "review",
     "pull-request",

package/data/craftbook-templates/pu/pull-request-review/versions/1.3.0/craftbook.json

@@ -0,0 +1,156 @@
+{
+  "id": "pull-request-review",
+  "name": "Pull Request Review",
+  "description": "Review a GitHub pull request and deliver a gated, evidence-based report. This is the PR-aware companion to Code Review: it accepts an explicit PR number from any branch, otherwise resolves the unique open PR for the project's checked-out branch, reads PR metadata, comments, files, and diff through the GitHub toolset, and writes `pr-review.md` without modifying source or posting back to GitHub. Three steps:\n\n1. **Scope the PR** — select an explicit PR number or the unique current-branch match and record the review surface\n2. **Review and report** — walk every changed file, cite concrete `path:line` evidence, and write a severity-ranked report\n3. **Deliver the verdict** — summarize approve vs request-changes in task notes\n\nThe craftbook stays available on `main`, `master`, and when the local branch is unknown because an explicit PR number is always valid. If no number is supplied and the current branch has no unique open PR, the reviewer asks instead of silently choosing another branch's PR.",
+  "basedOn": {
+    "name": "Gezel Code Review",
+    "url": "https://github.com/bendyline/gezel"
+  },
+  "entryStepId": "scope",
+  "triggers": [
+    "review this pr",
+    "review the current pr",
+    "review this pull request",
+    "pr review",
+    "review the github pull request"
+  ],
+  "requirements": [
+    {
+      "kind": "github"
+    }
+  ],
+  "toolsets": [
+    {
+      "toolsetId": "github",
+      "optional": true,
+      "autoAllow": true,
+      "reason": "read pull-request metadata, comments, changed files, and the unified diff"
+    }
+  ],
+  "paramSchema": {
+    "type": "object",
+    "properties": {
+      "number": {
+        "type": "number",
+        "title": "Pull request number",
+        "description": "Optional PR number. Leave blank to use the open PR whose head matches the project's checked-out branch."
+      },
+      "focus": {
+        "type": "string",
+        "title": "Review focus",
+        "description": "Optional area to emphasize, e.g. security, performance, or tests."
+      },
+      "intensity": {
+        "type": "string",
+        "title": "Intensity",
+        "enum": [
+          "low",
+          "medium",
+          "high"
+        ],
+        "default": "medium",
+        "squisq": {
+          "control": "segmented"
+        },
+        "description": "How deep to go on the diff walk."
+      }
+    }
+  },
+  "steps": [
+    {
+      "id": "scope",
+      "name": "Scope the pull request",
+      "description": "Resolve an explicit PR or the unique open PR for the checked-out branch, then record its metadata, changed files, existing review context, and review themes.",
+      "prompt": "**You are reviewing a pull request, not authoring it. Never modify project source in this craftbook.**\n\n**Your first tool call this turn:** `github_pr_list({})`. It lists open PRs for this project, puts PRs whose head matches the checked-out branch first, and marks a unique one `Current branch match — default`.\n\nSelect the PR with this precedence:\n\n1. If the invocation parameters or user message supply a PR number, use it.\n2. Otherwise use the unique `Current branch match — default`.\n3. If multiple PRs match the current branch, or no PR matches and more than one PR is open, call `ask_user_question` with the concrete choices. Never take an unrelated first result.\n4. If no PR is open, write a task note explaining that and stop.\n\nFor the selected number, call `github_pr_view`, `github_pr_files`, and `github_pr_comments`. Read the title/body, head and base branches, file list, additions/deletions, and any feedback already raised so you do not duplicate it. Then write ONE task note beginning `## Scope — PR #<number>` and include: title, URL, head → base, draft state, changed-file list, existing-review themes, and 3–6 review themes weighted by the requested focus and intensity. End by calling `advance_task_step`.",
+      "suggestedRole": "reviewer",
+      "gate": {
+        "at": "completion",
+        "scripts": [
+          {
+            "name": "checkTaskNoteContains",
+            "scope": "standard",
+            "inputs": {
+              "pattern": "##\\s*Scope\\s*[—-]\\s*PR\\s*#\\d+"
+            }
+          }
+        ],
+        "onReject": "scope",
+        "maxAttempts": 3
+      },
+      "next": "report"
+    },
+    {
+      "id": "report",
+      "name": "Review and write the report",
+      "description": "Walk the full PR diff and every changed file, then write a gated report with concrete citations and a verdict. The report is local; this recipe never posts to GitHub automatically.",
+      "prompt": "Use the PR number selected in the Scope note. Call `github_pr_diff` for the complete unified diff and `github_pr_files` for the per-file patches. Walk every changed file and review for correctness, security, data-loss risk, error handling, concurrency, compatibility, tests, and clarity — weighted by the requested focus and intensity. Use `read_file` only when you need surrounding workspace context. Do not repeat an existing PR comment unless the issue still needs action and you explicitly say it was already raised.\n\nCite every finding as `path:line` using a changed path and a line from the new side of the diff. Do not invent files, behavior, or line numbers. Any critical or major finding requires `request-changes`; otherwise use `approve`.\n\nWrite `pr-review.md` in ONE `write_file` call using exactly this skeleton:\n\n```\n# Pull Request Review — PR #<number>: <title>\n\n## Summary\n<2–6 sentences: what changes, overall risk, and whether existing comments cover any issue. Say \"No findings.\" when there are none.>\n\n## Findings\n| # | Severity | File | Line | Finding | Recommendation |\n|---|----------|------|------|---------|----------------|\n<one row per finding; severities: critical, major, minor, nit. Keep the header when there are no findings.>\n\n## Verdict\nVerdict: approve\n<or> Verdict: request-changes\n<one sentence of rationale>\n```\n\nDo not modify source and do not call `github_pr_comment`; the user asked for a review report, not an automatic public side effect. If the gate rejects, fix exactly the named gap and rewrite the whole report. Then call `advance_task_step`.",
+      "suggestedRole": "reviewer",
+      "advanceWhen": {
+        "file": "pr-review.md",
+        "minBytes": 500
+      },
+      "gate": {
+        "at": "completion",
+        "checks": [
+          {
+            "kind": "minBytes",
+            "file": "pr-review.md",
+            "bytes": 500
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "#\\s+Pull Request Review\\s+[—-]\\s+PR\\s+#\\d+",
+            "label": "PR-numbered title"
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "##\\s+Summary",
+            "label": "Summary section"
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "##\\s+Findings",
+            "label": "Findings section"
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "\\|\\s*Severity\\s*\\|",
+            "label": "findings table header"
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "Verdict:\\s*(approve|request-changes)",
+            "label": "verdict line"
+          },
+          {
+            "kind": "tableShape",
+            "file": "pr-review.md",
+            "requiredColumns": [
+              "Severity",
+              "File",
+              "Finding"
+            ]
+          }
+        ],
+        "onReject": "report",
+        "maxAttempts": 4
+      },
+      "next": "done"
+    },
+    {
+      "id": "done",
+      "name": "Deliver the verdict",
+      "description": "The report passed its gates. Summarize the verdict and point the user to the local report.",
+      "prompt": "Read `pr-review.md`, then write one final task note with `write_task_note`: `PR #<number> — Verdict: <approve|request-changes> — N findings (a critical, b major, c minor, d nit)` plus a one-paragraph summary. Tell the user the full local review is at `pr-review.md` and was not posted to GitHub. Then call `advance_task_step` to complete the task.",
+      "suggestedRole": "reviewer",
+      "terminal": true
+    }
+  ],
+  "version": "1.3.0",
+  "releasedAt": "2026-08-10T00:00:00Z"
+}

package/data/craftbook-templates/pu/pull-request-review/versions/1.3.0/test.json

@@ -0,0 +1,172 @@
+{
+  "schemaVersion": 1,
+  "title": "Current-branch pull request review",
+  "objective": "Verify that Pull Request Review selects the PR marked as the checked-out branch default, inspects its GitHub metadata and diff through a deterministic MCP fixture, and writes a cited request-changes report without posting to GitHub.",
+  "tags": [
+    "external",
+    "mcp",
+    "pull-request"
+  ],
+  "prompt": "Run the Pull Request Review craftbook for the current checked-out branch. The fake GitHub toolset is local and deterministic; do not use real network or credentials. Review the PR marked as the current-branch default, not unrelated PR #41. Write the complete local review to pr-review.md and do not post a GitHub comment.",
+  "setup": {
+    "projectName": "Current Branch PR Review Eval",
+    "about": "A local fixture project whose checked-out branch is codex/pr-review. GitHub operations are supplied by the fake github MCP toolset.",
+    "missionObjectives": "Review the open PR for codex/pr-review, cite concrete changed-file lines, identify the insecure fallback credential, and deliver pr-review.md without public side effects.",
+    "files": [
+      {
+        "path": "src/auth.ts",
+        "content": "export function isAdmin(token: string): boolean {\n  const expected = process.env.ADMIN_API_KEY || 'dev-admin-key';\n  return token === expected;\n}\n"
+      },
+      {
+        "path": "source/eval-context.md",
+        "content": "# Eval context\n\nThe checked-out branch is `codex/pr-review`. PR #52 is the only open pull request whose head matches that branch. PR #41 is unrelated and must not be reviewed.\n"
+      }
+    ],
+    "worker": {
+      "name": "Rina",
+      "role": "Reviewer",
+      "description": "A careful code reviewer who grounds findings in changed lines."
+    }
+  },
+  "mocks": [
+    {
+      "kind": "mcp",
+      "id": "github",
+      "toolsetId": "github",
+      "description": "Fake GitHub PR tools with two open PRs; PR #52 is the unique current-branch match and PR #41 is unrelated.",
+      "tools": [
+        {
+          "name": "github_pr_list",
+          "description": "List open PRs, prioritizing and marking the checked-out branch match.",
+          "resultTemplate": "#52 — Add admin API-key authentication (alex, codex/pr-review → main)\n  https://github.example.test/acme/widget/pull/52\n  Current branch match — default: codex/pr-review\n\n#41 — Refactor invoice export (sam, feature/invoice-export → main)\n  https://github.example.test/acme/widget/pull/41"
+        },
+        {
+          "name": "github_pr_view",
+          "description": "Fetch PR metadata for a selected number.",
+          "resultTemplate": "#52 — Add admin API-key authentication\nAuthor: alex\nBranches: codex/pr-review → main\nState: OPEN\nChanges: +4 −0 across 1 file(s)\nURL: https://github.example.test/acme/widget/pull/52\n\nAdds an API-key check for admin routes."
+        },
+        {
+          "name": "github_pr_files",
+          "description": "List changed files and patches for a selected PR.",
+          "resultTemplate": "src/auth.ts — added (+4 −0)\n```diff\n@@ -0,0 +1,4 @@\n+export function isAdmin(token: string): boolean {\n+  const expected = process.env.ADMIN_API_KEY || 'dev-admin-key';\n+  return token === expected;\n+}\n```"
+        },
+        {
+          "name": "github_pr_diff",
+          "description": "Fetch the full unified diff for a selected PR.",
+          "resultTemplate": "diff --git a/src/auth.ts b/src/auth.ts\nnew file mode 100644\n--- /dev/null\n+++ b/src/auth.ts\n@@ -0,0 +1,4 @@\n+export function isAdmin(token: string): boolean {\n+  const expected = process.env.ADMIN_API_KEY || 'dev-admin-key';\n+  return token === expected;\n+}\n"
+        },
+        {
+          "name": "github_pr_comments",
+          "description": "List existing PR comments.",
+          "resultTemplate": "No comments on this PR."
+        },
+        {
+          "name": "github_pr_comment",
+          "description": "Post a PR comment. Present only so the eval can prove the review recipe does not call it.",
+          "resultTemplate": {
+            "id": 9001,
+            "url": "https://github.example.test/acme/widget/pull/52#comment-9001"
+          }
+        }
+      ]
+    }
+  ],
+  "success": {
+    "summary": "pr-review.md reviews PR #52 (the unique current-branch match), cites src/auth.ts, flags the hard-coded fallback credential, requests changes, and never calls the GitHub comment tool.",
+    "deliverables": [
+      {
+        "path": "pr-review.md",
+        "kind": "markdown-report",
+        "minBytes": 500,
+        "checks": [
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "#\\s+Pull Request Review\\s+[—-]\\s+PR\\s+#52",
+            "flags": "i"
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "src/auth\\.ts(?::|\\s*\\|\\s*)[23]",
+            "flags": "i"
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "dev-admin-key|fallback credential|hard-coded credential|hardcoded credential",
+            "flags": "i"
+          },
+          {
+            "kind": "contains",
+            "file": "pr-review.md",
+            "pattern": "Verdict:\\s*request-changes",
+            "flags": "i"
+          },
+          {
+            "kind": "notContains",
+            "file": "pr-review.md",
+            "pattern": "PR\\s*#41|invoice export",
+            "flags": "i"
+          }
+        ]
+      }
+    ],
+    "mocks": [
+      {
+        "service": "github",
+        "requiredTools": [
+          "github_pr_list",
+          "github_pr_view",
+          "github_pr_files",
+          "github_pr_diff"
+        ],
+        "toolCalls": {
+          "github_pr_comment": {
+            "minCalls": 0,
+            "maxCalls": 0
+          }
+        }
+      }
+    ]
+  },
+  "rubric": {
+    "artifact": {
+      "path": "pr-review.md",
+      "kind": "markdown"
+    },
+    "axes": [
+      {
+        "name": "selection",
+        "description": "The report is explicitly about PR #52, the current-branch default, and contains no analysis of unrelated PR #41."
+      },
+      {
+        "name": "grounding",
+        "description": "Every finding is grounded in the supplied diff with a concrete src/auth.ts line citation."
+      },
+      {
+        "name": "severity",
+        "description": "The insecure fallback credential receives a proportionate severity and forces request-changes."
+      },
+      {
+        "name": "side-effects",
+        "description": "The review remains local and does not post a GitHub comment."
+      }
+    ]
+  },
+  "qualityFocus": [
+    "current-branch PR selection",
+    "diff-grounded findings",
+    "safe local-only delivery"
+  ],
+  "extensions": {
+    "legacySimulators": [
+      {
+        "id": "pull-request-review-github-mcp",
+        "kind": "mcp",
+        "status": "implemented",
+        "description": "Deterministic fake GitHub PR toolset with a unique current-branch match, an unrelated open PR, changed-file patches, and a forbidden comment side effect."
+      }
+    ]
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bendyline/gilde",
-  "version": "0.1.19",
+  "version": "0.1.21",
   "description": "The gilde catalog: model manifests, toolsets, craftbooks, roles, and project types for gezel.",
   "license": "MIT",
   "private": false,

package/schemas/chat-model-version.schema.json

@@ -254,6 +254,16 @@
           "exclusiveMinimum": 0,
           "maximum": 9007199254740991
         },
+        "kvBytesPerToken": {
+          "type": "integer",
+          "exclusiveMinimum": 0,
+          "maximum": 9007199254740991
+        },
+        "residentCtxTokens": {
+          "type": "integer",
+          "exclusiveMinimum": 0,
+          "maximum": 9007199254740991
+        },
         "quantization": {
           "type": "string"
         },

package/schemas/craftbook-doc.schema.json

@@ -158,6 +158,30 @@
         ]
       }
     },
+    "connectors": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "properties": {
+          "typeId": {
+            "type": "string",
+            "minLength": 1
+          },
+          "sourceId": {
+            "type": "string"
+          },
+          "optional": {
+            "type": "boolean"
+          },
+          "reason": {
+            "type": "string"
+          }
+        },
+        "required": [
+          "typeId"
+        ]
+      }
+    },
     "paramSchema": {
       "type": "object",
       "propertyNames": {

package/schemas/craftbook-template-version.schema.json

@@ -5505,6 +5505,30 @@
           "toolsetId"
         ]
       }
+    },
+    "connectors": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "properties": {
+          "typeId": {
+            "type": "string",
+            "minLength": 1
+          },
+          "sourceId": {
+            "type": "string"
+          },
+          "optional": {
+            "type": "boolean"
+          },
+          "reason": {
+            "type": "string"
+          }
+        },
+        "required": [
+          "typeId"
+        ]
+      }
     }
   },
   "required": [