@beltar/n8n-nodes-extract-archive 1.1.0 → 1.2.0

package/dist/nodes/ExtractArchive/ExtractArchive.node.d.ts

@@ -2,7 +2,6 @@ import { IExecuteFunctions, INodeExecutionData, INodeType, INodeTypeDescription
 export declare class ExtractArchive implements INodeType {
     description: INodeTypeDescription;
     private detectArchiveType;
-    private checkToolAvailable;
     private extractZip;
     private extractRar;
     private getAllFiles;

package/dist/nodes/ExtractArchive/ExtractArchive.node.js

@@ -32,15 +32,17 @@ var __importStar = (this && this.__importStar) || (function () {
         return result;
     };
 })();
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ExtractArchive = void 0;
 const n8n_workflow_1 = require("n8n-workflow");
-const child_process_1 = require("child_process");
 const fs = __importStar(require("fs"));
 const crypto = __importStar(require("crypto"));
 const path = __importStar(require("path"));
-const util_1 = require("util");
-const execAsync = (0, util_1.promisify)(child_process_1.exec);
+const promises_1 = require("stream/promises");
+const adm_zip_1 = __importDefault(require("adm-zip"));
 class ExtractArchive {
     constructor() {
         this.description = {
@@ -245,26 +247,9 @@ class ExtractArchive {
         // Default to zip
         return 'zip';
     }
-    checkToolAvailable(tool) {
-        try {
-            (0, child_process_1.execSync)(`which ${tool}`, { encoding: 'utf-8', stdio: 'pipe' });
-            return true;
-        }
-        catch {
-            return false;
-        }
-    }
     async extractZip(archivePath, outputDir, password) {
-        if (!this.checkToolAvailable('unzip')) {
-            throw new Error('unzip is not installed. Please install it: apk add unzip (Alpine) or apt-get install unzip (Debian/Ubuntu)');
-        }
-        const args = ['-o', '-q']; // Overwrite, quiet
-        if (password) {
-            args.push('-P', password);
-        }
-        args.push(archivePath, '-d', outputDir);
-        const command = `unzip ${args.map(a => `"${a}"`).join(' ')}`;
-        await execAsync(command);
+        const zip = new adm_zip_1.default(archivePath);
+        zip.extractAllTo(outputDir, true, undefined, password || undefined);
     }
     async extractRar(archivePath, outputDir, password) {
         const { createExtractorFromFile } = await Promise.resolve().then(() => __importStar(require('node-unrar-js')));
@@ -446,7 +431,8 @@ class ExtractArchive {
                                 ? path.join(targetDir, relPath)
                                 : path.join(targetDir, fileName);
                             fs.mkdirSync(path.dirname(destPath), { recursive: true });
-                            fs.copyFileSync(srcPath, destPath);
+                            // Use streams instead of copyFileSync to avoid EPERM on network shares (CIFS/SMB)
+                            await (0, promises_1.pipeline)(fs.createReadStream(srcPath), fs.createWriteStream(destPath));
                         }
                     }
                     if (outputMode === 'single') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@beltar/n8n-nodes-extract-archive",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "n8n node to extract ZIP and RAR archive files. Supports binary data or file path input.",
   "keywords": [
     "n8n",
@@ -40,6 +40,7 @@
     ]
   },
   "devDependencies": {
+    "@types/adm-zip": "^0.5.7",
     "@types/node": "^20.10.0",
     "n8n-workflow": "^1.20.0",
     "shx": "^0.4.0",
@@ -52,6 +53,7 @@
     "node": ">=18.0.0"
   },
   "dependencies": {
+    "adm-zip": "^0.5.16",
     "node-unrar-js": "^2.0.2"
   }
 }