@beinformed/ui 1.13.4 → 1.13.5

package/src/models/concepts/ConceptDetailModel.js

@@ -2,6 +2,7 @@
 import ResourceModel from "../base/ResourceModel";
 import ConceptRelationCollection from "./ConceptRelationCollection";
 import SourceReferenceCollection from "./SourceReferenceCollection";
+import ConceptTypeDetailModel from "./ConceptTypeDetailModel";
 
 import { TIMEVERSION_FILTER_NAME } from "../../constants/Constants";
 
@@ -14,7 +15,6 @@ import type {
 import type { ModularUIResponse } from "../../modularui";
 import type Href from "../href/Href";
 import type LinkModel from "../links/LinkModel";
-import type ConceptTypeDetailModel from "./ConceptTypeDetailModel";
 
 /**
  * Model for concept details, available through modelcatalog
@@ -70,7 +70,7 @@ export default class ConceptDetailModel extends ResourceModel {
   setChildModels(models: Array<ModularUIModel>) {
     // $FlowExpectedError[incompatible-type]
     const conceptTypeModel: ?ConceptTypeDetailModel = models.find(
-      (model) => model.type === "ConceptTypeDetail"
+      (model) => model instanceof ConceptTypeDetailModel
     );
 
     if (conceptTypeModel) {

package/src/models/concepts/ConceptLinkModel.js

@@ -5,12 +5,15 @@ import LinkCollection from "../links/LinkCollection";
 import ConceptTypeDetailModel from "./ConceptTypeDetailModel";
 import { TIMEVERSION_FILTER_NAME } from "../../constants/Constants";
 
-import type { ModularUIModel } from "../types";
+import type { IModelWithChildModels, ModularUIModel } from "../types";
 import type Href from "../href/Href";
 /**
  * Link to a concept
  */
-export default class ConceptLinkModel extends BaseModel {
+export default class ConceptLinkModel
+  extends BaseModel
+  implements IModelWithChildModels
+{
   _links: ?LinkCollection;
   _entryDate: ?ISO_DATE;
   _conceptType: ?ConceptTypeDetailModel;

package/src/models/concepts/ConceptRelationModel.js

@@ -2,12 +2,16 @@
 import ConceptLinkModel from "./ConceptLinkModel";
 import LinkModel from "../links/LinkModel";
 
-import type { ModularUIModel, textfragmentJSON } from "../types";
+import type {
+  IModelWithChildModels,
+  ModularUIModel,
+  textfragmentJSON,
+} from "../types";
 
 /**
  * Concept relation model
  */
-export default class ConceptRelationModel {
+export default class ConceptRelationModel implements IModelWithChildModels {
   _relation: Object;
   _concept: ConceptLinkModel;
 

package/src/models/content/ContentLinkModel.js

@@ -33,6 +33,7 @@ export default class ContentLinkModel
 
   /**
    */
+  // $FlowFixMe[method-unbinding]
   getInitialChildModelLinks(): Array<LinkModel> {
     if (this.contentTypeLink) {
       this.contentTypeLink.isCacheable = true;
@@ -44,6 +45,7 @@ export default class ContentLinkModel
 
   /**
    */
+  // $FlowFixMe[method-unbinding]
   setChildModels(models: Array<ModularUIModel>) {
     if (this.contentTypeLink) {
       const href = this.contentTypeLink.href;

package/src/models/href/Href.js

@@ -4,7 +4,7 @@ import { BASE, CONTENT_PATH, HTTP_METHODS } from "../../constants/Constants";
 import Parameter from "../parameter/Parameter";
 import { IllegalArgumentException } from "../../exceptions";
 
-import type { LocationShape } from "react-router";
+import type { LocationShape, Location } from "react-router";
 
 type HrefObject = {
   _path: string,
@@ -13,6 +13,7 @@ type HrefObject = {
   _resourcetype: string,
   _method: $Keys<typeof HTTP_METHODS>,
   _state: ?{ [key: string]: any },
+  pathname: ?string,
 };
 
 export type HrefInput = Href | HrefObject | LocationShape | string;
@@ -61,7 +62,7 @@ class Href {
   /**
    */
   setFromLocationOrObject(href: LocationShape | HrefObject) {
-    if (href.pathname) {
+    if (typeof href["pathname"] === "string") {
       this.path = href.pathname;
     } else if (typeof href._path === "string") {
       this.path = href._path;
@@ -438,7 +439,7 @@ class Href {
 
   /**
    */
-  toLocation(): LocationShape {
+  toLocation(): Location {
     return {
       pathname: this.path,
       search: this.querystring.length > 0 ? `?${this.querystring}` : "",

package/src/models/types.js

@@ -149,8 +149,8 @@ export interface ILayoutHintRule {
 }
 
 export interface IModelWithChildModels {
-  +getInitialChildModelLinks: () => Array<LinkModel>;
-  +setChildModels: (models: Array<ModularUIModel>) => void;
+  getInitialChildModelLinks(): Array<LinkModel>;
+  setChildModels(models: Array<ModularUIModel>): void;
 }
 
 export type FileEntryType = {

package/src/react-server/__tests__/serverUtil.spec.js

@@ -16,6 +16,20 @@ global.preferencesProvider = {
 
 const mockStore = configureMockStore();
 
+const getExpectedLocales = () =>
+  new Locales([
+    ...availableLocales.map((locale) =>
+      locale.code === "nl"
+        ? {
+            ...locale,
+            messages: {
+              message_nl: "Dutch message",
+            },
+          }
+        : locale
+    ),
+  ]);
+
 describe("serverUtil", () => {
   it("handles setI18n", () => {
     const store = mockStore({ i18n: {} });
@@ -39,25 +53,12 @@ describe("serverUtil", () => {
       }
     );
 
-    const expectedLocales = new Locales([
-      ...availableLocales.map((locale) =>
-        locale.code === "nl"
-          ? {
-              ...locale,
-              messages: {
-                message_nl: "Dutch message",
-              },
-            }
-          : locale
-      ),
-    ]);
-
     expect(store.getActions()).toStrictEqual([
       {
         type: "SET_LOCALES",
         payload: {
           locale: "en",
-          locales: expectedLocales,
+          locales: getExpectedLocales(),
         },
       },
     ]);

package/src/react-server/renderSSRComplete.js

@@ -21,6 +21,8 @@ import type { Theme } from "../react-theme/types";
 import type { ReduxStore } from "../redux/types";
 import type Href from "../models/href/Href";
 import type { TemplateProps } from "./htmlpage";
+import type { Location } from "react-router";
+
 type Props = {
   store: ReduxStore,
   theme: Theme,
@@ -46,7 +48,6 @@ const renderSSRComplete = ({
 
   const sheet = new ServerStyleSheet();
 
-  // $FlowExpectedError[incompatible-type]
   const location: Location = requestHref.toLocation();
 
   return createSSRComplete(store, () =>

package/src/react-server/serverNoSSR.js

@@ -56,7 +56,7 @@ const serverNoSSR = ({
 
   if (theme) {
     const storedTheme = store.getState()?.preferences?.theme;
-    // $FlowFixMe
+    // $FlowFixMe[incompatible-call]
     createTheme(storedTheme, theme);
   }
 

package/src/redux/_modularui/__tests__/actions.spec.js

@@ -152,6 +152,7 @@ describe("modularui actions", () => {
           targetModel: undefined,
         }),
       },
+      { type: "FINISH_PROGRESS" },
     ]);
   });
 });

package/src/redux/_modularui/actions.js

@@ -73,7 +73,8 @@ const loadModelSuccessAction = (
   modelToUpdate
 ): UpdateModelAction | SetModelAction => {
   if (modelToUpdate) {
-    if (typeof modelToUpdate.update === "function") {
+    // $FlowFixMe[prop-missing]
+    if (typeof modelToUpdate["update"] === "function") {
       const clonedModel = modelToUpdate.clone();
       clonedModel.update(model);
 
@@ -140,17 +141,16 @@ export const loadModularUI =
     dispatch(startProgress());
 
     const loadModelPromise = dispatch(loadModel(key, href, options));
-    if (typeof loadModelPromise !== "function" && loadModelPromise.then) {
-      return loadModelPromise
-        .then((response) => {
-          if (response?.type === "FINISH_PROGRESS") {
-            dispatch(updateStatus(key, MODULARUI_STATUS.FINISHED));
-          }
-
-          return dispatch(finishProgress());
-        })
-        .catch((error) => dispatch(handleError(error)));
-    }
+
+    return Promise.resolve(loadModelPromise)
+      .then((response) => {
+        if (response?.type === "FINISH_PROGRESS") {
+          dispatch(updateStatus(key, MODULARUI_STATUS.FINISHED));
+        }
+
+        return dispatch(finishProgress());
+      })
+      .catch((error) => dispatch(handleError(error)));
   };
 
 /**

package/src/redux/_modularui/reducer.js

@@ -74,7 +74,6 @@ const removeKey = (modelKey: string, state: ModularUIState): ModularUIState => {
   // eslint-disable-next-line no-unused-vars
   const { [modelKey]: _, ...newState } = state;
 
-  // $FlowExpectedError[incompatible-return]
   return newState;
 };
 

package/src/redux/actions/SignIn.js

@@ -66,17 +66,11 @@ export const login =
       .catch((error) => {
         if (error.id === "Error.ChangePasswordRequired") {
           const dispatchedReloadApplication = dispatch(reloadApplication());
-          if (
-            typeof dispatchedReloadApplication !== "function" &&
-            dispatchedReloadApplication.then
-          ) {
-            dispatchedReloadApplication
-              .then(() => {
-                Cache.addItem("auth", true);
-                return dispatch(changePassword());
-              })
-              .then(() => dispatch(finishProgress()));
-          }
+
+          return Promise.resolve(dispatchedReloadApplication).then(() => {
+            Cache.addItem("auth", true);
+            return dispatch(changePassword());
+          });
         }
 
         dispatch(loginFailed(error.id));

package/src/redux/actions/__tests__/Application.spec.js

@@ -27,6 +27,7 @@ describe("application actions", () => {
           href: new Href("/", "Application"),
         }),
       }),
+      { type: "FINISH_PROGRESS" },
     ]);
   });
 

package/src/redux/actions/__tests__/CustomErrorResponseHandler.spec.js

@@ -27,6 +27,7 @@ describe("custom error response handling", () => {
     const store = mockStore({});
 
     setCustomErrorResponseHandler((error) => {
+      // eslint-disable-next-line jest/no-conditional-in-test
       if (error.isRemoteServiceException) {
         return {
           type: "REMOTE_SERVICE_EXCEPTION",
@@ -50,6 +51,7 @@ describe("custom error response handling", () => {
     const store = mockStore({});
 
     setCustomErrorResponseHandler((error, defaultHandler) => (dispatch) => {
+      // eslint-disable-next-line jest/no-conditional-in-test
       if (error.isRemoteServiceException) {
         dispatch({
           type: "REMOTE_SERVICE_EXCEPTION",

package/src/utils/fetch/__tests__/xhr.spec.js

@@ -156,6 +156,7 @@ describe("xhr", () => {
         onProgress: ({ type, loaded, total, lengthComputable }) => {
           events.push({ type, loaded, total, lengthComputable });
 
+          // eslint-disable-next-line jest/no-conditional-in-test
           if (type === "loadend") {
             resolve(events);
           }

package/src/utils/helpers/objects.js

@@ -1,10 +1,10 @@
 // @flow
 import _has from "lodash/has";
+import _isPlainObject from "lodash/isPlainObject";
 
 /**
  */
-export const isPlainObject = (value: any): boolean =>
-  Object.prototype.toString.call(value) === "[object Object]";
+export const isPlainObject = (value: any): boolean => _isPlainObject(value);
 
 /**
  */