@beignet/cli 0.0.13 → 0.0.15

package/src/inspect.ts

@@ -1559,12 +1559,12 @@ async function inspectCanonicalConformance(
       });
     }
 
-    if (!/defineRouteGroup\s*<\s*AppContext\s*>/.test(source)) {
+    if (!/defineRouteGroup\s*<\s*AppContext\s*>\s*\(\s*\)\s*\(/.test(source)) {
       diagnostics.push({
         severity: "warning",
         code: "BEIGNET_FEATURE_ROUTE_GROUP_CONTEXT",
         file,
-        message: `${file} should call defineRouteGroup<AppContext>(...) for ordinary feature route groups, or defineRouteGroup<AppContext>()({ ... }) when group-level hooks enrich ctx.`,
+        message: `${file} should call defineRouteGroup<AppContext>()({ ... }) so route groups preserve per-route contract and use-case type checks.`,
       });
     }
   }
@@ -1975,6 +1975,30 @@ async function inspectProductionReadiness(
     config,
     sourceCache,
   );
+  const stripeMemoryProviderMismatch = await hasStripeMemoryProviderMismatch(
+    targetDir,
+    sourceCache,
+    configFiles,
+    installedPackages,
+    providerEntries,
+  );
+
+  diagnostics.push(
+    ...(await inspectEntitlementsProductionReadiness(
+      targetDir,
+      files,
+      config,
+      sourceCache,
+    )),
+    ...(await inspectPaymentsProductionReadiness(
+      targetDir,
+      files,
+      config,
+      sourceCache,
+      installedPackages,
+      stripeMemoryProviderMismatch,
+    )),
+  );
 
   for (const provider of providerDoctorRules) {
     if (!installedPackages.has(provider.packageName)) continue;
@@ -2048,6 +2072,184 @@ async function inspectProductionReadiness(
   return diagnostics;
 }
 
+async function inspectEntitlementsProductionReadiness(
+  targetDir: string,
+  files: string[],
+  config: ResolvedBeignetConfig,
+  sourceCache: Map<string, string>,
+): Promise<InspectDiagnostic[]> {
+  if (
+    !(await usesEntitlementChecks(targetDir, files, sourceCache)) ||
+    (await appPortsIncludesPort(
+      targetDir,
+      files,
+      config,
+      sourceCache,
+      "entitlements",
+    ))
+  ) {
+    return [];
+  }
+
+  return [
+    {
+      severity: "warning",
+      code: "BEIGNET_ENTITLEMENTS_PORT_MISSING",
+      file: config.paths.ports,
+      message:
+        "This app checks entitlements, but AppPorts does not declare an entitlements port. Add entitlements: EntitlementsPort; and wire a provider-backed entitlement resolver before deploying paid feature gates.",
+    },
+  ];
+}
+
+async function inspectPaymentsProductionReadiness(
+  targetDir: string,
+  files: string[],
+  config: ResolvedBeignetConfig,
+  sourceCache: Map<string, string>,
+  installedPackages: Set<string>,
+  stripeMemoryProviderMismatch: boolean,
+): Promise<InspectDiagnostic[]> {
+  if (
+    !(
+      hasBillingOrPaymentsFeature(files, config) ||
+      installedPackages.has("@beignet/provider-payments-stripe")
+    )
+  ) {
+    return [];
+  }
+
+  const diagnostics: InspectDiagnostic[] = [];
+
+  if (stripeMemoryProviderMismatch) {
+    diagnostics.push({
+      severity: "warning",
+      code: "BEIGNET_PAYMENTS_STRIPE_MEMORY_PROVIDER",
+      file: serverProviderFiles(files, config)[0] ?? config.paths.server,
+      message:
+        "@beignet/provider-payments-stripe is installed and Stripe env/config is present, but server/providers.ts still registers memory payments. Register stripePaymentsProvider before deploying Stripe-backed billing, or remove the Stripe provider/config until the app is ready to switch.",
+    });
+  }
+
+  if (!(await hasPaymentWebhookRoute(targetDir, files, config, sourceCache))) {
+    diagnostics.push({
+      severity: "warning",
+      code: "BEIGNET_PAYMENTS_WEBHOOK_ROUTE_MISSING",
+      file: directoryPath(config.paths.routes),
+      message:
+        "This app appears to use payments, but no route calls createPaymentWebhookRoute(...) or createWebhookRoute(...) for payments. Expose payment webhooks under app/api/webhooks/payments/route.ts or an equivalent configured route so provider events can update billing state.",
+    });
+  }
+
+  const billingContractsFile = `${directoryPath(config.paths.features)}/billing/contracts.ts`;
+  if (files.includes(billingContractsFile)) {
+    const source = await readCachedSource(
+      targetDir,
+      billingContractsFile,
+      sourceCache,
+    );
+    const checkoutContract = exportedConstInitializer(
+      source,
+      "createCheckoutSession",
+    );
+    if (
+      checkoutContract &&
+      !(
+        /\bidempotency\s*:/.test(checkoutContract) &&
+        /["']idempotency-key["']/.test(checkoutContract)
+      )
+    ) {
+      diagnostics.push({
+        severity: "warning",
+        code: "BEIGNET_BILLING_CHECKOUT_IDEMPOTENCY_MISSING",
+        file: billingContractsFile,
+        contract: "createCheckoutSession",
+        message:
+          "The billing checkout contract appears to create payment sessions without idempotency metadata and an idempotency-key header. Mark checkout as idempotent so retries do not create duplicate payment sessions.",
+      });
+    }
+  }
+
+  const billingUseCasesFile = `${directoryPath(config.paths.features)}/billing/use-cases/index.ts`;
+  if (files.includes(billingUseCasesFile)) {
+    const source = await readCachedSource(
+      targetDir,
+      billingUseCasesFile,
+      sourceCache,
+    );
+    if (
+      /\bctx\.ports\.idempotency\b/.test(source) &&
+      !(await appPortsIncludesIdempotency(
+        targetDir,
+        files,
+        config,
+        sourceCache,
+      ))
+    ) {
+      diagnostics.push({
+        severity: "warning",
+        code: "BEIGNET_BILLING_IDEMPOTENCY_PORT_MISSING",
+        file: config.paths.ports,
+        message:
+          "Billing use cases reference ctx.ports.idempotency, but AppPorts does not declare an idempotency port. Add idempotency to AppPorts and provider wiring, or remove the stale billing workflow dependency.",
+      });
+    }
+  }
+
+  const billingEntitlementsFile = `${directoryPath(config.paths.features)}/billing/entitlements.ts`;
+  if (
+    files.includes(billingEntitlementsFile) &&
+    !(await hasBillingEntitlementsProviderWiring(
+      targetDir,
+      files,
+      config,
+      sourceCache,
+    ))
+  ) {
+    diagnostics.push({
+      severity: "warning",
+      code: "BEIGNET_BILLING_ENTITLEMENTS_PROVIDER_MISSING",
+      file: path.dirname(config.paths.infrastructurePorts),
+      message:
+        "features/billing/entitlements.ts exists, but no infra or server provider appears to call createBillingEntitlements(...). Wire the billing-backed entitlements port into AppPorts so paid feature gates use app billing state.",
+    });
+  }
+
+  return diagnostics;
+}
+
+async function hasStripeMemoryProviderMismatch(
+  targetDir: string,
+  sourceCache: Map<string, string>,
+  configFiles: string[],
+  installedPackages: Set<string>,
+  providerEntries: string[],
+): Promise<boolean> {
+  if (!installedPackages.has("@beignet/provider-payments-stripe")) {
+    return false;
+  }
+  if (
+    findProviderEntryIndex(providerEntries, ["stripePaymentsProvider"]) >= 0
+  ) {
+    return false;
+  }
+  if (
+    findProviderEntryIndex(providerEntries, [
+      "createMemoryPaymentsProvider",
+      "createMemoryPayments",
+    ]) < 0
+  ) {
+    return false;
+  }
+
+  return anyFileMatches(
+    targetDir,
+    configFiles,
+    /\bSTRIPE_(?:SECRET_KEY|WEBHOOK_SECRET)\b/,
+    sourceCache,
+  );
+}
+
 // Local-dev ranges such as the generated-app conformance vendoring point each
 // @beignet/* package at a different path on purpose, so they are exempt from
 // the declared-range comparison. Their installed versions still participate in
@@ -2200,9 +2402,22 @@ async function inspectProviderRegistrationDrift(
     config,
     sourceCache,
   );
+  const stripeMemoryProviderMismatch = await hasStripeMemoryProviderMismatch(
+    targetDir,
+    sourceCache,
+    operationalConfigFiles(files, config),
+    installedPackages,
+    providerEntries,
+  );
 
   for (const provider of providerDoctorRules) {
     if (!installedPackages.has(provider.packageName)) continue;
+    if (
+      provider.packageName === "@beignet/provider-payments-stripe" &&
+      stripeMemoryProviderMismatch
+    ) {
+      continue;
+    }
 
     if (provider.variants !== undefined) {
       if (
@@ -2641,6 +2856,164 @@ function hasBetterAuthRoute(
   );
 }
 
+function hasBillingOrPaymentsFeature(
+  files: string[],
+  config: ResolvedBeignetConfig,
+): boolean {
+  const featuresPath = directoryPath(config.paths.features);
+  return files.some(
+    (file) =>
+      file.startsWith(`${featuresPath}/billing/`) ||
+      file.startsWith(`${featuresPath}/payments/`),
+  );
+}
+
+async function hasPaymentWebhookRoute(
+  targetDir: string,
+  files: string[],
+  config: ResolvedBeignetConfig,
+  sourceCache: Map<string, string>,
+): Promise<boolean> {
+  const routesPath = directoryPath(config.paths.routes);
+  const routeFiles = files.filter(
+    (file) => file.startsWith(`${routesPath}/`) && file.endsWith("/route.ts"),
+  );
+
+  for (const file of routeFiles) {
+    const source = await readCachedSource(targetDir, file, sourceCache);
+    if (containsCallExpression(source, "createPaymentWebhookRoute")) {
+      return true;
+    }
+    if (containsPaymentWebhookRoute(source)) {
+      return true;
+    }
+  }
+
+  return false;
+}
+
+function containsPaymentWebhookRoute(source: string): boolean {
+  if (!containsCallExpression(source, "createWebhookRoute")) return false;
+
+  return (
+    source.includes("payments.verifyWebhook") ||
+    source.includes("paymentWebhook")
+  );
+}
+
+async function appPortsIncludesIdempotency(
+  targetDir: string,
+  files: string[],
+  config: ResolvedBeignetConfig,
+  sourceCache: Map<string, string>,
+): Promise<boolean> {
+  return appPortsIncludesPort(
+    targetDir,
+    files,
+    config,
+    sourceCache,
+    "idempotency",
+  );
+}
+
+async function appPortsIncludesPort(
+  targetDir: string,
+  files: string[],
+  config: ResolvedBeignetConfig,
+  sourceCache: Map<string, string>,
+  portName: string,
+): Promise<boolean> {
+  if (!files.includes(config.paths.ports)) return false;
+
+  const source = await readCachedSource(
+    targetDir,
+    config.paths.ports,
+    sourceCache,
+  );
+  const declarationStart = source.search(/\bexport\s+type\s+AppPorts\b/);
+  if (declarationStart < 0) return false;
+
+  const bodyStart = source.indexOf("{", declarationStart);
+  if (bodyStart < 0) return false;
+
+  const body = balancedObjectSource(source, bodyStart);
+  return (
+    body !== undefined &&
+    new RegExp(`\\b${escapeRegExp(portName)}\\s*:`).test(body)
+  );
+}
+
+async function usesEntitlementChecks(
+  targetDir: string,
+  files: string[],
+  sourceCache: Map<string, string>,
+): Promise<boolean> {
+  for (const file of files) {
+    if (!/\.(?:ts|tsx|mts|cts)$/.test(file)) continue;
+    if (isTestSourceFile(file)) continue;
+
+    const source = await readCachedSource(targetDir, file, sourceCache);
+    if (
+      /\brequireEntitlement\s*\(/.test(source) ||
+      /\bctx\.ports\.entitlements\b/.test(source)
+    ) {
+      return true;
+    }
+  }
+
+  return false;
+}
+
+async function hasBillingEntitlementsProviderWiring(
+  targetDir: string,
+  files: string[],
+  config: ResolvedBeignetConfig,
+  sourceCache: Map<string, string>,
+): Promise<boolean> {
+  const infraPath = path.dirname(config.paths.infrastructurePorts);
+  const serverPath = path.dirname(config.paths.server);
+  const candidateFiles = files.filter(
+    (file) =>
+      /\.(?:ts|tsx|mts|cts)$/.test(file) &&
+      !isTestSourceFile(file) &&
+      (file.startsWith(`${infraPath}/`) || file.startsWith(`${serverPath}/`)),
+  );
+
+  for (const file of candidateFiles) {
+    const source = await readCachedSource(targetDir, file, sourceCache);
+    if (containsCallExpression(source, "createBillingEntitlements")) {
+      return true;
+    }
+  }
+
+  return false;
+}
+
+function isTestSourceFile(file: string): boolean {
+  return (
+    /(?:^|\/)tests\//.test(file) ||
+    /\.(?:test|spec)\.(?:ts|tsx|mts|cts)$/.test(file)
+  );
+}
+
+function exportedConstInitializer(
+  source: string,
+  exportName: string,
+): string | undefined {
+  const declaration = new RegExp(
+    `\\bexport\\s+const\\s+${escapeRegExp(exportName)}\\s*=`,
+  ).exec(source);
+  if (declaration?.index === undefined) return undefined;
+
+  const start = declaration.index;
+  const nextExport =
+    /\n\s*export\s+(?:const|function|type|interface|class)\s+/g;
+  nextExport.lastIndex = start + declaration[0].length;
+  const next = nextExport.exec(source);
+
+  return source.slice(start, next?.index ?? source.length);
+}
+
 function featureNameFromContractFile(
   file: string,
   config: ResolvedBeignetConfig,