@beechcms/api 0.5.0 → 0.6.0-preview.2

package/src/features/content/handlers/facets.ts

@@ -1,45 +1,49 @@
-import { Context } from 'hono'
-import { publicProblem } from '../../../public/problem-details'
-import { CONTENT_ERRORS } from '../constants'
-import { AppEnv } from '../../../types'
-
-export async function facetsHandler(context: Context<AppEnv>) {
-  const slug = context.req.param('slug')
-  if (!slug) {
-    return publicProblem(context, { 
-      type: 'content-invalid-slug', 
-      title: 'Bad Request', 
-      status: 400, 
-      detail: CONTENT_ERRORS.INVALID_SLUG 
-    })
-  }
-
-  const seed = context.get('getSeed')(slug)
-  if (!seed) {
-    return publicProblem(context, { 
-      type: 'content-seed-not-found', 
-      title: 'Not Found', 
-      status: 404, 
-      detail: CONTENT_ERRORS.SEED_NOT_FOUND 
-    })
-  }
-
-  try {
-    const repository = context.get('repository')
-    const { statuses, tagsByColumn } = await repository.getFacets(seed)
-
-    // Legacy format expected by the dashboard
-    return context.json({
-      statuses: Object.keys(statuses).sort((a, b) => a.localeCompare(b, 'it')),
-      tagsByColumnId: tagsByColumn,
-    })
-  } catch (error) {
-    console.error('Content facets error:', error)
-    return publicProblem(context, { 
-      type: 'content-database-error', 
-      title: 'Internal Server Error', 
-      status: 500, 
-      detail: CONTENT_ERRORS.DATABASE_ERROR 
-    })
-  }
-}
+// SPDX-License-Identifier: BUSL-1.1
+// Copyright (c) 2024–2026 Flavio De Musso. All rights reserved.
+// See LICENSE in the repository root for license terms.
+
+import { Context } from 'hono'
+import { publicProblem } from '../../../public/problem-details'
+import { CONTENT_ERRORS } from '../constants'
+import { AppEnv } from '../../../types'
+
+export async function facetsHandler(context: Context<AppEnv>) {
+  const slug = context.req.param('slug')
+  if (!slug) {
+    return publicProblem(context, { 
+      type: 'content-invalid-slug', 
+      title: 'Bad Request', 
+      status: 400, 
+      detail: CONTENT_ERRORS.INVALID_SLUG 
+    })
+  }
+
+  const seed = context.get('getSeed')(slug)
+  if (!seed) {
+    return publicProblem(context, { 
+      type: 'content-seed-not-found', 
+      title: 'Not Found', 
+      status: 404, 
+      detail: CONTENT_ERRORS.SEED_NOT_FOUND 
+    })
+  }
+
+  try {
+    const repository = context.get('repository')
+    const { statuses, tagsByColumn } = await repository.getFacets(seed)
+
+    // Legacy format expected by the dashboard
+    return context.json({
+      statuses: Object.keys(statuses).sort((a, b) => a.localeCompare(b, 'it')),
+      tagsByColumnId: tagsByColumn,
+    })
+  } catch (error) {
+    console.error('Content facets error:', error)
+    return publicProblem(context, { 
+      type: 'content-database-error', 
+      title: 'Internal Server Error', 
+      status: 500, 
+      detail: CONTENT_ERRORS.DATABASE_ERROR 
+    })
+  }
+}

package/src/features/content/handlers/get.ts

@@ -1,116 +1,120 @@
-import { Context } from 'hono'
-import { applyVisibility } from '../../../shared/apply-policies'
-import { publicProblem } from '../../../public/problem-details'
-import { CONTENT_ERRORS } from '../constants'
-import { AppEnv } from '../../../types'
-import { EntryNotFoundError } from '@beechcms/core'
-
-export async function getByIdHandler(context: Context<AppEnv>) {
-  const slug = context.req.param('slug')
-  const id = context.req.param('id')
-  if (!slug || !id) {
-    return publicProblem(context, { 
-      type: 'content-invalid-slug-or-id', 
-      title: 'Bad Request', 
-      status: 400, 
-      detail: CONTENT_ERRORS.INVALID_SLUG_OR_ID 
-    })
-  }
-
-  const seed = context.get('getSeed')(slug)
-  if (!seed) {
-    return publicProblem(context, { 
-      type: 'content-seed-not-found', 
-      title: 'Not Found', 
-      status: 404, 
-      detail: CONTENT_ERRORS.SEED_NOT_FOUND 
-    })
-  }
-
-  try {
-    const repository = context.get('repository')
-    const item = await repository.findById(seed, id)
-    
-    let hasPendingDraft = false
-    if (seed.allowDrafts) {
-      hasPendingDraft = await repository.hasDraft(seed, id)
-    }
-
-    return context.json({
-      ...item,
-      has_pending_draft: hasPendingDraft,
-      data: applyVisibility(item, seed)
-    })
-  } catch (error) {
-    if (error instanceof EntryNotFoundError) {
-      return publicProblem(context, { 
-        type: 'content-not-found', 
-        title: 'Not Found', 
-        status: 404, 
-        detail: CONTENT_ERRORS.NOT_FOUND 
-      })
-    }
-    console.error('Content detail error:', error)
-    return publicProblem(context, { 
-      type: 'content-database-error', 
-      title: 'Internal Server Error', 
-      status: 500, 
-      detail: CONTENT_ERRORS.DATABASE_ERROR 
-    })
-  }
-}
-
-export async function getBySlugHandler(context: Context<AppEnv>) {
-  const schemaSlug = context.req.param('schema_slug')
-  const entrySlug = context.req.param('entry_slug')
-  if (!schemaSlug || !entrySlug) {
-    return publicProblem(context, { 
-      type: 'content-invalid-slug-or-id', 
-      title: 'Bad Request', 
-      status: 400, 
-      detail: CONTENT_ERRORS.INVALID_SLUG_OR_ID 
-    })
-  }
-
-  const seed = context.get('getSeed')(schemaSlug)
-  if (!seed) {
-    return publicProblem(context, { 
-      type: 'content-seed-not-found', 
-      title: 'Not Found', 
-      status: 404, 
-      detail: CONTENT_ERRORS.SEED_NOT_FOUND 
-    })
-  }
-
-  try {
-    const repository = context.get('repository')
-    const item = await repository.findBySlug(seed, entrySlug)
-    
-    let hasPendingDraft = false
-    if (seed.allowDrafts) {
-      hasPendingDraft = await repository.hasDraft(seed, item.id)
-    }
-
-    return context.json({
-      ...item,
-      has_pending_draft: hasPendingDraft,
-      data: applyVisibility(item, seed)
-    })
-  } catch (error) {
-    if (error instanceof EntryNotFoundError) {
-      return publicProblem(context, { 
-        type: 'content-not-found', 
-        title: 'Not Found', 
-        status: 404, 
-        detail: CONTENT_ERRORS.NOT_FOUND 
-      })
-    }
-    console.error('Content by-slug error:', error)
-    return publicProblem(context, { 
-      type: 'content-database-error', 
-      title: 'Internal Server Error', 
-      status: 500, 
-      detail: CONTENT_ERRORS.DATABASE_ERROR 
-    })
-  }
-}
+// SPDX-License-Identifier: BUSL-1.1
+// Copyright (c) 2024–2026 Flavio De Musso. All rights reserved.
+// See LICENSE in the repository root for license terms.
+
+import { Context } from 'hono'
+import { applyVisibility } from '../../../shared/apply-policies'
+import { publicProblem } from '../../../public/problem-details'
+import { CONTENT_ERRORS } from '../constants'
+import { AppEnv } from '../../../types'
+import { EntryNotFoundError } from '@beechcms/core'
+
+export async function getByIdHandler(context: Context<AppEnv>) {
+  const slug = context.req.param('slug')
+  const id = context.req.param('id')
+  if (!slug || !id) {
+    return publicProblem(context, { 
+      type: 'content-invalid-slug-or-id', 
+      title: 'Bad Request', 
+      status: 400, 
+      detail: CONTENT_ERRORS.INVALID_SLUG_OR_ID 
+    })
+  }
+
+  const seed = context.get('getSeed')(slug)
+  if (!seed) {
+    return publicProblem(context, { 
+      type: 'content-seed-not-found', 
+      title: 'Not Found', 
+      status: 404, 
+      detail: CONTENT_ERRORS.SEED_NOT_FOUND 
+    })
+  }
+
+  try {
+    const repository = context.get('repository')
+    const item = await repository.findById(seed, id)
+    
+    let hasPendingDraft = false
+    if (seed.allowDrafts) {
+      hasPendingDraft = await repository.hasDraft(seed, id)
+    }
+
+    return context.json({
+      ...item,
+      has_pending_draft: hasPendingDraft,
+      data: applyVisibility(item, seed)
+    })
+  } catch (error) {
+    if (error instanceof EntryNotFoundError) {
+      return publicProblem(context, { 
+        type: 'content-not-found', 
+        title: 'Not Found', 
+        status: 404, 
+        detail: CONTENT_ERRORS.NOT_FOUND 
+      })
+    }
+    console.error('Content detail error:', error)
+    return publicProblem(context, { 
+      type: 'content-database-error', 
+      title: 'Internal Server Error', 
+      status: 500, 
+      detail: CONTENT_ERRORS.DATABASE_ERROR 
+    })
+  }
+}
+
+export async function getBySlugHandler(context: Context<AppEnv>) {
+  const schemaSlug = context.req.param('schema_slug')
+  const entrySlug = context.req.param('entry_slug')
+  if (!schemaSlug || !entrySlug) {
+    return publicProblem(context, { 
+      type: 'content-invalid-slug-or-id', 
+      title: 'Bad Request', 
+      status: 400, 
+      detail: CONTENT_ERRORS.INVALID_SLUG_OR_ID 
+    })
+  }
+
+  const seed = context.get('getSeed')(schemaSlug)
+  if (!seed) {
+    return publicProblem(context, { 
+      type: 'content-seed-not-found', 
+      title: 'Not Found', 
+      status: 404, 
+      detail: CONTENT_ERRORS.SEED_NOT_FOUND 
+    })
+  }
+
+  try {
+    const repository = context.get('repository')
+    const item = await repository.findBySlug(seed, entrySlug)
+    
+    let hasPendingDraft = false
+    if (seed.allowDrafts) {
+      hasPendingDraft = await repository.hasDraft(seed, item.id)
+    }
+
+    return context.json({
+      ...item,
+      has_pending_draft: hasPendingDraft,
+      data: applyVisibility(item, seed)
+    })
+  } catch (error) {
+    if (error instanceof EntryNotFoundError) {
+      return publicProblem(context, { 
+        type: 'content-not-found', 
+        title: 'Not Found', 
+        status: 404, 
+        detail: CONTENT_ERRORS.NOT_FOUND 
+      })
+    }
+    console.error('Content by-slug error:', error)
+    return publicProblem(context, { 
+      type: 'content-database-error', 
+      title: 'Internal Server Error', 
+      status: 500, 
+      detail: CONTENT_ERRORS.DATABASE_ERROR 
+    })
+  }
+}

package/src/features/content/handlers/helpers.test.ts

@@ -0,0 +1,180 @@
+import { describe, it, expect, vi } from 'vitest'
+import { Context } from 'hono'
+import { EntryNotFoundError, SlugConflictError } from '@beechcms/core'
+import { normalizeBody, contentValidationProblem, logContentActivity, dispatchContentAutomation, handleContentDatabaseError } from './helpers'
+import { CONTENT_ERRORS } from '../constants'
+
+// Mock dependencies
+vi.mock('../../../public/problem-details', () => ({
+  publicProblem: vi.fn((_ctx, details) => ({ mockProblem: true, ...details })),
+  fkProblemOrNull: vi.fn((_ctx, err, method) => {
+    if (err instanceof Error && err.message === 'FK_ERROR') return { mockFkProblem: true }
+    return null
+  }),
+}))
+
+describe('content handlers helpers', () => {
+  describe('normalizeBody', () => {
+    it('returns the object when input is an object', () => {
+      const obj = { a: 1 }
+      expect(normalizeBody(obj)).toBe(obj)
+    })
+
+    it('returns an empty object when input is null', () => {
+      expect(normalizeBody(null)).toEqual({})
+    })
+
+    it('returns an empty object when input is a primitive', () => {
+      expect(normalizeBody('string')).toEqual({})
+      expect(normalizeBody(123)).toEqual({})
+      expect(normalizeBody(true)).toEqual({})
+    })
+  })
+
+  describe('contentValidationProblem', () => {
+    it('calls publicProblem with correct parameters', () => {
+      const ctx = {} as Context
+      const errors = [{ field: 'title', expected: 'string', received: 'number', message: 'Wrong type' }]
+      const result = contentValidationProblem(ctx, errors)
+      
+      expect(result).toEqual({
+        mockProblem: true,
+        type: 'content-validation-failed',
+        title: 'Bad Request',
+        status: 400,
+        detail: 'Validation failed',
+        errors,
+      })
+    })
+  })
+
+  describe('logContentActivity', () => {
+    it('logs activity with correct payload', () => {
+      const mockLog = vi.fn()
+      const ctx = {
+        get: vi.fn((key) => {
+          if (key === 'jwtPayload') return { sub: 'user-1', email: 'test@test.com', name: 'John', surname: 'Doe' }
+          if (key === 'activityLogger') return { log: mockLog }
+        })
+      } as unknown as Context<any>
+
+      logContentActivity(ctx, 'create', 'entry-1', 'test-slug', 'Test Title')
+
+      expect(mockLog).toHaveBeenCalledWith({
+        action: 'create',
+        entityType: 'content',
+        entityId: 'entry-1',
+        entitySlug: 'test-slug',
+        details: { title: 'Test Title' },
+        actor: {
+          id: 'user-1',
+          email: 'test@test.com',
+          name: 'John Doe',
+        },
+      })
+    })
+
+    it('handles missing name and surname', () => {
+      const mockLog = vi.fn()
+      const ctx = {
+        get: vi.fn((key) => {
+          if (key === 'jwtPayload') return { sub: 'user-1' } // Missing name, surname, email
+          if (key === 'activityLogger') return { log: mockLog }
+        })
+      } as unknown as Context<any>
+
+      logContentActivity(ctx, 'update', 'entry-1', 'test-slug', 'Test Title')
+
+      expect(mockLog).toHaveBeenCalledWith({
+        action: 'update',
+        entityType: 'content',
+        entityId: 'entry-1',
+        entitySlug: 'test-slug',
+        details: { title: 'Test Title' },
+        actor: {
+          id: 'user-1',
+          email: 'unknown',
+          name: null,
+        },
+      })
+    })
+  })
+
+  describe('dispatchContentAutomation', () => {
+    it('schedules automation run', () => {
+      const mockWaitUntil = vi.fn()
+      const mockRun = vi.fn().mockReturnValue('mock-promise')
+      const ctx = {
+        get: vi.fn((key) => {
+          if (key === 'scheduler') return { waitUntil: mockWaitUntil }
+          if (key === 'automationRunner') return { run: mockRun }
+        })
+      } as unknown as Context<any>
+
+      const entry = { id: 1 }
+      dispatchContentAutomation(ctx, 'posts', 'create', entry)
+
+      expect(mockRun).toHaveBeenCalledWith({
+        seedSlug: 'posts',
+        event: 'create',
+        entry,
+      })
+      expect(mockWaitUntil).toHaveBeenCalledWith('mock-promise')
+    })
+  })
+
+  describe('handleContentDatabaseError', () => {
+    it('handles EntryNotFoundError', () => {
+      const ctx = {} as Context<any>
+      const error = new EntryNotFoundError('Not found')
+      const result = handleContentDatabaseError(ctx, error)
+
+      expect(result).toEqual({
+        mockProblem: true,
+        type: 'content-not-found',
+        title: 'Not Found',
+        status: 404,
+        detail: CONTENT_ERRORS.NOT_FOUND,
+      })
+    })
+
+    it('handles SlugConflictError', () => {
+      const ctx = {} as Context<any>
+      const error = new SlugConflictError('Conflict', 'slug')
+      const result = handleContentDatabaseError(ctx, error)
+
+      expect(result).toEqual({
+        mockProblem: true,
+        type: 'content-slug-conflict',
+        title: 'Conflict',
+        status: 409,
+        detail: CONTENT_ERRORS.SLUG_CONFLICT,
+      })
+    })
+
+    it('handles foreign key error', () => {
+      const ctx = { req: { method: 'POST' } } as unknown as Context<any>
+      const error = new Error('FK_ERROR')
+      const result = handleContentDatabaseError(ctx, error)
+
+      expect(result).toEqual({ mockFkProblem: true })
+    })
+
+    it('handles generic errors as 500', () => {
+      const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
+      const ctx = { req: { method: 'POST' } } as unknown as Context<any>
+      const error = new Error('Some db error')
+      const result = handleContentDatabaseError(ctx, error)
+
+      expect(result).toEqual({
+        mockProblem: true,
+        type: 'content-database-error',
+        title: 'Internal Server Error',
+        status: 500,
+        detail: CONTENT_ERRORS.DATABASE_ERROR,
+      })
+      expect(consoleSpy).toHaveBeenCalledWith('Content database error:', error)
+      consoleSpy.mockRestore()
+    })
+  })
+})

package/src/features/content/handlers/helpers.ts

@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: BUSL-1.1
+// Copyright (c) 2024–2026 Flavio De Musso. All rights reserved.
+// See LICENSE in the repository root for license terms.
+
+import { Context } from 'hono'
+import { EntryNotFoundError, SlugConflictError } from '@beechcms/core'
+import { publicProblem, fkProblemOrNull } from '../../../public/problem-details'
+import { CONTENT_ERRORS } from '../constants'
+import { AppEnv } from '../../../types'
+
+export function normalizeBody(raw: unknown): Record<string, unknown> {
+  return typeof raw === 'object' && raw !== null ? (raw as Record<string, unknown>) : {}
+}
+
+export function contentValidationProblem(
+  context: Context,
+  details: Array<{ field: string; expected: string; received: string; message: string }>
+) {
+  return publicProblem(context, { 
+    type: 'content-validation-failed', 
+    title: 'Bad Request', 
+    status: 400, 
+    detail: 'Validation failed', 
+    errors: details 
+  })
+}
+
+export function logContentActivity(
+  context: Context<AppEnv>,
+  action: 'create' | 'update' | 'delete',
+  id: string,
+  slug: string,
+  title: string
+) {
+  const jwtPayload = context.get('jwtPayload')
+  context.get('activityLogger').log({
+    action,
+    entityType: 'content',
+    entityId: id,
+    entitySlug: slug,
+    details: { title },
+    actor: {
+      id: jwtPayload.sub,
+      email: jwtPayload.email ?? 'unknown',
+      name: [jwtPayload.name, jwtPayload.surname].filter(Boolean).join(' ') || null,
+    },
+  })
+}
+
+export function dispatchContentAutomation(
+  context: Context<AppEnv>,
+  seedSlug: string,
+  event: 'create' | 'update' | 'delete',
+  entry: Record<string, unknown>
+) {
+  context.get('scheduler').waitUntil(
+    context.get('automationRunner').run({
+      seedSlug,
+      event,
+      entry,
+    }),
+  )
+}
+
+export function handleContentDatabaseError(context: Context<AppEnv>, error: unknown) {
+  if (error instanceof EntryNotFoundError) {
+    return publicProblem(context, { 
+      type: 'content-not-found', 
+      title: 'Not Found', 
+      status: 404, 
+      detail: CONTENT_ERRORS.NOT_FOUND 
+    })
+  }
+  if (error instanceof SlugConflictError) {
+    return publicProblem(context, {
+      type: 'content-slug-conflict',
+      title: 'Conflict',
+      status: 409,
+      detail: CONTENT_ERRORS.SLUG_CONFLICT,
+    })
+  }
+  
+  const fkResponse = fkProblemOrNull(context, error, context.req.method)
+  if (fkResponse) return fkResponse
+
+  console.error('Content database error:', error)
+  return publicProblem(context, {
+    type: 'content-database-error',
+    title: 'Internal Server Error',
+    status: 500,
+    detail: CONTENT_ERRORS.DATABASE_ERROR,
+  })
+}