@beauraines/node-helpers 2.10.0 → 2.13.0

package/.github/workflows/test.yaml

@@ -22,5 +22,6 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
       - run: npm ci
+      - run: npm run lint
       - run: npm run build --if-present
       - run: npm test

package/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
-## [2.10.0](https://github.com/beauraines/node-helpers/compare/v2.7.1...v2.10.0) (2023-07-01)
+## [2.13.0](https://github.com/beauraines/node-helpers/compare/v2.7.1...v2.13.0) (2023-07-01)
 
 
 ### Features

package/package.json

@@ -1,12 +1,14 @@
 {
   "name": "@beauraines/node-helpers",
-  "version": "2.10.0",
+  "version": "2.13.0",
   "description": "Collection of node helpers",
   "main": "index.js",
   "scripts": {
     "test": "jest",
     "release": "standard-version",
-    "should-release": "should-release"
+    "should-release": "should-release",
+    "lint": "eslint '*/**.js'",
+    "lint:fix": "eslint '*/**.js' --fix"
   },
   "author": "beau.raines@gmail.com",
   "license": "ISC",

package/src/azure.js

@@ -236,7 +236,6 @@ getStorageQueueSignedURL(queueUrl,options) {
       new StorageSharedKeyCredential(this.storageAccountName, this.storageAccountKey)
     );
     const containerClient = blobServiceClient.getContainerClient(containerName);
-    let i = 1;
     let blobs = []
     for await (const blob of containerClient.listBlobsFlat()) {
       blobs.push(blob)

package/src/azure.test.js

@@ -112,6 +112,7 @@ describe('Azure Storage module', () => {
         let blobName = 'package.json'
         let azure = new AzureStorage(account,accountKey,{cloudName:'Azurite'})
         let blobs = await azure.listBlobs(containerName)
+        console.log(blobs)
         expect(Array.isArray(blobs));
         expect(blobs.length).toBeGreaterThan(0)
         expect(blobs.filter(b => b.name == blobName).length).toBe(1)

package/src/config.js

@@ -47,7 +47,7 @@ const validateConfig = async (configFile, configProps) => {
     config = JSON.parse(config);
     // Check for properties
     let validConfig = true
-    for (key of configProps) {
+    for (const key of configProps) {
         validConfig = config[key] ? true : false
     }
 
@@ -67,7 +67,7 @@ const validateConfig = async (configFile, configProps) => {
 const createConfig = async (configFile,configProps) => {
     configFile = path.join(homedir(),configFile)
     let config = {}
-    for (key of configProps) {
+    for (const key of configProps) {
         config[key] = ''
     }
     fs.writeFileSync(configFile,JSON.stringify(config))

package/src/credentials.js

@@ -1,5 +1,6 @@
 const fs = require('fs');
 const {fileExists} = require('./helpers');
+const process = require('node:process')
 
 /**
  * Reads a file for credentials and validates that the file has the required attributes. 

package/src/database.js

@@ -1,4 +1,5 @@
 const {homedir} = require('os');
+const process = require('node:process')
 const sqlite = require('sqlite');
 const sqlite3 = require('sqlite3');
 const {fileExists} = require('./helpers');

package/src/database.test.js

@@ -4,6 +4,7 @@ const sqlite3 = require('sqlite3');
 const helpers = require('./helpers');
 const { getDBConnection } = require('./database');
 const path = require('path');
+const process = require('node:process')
 
 jest.mock('sqlite');
 jest.mock('os');
@@ -37,6 +38,7 @@ describe('database module', () => {
         
         const file = undefined;
         // call function with null file
+        // eslint-disable-next-line no-unused-vars
         const db = await getDBConnection(file)
 
         // In theory you should mock the open function and what it returns.
@@ -59,6 +61,7 @@ describe('database module', () => {
 
         const expectedDefaultFile = path.join(os.homedir(),'BurnDownStatus.db')
 
+        // eslint-disable-next-line no-unused-vars
         const db = await getDBConnection(expectedDefaultFile)
 
         expect(sqlite.open).toHaveBeenCalledWith({

package/src/helpers.js

@@ -115,6 +115,7 @@ function getEpochMillis() {
  * @param {object} options Optional options for display, e.g display min,max,last, range coercion
  * @returns 
  */
+// eslint-disable-next-line no-unused-vars
 function sparkline(data,label,options) {
   // TODO add handling if data is object
   // let open = last30days.map( x=> x.open_count)
@@ -153,9 +154,11 @@ async function streamToBuffer(readableStream) {
   return new Promise((resolve, reject) => {
     const chunks = [];
     readableStream.on("data", (data) => {
+      // eslint-disable-next-line no-undef
       chunks.push(data instanceof Buffer ? data : Buffer.from(data));
     });
     readableStream.on("end", () => {
+      // eslint-disable-next-line no-undef
       resolve(Buffer.concat(chunks));
     });
     readableStream.on("error", reject);

package/src/jira.js

@@ -8,6 +8,7 @@ const fetch = require('node-fetch');
  * @returns String
  */
 function credentialsToToken(email,token) {
+    // eslint-disable-next-line no-undef
     let bearerToken = Buffer.from(`${email}:${token}`).toString('base64');
     return bearerToken
 }