@bastidood/eslint-config 0.1.1 → 0.3.0

package/dist/compose/index.mjs

@@ -13,12 +13,12 @@ var RestrictionLists = class RestrictionLists {
 	#properties = ["error"];
 	#syntax = ["error"];
 	/** Append every list of an entry point's restrictions. */
-	append(restrictions) {
-		appendAll(this.#imports.paths, restrictions.importPaths);
-		appendAll(this.#imports.patterns, restrictions.importPatterns);
-		appendAll(this.#globals, restrictions.globals);
-		appendAll(this.#properties, restrictions.properties);
-		appendAll(this.#syntax, restrictions.syntax);
+	append({ importPaths, importPatterns, globals, properties, syntax }) {
+		appendAll(this.#imports.paths, importPaths);
+		appendAll(this.#imports.patterns, importPatterns);
+		appendAll(this.#globals, globals);
+		appendAll(this.#properties, properties);
+		appendAll(this.#syntax, syntax);
 	}
 	/** Copy these lists so that a scoped override can extend them without changing the top-level rules. */
 	copy() {

package/dist/{convert-B62YDKje.mjs → convert-Bc-edfKh.mjs}

@@ -10,6 +10,9 @@ const CORE = {
 		jsPlugins: [{
 			name: "eslint-js",
 			specifier: "oxlint-plugin-eslint"
+		}, {
+			name: "slopstopper",
+			specifier: "@bastidood/eslint-plugin-slopstopper"
 		}],
 		categories: {
 			correctness: "error",
@@ -271,6 +274,35 @@ const CORE = {
 			radix: "error",
 			"require-unicode-regexp": "error",
 			"require-yield": "error",
+			"slopstopper/destructure-on-sight": "error",
+			"slopstopper/handle-or-rethrow": "error",
+			"slopstopper/merge-exclusive-branches": "error",
+			"slopstopper/needless-type-intersection": "error",
+			"slopstopper/no-alias-object-type": "error",
+			"slopstopper/no-array-filter-map": "error",
+			"slopstopper/no-conditional-empty-object-spread": "error",
+			"slopstopper/no-equality-chain": "error",
+			"slopstopper/no-inferrable-return-type": "error",
+			"slopstopper/no-known-value-widening": "error",
+			"slopstopper/no-multiple-optional-parameters": "error",
+			"slopstopper/no-negated-group": "error",
+			"slopstopper/no-negated-quantifier-callback": "error",
+			"slopstopper/no-plain-template-literal": "error",
+			"slopstopper/no-positional-scalars": "error",
+			"slopstopper/no-private-modifier": "error",
+			"slopstopper/no-reduce-accumulator-copy": "error",
+			"slopstopper/no-temporary-access": "error",
+			"slopstopper/no-type-predicates": "error",
+			"slopstopper/no-unknown-returns": "error",
+			"slopstopper/no-unknown-type-aliases": "error",
+			"slopstopper/no-unsafe-dictionary-type": "error",
+			"slopstopper/prefer-class-over-factory": "error",
+			"slopstopper/prefer-de-morgan": "error",
+			"slopstopper/prefer-prefix-increment": "error",
+			"slopstopper/prefer-switch": "error",
+			"slopstopper/prefer-typeof-undefined": "error",
+			"slopstopper/prefer-while-true": "error",
+			"slopstopper/stepdown-order": "error",
 			"sort-keys": "off",
 			"symbol-description": "error",
 			"typescript/adjacent-overload-signatures": "error",
@@ -400,7 +432,7 @@ const CORE = {
 			"typescript/switch-exhaustiveness-check": ["error", {
 				allowDefaultCaseForExhaustiveSwitch: false,
 				considerDefaultExhaustiveForUnions: false,
-				requireDefaultForNonUnion: true
+				requireDefaultForNonUnion: false
 			}],
 			"typescript/triple-slash-reference": "error",
 			"typescript/unbound-method": "error",
@@ -422,8 +454,11 @@ const CORE = {
 			message: "Import through a path alias or package subpath import instead of a parent-relative path (`../`)."
 		}],
 		globals: [{
+			name: "Reflect",
+			message: "Call typed functions and read typed properties directly instead of through `Reflect`, and parse dynamic input into a domain type first. Suppress this diagnostic with a reason only where a typed access is impossible."
+		}, {
 			name: "undefined",
-			message: "Omit absent values instead of writing `undefined`: conditionally insert the property (as `exactOptionalPropertyTypes` requires) or leave out the argument, and use a `typeof` check to test for absence. Pass `void 0` only to a parameter that cannot be omitted and is explicitly typed to accept `undefined`."
+			message: "Omit absent values instead of writing `undefined`: add the property in an `if` after declaring the object (as `exactOptionalPropertyTypes` requires) or leave out the argument, and use a `typeof` check to test for absence. Pass `void 0` only to a parameter that cannot be omitted and is explicitly typed to accept `undefined`."
 		}],
 		properties: [{
 			object: "process",
@@ -431,9 +466,6 @@ const CORE = {
 			message: "Read environment variables only in the entry point: validate them there and pass the values as explicit parameters. Opt the entry point out with a file-level disable comment."
 		}],
 		syntax: [{
-			selector: "[accessibility=\"private\"]:not(MethodDefinition[kind=\"constructor\"])",
-			message: "Use an ECMAScript `#private` member instead of the TypeScript `private` modifier."
-		}, {
 			selector: "UnaryExpression[operator=\"void\"][argument.type=\"Literal\"]:not(:matches(CallExpression, NewExpression) > UnaryExpression.arguments)",
 			message: "Do not write `void 0` to produce `undefined`: omit the absent value by conditionally inserting the property (as `exactOptionalPropertyTypes` requires). `void 0` is allowed only as an argument to a parameter that cannot be omitted and is explicitly typed to accept `undefined`."
 		}]
@@ -1407,44 +1439,37 @@ const REACT_PERF = ["react-perf"];
 const TYPESCRIPT = ["@typescript-eslint"];
 const UNICORN = ["unicorn"];
 const VITEST = ["vitest"];
-/** ESLint rule namespaces that an Oxlint plugin covers. */
-function namespacesOf(plugin) {
-	switch (plugin) {
-		case "eslint": return ESLINT;
-		case "import": return IMPORT;
-		case "jsdoc": return JSDOC;
-		case "jsx-a11y": return JSX_A11Y;
-		case "node": return NODE;
-		case "promise": return PROMISE;
-		case "react": return REACT;
-		case "react-perf": return REACT_PERF;
-		case "typescript": return TYPESCRIPT;
-		case "unicorn": return UNICORN;
-		case "vitest": return VITEST;
-		default: return null;
-	}
-}
-/**
-* Whether ESLint can run a rule, given its ESLint name. The conversion prunes unsupported rules: Oxlint-only rules,
-* and rules or options that the ESLint 10 plugins lack.
-*/
-function isSupportedInEslint(eslintName) {
-	switch (eslintName) {
-		case "import/consistent-type-specifier-style": return false;
-		default: return !eslintName.startsWith("oxc/");
+/** Write the ESLint equivalents of explicitly configured Oxlint rules, skipping rules that ESLint cannot run. */
+function writeEslintRules(target, rules) {
+	for (const name in rules) {
+		if (!Object.hasOwn(rules, name)) continue;
+		const rule = rules[name];
+		if (typeof rule === "undefined") continue;
+		const eslintName = toEslintRuleName(name);
+		if (isSupportedInEslint(eslintName)) target[eslintName] = toEslintRuleEntry(rule);
 	}
 }
-/** Rename the rules that an ESLint 10 plugin publishes under a different name than Oxlint's `eslint-plugin-oxlint` lists. */
-function renamedInEslint(eslintName) {
-	switch (eslintName) {
-		case "unicorn/no-array-for-each": return "unicorn/no-for-each";
-		default: return eslintName;
+/** Translate an Oxlint rule name into the name of the same rule in ESLint and its plugins. */
+function toEslintRuleName(name) {
+	const separator = name.indexOf("/");
+	if (separator === -1) return name;
+	const rule = name.slice(separator + 1);
+	switch (name.slice(0, separator)) {
+		case "eslint-js": return rule;
+		case "typescript": return `@typescript-eslint/${rule}`;
+		case "node": return `n/${rule}`;
+		case "unicorn": return renamedInEslint(name);
+		case "react": {
+			const hook = `react-hooks/${rule}`;
+			return Object.hasOwn(reactHooksRules, hook) ? hook : name;
+		}
+		default: return name;
 	}
 }
-function namespaceOf(eslintName) {
-	const separator = eslintName.lastIndexOf("/");
-	return separator === -1 ? "eslint" : eslintName.slice(0, separator);
+function toEslintRuleEntry(rule) {
+	return Array.isArray(rule) ? [toEslintSeverity(rule[0]), ...rule.values().drop(1)] : toEslintSeverity(rule);
 }
+const CATEGORY_INDEX = indexCategories();
 /** Index the published category lists once: category, then ESLint namespace, then rule names. */
 function indexCategories() {
 	const sources = [
@@ -1471,50 +1496,25 @@ function indexCategories() {
 	}
 	return index;
 }
-const CATEGORY_INDEX = indexCategories();
-/** Translate an Oxlint rule name into the name of the same rule in ESLint and its plugins. */
-function toEslintRuleName(name) {
-	const separator = name.indexOf("/");
-	if (separator === -1) return name;
-	const rule = name.slice(separator + 1);
-	switch (name.slice(0, separator)) {
-		case "eslint-js": return rule;
-		case "typescript": return `@typescript-eslint/${rule}`;
-		case "node": return `n/${rule}`;
-		case "unicorn": return renamedInEslint(name);
-		case "react": {
-			const hook = `react-hooks/${rule}`;
-			return Object.hasOwn(reactHooksRules, hook) ? hook : name;
-		}
-		default: return name;
-	}
-}
-function toEslintSeverity(severity) {
-	switch (severity) {
-		case "deny":
-		case "error": return "error";
-		case "allow":
-		case "off": return "off";
-		case "warn": return "warn";
-		default: switch (severity) {
-			case 0:
-			case 1:
-			case 2: return severity;
-			default: throw new UnsupportedSeverityError(severity);
-		}
+/**
+* Whether ESLint can run a rule, given its ESLint name. The conversion prunes unsupported rules: Oxlint-only rules,
+* and rules or options that the ESLint 10 plugins lack.
+*/
+function isSupportedInEslint(eslintName) {
+	switch (eslintName) {
+		case "import/consistent-type-specifier-style": return false;
+		default: return !eslintName.startsWith("oxc/");
 	}
 }
-function toEslintRuleEntry(rule) {
-	return Array.isArray(rule) ? [toEslintSeverity(rule[0]), ...rule.values().drop(1)] : toEslintSeverity(rule);
+function namespaceOf(eslintName) {
+	const separator = eslintName.lastIndexOf("/");
+	return separator === -1 ? "eslint" : eslintName.slice(0, separator);
 }
-/** Write the ESLint equivalents of explicitly configured Oxlint rules, skipping rules that ESLint cannot run. */
-function writeEslintRules(target, rules) {
-	for (const name in rules) {
-		if (!Object.hasOwn(rules, name)) continue;
-		const rule = rules[name];
-		if (typeof rule === "undefined") continue;
-		const eslintName = toEslintRuleName(name);
-		if (isSupportedInEslint(eslintName)) target[eslintName] = toEslintRuleEntry(rule);
+/** Rename the rules that an ESLint 10 plugin publishes under a different name than Oxlint's `eslint-plugin-oxlint` lists. */
+function renamedInEslint(eslintName) {
+	switch (eslintName) {
+		case "unicorn/no-array-for-each": return "unicorn/no-for-each";
+		default: return eslintName;
 	}
 }
 /**
@@ -1558,4 +1558,36 @@ function writeNamespaceRules(target, byNamespace, plugins, severity) {
 		}
 	}
 }
+/** ESLint rule namespaces that an Oxlint plugin covers. */
+function namespacesOf(plugin) {
+	switch (plugin) {
+		case "eslint": return ESLINT;
+		case "import": return IMPORT;
+		case "jsdoc": return JSDOC;
+		case "jsx-a11y": return JSX_A11Y;
+		case "node": return NODE;
+		case "promise": return PROMISE;
+		case "react": return REACT;
+		case "react-perf": return REACT_PERF;
+		case "typescript": return TYPESCRIPT;
+		case "unicorn": return UNICORN;
+		case "vitest": return VITEST;
+		default: return null;
+	}
+}
+function toEslintSeverity(severity) {
+	switch (severity) {
+		case "deny":
+		case "error": return "error";
+		case "allow":
+		case "off": return "off";
+		case "warn": return "warn";
+		default: switch (severity) {
+			case 0:
+			case 1:
+			case 2: return severity;
+			default: throw new UnsupportedSeverityError(severity);
+		}
+	}
+}
 export { CORE as i, writeEslintRules as n, writeExtensionRules as r, writeCategoryRules as t };

package/dist/core.mjs

@@ -1,4 +1,5 @@
-import { i as CORE$1, n as writeEslintRules, r as writeExtensionRules, t as writeCategoryRules } from "./convert-B62YDKje.mjs";
+import { i as CORE$1, n as writeEslintRules, r as writeExtensionRules, t as writeCategoryRules } from "./convert-Bc-edfKh.mjs";
+import SLOPSTOPPER from "@bastidood/eslint-plugin-slopstopper";
 import { importX } from "eslint-plugin-import-x";
 import tseslint from "typescript-eslint";
 // src/core.ts
@@ -22,7 +23,8 @@ for (const { files, rules } of OVERRIDES) {
 }
 const PLUGIN_DEFINITIONS = {
 	"@typescript-eslint": TYPESCRIPT_ESLINT,
-	import: importX
+	import: importX,
+	slopstopper: SLOPSTOPPER
 };
 const RESTRICTIONS = {
 	...CORE$1.restrictions,

package/dist/jsdoc.mjs

@@ -1,4 +1,4 @@
-import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-B62YDKje.mjs";
+import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-Bc-edfKh.mjs";
 import jsdocPlugin from "eslint-plugin-jsdoc";
 // ../oxlint/src/jsdoc.ts
 const JSDOC$1 = { config: {

package/dist/node.mjs

@@ -1,4 +1,4 @@
-import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-B62YDKje.mjs";
+import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-Bc-edfKh.mjs";
 import nodePlugin from "eslint-plugin-n";
 // ../oxlint/src/node.ts
 /** Node.js rules for code that runs on Node.js. */

package/dist/promise.mjs

@@ -1,4 +1,4 @@
-import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-B62YDKje.mjs";
+import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-Bc-edfKh.mjs";
 import promisePlugin from "eslint-plugin-promise";
 // ../oxlint/src/promise.ts
 const PROMISE$1 = { config: {

package/dist/unicorn.mjs

@@ -1,4 +1,4 @@
-import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-B62YDKje.mjs";
+import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-Bc-edfKh.mjs";
 import unicornPlugin from "eslint-plugin-unicorn";
 // ../oxlint/src/unicorn.ts
 const UNICORN$1 = { config: {
@@ -105,7 +105,7 @@ const UNICORN$1 = { config: {
 		"unicorn/prefer-optional-catch-binding": "off",
 		"unicorn/prefer-prototype-methods": "error",
 		"unicorn/prefer-query-selector": "error",
-		"unicorn/prefer-reflect-apply": "error",
+		"unicorn/prefer-reflect-apply": "off",
 		"unicorn/prefer-regexp-test": "error",
 		"unicorn/prefer-response-static-json": "error",
 		"unicorn/prefer-set-has": "error",

package/dist/vitest.mjs

@@ -1,6 +1,8 @@
-import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-B62YDKje.mjs";
+import { i as CORE, n as writeEslintRules, t as writeCategoryRules } from "./convert-Bc-edfKh.mjs";
 import vitestPlugin from "@vitest/eslint-plugin";
 // ../oxlint/src/vitest.ts
+/** Steers module mocks toward dependency injection, as honest functions take their external collaborators as parameters. */
+const MODULE_MOCK_MESSAGE = "A module mock swaps out a dependency that the code under test hides. Make the code honest instead: have it take the stateful or external collaborator (a database, network client, file system, or clock) as a parameter, inject the real one from the entry point, and pass a fake in the test. If a mock is unavoidable, suppress this diagnostic with a reason and mock through `import()` so that the path stays type-checked.";
 const VITEST$1 = { config: {
 	plugins: ["vitest"],
 	rules: {
@@ -36,7 +38,11 @@ const VITEST$1 = { config: {
 		"vitest/no-large-snapshots": "error",
 		"vitest/no-mocks-import": "error",
 		"vitest/no-restricted-matchers": "off",
-		"vitest/no-restricted-vi-methods": "off",
+		"vitest/no-restricted-vi-methods": ["error", {
+			mock: MODULE_MOCK_MESSAGE,
+			doMock: MODULE_MOCK_MESSAGE,
+			importMock: MODULE_MOCK_MESSAGE
+		}],
 		"vitest/no-standalone-expect": "error",
 		"vitest/no-test-prefixes": "error",
 		"vitest/no-test-return-statement": "error",
@@ -83,7 +89,7 @@ const VITEST$1 = { config: {
 		"vitest/valid-describe-callback": "error",
 		"vitest/valid-expect": "error",
 		"vitest/valid-expect-in-promise": "error",
-		"vitest/valid-title": "error",
+		"vitest/valid-title": ["error", { ignoreTypeOfDescribeName: true }],
 		"vitest/warn-todo": "error"
 	}
 } };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bastidood/eslint-config",
-  "version": "0.1.1",
+  "version": "0.3.0",
   "description": "Strict baseline ESLint configuration generated from @bastidood/oxlint-config.",
   "license": "MIT",
   "homepage": "https://github.com/BastiDood/slopstopper",
@@ -26,6 +26,7 @@
     "access": "public"
   },
   "dependencies": {
+    "@bastidood/eslint-plugin-slopstopper": "^0.2.0",
     "@vitest/eslint-plugin": "^1.6.28",
     "eslint-plugin-import-x": "^4.17.1",
     "eslint-plugin-jsdoc": "^65.4.2",
@@ -35,12 +36,12 @@
     "typescript-eslint": "^8.72.1"
   },
   "devDependencies": {
-    "@bastidood/oxlint-config": "0.1.1",
+    "@bastidood/oxlint-config": "0.3.0",
     "@bastidood/tsconfig": "0.1.1",
     "@typescript/native": "npm:typescript@^7.0.2",
     "eslint": "^10.13.0",
     "eslint-plugin-oxlint": "^1.90.0",
-    "tsdown": "^0.23.2",
+    "tsdown": "^0.23.4",
     "typescript": "npm:@typescript/typescript6@^6.0.2"
   },
   "peerDependencies": {