@basthon/console-react 0.3.1 → 0.3.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -7,7 +7,6 @@ export default class Editor {
7
7
  private _kernel;
8
8
  private _editor;
9
9
  private _onSetContent?;
10
- private _silentChange;
11
10
  constructor(element: HTMLElement, kernel: KernelBase, onSetContent?: (_: string) => void, onChange?: () => void);
12
11
  /**
13
12
  * Set Ace mode from language.
@@ -19,9 +18,8 @@ export default class Editor {
19
18
  setTheme(theme: Theme): Promise<void>;
20
19
  /**
21
20
  * Dispatch action to set content.
22
- * If silent is true, editor's onChange is not triggered.
23
21
  */
24
- setContent(content: string, silent?: boolean): void;
22
+ setContent(content: string): void;
25
23
  /**
26
24
  * Set Ace editor content.
27
25
  */
package/lib/gui/editor.js CHANGED
@@ -4,7 +4,6 @@ import ace from "./ace";
4
4
  */
5
5
  export default class Editor {
6
6
  constructor(element, kernel, onSetContent, onChange) {
7
- this._silentChange = false;
8
7
  this._kernel = kernel;
9
8
  this._onSetContent = onSetContent;
10
9
  this._editor = ace.edit(element);
@@ -17,11 +16,7 @@ export default class Editor {
17
16
  });
18
17
  // connect onchange
19
18
  if (onChange != null)
20
- this._editor.session.on("change", () => {
21
- if (!this._silentChange)
22
- onChange();
23
- this._silentChange = false;
24
- });
19
+ this._editor.session.on("change", () => onChange());
25
20
  /* editor's completion */
26
21
  // removing all completers and keeping track of local completer
27
22
  const localCompleter = this._editor.completers[1]; // any hint to detect this dynamically?
@@ -88,10 +83,8 @@ export default class Editor {
88
83
  }
89
84
  /**
90
85
  * Dispatch action to set content.
91
- * If silent is true, editor's onChange is not triggered.
92
86
  */
93
- setContent(content, silent = false) {
94
- this._silentChange = silent === true;
87
+ setContent(content) {
95
88
  this._onSetContent?.(content);
96
89
  }
97
90
  /**
@@ -99,9 +92,7 @@ export default class Editor {
99
92
  */
100
93
  setContentNoDispatch(content) {
101
94
  if (content != null)
102
- this._editor.setValue(content);
103
- this._editor.scrollToRow(0);
104
- this._editor.gotoLine(0, 0, false);
95
+ this._editor.setValue(content, -1);
105
96
  }
106
97
  /**
107
98
  * Get editor's content
package/lib/gui/gui.d.ts CHANGED
@@ -39,9 +39,8 @@ export default class GUI extends GUIBase {
39
39
  content(): string;
40
40
  /**
41
41
  * Set editor's content.
42
- * If silent is true, editor's onChange is not triggered.
43
42
  */
44
- setContent(content: string, silent?: boolean): void;
43
+ setContent(content: string): void;
45
44
  /**
46
45
  * Notify the user with an error.
47
46
  */
package/lib/gui/gui.js CHANGED
@@ -62,10 +62,9 @@ export default class GUI extends GUIBase {
62
62
  }
63
63
  /**
64
64
  * Set editor's content.
65
- * If silent is true, editor's onChange is not triggered.
66
65
  */
67
- setContent(content, silent = false) {
68
- this._editor?.setContent(content, silent);
66
+ setContent(content) {
67
+ this._editor?.setContent(content);
69
68
  }
70
69
  /**
71
70
  * Notify the user with an error.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@basthon/console-react",
3
- "version": "0.3.1",
3
+ "version": "0.3.2",
4
4
  "description": "Basthon - Console React Component",
5
5
  "homepage": "https://basthon.fr",
6
6
  "bugs": {