@bastani/atomic 0.9.62 → 0.9.63

package/dist/builtin/workflows/src/index.js

@@ -1071,9 +1071,10 @@ function registerSqlPoolStorage(journal, storage) {
 function sqlPoolStorage(journal) {
   return poolStorage.get(journal);
 }
-var JOURNAL_READ_PAGE_SIZE = 256, NON_SNAPSHOT_EVENT_TYPES, poolStorage;
+var JOURNAL_READ_PAGE_SIZE = 256, JOURNAL_TRANSACTION, NON_SNAPSHOT_EVENT_TYPES, poolStorage;
 var init_internal = __esm(() => {
   init_types();
+  JOURNAL_TRANSACTION = { lockWaitMs: 10 * 60000 };
   NON_SNAPSHOT_EVENT_TYPES = [
     RUN_EVENT_TYPES.checkpointRecorded,
     RUN_EVENT_TYPES.messageSettled,
@@ -1368,7 +1369,7 @@ class LegacyJournalRuns {
           return;
         await tx.exec(`CREATE TABLE IF NOT EXISTS ${CURRENT.legacyDeleted}(${JOURNAL_COLUMNS.runId} TEXT PRIMARY KEY, deleted_at INTEGER NOT NULL)`);
         return new LegacyJournalRuns;
-      });
+      }, JOURNAL_TRANSACTION);
     } catch {
       return;
     }
@@ -1408,6 +1409,7 @@ class LegacyJournalRuns {
 }
 var CURRENT, COPIED_ALL_MARKER = "unprefixed-journal-tables", LEGACY_COLUMNS, PENDING_LEGACY_RUNS;
 var init_legacy_journal_tables = __esm(() => {
+  init_internal();
   init_types();
   CURRENT = renderStorageIdentifiers("journal", {
     ...JOURNAL_TABLES,
@@ -1458,7 +1460,7 @@ class SqlRunJournal {
     this.tables = tables;
     this.legacy = legacy;
     registerSqlPoolStorage(this, {
-      transaction: (body) => this.operation(() => this.database.transaction(body)),
+      transaction: (body) => this.operation(() => this.transaction(body)),
       read: (body) => this.operation(() => body(this.database)),
       withAppendGuard: (guard, action) => this.appendGuard.run(guard, action),
       tables: this.tables
@@ -1498,7 +1500,7 @@ class SqlRunJournal {
 					${JOURNAL_COLUMNS.holderId} TEXT, ${JOURNAL_COLUMNS.epoch} INTEGER NOT NULL, ${JOURNAL_COLUMNS.renewedAt} INTEGER NOT NULL
 				);
 			`);
-    });
+    }, JOURNAL_TRANSACTION);
     const legacy = options.prefix ? undefined : await LegacyJournalRuns.open(database);
     return new SqlRunJournal(database, t, legacy);
   }
@@ -1512,6 +1514,9 @@ class SqlRunJournal {
     if (this.closed)
       throw new StorageUnavailableError2(this.descriptor, new JournalClosedError);
   }
+  transaction(body) {
+    return this.database.transaction(body, JOURNAL_TRANSACTION);
+  }
   operation(action) {
     this.assertOpen();
     const result = action();
@@ -1538,7 +1543,7 @@ class SqlRunJournal {
     return this.operation(async () => {
       if (await this.legacy?.find(this.database, header.runId))
         return "exists";
-      const result = await this.database.run(`INSERT INTO ${runs} VALUES (?, ?, ?, ?, ?, ?) ON CONFLICT(${JOURNAL_COLUMNS.runId}) DO NOTHING`, header.runId, header.name, header.cwd, header.createdAt, header.status, json);
+      const result = await this.transaction((tx) => tx.run(`INSERT INTO ${runs} VALUES (?, ?, ?, ?, ?, ?) ON CONFLICT(${JOURNAL_COLUMNS.runId}) DO NOTHING`, header.runId, header.name, header.cwd, header.createdAt, header.status, json));
       return result.changes === 1 ? "created" : "exists";
     });
   }
@@ -1630,7 +1635,7 @@ class SqlRunJournal {
     this.assertOpen();
     validateText("runId", runId);
     validateText("holderId", holderId);
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.requireRun(tx, runId);
       const current = await this.leaseRow(tx, runId);
       if (current?.[JOURNAL_COLUMNS.holderId] === holderId)
@@ -1645,7 +1650,7 @@ class SqlRunJournal {
     validateText("runId", runId);
     validateText("holderId", holderId);
     validateText("expectedHolder", expectedHolder);
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.requireRun(tx, runId);
       const current = await this.leaseRow(tx, runId);
       if (current?.[JOURNAL_COLUMNS.holderId] !== expectedHolder)
@@ -1675,7 +1680,7 @@ class SqlRunJournal {
     this.assertOpen();
     validateText("runId", runId);
     validateText("holderId", holderId);
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.requireRun(tx, runId);
       const current = await this.leaseRow(tx, runId);
       if (current?.[JOURNAL_COLUMNS.holderId] === holderId)
@@ -1699,7 +1704,7 @@ class SqlRunJournal {
     validateText("runId", lease.runId);
     validateText("holderId", lease.holderId);
     const owned = { ...lease };
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.checkLease(tx, owned);
       await tx.run(`UPDATE ${this.tables.leases} SET ${JOURNAL_COLUMNS.renewedAt} = ${STORE_NOW} WHERE ${JOURNAL_COLUMNS.runId} = ?`, owned.runId);
     }));
@@ -1709,7 +1714,7 @@ class SqlRunJournal {
     validateText("runId", lease.runId);
     validateText("holderId", lease.holderId);
     const owned = { ...lease };
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.checkLease(tx, owned);
       await tx.run(`UPDATE ${this.tables.leases} SET ${JOURNAL_COLUMNS.holderId} = ? WHERE ${JOURNAL_COLUMNS.runId} = ?`, JOURNAL_LEASE.unheld, owned.runId);
     }));
@@ -1725,7 +1730,7 @@ class SqlRunJournal {
     const owned = { ...lease };
     const prepared = this.prepare(event, options?.key, this.appendGuard.getStore());
     const expected = options?.expectSeq;
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.checkLease(tx, owned);
       return this.insert(tx, owned, prepared, expected);
     }));
@@ -1745,7 +1750,7 @@ class SqlRunJournal {
     const batch = this.database.batch?.bind(this.database);
     if (batch && prepared.every((append) => append instanceof Error || append.guard === undefined && typeof append.payload === "string"))
       return this.operation(() => this.appendInOneRequest(batch, owned, prepared));
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.checkLease(tx, owned);
       const results = [];
       for (const append of prepared) {
@@ -1896,14 +1901,14 @@ class SqlRunJournal {
   async deleteRun(runId) {
     this.assertOpen();
     validateText("runId", runId);
-    return this.operation(() => this.database.transaction((tx) => this.deleteRunData(tx, runId)));
+    return this.operation(() => this.transaction((tx) => this.deleteRunData(tx, runId)));
   }
   async deleteOwnedRun(lease, expectSeq) {
     this.assertOpen();
     validateText("runId", lease.runId);
     validateText("holderId", lease.holderId);
     const owned = { ...lease };
-    return this.operation(() => this.database.transaction(async (tx) => {
+    return this.operation(() => this.transaction(async (tx) => {
       await this.checkLease(tx, owned);
       if (expectSeq !== undefined) {
         const actual = await this.sequence(tx, owned.runId);
@@ -4389,13 +4394,13 @@ class WorkflowObservationRuntime {
       return run.rootRunId;
     if (run.parentRunId === undefined)
       return run.id;
-    const parent = this.runs().find((candidate) => candidate.id === run.parentRunId);
+    const parent = this.runs.find(run.parentRunId);
     return parent ? this.rootRunId(parent) : run.parentRunId;
   }
   lifecycle(target, attribution = "unknown") {
     if (this.recovering && !this.liveRunIds.has(target.runId))
       return;
-    const run = this.runs().find((candidate) => candidate.id === target.runId);
+    const run = this.runs.find(target.runId);
     if (!run)
       return;
     const rootRunId = this.rootRunId(run);
@@ -4416,7 +4421,7 @@ class WorkflowObservationRuntime {
     });
   }
   control(runId, action, attribution = "unknown") {
-    const run = this.runs().find((candidate) => candidate.id === runId);
+    const run = this.runs.find(runId);
     if (!run)
       return;
     if ((action === "quit" || action === "kill" || action === "pause") && this.liveRunIds.has(runId))
@@ -4427,7 +4432,7 @@ class WorkflowObservationRuntime {
     this.invalidate({ runId });
   }
   heartbeat(runId, scheduledAt, intervalMinutes) {
-    const run = this.runs().find((candidate) => candidate.id === runId);
+    const run = this.runs.find(runId);
     if (run)
       this.emit({
         kind: "heartbeat",
@@ -4453,7 +4458,7 @@ class WorkflowObservationRuntime {
     if (changes === undefined) {
       const next = new Map;
       const nextOwners = new Map;
-      for (const run of this.runs()) {
+      for (const run of this.runs.all()) {
         const owners = nextOwners.get(run.id) ?? new Map;
         nextOwners.set(run.id, owners);
         this.captureRun(run, this.previous.has(`run:${run.id}`), next, owners);
@@ -4480,10 +4485,15 @@ class WorkflowObservationRuntime {
         nodes.tools.add(change.toolNodeId);
       changed.set(change.runId, nodes);
     }
-    for (const run of this.runs()) {
-      const change = changed.get(run.id);
-      if (change === undefined)
+    const ordered = [...changed.keys()].flatMap((runId) => {
+      const position = this.runs.position(runId);
+      return position === undefined ? [] : [{ runId, position }];
+    }).sort((left, right) => left.position - right.position);
+    for (const { runId } of ordered) {
+      const run = this.runs.find(runId);
+      if (run === undefined)
         continue;
+      const change = changed.get(runId);
       const existing = this.previous.has(`run:${run.id}`);
       const nodes = change === "run" || !existing ? undefined : change;
       const next = new Map;
@@ -4521,7 +4531,7 @@ class WorkflowObservationRuntime {
         keys.push(key);
       const previous = this.previous.get(key);
       if (!historical && this.liveRunIds.has(target.runId) && previous?.status !== target.status) {
-        this.lifecycle(previous && previous.kind !== "prompt" && target.kind !== "prompt" ? { ...target, previousStatus: previous.status } : target, this.runs().find((candidate) => candidate.id === target.runId)?.origin);
+        this.lifecycle(previous && previous.kind !== "prompt" && target.kind !== "prompt" ? { ...target, previousStatus: previous.status } : target, this.runs.find(target.runId)?.origin);
       }
     };
     visit("run", `run:${run.id}`, { kind: "run", runId: run.id, status: run.status });
@@ -4650,6 +4660,7 @@ function applyRunEndMetadata(run, metadata) {
 function createStoreState() {
   return {
     runs: [],
+    runPositions: new Map,
     notices: [],
     listeners: new Set,
     invalidationListeners: new Set,
@@ -4659,11 +4670,27 @@ function createStoreState() {
     version: 0
   };
 }
+function reindexRuns(state) {
+  state.runPositions.clear();
+  state.runs.forEach((run, position) => {
+    if (!state.runPositions.has(run.id))
+      state.runPositions.set(run.id, position);
+  });
+}
+function runPosition(state, runId) {
+  const position = state.runPositions.get(runId);
+  if (position !== undefined && state.runs[position]?.id === runId)
+    return position;
+  if (position === undefined && state.runPositions.size === state.runs.length)
+    return;
+  reindexRuns(state);
+  return state.runPositions.get(runId);
+}
 function createStoreContext(state = createStoreState()) {
   let cachedGraphVersion = -1;
   let cachedGraphSnapshot;
   const graphBuilder = new GraphStoreSnapshotBuilder;
-  const observation = new WorkflowObservationRuntime(() => state.runs, bumpAndNotify);
+  const observation = new WorkflowObservationRuntime({ all: () => state.runs, find: findRun, position: (runId) => runPosition(state, runId) }, bumpAndNotify);
   function snapshot() {
     return JSON.parse(JSON.stringify({ runs: state.runs, notices: state.notices, version: state.version }));
   }
@@ -4677,7 +4704,7 @@ function createStoreContext(state = createStoreState()) {
   function graphRun(runId) {
     if (cachedGraphSnapshot !== undefined && cachedGraphVersion === state.version)
       return findSnapshotRun(cachedGraphSnapshot.runs, runId);
-    const run = state.runs.find((candidate) => candidate.id === runId);
+    const run = findRun(runId);
     return run === undefined ? undefined : graphBuilder.buildRun(run);
   }
   let batchDepth = 0;
@@ -4731,7 +4758,29 @@ function createStoreContext(state = createStoreState()) {
     }
   }
   function findRun(runId) {
-    return state.runs.find((r) => r.id === runId);
+    const position = runPosition(state, runId);
+    return position === undefined ? undefined : state.runs[position];
+  }
+  function placeRun(run) {
+    const position = runPosition(state, run.id);
+    if (position !== undefined) {
+      state.runs[position] = run;
+      return;
+    }
+    state.runPositions.set(run.id, state.runs.length);
+    state.runs.push(run);
+  }
+  function removeRunAt(position) {
+    const [removed] = state.runs.splice(position, 1);
+    if (removed === undefined)
+      return;
+    state.runPositions.delete(removed.id);
+    for (let index = position;index < state.runs.length; index++)
+      state.runPositions.set(state.runs[index].id, index);
+  }
+  function clearRuns() {
+    state.runs.length = 0;
+    state.runPositions.clear();
   }
   function findStage(run, stageId) {
     return run.stages.find((s) => s.id === stageId);
@@ -4787,6 +4836,10 @@ function createStoreContext(state = createStoreState()) {
     batch,
     bumpAndNotify,
     findRun,
+    runPosition: (runId) => runPosition(state, runId),
+    placeRun,
+    removeRunAt,
+    clearRuns,
     findStage,
     rejectPrompt,
     rejectStagePrompt,
@@ -5868,6 +5921,9 @@ function createRunStoreMethods(context) {
     runs() {
       return state.runs;
     },
+    run(runId) {
+      return context.findRun(runId);
+    },
     notices() {
       return state.notices;
     },
@@ -5887,11 +5943,7 @@ function createRunStoreMethods(context) {
       return null;
     },
     recordRunStart(run) {
-      const index = state.runs.findIndex((existing) => existing.id === run.id);
-      if (index === -1)
-        state.runs.push(run);
-      else
-        state.runs[index] = run;
+      context.placeRun(run);
       context.bumpAndNotify({ runId: run.id });
     },
     recordRunSummary(runId, summary, summarizedThrough) {
@@ -6032,17 +6084,13 @@ function createRunStoreMethods(context) {
         restored.result = metadata.result;
       if (metadata.budgetState !== undefined)
         restored.budgetState = metadata.budgetState;
-      const index = state.runs.findIndex((candidate) => candidate.id === source.id);
-      if (index < 0)
-        state.runs.push(restored);
-      else
-        state.runs[index] = restored;
+      context.placeRun(restored);
       context.bumpAndNotify();
       return true;
     },
     removeRun(runId) {
-      const index = state.runs.findIndex((r) => r.id === runId);
-      if (index < 0)
+      const index = context.runPosition(runId);
+      if (index === undefined)
         return false;
       const run = state.runs[index];
       const pending = run.pendingPrompt;
@@ -6054,7 +6102,7 @@ function createRunStoreMethods(context) {
       for (const stage of run.stages) {
         state.stagePromptAnswers.delete(context.stagePromptAnswerKey(runId, stage.id));
       }
-      state.runs.splice(index, 1);
+      context.removeRunAt(index);
       for (let i = state.notices.length - 1;i >= 0; i--) {
         if (state.notices[i]?.runId === runId)
           state.notices.splice(i, 1);
@@ -6146,7 +6194,7 @@ function createRunStoreMethods(context) {
     clear() {
       if (state.runs.length === 0 && state.notices.length === 0 && state.resolvers.size === 0 && state.stagePromptAnswers.size === 0 && state.stagePromptDrafts.size === 0)
         return;
-      state.runs.length = 0;
+      context.clearRuns();
       state.notices.length = 0;
       for (const entry of state.resolvers.values()) {
         entry.reject(new Error("atomic-workflows: store cleared"));
@@ -67750,16 +67798,25 @@ class PoolStageHandoff {
           throw outside2(run.id);
       }
     };
-    const before = new Map(this.store.runs().map((run) => [run.id, run]));
+    const before = this.known(subtree);
     owned(before);
     if (subtree.some((run) => before.get(run.id) === undefined))
       await this.backend.catchUpWorkflow(root);
     await this.queue.assertCurrent(this.lease, work);
     return () => this.commit(work, subtree, owned);
   }
+  known(subtree) {
+    const known = new Map;
+    for (const run of subtree) {
+      const existing = this.store.run(run.id);
+      if (existing !== undefined)
+        known.set(run.id, existing);
+    }
+    return known;
+  }
   commit(work, subtree, owned) {
     const root = this.lease.runId;
-    const known = new Map(this.store.runs().map((run) => [run.id, run]));
+    const known = this.known(subtree);
     owned(known);
     const attempt = this.enter(work);
     const execution = {
@@ -67793,7 +67850,7 @@ class PoolStageHandoff {
         else
           attempt.sessions.set(key, stage.sessionId);
       }
-      const previous = this.store.runs().find((candidate) => candidate.id === run.id);
+      const previous = this.store.run(run.id);
       for (const stage of run.stages)
         if (previous?.stages.find((candidate) => candidate.id === stage.id)?.attached === true)
           stage.attached = true;
@@ -67812,7 +67869,7 @@ class PoolStageHandoff {
     }
     if (runs.length === 0)
       return [];
-    const rootRun = this.store.runs().find((run) => run.id === root);
+    const rootRun = this.store.run(root);
     const boundary = rootRun?.stages.find((stage) => stage.id === work.boundaryId);
     if (authoritativeWorkflowChildRunId(boundary) !== work.childRunId)
       throw new Error(`Pool work boundary ${work.boundaryId} is not linked to ${work.childRunId} in the root run`);
@@ -67877,7 +67934,7 @@ class PoolStageHandoff {
     for (const id of attempt.runs)
       rotateWorkflowPendingStageRouteCapability(this.store, id);
     for (const id of attempt.runs) {
-      const run = this.store.runs().find((candidate) => candidate.id === id);
+      const run = this.store.run(id);
       if (run?.stages.some((stage) => isLive(stage)) !== true)
         continue;
       this.store.recordRunStart({
@@ -69573,7 +69630,7 @@ class LocalWorkerPool {
     return false;
   }
   applyHeldAnswer(runId, stageId, heldGeneration) {
-    const stage = this.store?.runs().find((run) => run.id === runId)?.stages.find((candidate) => candidate.id === stageId);
+    const stage = this.store?.run(runId)?.stages.find((candidate) => candidate.id === stageId);
     if (stage === undefined || this.closed)
       return;
     const generation = stage.workerExecution?.generation ?? 0;
@@ -69629,7 +69686,7 @@ class LocalWorkerPool {
     const key = JSON.stringify([runId, stageId]);
     let view = this.stageViews.get(key);
     if (view === undefined) {
-      const stageName = this.store?.runs().find((run) => run.id === runId)?.stages.find((stage) => stage.id === stageId)?.name ?? stageId;
+      const stageName = this.store?.run(runId)?.stages.find((stage) => stage.id === stageId)?.name ?? stageId;
       const created = { key, holders: 0, opening: Promise.resolve(undefined) };
       const transport = this.stageTransport((reason) => {
         tracePooledWatch("root.view.watch-ended", { key, reason, current: this.stageViews.get(key) === created });
@@ -69695,10 +69752,9 @@ class LocalWorkerPool {
     };
   }
   reconnectStageViews() {
-    const runs = this.store?.runs() ?? [];
     const stageOf = (key) => {
       const [runId, stageId] = JSON.parse(key);
-      const run = runs.find((candidate) => candidate.id === runId);
+      const run = this.store?.run(runId);
       return { runId, stageId, run, stage: run?.stages.find((candidate) => candidate.id === stageId) };
     };
     const ended = (key) => {
@@ -69779,7 +69835,7 @@ class LocalWorkerPool {
     };
   }
   rootProjection() {
-    const run = this.store?.runs().find((candidate) => candidate.id === this.root);
+    const run = this.root === undefined ? undefined : this.store?.run(this.root);
     return run === undefined ? undefined : projectRootRun(run);
   }
   rootRun() {