@bastani/atomic 0.9.16-alpha.2 → 0.9.16-alpha.4

package/dist/builtin/subagents/src/runs/foreground/notify.ts

@@ -1,355 +0,0 @@
-/**
- * Subagent completion notifications.
- */
-
-import { type ExtensionAPI, isStaleExtensionContextError } from "@bastani/atomic";
-import { resolveSubagentIntercomTarget } from "../../intercom/intercom-bridge.js";
-import {
-	SUBAGENT_COMPLETE_EVENT,
-	SUBAGENT_TERMINAL_ORDERING_BARRIER_EVENT,
-	type SubagentAttemptStatus,
-} from "../../shared/types.js";
-import type { CompletionNotificationEnvelope } from "./completion-notification.js";
-
-interface SubagentStepResult {
-	agent: string;
-	output: string;
-	status: SubagentAttemptStatus;
-	intercomTarget?: string;
-	index?: number;
-}
-
-export interface SubagentNotifyDetails {
-	agent: string;
-	status: "completed" | "failed" | "interrupted";
-	taskInfo?: string;
-	resultPreview: string;
-	durationMs?: number;
-	sessionLabel?: string;
-	sessionValue?: string;
-}
-
-interface SubagentResult {
-	id: string | null;
-	runId?: string;
-	notificationId?: string;
-	agent: string | null;
-	status: SubagentAttemptStatus;
-	summary: string;
-	state?: string;
-	timestamp: number;
-	durationMs?: number;
-	sessionFile?: string;
-	shareUrl?: string;
-	gistUrl?: string;
-	shareError?: string;
-	results?: SubagentStepResult[];
-	taskIndex?: number;
-	totalTasks?: number;
-	noticeLabel?: string;
-}
-
-interface TerminalPreludeMessage {
-	customType: string;
-	content: string;
-	display: boolean;
-	details?: unknown;
-}
-
-interface NotifyRegistration {
-	unsubscribe: () => void;
-}
-
-function getNotifyRegistry(): WeakMap<ExtensionAPI, NotifyRegistration> {
-	const key = "__piSubagentsNotifyRegistrations";
-	const store = globalThis as Record<string, unknown>;
-	const existing = store[key];
-	if (existing instanceof WeakMap) return existing as WeakMap<ExtensionAPI, NotifyRegistration>;
-	const registry = new WeakMap<ExtensionAPI, NotifyRegistration>();
-	store[key] = registry;
-	return registry;
-}
-
-function getNotifySeenRegistry(): WeakMap<ExtensionAPI, Map<string, number>> {
-	const key = "__piSubagentsNotifySeenByApi";
-	const store = globalThis as Record<string, unknown>;
-	const existing = store[key];
-	if (existing instanceof WeakMap) return existing as WeakMap<ExtensionAPI, Map<string, number>>;
-	const registry = new WeakMap<ExtensionAPI, Map<string, number>>();
-	store[key] = registry;
-	return registry;
-}
-
-function getNotifySeen(pi: ExtensionAPI): Map<string, number> {
-	const registry = getNotifySeenRegistry();
-	const existing = registry.get(pi);
-	if (existing) return existing;
-	const seen = new Map<string, number>();
-	registry.set(pi, seen);
-	return seen;
-}
-
-function buildCompletionKey(data: SubagentResult, fallback: string): string {
-	if (data.runId) return `run:${data.runId}`;
-	if (data.id) return `id:${data.id}`;
-	return `meta:${data.agent ?? "unknown"}:${data.timestamp}:${data.taskIndex ?? "-"}:${fallback}`;
-}
-
-function hasSeenWithTtl(seen: Map<string, number>, key: string, now: number, ttlMs: number): boolean {
-	for (const [seenKey, seenAt] of seen) if (now - seenAt > ttlMs) seen.delete(seenKey);
-	return seen.has(key);
-}
-
-function recordSeen(seen: Map<string, number>, key: string, now: number): void {
-	seen.set(key, now);
-}
-function isPromiseLike(value: unknown): value is PromiseLike<void> {
-	return (
-		(typeof value === "object" || typeof value === "function") &&
-		value !== null &&
-		typeof (value as { then?: unknown }).then === "function"
-	);
-}
-
-async function dispatchFallback(
-	pi: ExtensionAPI,
-	prefix: TerminalPreludeMessage[],
-	terminalMessage: TerminalPreludeMessage,
-	deliveryOptions: Parameters<ExtensionAPI["sendMessage"]>[1],
-): Promise<void> {
-	let delivered = 0;
-	try {
-		for (const message of prefix) {
-			await pi.sendMessage(message, { deliverAs: "steer" });
-			delivered += 1;
-		}
-		await pi.sendMessage(terminalMessage, deliveryOptions);
-	} catch (error) {
-		const failure = new Error(error instanceof Error ? error.message : String(error), { cause: error });
-		Object.assign(failure, { terminalPreludeDelivered: delivered });
-		throw failure;
-	}
-}
-
-export default function registerSubagentNotify(pi: ExtensionAPI): () => void {
-	const registry = getNotifyRegistry();
-	const previous = registry.get(pi);
-	const seen = getNotifySeen(pi);
-	const ttlMs = 10 * 60 * 1000;
-
-	const emitTerminalOrderingBarrier = (
-		result: SubagentResult,
-		dispatch?: (prefix: TerminalPreludeMessage[]) => void | Promise<void>,
-	): Promise<void> | undefined => {
-		const runId = result.runId ?? result.id;
-		if (!runId) return undefined;
-		const resultTargets =
-			result.results?.map(
-				(child, arrayIndex) =>
-					child.intercomTarget?.trim() ||
-					resolveSubagentIntercomTarget(runId, child.agent, child.index ?? arrayIndex),
-			) ?? [];
-		const sourceSessionTargets =
-			resultTargets.length > 0
-				? resultTargets
-				: result.agent
-					? [resolveSubagentIntercomTarget(runId, result.agent, 0)]
-					: [];
-		if (sourceSessionTargets.length === 0) return undefined;
-		const terminalId = result.notificationId?.startsWith("completion-notify-")
-			? result.notificationId.slice("completion-notify-".length)
-			: result.notificationId;
-		let dispatchStarted = false;
-		const barrierDispatch = dispatch
-			? (prefix: TerminalPreludeMessage[]) => {
-					dispatchStarted = true;
-					return dispatch(prefix);
-				}
-			: undefined;
-		const payload = {
-			runId,
-			...(terminalId ? { terminalId } : {}),
-			terminalAt: Number.isFinite(result.timestamp) ? result.timestamp : Date.now(),
-			source: "detached-notify" as const,
-			sourceSessionTargets,
-			...(barrierDispatch ? { dispatch: barrierDispatch } : {}),
-		};
-		Object.defineProperty(payload, "terminalOwner", { value: pi });
-		try {
-			pi.events.emit(SUBAGENT_TERMINAL_ORDERING_BARRIER_EVENT, payload);
-		} catch (error) {
-			if (!isStaleExtensionContextError(error) || dispatchStarted) throw error;
-		}
-		const globalHandler = (globalThis as Record<string, unknown>).__atomicTerminalOrderingBarrierHandler;
-		if (typeof globalHandler === "function") (globalHandler as (value: unknown) => void)(payload);
-		return (payload as typeof payload & { completion?: Promise<void> }).completion;
-	};
-	const inFlight = new Map<string, Promise<void>>();
-	let registration: NotifyRegistration | undefined;
-	const handleComplete = (data: unknown): void => {
-		if (!registration || registry.get(pi) !== registration) return;
-		const result = data as SubagentResult & Partial<CompletionNotificationEnvelope>;
-		const now = Date.now();
-		const key = result.notificationId
-			? `notification:${result.notificationId}`
-			: buildCompletionKey(result, "notify");
-		if (hasSeenWithTtl(seen, key, now, ttlMs)) {
-			result.acknowledge?.(true);
-			return;
-		}
-		const pending = inFlight.get(key);
-		if (pending) {
-			result.defer?.();
-			void pending.then(
-				() => result.acknowledge?.(true),
-				() => result.acknowledge?.(false),
-			);
-			return;
-		}
-		const ownership = Promise.withResolvers<void>();
-		void ownership.promise.catch(() => {});
-		inFlight.set(key, ownership.promise);
-		const agent = result.agent ?? "unknown";
-		const summary = typeof result.summary === "string" ? result.summary : "";
-		const interrupted = result.status === "interrupted" || result.state === "interrupted";
-		const status = interrupted
-			? "interrupted"
-			: result.status === "ok"
-				? "completed"
-				: result.status === "continued"
-					? "interrupted"
-					: "failed";
-
-		const taskInfo =
-			result.taskIndex !== undefined && result.totalTasks !== undefined
-				? `(${result.taskIndex + 1}/${result.totalTasks})`
-				: undefined;
-
-		const sessionLine = result.shareUrl
-			? `Session: ${result.shareUrl}`
-			: result.shareError
-				? `Session share error: ${result.shareError}`
-				: result.sessionFile
-					? `Session file: ${result.sessionFile}`
-					: undefined;
-
-		const displaySummary = summary.trim() ? summary : "(no output)";
-		const noticeLabel =
-			typeof result.noticeLabel === "string" && result.noticeLabel.trim()
-				? result.noticeLabel.trim()
-				: "Subagent task";
-		let sessionLabel: string | undefined;
-		let sessionValue: string | undefined;
-		if (sessionLine) {
-			const separator = sessionLine.indexOf(":");
-			sessionLabel = sessionLine.slice(0, separator).toLowerCase();
-			sessionValue = sessionLine.slice(separator + 1).trim();
-		}
-		const details: SubagentNotifyDetails = {
-			agent,
-			status,
-			...(taskInfo ? { taskInfo } : {}),
-			resultPreview: displaySummary,
-			...(result.durationMs !== undefined ? { durationMs: result.durationMs } : {}),
-			...(sessionLabel && sessionValue ? { sessionLabel, sessionValue } : {}),
-		};
-		const content = [
-			`${noticeLabel} ${status}: **${agent}**${taskInfo ? ` ${taskInfo}` : ""}`,
-			"",
-			displaySummary,
-			sessionLine ? "" : undefined,
-			sessionLine,
-		]
-			.filter((line) => line !== undefined)
-			.join("\n");
-
-		const terminalMessage: TerminalPreludeMessage = {
-			customType: "subagent-notify",
-			content,
-			display: true,
-			details,
-		};
-		const deliveryOptions = { triggerTurn: true, stageAdmissionKey: `subagent:${key}` } as const;
-		const succeed = (): void => {
-			recordSeen(seen, key, Date.now());
-			inFlight.delete(key);
-			ownership.resolve();
-			result.acknowledge?.(true);
-		};
-		const fail = (error: unknown): void => {
-			inFlight.delete(key);
-			ownership.reject(error);
-			result.acknowledge?.(false);
-			console.error("Failed to deliver subagent completion notification:", error);
-		};
-		const observe = (delivery: PromiseLike<void>): void => {
-			result.defer?.();
-			void Promise.resolve(delivery).then(succeed, fail);
-		};
-		try {
-			let dispatched = false;
-			const barrierCompletion = emitTerminalOrderingBarrier(result, (prefix) => {
-				dispatched = true;
-				if (typeof pi.sendMessages === "function") {
-					return pi.sendMessages([...prefix, terminalMessage], deliveryOptions);
-				}
-				return dispatchFallback(pi, prefix, terminalMessage, deliveryOptions);
-			});
-			if (barrierCompletion) {
-				observe(barrierCompletion);
-				return;
-			}
-			if (!dispatched) {
-				const delivery = pi.sendMessage(terminalMessage, deliveryOptions);
-				if (isPromiseLike(delivery)) {
-					observe(delivery);
-					return;
-				}
-			}
-			succeed();
-		} catch (error) {
-			fail(error);
-		}
-	};
-	let unsubscribe: () => void;
-	try {
-		unsubscribe = pi.events.on(SUBAGENT_COMPLETE_EVENT, handleComplete);
-	} catch (error) {
-		if (!isStaleExtensionContextError(error)) throw error;
-		// A stale API cannot accept a new subscription; keep the prior one usable.
-		return () => {};
-	}
-	registration = { unsubscribe };
-	registry.set(pi, registration);
-	if (previous) {
-		try {
-			previous.unsubscribe();
-		} catch (error) {
-			if (isStaleExtensionContextError(error)) {
-				// The old handler is inert because the registry now belongs to this registration.
-			} else {
-				// A failed replacement cleanup aborts activation; remove the new entry before rethrowing.
-				if (registry.get(pi) === registration) registry.delete(pi);
-				try {
-					unsubscribe();
-				} catch (rollbackError) {
-					if (!isStaleExtensionContextError(rollbackError)) {
-						throw new AggregateError([error, rollbackError], "Failed to roll back notification registration");
-					}
-					// Stale cleanup is best effort after the registry rollback.
-				}
-				throw error;
-			}
-		}
-	}
-	return () => {
-		if (!registration || registry.get(pi) !== registration) return;
-		registry.delete(pi);
-		try {
-			unsubscribe();
-		} catch (error) {
-			if (!isStaleExtensionContextError(error)) throw error;
-			// Stale event-bus cleanup is best effort.
-		}
-	};
-}

package/dist/builtin/subagents/src/runs/foreground/parent-ask-output.ts

@@ -1,48 +0,0 @@
-import type { ForegroundParentAskHandoff, ParentAskHandoffRequest } from "../../shared/types.js";
-
-function formatAttachments(request: ParentAskHandoffRequest): string {
-	let text = "";
-	for (const attachment of request.attachments ?? []) {
-		if (attachment.language) {
-			text += `\n\n---\n📎 ${attachment.name}\n~~~${attachment.language}\n${attachment.content}\n~~~`;
-		} else {
-			text += `\n\n---\n📎 ${attachment.name}\n${attachment.content}`;
-		}
-	}
-	return text;
-}
-
-function formatQuestion(request: ParentAskHandoffRequest): string {
-	const parts: string[] = [];
-	if (request.question.length > 0) parts.push(request.question);
-	if (request.interview) parts.push(JSON.stringify(request.interview, null, 2));
-	return parts.join("\n\n") + formatAttachments(request);
-}
-
-function freshTask(request: ParentAskHandoffRequest): string {
-	return [
-		"[TASK_CONTEXT]",
-		"Original delegated task and objective:",
-		request.taskContext ?? "(Original task context unavailable.)",
-		"",
-		`Previous child identity: ${request.agent} (child ${request.index + 1})`,
-		"Previous child question:",
-		formatQuestion(request),
-		"",
-		"Continue with this supervisor answer: <SUPERVISOR_ANSWER>",
-	].join("\n");
-}
-
-export function formatParentAskHandoffOutput(handoff: ForegroundParentAskHandoff): string {
-	const request = handoff.request;
-	const call = JSON.stringify({ agent: request.agent, task: freshTask(request) }, null, 2);
-	return [
-		`Subagent yielded for parent input (${request.agent}, child ${request.index + 1}).`,
-		`Previous run (terminal): ${request.runId}`,
-		"Question:",
-		formatQuestion(request),
-		"",
-		"Start a fresh subagent with a new run identity, replacing <SUPERVISOR_ANSWER> with your answer:",
-		`subagent(${call})`,
-	].join("\n");
-}

package/dist/builtin/subagents/src/runs/foreground/subagent-executor-burst-display.ts

@@ -1,46 +0,0 @@
-import type { SubagentToolResult } from "../../shared/types.js";
-
-interface BurstDisplay {
-	ownerId: string;
-	callIds: string[];
-	taskCount: number;
-	result?: SubagentToolResult;
-}
-
-const MAX_RETAINED_BURST_DISPLAYS = 100;
-const displays: BurstDisplay[] = [];
-const displayByCallId = new Map<string, BurstDisplay>();
-
-export interface BurstDisplaySnapshot {
-	owner: boolean;
-	taskCount: number;
-	result?: SubagentToolResult;
-}
-
-export function registerBurstDisplay(callIds: string[], taskCount: number): BurstDisplay {
-	const display: BurstDisplay = { ownerId: callIds[0]!, callIds, taskCount };
-	displays.push(display);
-	for (const callId of callIds) displayByCallId.set(callId, display);
-	while (displays.length > MAX_RETAINED_BURST_DISPLAYS) {
-		const expired = displays.shift();
-		if (!expired) break;
-		for (const callId of expired.callIds) {
-			if (displayByCallId.get(callId) === expired) displayByCallId.delete(callId);
-		}
-	}
-	return display;
-}
-
-export function updateBurstDisplay(display: BurstDisplay, result: SubagentToolResult): void {
-	display.result = result;
-}
-
-export function getBurstDisplay(callId: string): BurstDisplaySnapshot | undefined {
-	const display = displayByCallId.get(callId);
-	if (!display) return undefined;
-	return {
-		owner: display.ownerId === callId,
-		taskCount: display.taskCount,
-		...(display.result ? { result: display.result } : {}),
-	};
-}