@bastani/atomic 0.9.12-alpha.1 → 0.9.13-alpha.1

package/dist/builtin/subagents/src/runs/{shared/subagent-prompt-runtime.ts → inprocess/prompt-behavior.ts}

@@ -1,15 +1,4 @@
-import * as fs from "node:fs";
-import { createStructuredOutputTool, type ExtensionAPI, getEnvValue } from "@bastani/atomic";
-import type { JsonSchemaObject } from "../../shared/types.ts";
-import {
-	SUBAGENT_FANOUT_CHILD_ENV,
-	SUBAGENT_INHERIT_PROJECT_CONTEXT_ENV,
-	SUBAGENT_INHERIT_SKILLS_ENV,
-	SUBAGENT_INTERCOM_SESSION_NAME_ENV,
-} from "./pi-args.ts";
-import { STRUCTURED_OUTPUT_CAPTURE_ENV, STRUCTURED_OUTPUT_SCHEMA_ENV } from "./structured-output.ts";
-
-export { SUBAGENT_INTERCOM_SESSION_NAME_ENV } from "./pi-args.ts";
+import type { AgentMessage } from "@earendil-works/pi-agent-core";
 
 export const CHILD_SUBAGENT_BOUNDARY_INSTRUCTIONS = [
 	"You are a child subagent, not the parent orchestrator.",
@@ -42,19 +31,23 @@ const PROJECT_CONTEXT_HEADER = "\n\n# Project Context\n\nProject-specific instru
 const SKILLS_HEADER = "\n\nThe following skills provide specialized instructions for specific tasks.";
 const DATE_HEADER = "\nCurrent date:";
 
-function readBooleanEnv(name: string): boolean | undefined {
-	const value = getEnvValue(name);
-	if (value === undefined) return undefined;
-	return value !== "0";
+export interface ChildPromptPolicy {
+	readonly inheritProjectContext: boolean;
+	readonly inheritSkills: boolean;
+	readonly fanoutAuthorized: boolean;
+}
+
+export interface PromptRewriteOptions {
+	readonly inheritProjectContext: boolean;
+	readonly inheritSkills: boolean;
+	readonly fanoutChild?: boolean;
 }
 
 function findSectionEnd(prompt: string, startIndex: number, nextHeaders: string[]): number {
 	let endIndex = prompt.length;
 	for (const header of nextHeaders) {
 		const index = prompt.indexOf(header, startIndex);
-		if (index !== -1 && index < endIndex) {
-			endIndex = index;
-		}
+		if (index !== -1 && index < endIndex) endIndex = index;
 	}
 	return endIndex;
 }
@@ -89,17 +82,10 @@ function stripChildBoundaryInstructions(prompt: string): string {
 	return rewritten.replace(/^(?:[ \t]*\r?\n)+/, "");
 }
 
-export function rewriteSubagentPrompt(
-	prompt: string,
-	options: { inheritProjectContext: boolean; inheritSkills: boolean; fanoutChild?: boolean },
-): string {
+export function rewriteSubagentPrompt(prompt: string, options: PromptRewriteOptions): string {
 	let rewritten = prompt;
-	if (!options.inheritProjectContext) {
-		rewritten = stripProjectContext(rewritten);
-	}
-	if (!options.inheritSkills) {
-		rewritten = stripInheritedSkills(rewritten);
-	}
+	if (!options.inheritProjectContext) rewritten = stripProjectContext(rewritten);
+	if (!options.inheritSkills) rewritten = stripInheritedSkills(rewritten);
 	rewritten = stripSubagentOrchestrationSkill(rewritten);
 	rewritten = stripChildBoundaryInstructions(rewritten);
 	const boundary = options.fanoutChild ? CHILD_FANOUT_BOUNDARY_INSTRUCTIONS : CHILD_SUBAGENT_BOUNDARY_INSTRUCTIONS;
@@ -123,28 +109,28 @@ function isSubagentToolCallBlock(block: unknown): boolean {
 	return b?.type === "toolCall" && b.name === "subagent";
 }
 
-function stripAssistantSubagentToolCallBlocks(message: unknown): unknown | undefined {
+function stripAssistantSubagentToolCallBlocks<T>(message: T): T | undefined {
 	const m = message as { role?: string; content?: unknown };
 	if (m?.role !== "assistant" || !Array.isArray(m.content)) return message;
 	const filteredContent = m.content.filter((block) => !isSubagentToolCallBlock(block));
 	if (filteredContent.length === m.content.length) return message;
 	if (filteredContent.length === 0) return undefined;
-	return { ...m, content: filteredContent };
+	return { ...m, content: filteredContent } as T;
 }
 
-export function stripParentOnlySubagentMessages(messages: unknown[]): unknown[] {
-	const preserveCurrentFanoutToolHistory = process.env[SUBAGENT_FANOUT_CHILD_ENV] === "1";
+/** Remove parent-only orchestration history while preserving it for an authorized fanout child. */
+export function stripParentOnlySubagentMessages<T>(messages: T[], preserveFanoutToolHistory = false): T[] {
 	let changed = false;
-	const filtered: unknown[] = [];
+	const filtered: T[] = [];
 	for (const message of messages) {
 		if (
 			isParentOnlySubagentMessage(message) ||
-			(!preserveCurrentFanoutToolHistory && isSubagentToolResultMessage(message))
+			(!preserveFanoutToolHistory && isSubagentToolResultMessage(message))
 		) {
 			changed = true;
 			continue;
 		}
-		const stripped = preserveCurrentFanoutToolHistory ? message : stripAssistantSubagentToolCallBlocks(message);
+		const stripped = preserveFanoutToolHistory ? message : stripAssistantSubagentToolCallBlocks(message);
 		if (stripped === undefined) {
 			changed = true;
 			continue;
@@ -155,44 +141,20 @@ export function stripParentOnlySubagentMessages(messages: unknown[]): unknown[]
 	return changed ? filtered : messages;
 }
 
-export default function registerSubagentPromptRuntime(pi: ExtensionAPI): void {
-	const structuredOutputPath = process.env[STRUCTURED_OUTPUT_CAPTURE_ENV];
-	const structuredSchemaPath = process.env[STRUCTURED_OUTPUT_SCHEMA_ENV];
-	if (structuredOutputPath && structuredSchemaPath) {
-		const schema = JSON.parse(fs.readFileSync(structuredSchemaPath, "utf-8")) as JsonSchemaObject;
-		pi.registerTool(
-			createStructuredOutputTool({
-				schema,
-				output: { outputPath: structuredOutputPath },
-			}),
-		);
-	}
-
-	const onRuntimeEvent = pi.on as unknown as (event: string, handler: (event: unknown) => unknown) => void;
-	onRuntimeEvent("context", (event) => {
-		const contextEvent = event as { messages?: unknown[] };
-		if (!Array.isArray(contextEvent.messages)) return undefined;
-		const messages = stripParentOnlySubagentMessages(contextEvent.messages);
-		if (messages === contextEvent.messages) return undefined;
-		return { messages };
-	});
-
-	pi.on("before_agent_start", async (event) => {
-		const intercomSessionName = getEnvValue(SUBAGENT_INTERCOM_SESSION_NAME_ENV)?.trim();
-		if (intercomSessionName && typeof pi.setSessionName === "function") {
-			pi.setSessionName(intercomSessionName);
-		}
+export interface InProcessChildPromptBehavior {
+	readonly systemPromptTransform: (prompt: string) => string;
+	readonly initialContextTransform: (messages: AgentMessage[]) => AgentMessage[];
+}
 
-		const inheritProjectContext = readBooleanEnv(SUBAGENT_INHERIT_PROJECT_CONTEXT_ENV);
-		const inheritSkills = readBooleanEnv(SUBAGENT_INHERIT_SKILLS_ENV);
-		const fanoutChild = readBooleanEnv(SUBAGENT_FANOUT_CHILD_ENV);
-		if (inheritProjectContext === undefined && inheritSkills === undefined && fanoutChild === undefined) return;
-		const rewritten = rewriteSubagentPrompt(event.systemPrompt, {
-			inheritProjectContext: inheritProjectContext ?? true,
-			inheritSkills: inheritSkills ?? true,
-			fanoutChild: fanoutChild === true,
-		});
-		if (rewritten === event.systemPrompt) return;
-		return { systemPrompt: rewritten };
-	});
+/** Build the construction-time transforms for one admitted in-process child. */
+export function createInProcessChildPromptBehavior(policy: ChildPromptPolicy): InProcessChildPromptBehavior {
+	return {
+		systemPromptTransform: (prompt) =>
+			rewriteSubagentPrompt(prompt, {
+				inheritProjectContext: policy.inheritProjectContext,
+				inheritSkills: policy.inheritSkills,
+				fanoutChild: policy.fanoutAuthorized,
+			}),
+		initialContextTransform: (messages) => stripParentOnlySubagentMessages(messages, policy.fanoutAuthorized),
+	};
 }