@bastani/atomic 0.8.14-0 → 0.8.15-0

package/dist/builtin/workflows/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bastani/workflows",
-  "version": "0.8.14-0",
+  "version": "0.8.15-0",
   "private": true,
   "description": "Atomic extension for multi-stage workflow authoring and execution.",
   "contributors": [

package/dist/builtin/workflows/src/extension/background-ui-adapter.ts

@@ -1,9 +1,11 @@
 /**
- * Background workflow HIL adapter — bridges `ctx.ui.input/confirm/select/editor`
- * to store-backed pending prompts instead of pi.ui modal dialogs.
+ * Legacy background workflow HIL adapter — bridges
+ * `ctx.ui.input/confirm/select/editor` to run-level store-backed pending
+ * prompts instead of pi.ui modal dialogs.
  *
- * Detached runs use this adapter so the main chat editor stays usable while
- * a workflow is in flight. HIL surfaces through the graph viewer overlay:
+ * Normal detached workflow runs now use executor-owned synthetic prompt nodes
+ * backed by `StageSnapshot.pendingPrompt`; this adapter remains for tests and
+ * non-executor fallback callers that still need the run-level graph overlay:
  *
  *   1. Stage calls `ctx.ui.editor(prefill)`
  *   2. Adapter records a `PendingPrompt` on the run via the store
@@ -17,6 +19,10 @@
  * rejects via `recordRunEnd` so the executor can finalise cleanly — no leaked
  * pending promises.
  *
+ * @internal Legacy fallback retained for tests and non-executor callers.
+ * TODO(workflows): delete after all tests and fallback entrypoints migrate to
+ * executor-owned synthetic prompt nodes.
+ *
  * cross-ref:
  *   src/shared/store-types.ts PendingPrompt
  *   src/shared/store.ts recordPendingPrompt / resolvePendingPrompt / awaitPendingPrompt
@@ -111,13 +117,13 @@ function fallbackForKind(descriptor: PromptDescriptor): unknown {
 }
 
 /**
- * Build a `WorkflowUIAdapter` whose methods record prompts on `runId` via
- * the store and await user response through the graph viewer.
+ * Build a legacy `WorkflowUIAdapter` whose methods record prompts on `runId`
+ * via the store and await user response through the graph viewer overlay.
  *
- * This is the only HIL surface a workflow body sees — `pi.ui.editor`,
- * `pi.ui.confirm`, etc. are intentionally never invoked from inside a run.
- * The chat editor stays free; the user attends to prompts via F2 / the
- * `/workflow connect` overlay.
+ * Detached workflow execution normally uses node-local prompt stages instead.
+ * `pi.ui.editor`, `pi.ui.confirm`, etc. are still intentionally never invoked
+ * from inside a background run. The chat editor stays free; fallback callers
+ * attend to run-level prompts via F2 / the `/workflow connect` overlay.
  *
  * `signal` is the run's `AbortController.signal`; when fired (e.g. via
  * `/workflow interrupt <id>`), any HIL waiter rejects so the workflow body
@@ -144,6 +150,9 @@ export function buildBackgroundUIAdapter(
       message: string,
       options: readonly T[],
     ): Promise<T> {
+      if (options.length === 0) {
+        throw new Error("pi-workflows: ctx.ui.select requires at least one option");
+      }
       const response = await ask(store, runId, {
         kind: "select",
         message,
@@ -152,7 +161,7 @@ export function buildBackgroundUIAdapter(
       if (typeof response === "string" && (options as readonly string[]).includes(response)) {
         return response as T;
       }
-      return options[0];
+      return options[0]!;
     },
 
     async editor(initial?: string): Promise<string> {

package/dist/builtin/workflows/src/extension/index.ts

@@ -3266,6 +3266,7 @@ function factory(pi: ExtensionAPI): void {
         persistence: persistenceRef.current,
       });
       store.clear();
+      stageControlRegistry.clear();
 
       // pi-intercom session naming lives here so we don't trip the
       // loader's "Action methods cannot be called during extension

package/dist/builtin/workflows/src/extension/status-writer.ts

@@ -42,6 +42,8 @@ export interface StatusWriterOpts {
 }
 
 export interface StatusWriter {
+  /** Wait until all currently queued status writes have reached disk. */
+  flush(): Promise<void>;
   /** Stop receiving store updates and cancel any pending flush. */
   unsubscribe(): void;
 }
@@ -105,7 +107,7 @@ export function createStatusWriter(
   opts: StatusWriterOpts = {},
 ): StatusWriter {
   if (!config.statusFile) {
-    return { unsubscribe() {} };
+    return { async flush() {}, unsubscribe() {} };
   }
 
   const filePath = resolveStatusFilePath(config, opts);
@@ -117,6 +119,7 @@ export function createStatusWriter(
   let active = true;
   let writing = false;
   let pendingContent: string | null = null;
+  let drainPromise: Promise<void> | null = null;
 
   function recordWriteError(err: unknown): void {
     const msg = err instanceof Error ? err.message : String(err);
@@ -148,16 +151,28 @@ export function createStatusWriter(
       }
     } finally {
       writing = false;
-      if (active && pendingContent !== null) void drainWrites();
     }
   }
 
+  function ensureDrain(): Promise<void> {
+    drainPromise ??= drainWrites().finally(() => {
+      drainPromise = null;
+      if (active && pendingContent !== null) void ensureDrain();
+    });
+    return drainPromise;
+  }
+
   const unsubscribeStore = store.subscribe((snap: StoreSnapshot) => {
     pendingContent = JSON.stringify(snap, null, 2);
-    void drainWrites();
+    void ensureDrain();
   });
 
   return {
+    async flush() {
+      while (active && (pendingContent !== null || drainPromise !== null)) {
+        await ensureDrain();
+      }
+    },
     unsubscribe() {
       active = false;
       pendingContent = null;

package/dist/builtin/workflows/src/runs/background/runner.ts

@@ -23,7 +23,6 @@ import { run as syncRun } from "../foreground/executor.js";
 import { cancellationRegistry as defaultCancellationRegistry } from "./cancellation-registry.js";
 import { jobTracker as defaultJobTracker } from "./job-tracker.js";
 import { store as defaultStore } from "../../shared/store.js";
-import { buildBackgroundUIAdapter } from "../../extension/background-ui-adapter.js";
 
 // ---------------------------------------------------------------------------
 // Types
@@ -103,20 +102,19 @@ export function runDetached<TInputs extends Record<string, unknown>>(
   //    are not lost.
   registry.register(runId, controller);
 
-  // 4. Build executor opts — inject runId seam, signal, and a store-backed
-  //    HIL adapter. Background runs must NOT route ctx.ui.* through pi.ui
-  //    dialogs (those steal focus from the main chat editor); the adapter
-  //    records prompts on the run and the graph viewer overlay drives the
-  //    response. Destructure `jobs`/`cancellation`/`ui` out so they're not
-  //    forwarded to RunOpts twice.
+  // 4. Build executor opts — inject runId seam, signal, and node-local
+  //    store-backed HIL. Background runs must NOT route ctx.ui.* through pi.ui
+  //    dialogs (those steal focus from the main chat editor); the executor
+  //    records prompts on synthetic workflow nodes and the attached stage chat
+  //    drives the response. Destructure `jobs`/`cancellation`/`ui` out so
+  //    they're not forwarded to RunOpts twice.
   const {
     jobs: _jobs,
     cancellation: _cancellation,
-    ui: _ignoredFgUi,
+    ui: _ui,
     store: storeOverride,
     ...restOpts
   } = opts;
-  void _ignoredFgUi;
   const store: Store = storeOverride ?? defaultStore;
   const execOpts: RunOpts = {
     ...restOpts,
@@ -124,7 +122,7 @@ export function runDetached<TInputs extends Record<string, unknown>>(
     signal: controller.signal,
     cancellation: registry,
     store,
-    ui: buildBackgroundUIAdapter(store, runId, controller.signal),
+    usePromptNodesForUi: true,
     deferWorkflowStart: true,
   };