@basou/cli 0.32.0 → 0.34.0

package/dist/index.js

@@ -10552,12 +10552,17 @@ async function inspectRepo(repoPath) {
 async function checkPortfolioSafety(workspaces) {
   const findings = [];
   let monitoredReposChecked = 0;
+  const records = [];
   for (const ws of workspaces) {
     const wsReal = await canonical(ws.repoRoot);
     let sourceRoots = [];
+    let viewPath;
+    let isMaster = false;
     try {
       const manifest = await readManifest12(ws.paths);
       sourceRoots = manifest.import?.source_roots ?? [];
+      viewPath = manifest.workspace.view;
+      isMaster = true;
     } catch (error) {
       if (error instanceof Error && error.message === "YAML file not found") {
         sourceRoots = [];
@@ -10569,6 +10574,7 @@ async function checkPortfolioSafety(workspaces) {
           kind: "unverifiable",
           detail: "the workspace manifest is present but unreadable \u2014 cannot determine which repos it monitors; treat as unsafe"
         });
+        records.push({ ws, real: wsReal, isMaster: false, claimed: /* @__PURE__ */ new Set() });
         continue;
       }
     }
@@ -10578,6 +10584,12 @@ async function checkPortfolioSafety(workspaces) {
       const real = await canonical(display);
       if (real !== wsReal) monitored.set(real, display);
     }
+    const claimed = new Set(monitored.keys());
+    if (isMaster && viewPath !== void 0) {
+      const viewReal = await canonical(resolve11(ws.repoRoot, viewPath));
+      if (viewReal !== wsReal) claimed.add(viewReal);
+    }
+    records.push({ ws, real: wsReal, isMaster, claimed });
     for (const [real, display] of monitored) {
       monitoredReposChecked++;
       if (isInside(wsReal, real)) {
@@ -10601,8 +10613,39 @@ async function checkPortfolioSafety(workspaces) {
       }
     }
   }
+  findings.push(...detectRedundantEntries(records));
   return { findings, workspacesChecked: workspaces.length, monitoredReposChecked };
 }
+function detectRedundantEntries(records) {
+  const masterIdentity = (r) => {
+    if (r.isMaster) return r.real;
+    const owner = records.find((o) => o.isMaster && o.claimed.has(r.real));
+    return owner !== void 0 ? owner.real : r.real;
+  };
+  const groups = /* @__PURE__ */ new Map();
+  for (const r of records) {
+    const key = masterIdentity(r);
+    const group = groups.get(key);
+    if (group !== void 0) group.push(r);
+    else groups.set(key, [r]);
+  }
+  const findings = [];
+  for (const [identity, group] of groups) {
+    if (group.length < 2) continue;
+    const primary = group.find((r) => r.real === identity) ?? group[0];
+    for (const r of group) {
+      if (r === primary) continue;
+      findings.push({
+        workspaceLabel: r.ws.label,
+        workspaceRoot: r.ws.repoRoot,
+        monitoredRepo: r.ws.repoRoot,
+        kind: "redundant",
+        detail: `resolves to the same workspace as portfolio entry "${primary.ws.label}" (${primary.ws.repoRoot}) and shows a duplicate card \u2014 register only the planning master (the anchor that owns .basou), not its workspace view or a source-root repo; remove this entry from the registry`
+      });
+    }
+  }
+  return findings;
+}
 function formatSafetyReport(result) {
   if (result.findings.length === 0) {
     if (result.monitoredReposChecked === 0) {
@@ -10614,13 +10657,23 @@ function formatSafetyReport(result) {
       `Portfolio safety: OK. ${result.workspacesChecked} workspace(s), ${result.monitoredReposChecked} monitored repo(s) checked \u2014 no .basou footprint, no overlap.`
     ];
   }
-  const lines = [`Portfolio safety: DANGER \u2014 ${result.findings.length} finding(s):`];
+  const kinds = new Set(result.findings.map((f) => f.kind));
+  const hasWriteRisk = kinds.has("footprint") || kinds.has("overlap") || kinds.has("unverifiable");
+  const severity = hasWriteRisk ? "DANGER" : "WARNING";
+  const lines = [`Portfolio safety: ${severity} \u2014 ${result.findings.length} finding(s):`];
   for (const f of result.findings) {
     lines.push(`  [${f.kind}] ${f.monitoredRepo} (workspace "${f.workspaceLabel}"): ${f.detail}`);
   }
-  lines.push(
-    "A monitored repo must have no basou footprint. Use a separate workspace repo whose source_roots point at the monitored repo as a sibling; never 'basou init' / 'run' / 'exec' inside a monitored repo."
-  );
+  if (hasWriteRisk) {
+    lines.push(
+      "A monitored repo must have no basou footprint. Use a separate workspace repo whose source_roots point at the monitored repo as a sibling; never 'basou init' / 'run' / 'exec' inside a monitored repo."
+    );
+  }
+  if (kinds.has("redundant")) {
+    lines.push(
+      "A redundant entry is a workspace already reached through another registered planning master. Register only the planning master (the anchor that owns .basou), never its workspace view or its member / source-root repos \u2014 those resolve back to the same workspace and produce duplicate cards."
+    );
+  }
   return lines;
 }
 
@@ -11855,7 +11908,7 @@ async function doRunView(options, ctx) {
     }
     if (result.findings.length > 0) {
       console.error(
-        `Portfolio safety: ${result.findings.length} unverifiable item(s) \u2014 the read-only view will still open; run 'basou view --check' for detail.`
+        `Portfolio safety: ${result.findings.length} non-blocking finding(s) \u2014 the read-only view will still open; run 'basou view --check' for detail.`
       );
     }
   }