@bash-app/bash-common 30.224.0 → 30.226.0

package/src/utils/__tests__/getBackendHost.test.ts

@@ -0,0 +1,128 @@
+/**
+ * getBackendHost — chooses the API origin (api.bash.community vs localhost:3500
+ * vs the bundled API_HOST for native Capacitor builds).
+ *
+ * This file pins the contract so a future "let's tidy up env handling" change
+ * doesn't accidentally re-introduce the same class of bug we just fixed in
+ * getFrontendHost (server-only env vars leaking into the browser code path).
+ */
+import { getBackendHost } from "../urlUtils.js";
+
+type WindowLocationStub = {
+  protocol: string;
+  hostname: string;
+  host: string;
+  port: string;
+};
+
+type CapacitorStub = { isNativePlatform?: () => boolean };
+
+const ORIGINAL_WINDOW = (globalThis as { window?: unknown }).window;
+
+function setWindow(loc: WindowLocationStub, capacitor?: CapacitorStub): void {
+  (
+    globalThis as unknown as {
+      window: { location: WindowLocationStub; Capacitor?: CapacitorStub };
+    }
+  ).window = {
+    location: loc,
+    ...(capacitor ? { Capacitor: capacitor } : {}),
+  };
+}
+
+function clearWindow(): void {
+  if (ORIGINAL_WINDOW === undefined) {
+    delete (globalThis as { window?: unknown }).window;
+  } else {
+    (globalThis as { window?: unknown }).window = ORIGINAL_WINDOW;
+  }
+}
+
+afterEach(() => {
+  clearWindow();
+});
+
+describe("getBackendHost — local dev", () => {
+  it("returns http://localhost:3500 for localhost (does NOT reuse :3000 from the page)", () => {
+    setWindow({
+      protocol: "http:",
+      hostname: "localhost",
+      host: "localhost:3000",
+      port: "3000",
+    });
+    expect(getBackendHost()).toBe("http://localhost:3500");
+  });
+
+  it("returns http://127.0.0.1:3500 for 127.0.0.1", () => {
+    setWindow({
+      protocol: "http:",
+      hostname: "127.0.0.1",
+      host: "127.0.0.1:3000",
+      port: "3000",
+    });
+    expect(getBackendHost()).toBe("http://127.0.0.1:3500");
+  });
+
+  it("uses the LAN IP for 192.168.x.x (so a phone on the same wifi can hit the dev API)", () => {
+    setWindow({
+      protocol: "http:",
+      hostname: "192.168.1.42",
+      host: "192.168.1.42:3000",
+      port: "3000",
+    });
+    expect(getBackendHost()).toBe("http://192.168.1.42:3500");
+  });
+});
+
+describe("getBackendHost — deployed web", () => {
+  // For deployed web, getBackendHost falls back to API_HOST (compiled in from
+  // process.env.REACT_APP_API at bundle time; defaults to http://localhost:3500
+  // when unset, which is what jest sees here). The contract we pin is "for any
+  // non-local hostname, do NOT derive the API URL from window.location" — that
+  // would silently route prod browsers at api.bash.community… instead of the
+  // configured API_HOST.
+  it("does not derive the backend host from window.location for deployed sites", () => {
+    setWindow({
+      protocol: "https:",
+      hostname: "bash.community",
+      host: "bash.community",
+      port: "",
+    });
+    const result = getBackendHost();
+    expect(result).not.toContain("bash.community:3500");
+    expect(result).not.toContain("bash.community:3000");
+  });
+
+  it("does not derive the backend host from a QA subdomain either", () => {
+    setWindow({
+      protocol: "https:",
+      hostname: "qa.bash.community",
+      host: "qa.bash.community",
+      port: "",
+    });
+    const result = getBackendHost();
+    expect(result).not.toContain("qa.bash.community:3500");
+  });
+});
+
+describe("getBackendHost — Capacitor native (iOS / Android)", () => {
+  it("uses the bundled API_HOST when running inside a Capacitor WebView (hostname is 'localhost' but it's not really local dev)", () => {
+    // Capacitor loads from a localhost-like origin inside the WebView. If we
+    // routed to the localhost dev API based on hostname alone, the app would
+    // hit a port that doesn't exist on the device. The native check must win.
+    setWindow(
+      {
+        protocol: "capacitor:",
+        hostname: "localhost",
+        host: "localhost",
+        port: "",
+      },
+      { isNativePlatform: () => true }
+    );
+    const result = getBackendHost();
+    // We can't pin the exact value (depends on REACT_APP_API at build time),
+    // but we CAN pin the negative: it must not be the dev-server URL just
+    // because the WebView happens to say hostname=localhost.
+    expect(result).toBe(process.env.REACT_APP_API ?? "http://localhost:3500");
+  });
+});

package/src/utils/__tests__/getFrontendHost.test.ts

@@ -0,0 +1,232 @@
+/**
+ * getFrontendHost — the single source of truth for the URL prefix that goes
+ * into every shareable Bash link (SharePopup, embed snippets, LinkedIn
+ * Announce, Facebook event helper, QR codes…).
+ *
+ * THE BUG THIS FILE PINS
+ * ----------------------
+ * Pre-fix, getFrontendHost() called isProduction() which inspects
+ * process.env.ENVIRONMENT / BASH_ENV / NODE_ENV. Those env vars are server-
+ * only — Vite's envPlugin only inlines REACT_APP_* / VITE_* / NODE_ENV /
+ * PUBLIC_URL into the browser bundle. As a result, in the production browser
+ * `process.env.ENVIRONMENT` is undefined → isProduction() returns false →
+ * getFrontendHost() falls into the dev branch → appends ":3000" to whatever
+ * hostname the user is on. Real user-visible breakage:
+ *
+ *     https://bash.community:3000/bash/cmo3...-empanada-fest-slc?ref=...
+ *
+ * Facebook / iMessage / LinkedIn cannot fetch a preview because :3000 isn't
+ * publicly reachable, and the link itself looks broken to recipients.
+ *
+ * THE CONTRACT WE PIN
+ * -------------------
+ *   localhost / 127.0.0.1 / 192.168.x.x  → preserve the dev port (3000 default)
+ *   <anything else>                       → use window.location.host AS-IS
+ *                                           (no port appending, no env-var dependency)
+ *
+ * Browser-hostname-driven, not env-var-driven, so the answer is correct
+ * regardless of how CI sets ENVIRONMENT / BASH_ENV.
+ */
+import { getFrontendHost } from "../urlUtils.js";
+
+type WindowLocationStub = {
+  protocol: string;
+  hostname: string;
+  host: string;
+  port: string;
+};
+
+const ORIGINAL_WINDOW = (globalThis as { window?: unknown }).window;
+
+function setLocation(loc: WindowLocationStub): void {
+  (globalThis as unknown as { window: { location: WindowLocationStub } }).window = {
+    location: loc,
+  };
+}
+
+function clearLocation(): void {
+  if (ORIGINAL_WINDOW === undefined) {
+    delete (globalThis as { window?: unknown }).window;
+  } else {
+    (globalThis as { window?: unknown }).window = ORIGINAL_WINDOW;
+  }
+}
+
+afterEach(() => {
+  clearLocation();
+});
+
+// ============================================================================
+// PRODUCTION (the regression we're fixing)
+// ============================================================================
+
+describe("getFrontendHost — production (the share-link bug)", () => {
+  it("returns 'https://bash.community' for the production domain (NO :3000)", () => {
+    setLocation({
+      protocol: "https:",
+      hostname: "bash.community",
+      host: "bash.community",
+      port: "",
+    });
+    const host = getFrontendHost();
+    expect(host).toBe("https://bash.community");
+    expect(host).not.toMatch(/:3000/);
+  });
+
+  it("does NOT append :3000 to bash.community even if the bundle has no ENVIRONMENT env var", () => {
+    // Simulate the production browser bundle: ENVIRONMENT/BASH_ENV are NOT inlined.
+    const origEnv = process.env.ENVIRONMENT;
+    const origBashEnv = process.env.BASH_ENV;
+    const origNodeEnv = process.env.NODE_ENV;
+    try {
+      delete process.env.ENVIRONMENT;
+      delete process.env.BASH_ENV;
+      // Vite would replace process.env.NODE_ENV with "production" at build time.
+      (process.env as { NODE_ENV?: string }).NODE_ENV = "production";
+
+      setLocation({
+        protocol: "https:",
+        hostname: "bash.community",
+        host: "bash.community",
+        port: "",
+      });
+
+      expect(getFrontendHost()).toBe("https://bash.community");
+    } finally {
+      if (origEnv === undefined) {
+        delete process.env.ENVIRONMENT;
+      } else {
+        process.env.ENVIRONMENT = origEnv;
+      }
+      if (origBashEnv === undefined) {
+        delete process.env.BASH_ENV;
+      } else {
+        process.env.BASH_ENV = origBashEnv;
+      }
+      if (origNodeEnv === undefined) {
+        delete (process.env as { NODE_ENV?: string }).NODE_ENV;
+      } else {
+        (process.env as { NODE_ENV?: string }).NODE_ENV = origNodeEnv;
+      }
+    }
+  });
+
+  it("works for the QA subdomain (qa.bash.community → no :3000)", () => {
+    setLocation({
+      protocol: "https:",
+      hostname: "qa.bash.community",
+      host: "qa.bash.community",
+      port: "",
+    });
+    expect(getFrontendHost()).toBe("https://qa.bash.community");
+  });
+
+  it("works for any vanity subdomain (org.bash.community → no :3000)", () => {
+    setLocation({
+      protocol: "https:",
+      hostname: "myorg.bash.community",
+      host: "myorg.bash.community",
+      port: "",
+    });
+    expect(getFrontendHost()).toBe("https://myorg.bash.community");
+  });
+
+  it("preserves an EXPLICIT non-default port if the deployed site is running on one", () => {
+    // (uncommon but legal — e.g. preview deploy on :8080)
+    setLocation({
+      protocol: "https:",
+      hostname: "preview.bash.community",
+      host: "preview.bash.community:8080",
+      port: "8080",
+    });
+    expect(getFrontendHost()).toBe("https://preview.bash.community:8080");
+  });
+});
+
+// ============================================================================
+// LOCAL DEV (must keep working)
+// ============================================================================
+
+describe("getFrontendHost — local development", () => {
+  it("returns http://localhost:3000 for hostname=localhost", () => {
+    setLocation({
+      protocol: "http:",
+      hostname: "localhost",
+      host: "localhost:3000",
+      port: "3000",
+    });
+    expect(getFrontendHost()).toBe("http://localhost:3000");
+  });
+
+  it("returns http://127.0.0.1:3000 for hostname=127.0.0.1", () => {
+    setLocation({
+      protocol: "http:",
+      hostname: "127.0.0.1",
+      host: "127.0.0.1:3000",
+      port: "3000",
+    });
+    expect(getFrontendHost()).toBe("http://127.0.0.1:3000");
+  });
+
+  it("returns the LAN-IP dev URL with :3000 for 192.168.x.x (mobile-on-same-wifi dev)", () => {
+    setLocation({
+      protocol: "http:",
+      hostname: "192.168.1.42",
+      host: "192.168.1.42:3000",
+      port: "3000",
+    });
+    expect(getFrontendHost()).toBe("http://192.168.1.42:3000");
+  });
+});
+
+// ============================================================================
+// NGROK / TUNNELS (deployed-equivalent — should NOT get :3000)
+// ============================================================================
+
+describe("getFrontendHost — ngrok / public tunnels", () => {
+  it("does NOT append :3000 to an ngrok-free.dev tunnel hostname", () => {
+    // ngrok forwards port 443 publicly to the local :3000; the link Facebook
+    // crawls must hit the public 443, never the local 3000.
+    setLocation({
+      protocol: "https:",
+      hostname: "abc-123.ngrok-free.dev",
+      host: "abc-123.ngrok-free.dev",
+      port: "",
+    });
+    expect(getFrontendHost()).toBe("https://abc-123.ngrok-free.dev");
+  });
+
+  it("does NOT append :3000 to a .lhr.life tunnel", () => {
+    setLocation({
+      protocol: "https:",
+      hostname: "myapp.lhr.life",
+      host: "myapp.lhr.life",
+      port: "",
+    });
+    expect(getFrontendHost()).toBe("https://myapp.lhr.life");
+  });
+});
+
+// ============================================================================
+// SHARE-URL ASSEMBLY (the exact concatenation SharePopup performs)
+// ============================================================================
+
+describe("getFrontendHost — composed share URL (SharePopup integration)", () => {
+  it("composes the canonical share URL Facebook can crawl", () => {
+    setLocation({
+      protocol: "https:",
+      hostname: "bash.community",
+      host: "bash.community",
+      port: "",
+    });
+    const host = getFrontendHost();
+    const path = "/bash/evt_123-empanada-fest-slc";
+    const fullShareUrl = host + path;
+
+    expect(fullShareUrl).toBe(
+      "https://bash.community/bash/evt_123-empanada-fest-slc"
+    );
+    // Hard guard — this is the literal regression we're preventing.
+    expect(fullShareUrl).not.toMatch(/bash\.community:3000/);
+  });
+});

package/src/utils/__tests__/promoCodesUtils.test.ts

@@ -0,0 +1,237 @@
+/**
+ * promoCodesUtils — locate / aggregate / re-distribute promo codes across a
+ * BashEvent's ticket tiers.
+ *
+ * These three helpers are tiny but they sit on the path between checkout
+ * UI ↔ pricing engine. A bug in `findPromoCodeFromBashEvent` would cause a
+ * promo to silently fail to apply at checkout (lost revenue / angry user).
+ * A bug in `updatePromoCodesOnBashEventTicketTiers` would scramble which
+ * tier a promo code belongs to after edits in the host wizard.
+ */
+import {
+  findPromoCodeFromBashEvent,
+  getPromoCodesFromBashEvent,
+  updatePromoCodesOnBashEventTicketTiers,
+} from "../promoCodesUtils.js";
+import type {
+  BashEventExt,
+  TicketTierExt,
+} from "../../extendedSchemas.js";
+import type { BashEventPromoCode } from "@prisma/client";
+
+function makePromo(
+  id: string,
+  ticketTierId: string,
+  overrides: Partial<BashEventPromoCode> = {}
+): BashEventPromoCode {
+  return {
+    id,
+    ticketTierId,
+    code: `CODE-${id}`,
+    discountPercent: 10,
+    discountAmount: null,
+    maxRedemptions: null,
+    redemptionCount: 0,
+    expiresAt: null,
+    createdAt: new Date(0),
+    updatedAt: new Date(0),
+    ...overrides,
+  } as unknown as BashEventPromoCode;
+}
+
+function makeTier(
+  id: string,
+  promoCodes: BashEventPromoCode[]
+): TicketTierExt {
+  return {
+    id,
+    title: `Tier ${id}`,
+    promoCodes,
+  } as unknown as TicketTierExt;
+}
+
+function makeBashEvent(tiers: TicketTierExt[]): BashEventExt {
+  return { ticketTiers: tiers } as unknown as BashEventExt;
+}
+
+// ============================================================================
+// findPromoCodeFromBashEvent
+// ============================================================================
+
+describe("findPromoCodeFromBashEvent", () => {
+  it("returns undefined when promoCodeId is undefined (no lookup attempted)", () => {
+    const bash = makeBashEvent([makeTier("t1", [makePromo("p1", "t1")])]);
+    expect(findPromoCodeFromBashEvent(bash, undefined)).toBeUndefined();
+  });
+
+  it("returns undefined when promoCodeId is the empty string (falsy guard)", () => {
+    const bash = makeBashEvent([makeTier("t1", [makePromo("p1", "t1")])]);
+    expect(findPromoCodeFromBashEvent(bash, "")).toBeUndefined();
+  });
+
+  it("returns undefined when bashEvent is null", () => {
+    expect(findPromoCodeFromBashEvent(null, "p1")).toBeUndefined();
+  });
+
+  it("returns undefined when bashEvent is undefined", () => {
+    expect(findPromoCodeFromBashEvent(undefined, "p1")).toBeUndefined();
+  });
+
+  it("returns undefined when ticketTiers is empty", () => {
+    expect(
+      findPromoCodeFromBashEvent(makeBashEvent([]), "p1")
+    ).toBeUndefined();
+  });
+
+  it("finds a promo on the FIRST tier", () => {
+    const promo = makePromo("p1", "t1");
+    const bash = makeBashEvent([
+      makeTier("t1", [promo]),
+      makeTier("t2", [makePromo("p2", "t2")]),
+    ]);
+    expect(findPromoCodeFromBashEvent(bash, "p1")).toBe(promo);
+  });
+
+  it("finds a promo on a NON-FIRST tier (iterates across tiers)", () => {
+    const promo = makePromo("p2", "t2");
+    const bash = makeBashEvent([
+      makeTier("t1", [makePromo("p1", "t1")]),
+      makeTier("t2", [promo]),
+    ]);
+    expect(findPromoCodeFromBashEvent(bash, "p2")).toBe(promo);
+  });
+
+  it("returns the FIRST match if the same id appears on multiple tiers (defensive — shouldn't happen but guard the order)", () => {
+    const dupOnT1 = makePromo("dup", "t1");
+    const dupOnT2 = makePromo("dup", "t2");
+    const bash = makeBashEvent([
+      makeTier("t1", [dupOnT1]),
+      makeTier("t2", [dupOnT2]),
+    ]);
+    expect(findPromoCodeFromBashEvent(bash, "dup")).toBe(dupOnT1);
+  });
+
+  it("returns undefined when promoCodeId doesn't match any tier's promo", () => {
+    const bash = makeBashEvent([makeTier("t1", [makePromo("p1", "t1")])]);
+    expect(findPromoCodeFromBashEvent(bash, "missing")).toBeUndefined();
+  });
+
+  it("does not throw when a tier has no promoCodes array (defensive)", () => {
+    const tier = { id: "t1", promoCodes: [] } as unknown as TicketTierExt;
+    expect(() =>
+      findPromoCodeFromBashEvent(makeBashEvent([tier]), "p1")
+    ).not.toThrow();
+  });
+});
+
+// ============================================================================
+// getPromoCodesFromBashEvent
+// ============================================================================
+
+describe("getPromoCodesFromBashEvent", () => {
+  it("returns [] when bashEvent is null", () => {
+    expect(getPromoCodesFromBashEvent(null)).toEqual([]);
+  });
+
+  it("returns [] when bashEvent is undefined", () => {
+    expect(getPromoCodesFromBashEvent(undefined)).toEqual([]);
+  });
+
+  it("returns [] when there are no ticket tiers", () => {
+    expect(getPromoCodesFromBashEvent(makeBashEvent([]))).toEqual([]);
+  });
+
+  it("returns [] when no tier has any promo codes", () => {
+    const bash = makeBashEvent([makeTier("t1", []), makeTier("t2", [])]);
+    expect(getPromoCodesFromBashEvent(bash)).toEqual([]);
+  });
+
+  it("flattens promo codes across multiple tiers in tier order", () => {
+    const p1 = makePromo("p1", "t1");
+    const p2 = makePromo("p2", "t2");
+    const p3 = makePromo("p3", "t2");
+    const bash = makeBashEvent([
+      makeTier("t1", [p1]),
+      makeTier("t2", [p2, p3]),
+    ]);
+    expect(getPromoCodesFromBashEvent(bash)).toEqual([p1, p2, p3]);
+  });
+
+  it("skips tiers with empty promoCodes (filter step)", () => {
+    const p1 = makePromo("p1", "t1");
+    const bash = makeBashEvent([
+      makeTier("t1", [p1]),
+      makeTier("t2", []),
+      makeTier("t3", [makePromo("p3", "t3")]),
+    ]);
+    const all = getPromoCodesFromBashEvent(bash);
+    expect(all.map((p) => p.id)).toEqual(["p1", "p3"]);
+  });
+});
+
+// ============================================================================
+// updatePromoCodesOnBashEventTicketTiers
+// ============================================================================
+
+describe("updatePromoCodesOnBashEventTicketTiers", () => {
+  it("re-buckets promos onto tiers by ticketTierId (mutates in place)", () => {
+    const bash = makeBashEvent([
+      makeTier("t1", []),
+      makeTier("t2", []),
+    ]);
+    const promos = [
+      makePromo("p1", "t1"),
+      makePromo("p2", "t2"),
+      makePromo("p3", "t1"),
+    ];
+
+    updatePromoCodesOnBashEventTicketTiers(bash, promos);
+
+    expect(bash.ticketTiers?.[0].promoCodes.map((p) => p.id)).toEqual([
+      "p1",
+      "p3",
+    ]);
+    expect(bash.ticketTiers?.[1].promoCodes.map((p) => p.id)).toEqual(["p2"]);
+  });
+
+  it("REPLACES existing promo codes on each tier (not appended)", () => {
+    const oldPromo = makePromo("old", "t1");
+    const bash = makeBashEvent([makeTier("t1", [oldPromo])]);
+
+    updatePromoCodesOnBashEventTicketTiers(bash, [makePromo("new", "t1")]);
+
+    expect(bash.ticketTiers?.[0].promoCodes.map((p) => p.id)).toEqual([
+      "new",
+    ]);
+  });
+
+  it("clears tiers that have no matching promos in the new list", () => {
+    const bash = makeBashEvent([
+      makeTier("t1", [makePromo("oldA", "t1")]),
+      makeTier("t2", [makePromo("oldB", "t2")]),
+    ]);
+
+    updatePromoCodesOnBashEventTicketTiers(bash, [makePromo("newA", "t1")]);
+
+    expect(bash.ticketTiers?.[0].promoCodes.map((p) => p.id)).toEqual([
+      "newA",
+    ]);
+    expect(bash.ticketTiers?.[1].promoCodes).toEqual([]);
+  });
+
+  it("ignores promos whose ticketTierId doesn't match any tier on the event (orphans dropped)", () => {
+    const bash = makeBashEvent([makeTier("t1", [])]);
+    updatePromoCodesOnBashEventTicketTiers(bash, [
+      makePromo("p1", "t1"),
+      makePromo("orphan", "tDoesNotExist"),
+    ]);
+    expect(bash.ticketTiers?.[0].promoCodes.map((p) => p.id)).toEqual(["p1"]);
+  });
+
+  it("is a no-op when ticketTiers is undefined", () => {
+    const bash = { ticketTiers: undefined } as unknown as BashEventExt;
+    expect(() =>
+      updatePromoCodesOnBashEventTicketTiers(bash, [makePromo("p1", "t1")])
+    ).not.toThrow();
+  });
+});