@barefootjs/vite 0.33.2 → 0.33.3

package/dist/discover.d.ts

@@ -30,14 +30,40 @@ export interface DiscoveredComponent {
     content: string;
     /** Whether the file's content starts with a `'use client'` directive. */
     isClient: boolean;
+    /**
+     * `isClient`, OR this file transitively instantiates a component that
+     * needs one — the property `computeClientEntryPaths` computes over the
+     * whole discovered corpus. This, not `isClient`, is the signal for
+     * "does this file need its own client bundle and a `<script>` on the
+     * page": a plain server component that merely renders a `'use client'`
+     * descendant still needs an `initChild(...)` call to run in the
+     * browser, and that call lives in ITS OWN compiled init, not the
+     * child's (issue #2767 — `hydrateElementScope` in
+     * `@barefootjs/client`'s `runtime/hydrate.ts` explicitly skips any
+     * element carrying the child marker, deferring to the parent's
+     * `initChild`; if the parent's own bundle never ships, that call never
+     * happens and the child never hydrates, silently).
+     */
+    needsClientEntry: boolean;
     /**
      * Every component this file exports, from `@barefootjs/jsx`'s TS-AST
      * walk (`listExportedComponents`) — never a regex, and never the
      * basename standing in for the name. A file exporting more than one
      * component (`icon/index.tsx` → `CopyIcon` + `CheckIcon`) is why this
-     * exists; see `buildChildNameIndex`.
+     * exists; see `buildChildNameIndex`. Populated for EVERY file, not just
+     * client ones — `computeClientEntryPaths` resolves JSX tag references
+     * by name across the whole corpus, so a server file must be indexable
+     * too (it may itself be someone else's `referencedComponents` target).
      */
     exportedComponents: string[];
+    /**
+     * PascalCase JSX tag identifiers this file's JSX instantiates (its
+     * component-instantiation out-edges), from `@barefootjs/jsx`'s
+     * `scanComponentFile`. Feeds `computeClientEntryPaths` — never used for
+     * anything import-resolution-shaped, so an unresolved or aliased tag
+     * name is simply not an edge (see that function's docstring).
+     */
+    referencedComponents: string[];
     /**
      * `CompileOptions.cssLayerPrefix` this file should compile with, carried
      * over unchanged from whichever `components` entry's `dir` this file was
@@ -80,6 +106,46 @@ export interface ResolvedComponentDirEntry {
  * `@bf-child:` name collisions.
  */
 export declare function discoverComponents(entries: readonly (string | ResolvedComponentDirEntry)[], readFile: (absPath: string) => Promise<string>): Promise<DiscoveredComponent[]>;
+/**
+ * Which discovered files need their OWN client bundle and `<script>` tag on
+ * the page: every `'use client'` file (the seed set), plus every file that
+ * transitively instantiates one — a plain server component nested between
+ * the SSR root and a `'use client'` descendant still needs its own compiled
+ * `init` to run in the browser, because that's the ONLY place the
+ * `initChild(...)` call reaching the client descendant is emitted (issue
+ * #2767; see `DiscoveredComponent.needsClientEntry`'s docstring). A nested
+ * component can't self-hydrate to make up for a missing parent bundle: its
+ * SSR root carries the child marker (`bf-h`), which `hydrateElementScope`
+ * (`@barefootjs/client`'s `runtime/hydrate.ts`) unconditionally skips,
+ * deferring to a parent's `initChild` call that only exists if the parent's
+ * own bundle shipped.
+ *
+ * Deliberately NOT `analyzeClientNeeds(ir).needsInit` (the compiler's
+ * per-file "does this file's compiled init do anything nontrivial" signal)
+ * — that's true for almost any server component with dynamic content at
+ * all (a prop interpolation, a conditional, a `.map()`, a plain
+ * `onClick`...), not just ones that own a client descendant. Gating Vite
+ * entries on it would bundle huge swaths of purely-server trees that have
+ * nothing to hydrate. The property this function computes — "is there a
+ * `'use client'` file reachable via component-instantiation edges" — is
+ * inherently cross-file, so it can only be answered here, with the whole
+ * discovered corpus in hand, not by any single-file compiler analysis.
+ *
+ * Pure structural closure over JSX tag references — no compile. Resolves
+ * each file's `referencedComponents` (JSX tag names) to the file that
+ * exports that name via the shared `nameIndexOver` index, then walks the
+ * REVERSE edges breadth-first from the `isClient` seed set. Cycle-safe (a
+ * visited-set) and runs in O(files + edges); on this repo's real
+ * `ui`/`site` component corpus (~260 files) the whole discovery pass
+ * (parse + this closure) costs low-single-digit milliseconds.
+ *
+ * The closure only ever needs to walk upward from a `'use client'` seed:
+ * a client file cannot legally import a server component in the first
+ * place (`analyzer.ts`'s `validateClientImports` raises BF003, a hard
+ * compile error), so there is no "server child of a client parent needing
+ * its own entry" shape to account for.
+ */
+export declare function computeClientEntryPaths(rows: readonly Pick<DiscoveredComponent, 'absPath' | 'isClient' | 'exportedComponents' | 'referencedComponents'>[]): Set<string>;
 /**
  * Component-name → absolute-path index used to resolve `@bf-child:<Name>`
  * markers (see `child-marker.ts`) to a real file: a bare-marker child
@@ -88,10 +154,16 @@ export declare function discoverComponents(entries: readonly (string | ResolvedC
  * `resolveId` needs a name→file lookup built from a full discovery pass.
  *
  * Keyed by each exported component NAME, which is what the marker
- * carries. Server-only files are excluded: a `@bf-child:` marker only
- * ever names another component this one instantiates at runtime
- * (`initChild`/`createComponent`), which requires an `init` function only
- * a `'use client'` file has.
+ * carries. Files that don't need their own client entry are excluded: a
+ * `@bf-child:` marker only ever names another component this one
+ * instantiates at runtime (`initChild`/`createComponent`), which requires
+ * a REAL `init` — and a file with `needsClientEntry: false` compiles to a
+ * no-op template-only mount (`generateTemplateOnlyMount` in
+ * `@barefootjs/jsx`'s `ir-to-client-js`), nothing to jump to. This is
+ * `needsClientEntry`, not `isClient` — a plain server file that owns a
+ * `'use client'` descendant is a legitimate marker target too (issue
+ * #2767: it's the file whose compiled init actually contains the
+ * `initChild(...)` call reaching that descendant).
  *
  * This used to key on the file's basename, which worked only because the
  * one-component-per-file convention makes the two coincide
@@ -113,5 +185,5 @@ export declare function discoverComponents(entries: readonly (string | ResolvedC
  * `components` option's order — so an earlier directory shadows a later
  * one, the same precedence the option list already implies.
  */
-export declare function buildChildNameIndex(discovered: readonly Pick<DiscoveredComponent, 'absPath' | 'isClient' | 'exportedComponents'>[]): Map<string, string>;
+export declare function buildChildNameIndex(discovered: readonly Pick<DiscoveredComponent, 'absPath' | 'needsClientEntry' | 'exportedComponents'>[]): Map<string, string>;
 //# sourceMappingURL=discover.d.ts.map

package/dist/discover.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"discover.d.ts","sourceRoot":"","sources":["../src/discover.ts"],"names":[],"mappings":"AAeA;mDACmD;AACnD,wBAAgB,qBAAqB,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAe9D;AAED;;;;;;;GAOG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAO3D;AAED;;;GAGG;AACH,wBAAsB,sBAAsB,CAC1C,GAAG,EAAE,MAAM,EACX,OAAO,CAAC,EAAE;IAAE,QAAQ,CAAC,EAAE,MAAM,EAAE,CAAA;CAAE,GAChC,OAAO,CAAC,MAAM,EAAE,CAAC,CAwBnB;AAED,MAAM,WAAW,mBAAmB;IAClC,+CAA+C;IAC/C,OAAO,EAAE,MAAM,CAAA;IACf;;;;;;OAMG;IACH,OAAO,EAAE,MAAM,CAAA;IACf,yEAAyE;IACzE,QAAQ,EAAE,OAAO,CAAA;IACjB;;;;;;OAMG;IACH,kBAAkB,EAAE,MAAM,EAAE,CAAA;IAC5B;;;;;OAKG;IACH,cAAc,CAAC,EAAE,MAAM,CAAA;CACxB;AAED;;;;;;;;;;GAUG;AACH,MAAM,WAAW,yBAAyB;IACxC,qDAAqD;IACrD,GAAG,EAAE,MAAM,CAAA;IACX;+CAC2C;IAC3C,cAAc,CAAC,EAAE,MAAM,CAAA;IACvB;8CAC0C;IAC1C,QAAQ,CAAC,EAAE,MAAM,EAAE,CAAA;CACpB;AAED;;;;;;;;;;;GAWG;AACH,wBAAsB,kBAAkB,CACtC,OAAO,EAAE,SAAS,CAAC,MAAM,GAAG,yBAAyB,CAAC,EAAE,EACxD,QAAQ,EAAE,CAAC,OAAO,EAAE,MAAM,KAAK,OAAO,CAAC,MAAM,CAAC,GAC7C,OAAO,CAAC,mBAAmB,EAAE,CAAC,CAuBhC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAgCG;AACH,wBAAgB,mBAAmB,CAIjC,UAAU,EAAE,SAAS,IAAI,CAAC,mBAAmB,EAAE,SAAS,GAAG,UAAU,GAAG,oBAAoB,CAAC,EAAE,GAC9F,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAerB"}
+{"version":3,"file":"discover.d.ts","sourceRoot":"","sources":["../src/discover.ts"],"names":[],"mappings":"AAeA;mDACmD;AACnD,wBAAgB,qBAAqB,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAe9D;AAED;;;;;;;GAOG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAO3D;AAED;;;GAGG;AACH,wBAAsB,sBAAsB,CAC1C,GAAG,EAAE,MAAM,EACX,OAAO,CAAC,EAAE;IAAE,QAAQ,CAAC,EAAE,MAAM,EAAE,CAAA;CAAE,GAChC,OAAO,CAAC,MAAM,EAAE,CAAC,CAwBnB;AAED,MAAM,WAAW,mBAAmB;IAClC,+CAA+C;IAC/C,OAAO,EAAE,MAAM,CAAA;IACf;;;;;;OAMG;IACH,OAAO,EAAE,MAAM,CAAA;IACf,yEAAyE;IACzE,QAAQ,EAAE,OAAO,CAAA;IACjB;;;;;;;;;;;;;OAaG;IACH,gBAAgB,EAAE,OAAO,CAAA;IACzB;;;;;;;;;OASG;IACH,kBAAkB,EAAE,MAAM,EAAE,CAAA;IAC5B;;;;;;OAMG;IACH,oBAAoB,EAAE,MAAM,EAAE,CAAA;IAC9B;;;;;OAKG;IACH,cAAc,CAAC,EAAE,MAAM,CAAA;CACxB;AAED;;;;;;;;;;GAUG;AACH,MAAM,WAAW,yBAAyB;IACxC,qDAAqD;IACrD,GAAG,EAAE,MAAM,CAAA;IACX;+CAC2C;IAC3C,cAAc,CAAC,EAAE,MAAM,CAAA;IACvB;8CAC0C;IAC1C,QAAQ,CAAC,EAAE,MAAM,EAAE,CAAA;CACpB;AAED;;;;;;;;;;;GAWG;AACH,wBAAsB,kBAAkB,CACtC,OAAO,EAAE,SAAS,CAAC,MAAM,GAAG,yBAAyB,CAAC,EAAE,EACxD,QAAQ,EAAE,CAAC,OAAO,EAAE,MAAM,KAAK,OAAO,CAAC,MAAM,CAAC,GAC7C,OAAO,CAAC,mBAAmB,EAAE,CAAC,CA4BhC;AA+BD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAsCG;AACH,wBAAgB,uBAAuB,CACrC,IAAI,EAAE,SAAS,IAAI,CAAC,mBAAmB,EAAE,SAAS,GAAG,UAAU,GAAG,oBAAoB,GAAG,sBAAsB,CAAC,EAAE,GACjH,GAAG,CAAC,MAAM,CAAC,CAoCb;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAsCG;AACH,wBAAgB,mBAAmB,CAIjC,UAAU,EAAE,SAAS,IAAI,CAAC,mBAAmB,EAAE,SAAS,GAAG,kBAAkB,GAAG,oBAAoB,CAAC,EAAE,GACtG,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAErB"}