@barefootjs/mojolicious 0.35.2 → 0.35.3

package/dist/adapter/index.js

@@ -977,7 +977,7 @@ function generateDerivedMemoSeed(ctx, ir) {
 }
 
 // src/adapter/props/prop-classes.ts
-import { collectLoopBoundNames } from "@barefootjs/jsx";
+import { collectLoopBoundNames, resolveBodyDestructuredPropAliases } from "@barefootjs/jsx";
 
 // src/adapter/value/parsed-literal.ts
 function isStringTypeInfo(type) {
@@ -1015,6 +1015,10 @@ function collectStringValueNames(ir) {
     if (isStringTypeInfo(p.type))
       names.add(p.name);
   }
+  for (const [local, callerKey] of resolveBodyDestructuredPropAliases(ir.metadata.localConstants ?? [], ir.metadata.propsObjectName)) {
+    if (names.has(callerKey))
+      names.add(local);
+  }
   for (const c of ir.metadata.localConstants) {
     if (isStringTypeInfo(c.type ?? undefined) || isBareStringLiteral(c.value))
       names.add(c.name);

package/dist/adapter/props/prop-classes.d.ts

@@ -59,6 +59,22 @@ export declare function collectNullableOptionalProps(ir: ComponentIR): Set<strin
  * elsewhere in the component) but safe: the suppressed case just falls
  * back to today's numeric `+` — the same, already-accepted residual as an
  * unresolvable operand — never silently-wrong output.
+ *
+ * A bare-props-form component's BODY-destructured, RENAMED prop
+ * (`const { fallbackLabel: skipLabel } = props`, the #2788 alias family)
+ * has no `propsParams` entry of its own — `propsParams` only carries the
+ * TYPE-level, caller-facing names, and the local alias never appears
+ * there. Without the alias resolved here too, a string-typed prop
+ * referenced only under its local rename inside a filter predicate
+ * (`t => t.label !== skipLabel`) is invisible to this witness, so its
+ * equality lowers to numeric `!=` instead of `ne` — every row is
+ * dropped, since `'Alpha' != 'Alpha'` and `'Beta' != 'Alpha'` both
+ * numify to `0 != 0` (#2883). `resolveBodyDestructuredPropAliases`
+ * already recognizes this exact destructuring shape (built for #2788's
+ * top-level splice path); reusing it here keeps this one witness the
+ * single source of truth `MojoFilterEmitter`/`MojoTopLevelEmitter` both
+ * read via `_isStringValueName`, rather than growing a second, adapter-
+ * emitter-local alias lookup.
  */
 export declare function collectStringValueNames(ir: ComponentIR): Set<string>;
 //# sourceMappingURL=prop-classes.d.ts.map

package/dist/adapter/props/prop-classes.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prop-classes.d.ts","sourceRoot":"","sources":["../../../src/adapter/props/prop-classes.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAyB,KAAK,WAAW,EAAE,MAAM,iBAAiB,CAAA;AAGzE;;;;GAIG;AACH,wBAAgB,wBAAwB,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAMrE;AAED;;;;;GAKG;AACH,wBAAgB,wBAAwB,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAMrE;AAED;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,4BAA4B,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAWzE;AAED;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,wBAAgB,uBAAuB,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAepE"}
+{"version":3,"file":"prop-classes.d.ts","sourceRoot":"","sources":["../../../src/adapter/props/prop-classes.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAA6D,KAAK,WAAW,EAAE,MAAM,iBAAiB,CAAA;AAG7G;;;;GAIG;AACH,wBAAgB,wBAAwB,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAMrE;AAED;;;;;GAKG;AACH,wBAAgB,wBAAwB,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAMrE;AAED;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,4BAA4B,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAWzE;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAuCG;AACH,wBAAgB,uBAAuB,CAAC,EAAE,EAAE,WAAW,GAAG,GAAG,CAAC,MAAM,CAAC,CAqBpE"}

package/dist/index.js

@@ -977,7 +977,7 @@ function generateDerivedMemoSeed(ctx, ir) {
 }
 
 // src/adapter/props/prop-classes.ts
-import { collectLoopBoundNames } from "@barefootjs/jsx";
+import { collectLoopBoundNames, resolveBodyDestructuredPropAliases } from "@barefootjs/jsx";
 
 // src/adapter/value/parsed-literal.ts
 function isStringTypeInfo(type) {
@@ -1015,6 +1015,10 @@ function collectStringValueNames(ir) {
     if (isStringTypeInfo(p.type))
       names.add(p.name);
   }
+  for (const [local, callerKey] of resolveBodyDestructuredPropAliases(ir.metadata.localConstants ?? [], ir.metadata.propsObjectName)) {
+    if (names.has(callerKey))
+      names.add(local);
+  }
   for (const c of ir.metadata.localConstants) {
     if (isStringTypeInfo(c.type ?? undefined) || isBareStringLiteral(c.value))
       names.add(c.name);
@@ -1922,9 +1926,7 @@ var conformancePins = {
   "namespace-import-primitive": [{ code: "BF013", severity: "error" }]
 };
 // src/render-divergences.ts
-var renderDivergences = {
-  "filter-predicate-renamed-prop": "https://github.com/piconic-ai/barefootjs/issues/2883"
-};
+var renderDivergences = {};
 export {
   renderDivergences,
   mojoAdapter,

package/dist/render-divergences.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"render-divergences.d.ts","sourceRoot":"","sources":["../src/render-divergences.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAA;AAQxD,eAAO,MAAM,iBAAiB,EAAE,iBAW/B,CAAA"}
+{"version":3,"file":"render-divergences.d.ts","sourceRoot":"","sources":["../src/render-divergences.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,iBAAiB,CAAA;AAQxD,eAAO,MAAM,iBAAiB,EAAE,iBAAsB,CAAA"}

package/dist/vite.js

@@ -2175,6 +2175,20 @@ function propsDestructureBinding(p) {
   const binding = callerKey === localName ? localName : `${isIdentifierName(callerKey) ? callerKey : JSON.stringify(callerKey)}: ${localName}`;
   return p.defaultValue ? `${binding} = ${p.defaultValue}` : binding;
 }
+function resolveBodyDestructuredPropAliases(localConstants, propsObjectName) {
+  const aliases = new Map;
+  if (propsObjectName === null)
+    return aliases;
+  for (const c of localConstants) {
+    if (c.isModule)
+      continue;
+    const m = c.parsed;
+    if (m?.kind === "member" && !m.computed && m.object.kind === "identifier" && m.object.name === propsObjectName) {
+      aliases.set(c.name, m.property);
+    }
+  }
+  return aliases;
+}
 var EMPTY_SET = new Set;
 
 // ../jsx/src/ir-to-client-js/csr-substitute.ts
@@ -3421,8 +3435,11 @@ function matchSearchParamsMethodCall(callee, args, localNames) {
 // ../jsx/src/ir-to-client-js/prune-unused-prop-extractions.ts
 import ts19 from "typescript";
 
-// ../jsx/src/ir-to-client-js/control-flow/plan/lazy-preamble.ts
+// ../jsx/src/ir-to-client-js/emit-reactive.ts
 import ts20 from "typescript";
+
+// ../jsx/src/ir-to-client-js/control-flow/plan/lazy-preamble.ts
+import ts21 from "typescript";
 var NO_PREAMBLE = {
   lazySafe: true,
   facts: { declaredNames: new Set, freeNames: new Set }
@@ -3471,9 +3488,6 @@ var INERT_BINDING_GLOBALS = new Set([
   "decodeURI"
 ]);
 
-// ../jsx/src/ir-to-client-js/emit-reactive.ts
-import ts21 from "typescript";
-
 // ../jsx/src/ir-to-client-js/control-flow/stringify/event-delegation.ts
 var NON_BUBBLING_EVENTS = new Set([
   "blur",
@@ -6250,6 +6264,10 @@ function collectStringValueNames(ir) {
     if (isStringTypeInfo(p.type))
       names.add(p.name);
   }
+  for (const [local, callerKey] of resolveBodyDestructuredPropAliases(ir.metadata.localConstants ?? [], ir.metadata.propsObjectName)) {
+    if (names.has(callerKey))
+      names.add(local);
+  }
   for (const c of ir.metadata.localConstants) {
     if (isStringTypeInfo(c.type ?? undefined) || isBareStringLiteral(c.value))
       names.add(c.name);

package/lib/BarefootJS/Backend/Mojo.pm

@@ -1,5 +1,5 @@
 package BarefootJS::Backend::Mojo;
-our $VERSION = "0.35.1";
+our $VERSION = "0.35.2";
 use Mojo::Base -base, -signatures;
 
 use Mojo::ByteStream qw(b);

package/lib/Mojolicious/Plugin/BarefootJS/DevReload.pm

@@ -1,5 +1,5 @@
 package Mojolicious::Plugin::BarefootJS::DevReload;
-our $VERSION = "0.35.1";
+our $VERSION = "0.35.2";
 use Mojo::Base 'Mojolicious::Plugin', -signatures;
 
 =head1 NAME

package/lib/Mojolicious/Plugin/BarefootJS.pm

@@ -1,5 +1,5 @@
 package Mojolicious::Plugin::BarefootJS;
-our $VERSION = "0.35.1";
+our $VERSION = "0.35.2";
 use Mojo::Base 'Mojolicious::Plugin', -signatures;
 
 use Mojo::File qw(path);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@barefootjs/mojolicious",
-  "version": "0.35.2",
+  "version": "0.35.3",
   "description": "Mojolicious EP template adapter for BarefootJS - generates .html.ep files from IR",
   "type": "module",
   "main": "./dist/index.js",
@@ -52,7 +52,7 @@
     "directory": "packages/adapter-mojolicious"
   },
   "dependencies": {
-    "@barefootjs/shared": "0.35.2"
+    "@barefootjs/shared": "0.35.3"
   },
   "peerDependencies": {
     "@barefootjs/jsx": ">=0.2.0",
@@ -70,9 +70,9 @@
   },
   "devDependencies": {
     "@barefootjs/adapter-tests": "0.1.0",
-    "@barefootjs/jsx": "0.35.2",
-    "@barefootjs/vite": "0.35.2",
-    "@barefootjs/client": "0.35.2",
+    "@barefootjs/jsx": "0.35.3",
+    "@barefootjs/vite": "0.35.3",
+    "@barefootjs/client": "0.35.3",
     "vite": "^6.0.0"
   }
 }

package/src/__tests__/mojo-adapter.test.ts

@@ -733,6 +733,40 @@ export function L() {
     expect(result.template).not.toContain('$sel eq $t->{n}')
   })
 
+  test('compares a filter predicate against a renamed body-destructured prop with Perl `ne`, not numeric `!=` (#2883)', () => {
+    // `MojoFilterEmitter.identifier()` correctly resolves `skipLabel` to
+    // `$skipLabel` (Mojo seeds/derives that stash key for the #2788 alias
+    // family, same as the top-level splice path) — the actual bug was
+    // `collectStringValueNames`'s witness for `eq`/`ne` vs `==`/`!=` not
+    // knowing about body-destructured RENAMED props, so this comparison
+    // fell through to numeric `!=`. `'Alpha' != 'Alpha'` and
+    // `'Beta' != 'Alpha'` both numify to `0 != 0` — every row was
+    // filtered out regardless of the real string value.
+    const result = compileAndGenerate(`
+"use client"
+import { createSignal } from "@barefootjs/client"
+
+type Todo = { id: number; label: string }
+
+export function FilterPredicateRenamedProp(props: { fallbackLabel: string }) {
+  const { fallbackLabel: skipLabel } = props
+  const [todos] = createSignal<Todo[]>([
+    { id: 1, label: 'Alpha' },
+    { id: 2, label: 'Beta' },
+  ])
+  return (
+    <ul>
+      {todos().filter(t => t.label !== skipLabel).map(t => (
+        <li key={t.id}>{t.label}</li>
+      ))}
+    </ul>
+  )
+}
+`)
+    expect(result.template).toContain('$t->{label} ne $skipLabel')
+    expect(result.template).not.toContain('$t->{label} != $skipLabel')
+  })
+
   test('generates script registration for client components', () => {
     const result = compileAndGenerate(`
 "use client"

package/src/adapter/props/prop-classes.ts

@@ -7,7 +7,7 @@
  * adapter's `props/prop-types.ts`. No adapter instance state.
  */
 
-import { collectLoopBoundNames, type ComponentIR } from '@barefootjs/jsx'
+import { collectLoopBoundNames, resolveBodyDestructuredPropAliases, type ComponentIR } from '@barefootjs/jsx'
 import { isStringTypeInfo, isBareStringLiteral } from '../value/parsed-literal.ts'
 
 /**
@@ -88,6 +88,22 @@ export function collectNullableOptionalProps(ir: ComponentIR): Set<string> {
  * elsewhere in the component) but safe: the suppressed case just falls
  * back to today's numeric `+` — the same, already-accepted residual as an
  * unresolvable operand — never silently-wrong output.
+ *
+ * A bare-props-form component's BODY-destructured, RENAMED prop
+ * (`const { fallbackLabel: skipLabel } = props`, the #2788 alias family)
+ * has no `propsParams` entry of its own — `propsParams` only carries the
+ * TYPE-level, caller-facing names, and the local alias never appears
+ * there. Without the alias resolved here too, a string-typed prop
+ * referenced only under its local rename inside a filter predicate
+ * (`t => t.label !== skipLabel`) is invisible to this witness, so its
+ * equality lowers to numeric `!=` instead of `ne` — every row is
+ * dropped, since `'Alpha' != 'Alpha'` and `'Beta' != 'Alpha'` both
+ * numify to `0 != 0` (#2883). `resolveBodyDestructuredPropAliases`
+ * already recognizes this exact destructuring shape (built for #2788's
+ * top-level splice path); reusing it here keeps this one witness the
+ * single source of truth `MojoFilterEmitter`/`MojoTopLevelEmitter` both
+ * read via `_isStringValueName`, rather than growing a second, adapter-
+ * emitter-local alias lookup.
  */
 export function collectStringValueNames(ir: ComponentIR): Set<string> {
   const names = new Set<string>()
@@ -99,6 +115,12 @@ export function collectStringValueNames(ir: ComponentIR): Set<string> {
   for (const p of ir.metadata.propsParams) {
     if (isStringTypeInfo(p.type)) names.add(p.name)
   }
+  for (const [local, callerKey] of resolveBodyDestructuredPropAliases(
+    ir.metadata.localConstants ?? [],
+    ir.metadata.propsObjectName,
+  )) {
+    if (names.has(callerKey)) names.add(local)
+  }
   for (const c of ir.metadata.localConstants) {
     if (isStringTypeInfo(c.type ?? undefined) || isBareStringLiteral(c.value)) names.add(c.name)
   }

package/src/render-divergences.ts

@@ -15,15 +15,4 @@ import type { RenderDivergences } from '@barefootjs/jsx'
 // at value position and the runtime evaluator's `object-literal` case
 // now merges it, so the seed classifies `derived` and SSRs identically
 // to Hono.
-export const renderDivergences: RenderDivergences = {
-  // #2883: `MojoFilterEmitter.identifier()` (expr/emitters.ts) resolves a
-  // `.filter()` predicate identifier against only the loop param and
-  // `localVarMap` — a bare-props-form renamed prop destructure (`const {
-  // fallbackLabel: skipLabel } = props`, the #2788 alias family) falls
-  // through to a bare `$skipLabel`, a Perl variable never declared in the
-  // generated `.html.ep`. Every row is filtered out (the fixture's
-  // reference expects only the non-matching row to survive). Unrelated to
-  // #2857's Go Template adapter fix that this fixture was added for — this
-  // fixture is a shared cross-adapter conformance fixture, not Go-specific.
-  'filter-predicate-renamed-prop': 'https://github.com/piconic-ai/barefootjs/issues/2883',
-}
+export const renderDivergences: RenderDivergences = {}